On Tue, Nov 11, 2014 at 05:24:43AM -0500, Francesco Romani wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Francesco Romani" <fromani@redhat.com> Cc: devel@ovirt.org Sent: Monday, November 10, 2014 1:21:53 PM Subject: Re: [ovirt-devel] [VDSM][JSON] jsonrpc coding/encoding performance on RHEL/Centos 6
We have vdsm/lib/compat.py for this stuff.
Then everyone needing json will do "from vdsm.compat import json"
Do you think is better to have an hard dependency on 'simplejson' or a soft one like I showed above hidden on compat.py?
I think we agree that 'explicit is better than implicit' here, so... (see below).
I know ganeti has a hard dependency on simplejson for performance reasons, so you wouldn't be the first virtualization project to do so :)
Nice catch - using pure python encoder/decoder is indeed much slower, strange that Python 2.6 does not include the c extension.
I think we would like to use simplejson on all platforms, to make the build and support simpler.
...agreed, and posted http://gerrit.ovirt.org/#/c/35024/