imo the preliminary patches (separated or not) should be only adding the missing columns widths. once done, a single patch should activate column re-sizing in a single shot -i.e removing the method (enableColumn...) and enabling the feature. btw, what is the time in Boston? Thanks, Gilad. ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Daniel Erez" <derez@redhat.com>, "Alona Kaplan" <alkaplan@redhat.com>, "Tal Nisan" <tnisan@redhat.com>, gchaplik@redhat.com, "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, April 25, 2013 10:30:48 AM Subject: enable column resizing on all sub-tabs?
Vojtech[/others] - what do you think about Gilad's comment below? would it be possible / more correct to activate column resizing within the base grid class itself by default (or something similar), rather than enable it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to have its width explicitly set]
---- Thanks, Einav
----- Original Message -----
From: gchaplik@redhat.com To: "Daniel Erez" <derez@redhat.com> Cc: "Einav Cohen" <ecohen@redhat.com>, "Vojtech Szocs" <vszocs@redhat.com>, "Alona Kaplan" <alkaplan@redhat.com>, "Tal Nisan" <tnisan@redhat.com> Sent: Thursday, April 25, 2013 3:23:56 AM Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab: sub-tabs resizable columns
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns ......................................................................
Patch Set 4:
why we need to invoke getTable().enableColumnResizing() on each sub-tab? don't we want all grid subtabs to have column resizing?
-- To view, visit http://gerrit.ovirt.org/14105 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>