[ovirt-devel] changes in dbscripts/common_sp.sql functions validation

Hi All Patch [1] is about to be merged soon and it changes the behaviour of dbscripts/common_sp.sql functions validation. In dbscripts/common_sp.sql we have several helper functions that execute dynamic SQL using the EXECUTE command In order to validate parameters as table name , column name etc, we used to check those parameters with the information stored in the information_schema data Due to that we had some side effects: 1. fn_db_change_column_type did not accept valid types as DECIMAL since in the information_schema data in is named NUMERIC 2. fn_db_change_column_type did not accept precision in the origin column type as NUMERIC(24,4) for example 3. fn_db_change_column_type swallowed any error causing scripts not to perform the action but to consider as successful Patch [1] fixes all those issues and now the comon_sp.sql functions will trust errors thrown by using the EXECUTE command without validating the SQL syntax before. This will resolve issues 1 and 2 listed above In addition, the patch fixes issue 3 by adding the needed upgrade scripts to enforce the changes that were not performed in former upgrade scripts updates. Please feel free to contact me on any issues/questions regarding those changes Regards Eli Mesika [1] https://gerrit.ovirt.org/#/c/ovirt-engine/+/117448/