[ovirt-devel] Re: ovirt-engine has been tagged (ovirt-engine-4.3.1)

On Tue, Feb 19, 2019 at 4:41 AM Tal Nisan <tnisan(a)redhat.com&gt; wrote: > > > On Tue, Feb 19, 2019 at 11:30 AM Doron Fediuck <dfediuck(a)redhat.com&gt; > wrote: > >> >> >> On Tue, 19 Feb 2019 at 11:14, Tal Nisan <tnisan(a)redhat.com&gt; wrote: >> >>> >>> >>> On Tue, Feb 19, 2019 at 11:03 AM Doron Fediuck <dfediuck(a)redhat.com&gt; >>> wrote: >>> >>>> >>>> >>>> On Tue, 19 Feb 2019 at 10:56, Tal Nisan <tnisan(a)redhat.com&gt; wrote: >>>> >>>>> OK seems like I've found the reason, Ori you merged this patch >>>>> between the time when the version bumps were pushed and their actual merge >>>>> which cause them to rebase on the broken patch - >>>>> https://gerrit.ovirt.org/#/c/96610/ >>>>> Note that Jenkins failed on patchset 12 while CI was marked as +1 >>>>> manually (I guess wrongly based on the fact the artifacts were successfully >>>>> build but that does not mean tests passed) >>>>> >>>>> >>>> As a next step I'd like to know how do we avoid it next time? >>>> >>> Really hard to avoid, there's not many chance for that to happen since >>> the time window is quite short, if we decide to keep on rebasing the >>> version bumps it will not help much because Jenkins is still taking quite a >>> lot of time and potentially broken patches can be merged at this point. >>> What we can do is set a no-merge time in this specific time frame (only >>> if building from master, on the stable branches the maintainers take care >>> of all merges so no problem there) in which no one will merge patches to >>> keep stability >>> >> >> Will a maintainers' mailing list (single for all ovirt projects) help >> here or would we prefer a mutex somewhere? >> > Given the short time window in which this can happen I think the devel > list should do, a short email of "build is about to go soon, please hold > your merges until engine has been tagged" will probably be enough > I've found that many developers filter devel and other mailing lists into labels and infrequently check them. Not sure this will work.

> >>>> >>>>> >>>>> On Tue, Feb 19, 2019 at 10:50 AM Tal Nisan <tnisan(a)redhat.com&gt; wrote: >>>>> >>>>>> I don't get it, both version bump patches passed Jenkins with all >>>>>> unit tests: >>>>>> https://gerrit.ovirt.org/#/c/97835 >>>>>> And the Jenkins job: >>>>>> >>>>>> https://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/... >>>>>> >>>>>> Fred, what is the suspected patch that broke the tests? I suspect >>>>>> Gerrit auto rebase might broke something in case the version bump patches >>>>>> were not fully rebased on master when they were pushed >>>>>> >>>>>> On Tue, Feb 19, 2019 at 9:51 AM Fred Rolland <frolland(a)redhat.com&gt; >>>>>> wrote: >>>>>> >>>>>>> This fixes the failing test: >>>>>>> https://gerrit.ovirt.org/#/c/97865/ >>>>>>> >>>>>>> On Tue, Feb 19, 2019 at 9:28 AM Benny Zlotnik <bzlotnik(a)redhat.com&gt; >>>>>>> wrote: >>>>>>> >>>>>>>> I created a revert patch last night: >>>>>>>> https://gerrit.ovirt.org/#/c/97854/ >>>>>>>> >>>>>>>> frolland is currently checking if it's easy to fix without >>>>>>>> reverting >>>>>>>> >>>>>>>> On Tue, Feb 19, 2019, 09:18 Sandro Bonazzola <sbonazzo(a)redhat.com >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> please note engine build failed with: >>>>>>>>> >>>>>>>>> *17:45:54* [ERROR] Tests run: 11, Failures: 0, Errors: 3, Skipped: 1, Time elapsed: 0.258 s <<< FAILURE! - in org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest*17:45:54* [ERROR] testAdd Time elapsed: 0.027 s <<< ERROR!*17:45:54* org.ovirt.engine.api.restapi.utils.MappingException: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAdd(BackendAttachedStorageDomainsResourceTest.java:75)*17:45:54* Caused by: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAdd(BackendAttachedStorageDomainsResourceTest.java:75)*17:45:54* Caused by: java.lang.NullPointerException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAdd(BackendAttachedStorageDomainsResourceTest.java:75)*17:45:54* *17:45:54* [ERROR] testList Time elapsed: 0.018 s <<< ERROR!*17:45:54* org.ovirt.engine.api.restapi.utils.MappingException: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.getCollection(BackendAttachedStorageDomainsResourceTest.java:251)*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testList(BackendAttachedStorageDomainsResourceTest.java:179)*17:45:54* Caused by: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.getCollection(BackendAttachedStorageDomainsResourceTest.java:251)*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testList(BackendAttachedStorageDomainsResourceTest.java:179)*17:45:54* Caused by: java.lang.NullPointerException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.getCollection(BackendAttachedStorageDomainsResourceTest.java:251)*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testList(BackendAttachedStorageDomainsResourceTest.java:179)*17:45:54* *17:45:54* [ERROR] testAddByName Time elapsed: 0.022 s <<< ERROR!*17:45:54* org.ovirt.engine.api.restapi.utils.MappingException: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAddByName(BackendAttachedStorageDomainsResourceTest.java:116)*17:45:54* Caused by: java.lang.reflect.InvocationTargetException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAddByName(BackendAttachedStorageDomainsResourceTest.java:116)*17:45:54* Caused by: java.lang.NullPointerException*17:45:54* at org.ovirt.engine.api.restapi.resource.BackendAttachedStorageDomainsResourceTest.testAddByName(BackendAttachedStorageDomainsResourceTest.java:116)*17:45:54* *17:45:54* [INFO] Running org.ovirt.engine.api.restapi.util.LinkFollowerTest*17:45:54* [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.175 s - in org.ovirt.engine.api.restapi.util.LinkFollowerTest*17:45:54* [INFO] Running org.ovirt.engine.api.restapi.util.FenceOptionsParserTest*17:45:54* ERROR org.ovirt.engine.api.restapi.util.FenceOptionsParser - No type specified for fencing option "one".*17:45:54* ERROR org.ovirt.engine.api.restapi.util.FenceOptionsParser - Invalid fencing option description "three".*17:45:54* ERROR org.ovirt.engine.api.restapi.util.FenceOptionsParser - Invalid fencing agent description "foo:::one=1,two=2,three=3".*17:45:54* [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 s - in org.ovirt.engine.api.restapi.util.FenceOptionsParserTest*17:45:54* [INFO] Running org.ovirt.engine.api.restapi.util.LinkHelperTest*17:45:54* [INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 s - in org.ovirt.engine.api.restapi.util.LinkHelperTest*17:45:54* [INFO] Running org.ovirt.engine.api.restapi.util.QueryHelperTest*17:45:54* [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.ovirt.engine.api.restapi.util.QueryHelperTest*17:45:55* [INFO] *17:45:55* [INFO] Results:*17:45:55* [INFO] *17:45:55* [ERROR] Failures: *17:45:55* [ERROR] BackendAttachedStorageDomainResourceTest.testRemoveCantDo:181->doTestBadRemove:203 Unexpected exception type thrown ==> expected: <javax.ws.rs.WebApplicationException> but was: <org.ovirt.engine.api.restapi.utils.MappingException>*17:45:55* [ERROR] BackendAttachedStorageDomainResourceTest.testRemoveFailed:186->doTestBadRemove:203 Unexpected exception type thrown ==> expected: <javax.ws.rs.WebApplicationException> but was: <org.ovirt.engine.api.restapi.utils.MappingException>*17:45:55* [ERROR] BackendStorageDomainResourceTest.testConflictedUpdate:175 Unexpected exception type thrown ==> expected: <javax.ws.rs.WebApplicationException> but was: <org.ovirt.engine.api.restapi.utils.MappingException>*17:45:55* [ERROR] BackendStorageDomainResourceTest.testUpdateCantDo:145->doTestBadUpdate:164 Unexpected exception type thrown ==> expected: <javax.ws.rs.WebApplicationException> but was: <org.ovirt.engine.api.restapi.utils.MappingException>*17:45:55* [ERROR] BackendStorageDomainResourceTest.testUpdateFailed:150->doTestBadUpdate:164 Unexpected exception type thrown ==> expected: <javax.ws.rs.WebApplicationException> but was: <org.ovirt.engine.api.restapi.utils.MappingException>*17:45:55* [ERROR] Errors: *17:45:55* [ERROR] BackendAttachedStorageDomainResourceTest.testGet:69 ? Mapping java.lang.reflec...*17:45:55* [ERROR] BackendAttachedStorageDomainResourceTest.testRemove:152 ? Mapping java.lang.re...*17:45:55* [ERROR] BackendAttachedStorageDomainResourceTest.testRemoveLocalStorage:176 ? Mapping ...*17:45:55* [ERROR] BackendAttachedStorageDomainsResourceTest.testAdd:75 ? Mapping java.lang.refle...*17:45:55* [ERROR] BackendAttachedStorageDomainsResourceTest.testAddByName:116 ? Mapping java.lan...*17:45:55* [ERROR] BackendAttachedStorageDomainsResourceTest.testList:179->getCollection:251 ? Mapping*17:45:55* [ERROR] BackendStorageDomainResourceTest.testGet:79 ? Mapping java.lang.reflect.Invoca...*17:45:55* [ERROR] BackendStorageDomainResourceTest.testGetFcp:91 ? Mapping java.lang.reflect.Inv...*17:45:55* [ERROR] BackendStorageDomainResourceTest.testUpdate:140 ? Mapping java.lang.reflect.In...*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddExistingStorageDomain:169->doTestAddStorageDomain:211 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddIscsiStorageDomain:348 ? Mapping java...*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddIscsiStorageDomainAssumingConnection:392 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddLocalStorageDomain:251 ? Mapping java...*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddPosixStorageDomain:301 ? Mapping java...*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddStorageDomain:82->doTestAddStorageDomain:211 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddStorageDomainWithExistingConnectionId:128 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest.testAddStorageDomainWithHostName:162->doTestAddStorageDomain:211 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest>AbstractBackendCollectionResourceTest.testList:72->getCollection:634 ? Mapping*17:45:55* [ERROR] BackendStorageDomainsResourceTest>AbstractBackendCollectionResourceTest.testQuery:81->getCollection:634 ? Mapping*17:45:55* [INFO] *17:45:55* [ERROR] Tests run: 1849, Failures: 5, Errors: 19, Skipped: 65*17:45:55* [INFO] *17:45:55* [INFO] ------------------------------------------------------------------------*17:45:55* [INFO] Reactor Summary:*17:45:55* [INFO] *17:45:55* [INFO] oVirt Findbugs Filters ............................ SUCCESS [1.970s]*17:45:55* [INFO] ovirt-root ........................................ SUCCESS [3.307s]*17:45:55* [INFO] oVirt Build Tools root ............................ SUCCESS [1.213s]*17:45:55* [INFO] oVirt checkstyle .................................. SUCCESS [2.121s]*17:45:55* [INFO] oVirt Checkstyle Checks ........................... SUCCESS [3.430s]*17:45:55* [INFO] oVirt Modules - backend ........................... SUCCESS [0.734s]*17:45:55* [INFO] oVirt Manager ..................................... SUCCESS [0.738s]*17:45:55* [INFO] oVirt Engine dependencies ......................... SUCCESS [0.891s]*17:45:55* [INFO] oVirt Engine common dependencies .................. SUCCESS [3.350s]*17:45:55* [INFO] oVirt Engine tools dependencies ................... SUCCESS [0.813s]*17:45:55* [INFO] Utilities to extend java.logging framework ........ SUCCESS [1.682s]*17:45:55* [INFO] Extensions API root ............................... SUCCESS [0.005s]*17:45:55* [INFO] ovirt-engine-extensions-api ....................... SUCCESS [9.274s]*17:45:55* [INFO] oVirt Modules - manager ........................... SUCCESS [2.056s]*17:45:55* [INFO] Universal utilities ............................... SUCCESS [20.282s]*17:45:55* [INFO] Extensions manager ................................ SUCCESS [5.412s]*17:45:55* [INFO] GWT UI Compatibility .............................. SUCCESS [6.178s]*17:45:55* [INFO] Common Code ....................................... SUCCESS [36.381s]*17:45:55* [INFO] Common utilities .................................. SUCCESS [35.291s]*17:45:55* [INFO] Branding package .................................. SUCCESS [9.146s]*17:45:55* [INFO] ovirt-engine sso .................................. SUCCESS [5.829s]*17:45:55* [INFO] Data Access Layer ................................. SUCCESS [30.876s]*17:45:55* [INFO] engine scheduler bean ............................. SUCCESS [6.888s]*17:45:55* [INFO] Vds broker ........................................ SUCCESS [32.916s]*17:45:55* [INFO] builtin-extensions ................................ SUCCESS [2.320s]*17:45:55* [INFO] Search Backend .................................... SUCCESS [10.064s]*17:45:55* [INFO] Backend Authentication, Authorization and Accounting SUCCESS [7.355s]*17:45:55* [INFO] Custom Application Server Authentication Plugin ... SUCCESS [3.320s]*17:45:55* [INFO] Backend Logic @Service bean ....................... SUCCESS [2:51.560s]*17:45:55* [INFO] oVirt RESTful API Backend Integration ............. SUCCESS [1.084s]*17:45:55* [INFO] oVirt RESTful API interface ....................... SUCCESS [1.005s]*17:45:55* [INFO] oVirt Engine API Definition ....................... SUCCESS [50.498s]*17:45:55* [INFO] oVirt Engine API Commom Parent POM ................ SUCCESS [1.037s]*17:45:55* [INFO] oVirt Engine API Common JAX-RS .................... SUCCESS [8.077s]*17:45:55* [INFO] oVirt RESTful API Backend Integration Type Mappers SUCCESS [22.779s]*17:45:55* [INFO] oVirt RESTful API Backend Integration JAX-RS Resources FAILURE [1:52.179s] >>>>>>>>> >>>>>>>>> >>>>>>>>> Job is here: >>>>>>>>> https://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86... >>>>>>>>> >>>>>>>>> So we need a respin once fixed. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> SANDRO BONAZZOLA >>>>>>>>> >>>>>>>>> MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV >>>>>>>>> >>>>>>>>> Red Hat EMEA <https://www.redhat.com/> >>>>>>>>> >>>>>>>>> sbonazzo(a)redhat.com >>>>>>>>> <https://red.ht/sig> >>>>>>>>> _______________________________________________ >>>>>>>>> Devel mailing list -- devel(a)ovirt.org >>>>>>>>> To unsubscribe send an email to devel-leave(a)ovirt.org >>>>>>>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >>>>>>>>> oVirt Code of Conduct: >>>>>>>>> https://www.ovirt.org/community/about/community-guidelines/ >>>>>>>>> List Archives: >>>>>>>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/2GJAJHWAD5X... >>>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Devel mailing list -- devel(a)ovirt.org >>>>>>>> To unsubscribe send an email to devel-leave(a)ovirt.org >>>>>>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >>>>>>>> oVirt Code of Conduct: >>>>>>>> https://www.ovirt.org/community/about/community-guidelines/ >>>>>>>> List Archives: >>>>>>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/32XDCPM6IPO... >>>>>>>> >>>>>>> _______________________________________________ >>>>>>> Devel mailing list -- devel(a)ovirt.org >>>>>>> To unsubscribe send an email to devel-leave(a)ovirt.org >>>>>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >>>>>>> oVirt Code of Conduct: >>>>>>> https://www.ovirt.org/community/about/community-guidelines/ >>>>>>> List Archives: >>>>>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/LV6XFFQPI4Z... >>>>>>> >>>>>> _______________________________________________ >>>>> Devel mailing list -- devel(a)ovirt.org >>>>> To unsubscribe send an email to devel-leave(a)ovirt.org >>>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >>>>> oVirt Code of Conduct: >>>>> https://www.ovirt.org/community/about/community-guidelines/ >>>>> List Archives: >>>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/THBBN6G2ETA... >>>>> >>>> _______________________________________________ > Devel mailing list -- devel(a)ovirt.org > To unsubscribe send an email to devel-leave(a)ovirt.org > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > oVirt Code of Conduct: > https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZG57PMU7GKJ... > -- GREG SHEREMETA SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX Red Hat NA <https://www.redhat.com/> gshereme(a)redhat.com IRC: gshereme <https://red.ht/sig>