On Mon, Nov 23, 2020 at 11:20 AM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 11/20/20 12:15 PM, Martin Perina wrote:
On Fri, Nov 20, 2020 at 12:02 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 11/20/20 11:50 AM, Martin Perina wrote: > > > On Fri, Nov 20, 2020 at 11:46 AM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com> > <mailto:msobczyk@redhat.com <mailto:msobczyk@redhat.com>>> wrote: > > Posted https://gerrit.ovirt.org/#/c/112302/ <https://gerrit.ovirt.org/#/c/112302/> > <https://gerrit.ovirt.org/#/c/112302/ <https://gerrit.ovirt.org/#/c/112302/>> to remove all 4.3 suites. > Please review. > > > Could you please remove network suite 4.3 from that patch? Network > team would like to keep to verify 4.3 hosts functionality. And they > have already removed 4.3 execution from check-patch > https://gerrit.ovirt.org/#/c/112291/ <https://gerrit.ovirt.org/#/c/112291/> > <https://gerrit.ovirt.org/#/c/112291/ <https://gerrit.ovirt.org/#/c/112291/>> > The plan is to execute 4.3 network suite only nightly Done. If there is still a need to run a 4.3 suite nightly, I'd be pushing towards creating a 4.3 branch and removing the code from master though.
Definitely, I've just created ovirt-engine-4.3 from current master, so we have current status saved and your removal patch can be merged to master
It seems that the tip of the branch points to a commit that already includes Eitan's change that removed 'network_suite_4.3' from 'stdci.yaml' [6], so we can't run this pipeline in CI. Could you please change the branch to point to the commit just before that? [7]
Readded: https://gerrit.ovirt.org/#/c/112324/
Regards, Marcin
[6] https://gerrit.ovirt.org/#/c/112291/ [7] a2a462ef2f409ce5ef293adef6ecbb0c86c9d4a7
> > > On 10/12/20 6:28 PM, Michal Skrivanek wrote: > >> On 12 Oct 2020, at 14:49, Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com> > <mailto:msobczyk@redhat.com <mailto:msobczyk@redhat.com>>> wrote: > >> > >> Hi all, > >> > >> after minimizing the usage of lago in basic suite, > >> and some minor adjustments in the network suite, we are finally > >> able to remove lago OST plugin as a dependency [1]. > >> > >> This however comes with a price of keeping lots of ugly > ifology, i.e. [2][3]. > >> There's big disparity between OST runs we have on el7 and el8. > >> There's also tons of symlink-based code sharing between suites > - be it 4.3 > >> suites and master suites or simply different types of
suites.
> >> The basic suite has its own 'test_utils', which is copied/symlinked > >> in multiple places. There's also 'ost_utils', which is
really
> messy ATM. > >> It's very hard to keep track and maintain all of this... > >> > >> At this moment, we are able to run basic suite and network suite > >> on el8, with prebuilt ost-images and without lago plugin. > >> HE suites should be the next step. We have patches that make them > >> py3-compatible that probably still need some attention [4][5]. > >> We don't have any prebuilt HE ost-images, but this will be handled > >> in the nearest future. > >> > >> I think it's good time to detach ourselves from the legacy stuff > >> and start with a clean slate. My proposition would be to branch > >> out 4.3 in ovirt-system-tests and not use py2/el7 in the master > >> branch at all. This would allow us to focus on py3, el8 and > ost-images > >> efforts while keeping the legacy stuff intact. > >> > >> WDYT? > > Great. We don’t really need 4.3 that much anymore. > > > >> Regards, Marcin > >> > >> [1] https://gerrit.ovirt.org/#/c/111643/ <https://gerrit.ovirt.org/#/c/111643/> > <https://gerrit.ovirt.org/#/c/111643/ <https://gerrit.ovirt.org/#/c/111643/>> > >> [2] > https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/control.sh <https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/control.sh
> <
https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/control.sh
<https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/control.sh
> >> [3] >
https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/test-scenarios/conf...
<
https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/test-scenarios/conf...
> <
https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/test-scenarios/conf...
<
https://gerrit.ovirt.org/#/c/111643/6/basic-suite-master/test-scenarios/conf...
> >> [4] https://gerrit.ovirt.org/108809 <https://gerrit.ovirt.org/108809> > <https://gerrit.ovirt.org/108809 <https://gerrit.ovirt.org/108809>> > >> [5] https://gerrit.ovirt.org/110097 <https://gerrit.ovirt.org/110097> > <https://gerrit.ovirt.org/110097 <https://gerrit.ovirt.org/110097>> > >> > > > > -- > Martin Perina > Manager, Software Engineering > Red Hat Czech s.r.o.
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.