Re: [ovirt-devel] [ OST Failure Report ] [ oVirt Master ] [ upgrade suites failed! ] [ 15/10/17 ]

On Mon, Oct 16, 2017 at 9:28 AM, Daniel Belenky <dbelenky(a)redhat.com&gt; wrote: Please add a direct link next time, if possible. This is it: http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3146/artifa... And a bit above the snippet below, there is: 2017-10-13 22:26:24,274-0400 DEBUG otopi.plugins.ovirt_engine_setup.ovirt_engine.upgrade.asynctasks plugin.execute:926 execute-output: ('/usr/share/ovirt-engine/setup/dbutils/taskcleaner.sh', '-l', '/var/log/ovirt-engine/setup/ovirt-engine-setup-20171013222617-73f0df.log', '-u', 'engine', '-s', 'localhost', '-p', '5432', '-d', 'engine', '-q', '-r', '-Z') stderr: /usr/share/ovirt-engine/bin/generate-pgpass.sh: line 3: /usr/share/ovirt-engine/setup/dbutils/engine-prolog.sh: No such file or directory 2017-10-13 22:26:24,274-0400 DEBUG otopi.context context._executeMethod:143 method exception With [1], taskcleaner.sh sources generate-pgpass.sh . generate-pgpass.sh is in ovirt-engine-tools, which in upgrade flows, is not yet upgraded (at the point of above failure). generate-pgpass.sh in 4.1 used to source engine-prolog.sh , using a path relative to "$0". In master it does not, but we now upgrade and it does. This, in principle, is the core of the bug: A file, such as generate-pgpass.sh, that's supposed to be sourced from some other files, should not by itself source other files that are relative to "$0", because it can't know what "$0" is - it's the path of the script sourcing it, not of itself. It seems like luckily we were not affected by this in 4.1, because all of the files that sourced generate-pgpass.sh were together with it in the same directory. But with [1], taskcleaner does too now, and is in a different directory. Not sure what's the best solution: - revert [1] (and introduce it later on, in 4.3) - patch 4.1's generate-pgpass.sh and require the fixed 4.1 version in 4.2 setup - Somehow trick everything to work together? Not sure. Seems like you can't set $0. [1] https://gerrit.ovirt.org/82511 Regards, -- Didi