On 30 Nov 2017, at 05:13, Yaniv Kaul <ykaul@redhat.com> wrote: =20 =20 =20 On Thu, Nov 30, 2017 at 11:38 AM, Arik Hadas <ahadas@redhat.com = <mailto:ahadas@redhat.com>> wrote: =20 =20 On Thu, Nov 30, 2017 at 11:10 AM, Martin Sivak <msivak@redhat.com = <mailto:msivak@redhat.com>> wrote: =20 =20 Bug ID Product Assignee Status Summary 1518887 <https://bugzilla.redhat.com/show_bug.cgi?id=3D1518887> = ovirt-hosted-engine-ha bugs@ovirt.org <mailto:bugs@ovirt.org> NEW = ovirt-ha-agent fails parsing the OVF_STORE due to a change in OVF = namespace URI =20 I'm in favor of reverting the virt change personally. =20 Unless something else depends on it, the commit message said vdsm = needs this. =20 vdsm needs it because we would like vdsm to be able to parse OVA files =
--Apple-Mail=_AFE2C3E6-A66D-4F8E-915C-617430C259F0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 that are generated by us and OVA files that are generated by others = (and are VMware-compatbile) with the existing code in vdsm. The existing = code is tailored to VMware-compatible OVA files that are generated by = others, in which the uri doesn't include that slash at the end.
=20 It would be best to adjust ovirt-ha-agent to parse the right uri. However, it that's too complicated, an alternative solution is to keep = writing the previous uri to ovirt's OVFs, i.e., those in OVF_STORE and = in snapshot's configuration. That would be a pitty since we want to = minimize the differences between the OVFs we generate, but it would be = better than reverting the change.. =20 I think a reasonable alternative is to revert the change, adjust HE to = use both formats, and then introduce the new format. The first step = (revert) should be done for 4.2.0 (today?) and the rest for 4.2.1.
It shouldn=E2=80=99t take too long to polish [1] and rebuild = ovirt-hosted-engine-ha Thanks Martin for posting it! Thanks, michal [1] https://gerrit.ovirt.org/#/c/84933/
Y. =20 =20 =20 =20 1516113 <https://bugzilla.redhat.com/show_bug.cgi?id=3D1516113> = cockpit-ovirt phbailey@redhat.com <mailto:phbailey@redhat.com> = POST Deploy the HostedEngine failed with the default CPU type =20 Would be happy if the remaining patch could get reviewed quickly. =20 =20 =20 =20 1518693 <https://bugzilla.redhat.com/show_bug.cgi?id=3D1518693> = ovirt-engine akrejcir@redhat.com <mailto:akrejcir@redhat.com> = POST Quota is needed to copy template disk =20 This is only via REST and the default quota can be used as a = workaround - why is this a blocker? =20 Automation added it because Raz marked it as Regression. But the = change was intentional. =20 =20 1517810 <https://bugzilla.redhat.com/show_bug.cgi?id=3D1517810> = ovirt-engine stirabos@redhat.com <mailto:stirabos@redhat.com> = Adding additional ha-host fails. =20 This one has a verified engine fix now, we just need to merge it and = update Node 0 setup (also verified). =20 =20 Martin =20 =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 =20 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--Apple-Mail=_AFE2C3E6-A66D-4F8E-915C-617430C259F0 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" = class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div = class=3D"">On 30 Nov 2017, at 05:13, Yaniv Kaul <<a = href=3D"mailto:ykaul@redhat.com" class=3D"">ykaul@redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote">On Thu, Nov 30, 2017 at 11:38 AM, = Arik Hadas <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:ahadas@redhat.com" target=3D"_blank" = class=3D"">ahadas@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 = .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr" = class=3D""><br class=3D""><div class=3D"gmail_extra"><br class=3D""><div = class=3D"gmail_quote"><span class=3D"">On Thu, Nov 30, 2017 at 11:10 AM, = Martin Sivak <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:msivak@redhat.com" target=3D"_blank" = class=3D"">msivak@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><span = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D""><br class=3D""></div><br class=3D""><div class=3D""> =09 =09 =09 =09 <table border=3D"0" cellspacing=3D"0" class=3D""> <colgroup width=3D"62" class=3D""></colgroup> <colgroup width=3D"167" class=3D""></colgroup> <colgroup width=3D"141" class=3D""></colgroup> <colgroup width=3D"51" class=3D""></colgroup> <colgroup width=3D"703" class=3D""></colgroup> <tbody class=3D""><tr class=3D""> <td align=3D"left" height=3D"17" class=3D"">Bug ID</td> <td align=3D"left" class=3D"">Product</td> <td align=3D"left" class=3D"">Assignee</td> <td align=3D"left" class=3D"">Status</td> <td align=3D"left" class=3D"">Summary</td> </tr> <tr class=3D""> <td align=3D"right" height=3D"17" class=3D""><a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1518887" = target=3D"_blank" class=3D"">1518887</a></td> <td align=3D"left" class=3D"">ovirt-hosted-engine-ha</td> <td align=3D"left" class=3D""><a = href=3D"mailto:bugs@ovirt.org" target=3D"_blank" = class=3D"">bugs@ovirt.org</a></td> <td align=3D"left" class=3D"">NEW</td> <td align=3D"left" class=3D"">ovirt-ha-agent fails = parsing the OVF_STORE due to a change in OVF namespace = URI</td></tr></tbody></table></div></div></blockquote><div class=3D""><br = class=3D""></div></span><div class=3D"">I'm in favor of reverting the = virt change personally.</div></div></div></div></blockquote><div = class=3D""><br class=3D""></div><div class=3D"">Unless something else = depends on it, the commit message said vdsm needs = this.</div></div></div></div></blockquote><div class=3D""><br = class=3D""></div></span><div class=3D"">vdsm needs it because we would = like vdsm to be able to parse OVA files that are generated by us and OVA = files that are generated by others (and are VMware-compatbile) = with the existing code in vdsm. The existing code is tailored to = VMware-compatible OVA files that are generated by others, in which the = uri doesn't include that slash at the end.</div><div class=3D""><br = class=3D""></div><div class=3D"">It would be best to adjust = ovirt-ha-agent to parse the right uri.</div><div class=3D"">However, it = that's too complicated, an alternative solution is to keep writing the = previous uri to ovirt's OVFs, i.e., those in OVF_STORE and in snapshot's = configuration. That would be a pitty since we want to minimize the = differences between the OVFs we generate, but it would be better than = reverting the change..</div></div></div></div></blockquote><div = class=3D""><br class=3D""></div><div class=3D"">I think a reasonable = alternative is to revert the change, adjust HE to use both formats, and = then introduce the new format. The first step (revert) should be done = for 4.2.0 (today?) and the rest for = 4.2.1.</div></div></div></div></div></blockquote><div><br = class=3D""></div>It shouldn=E2=80=99t take too long to polish [1] and = rebuild ovirt-hosted-engine-ha</div><div>Thanks Martin for posting = it!</div><div><br = class=3D""></div><div>Thanks,</div><div>michal</div><div><br = class=3D""></div><div>[1] <a = href=3D"https://gerrit.ovirt.org/#/c/84933/" = class=3D"">https://gerrit.ovirt.org/#/c/84933/</a></div><div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D"">Y.</div><div class=3D""><br = class=3D""></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 = .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr" = class=3D""><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><span class=3D""><div dir=3D"ltr" = class=3D""><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><span class=3D""><div = class=3D""> <br class=3D""></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D""><table border=3D"0" cellspacing=3D"0" class=3D""><tbody = class=3D""><tr class=3D""> </tr> <tr class=3D""> <td align=3D"right" height=3D"17" class=3D""><a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1516113" = target=3D"_blank" class=3D"">1516113</a></td> <td align=3D"left" class=3D"">cockpit-ovirt</td> <td align=3D"left" class=3D""><a = href=3D"mailto:phbailey@redhat.com" target=3D"_blank" = class=3D"">phbailey@redhat.com</a></td> <td align=3D"left" class=3D"">POST</td> <td align=3D"left" class=3D"">Deploy the HostedEngine = failed with the default CPU = type</td></tr></tbody></table></div></div></blockquote><div class=3D""><br= class=3D""></div></span><div class=3D"">Would be happy if the remaining = patch could get reviewed = quickly.</div></div></div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D""><br class=3D""></div><div = class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><span class=3D""><div = class=3D""> <br class=3D""></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D""><table border=3D"0" cellspacing=3D"0" class=3D""><tbody = class=3D""><tr class=3D""> </tr> <tr class=3D""> <td align=3D"right" height=3D"17" class=3D""><a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1518693" = target=3D"_blank" class=3D"">1518693</a></td> <td align=3D"left" class=3D"">ovirt-engine</td> <td align=3D"left" class=3D""><a = href=3D"mailto:akrejcir@redhat.com" target=3D"_blank" = class=3D"">akrejcir@redhat.com</a></td> <td align=3D"left" class=3D"">POST</td> <td align=3D"left" class=3D"">Quota is needed to copy = template disk</td></tr></tbody></table></div></div></blockquote><div = class=3D""><br class=3D""></div></span><div class=3D"">This is only via = REST and the default quota can be used as a workaround - why is this a = blocker?</div></div></div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">Automation added it because Raz marked = it as Regression. But the change was intentional.</div><div = class=3D""> </div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><span = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(= 204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D""><table border=3D"0" cellspacing=3D"0" class=3D""><tbody = class=3D""><tr class=3D""> </tr> <tr class=3D""> <td align=3D"right" height=3D"17" class=3D""><a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1517810" = target=3D"_blank" class=3D"">1517810</a></td> <td align=3D"left" class=3D"">ovirt-engine</td> <td align=3D"left" class=3D""><a = href=3D"mailto:stirabos@redhat.com" target=3D"_blank" = class=3D"">stirabos@redhat.com</a></td> <td align=3D"left" class=3D"">Adding additional ha-host = fails.</td></tr></tbody></table></div></div></blockquote></span></div></di= v></div></blockquote><div class=3D""><br class=3D""></div><div = class=3D"">This one has a verified engine fix now, we just need to merge = it and update Node 0 setup (also verified).</div><span = class=3D"m_7051580001592472347gmail-HOEnZb"><font color=3D"#888888" = class=3D""><div class=3D""><br class=3D""></div><div class=3D""><br = class=3D""></div><div class=3D"">Martin</div></font></span></div><br = class=3D""></div></div> <br class=3D""></span><span class=3D"">______________________________<wbr = class=3D"">_________________<br class=3D""> Devel mailing list<br class=3D""> <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""> <a href=3D"http://lists.ovirt.org/mailman/listinfo/devel" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman<wbr = class=3D"">/listinfo/devel</a><br class=3D""></span></blockquote></div><br= class=3D""></div></div> </blockquote></div><br class=3D""></div></div> _______________________________________________<br class=3D"">Devel = mailing list<br class=3D""><a href=3D"mailto:Devel@ovirt.org" = class=3D"">Devel@ovirt.org</a><br = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</div></blockquote=
</div><br class=3D""></body></html>=
--Apple-Mail=_AFE2C3E6-A66D-4F8E-915C-617430C259F0--