----- Original Message -----
From: "Yaniv Kaul" <ykaul@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: engine-devel@ovirt.org Sent: Tuesday, February 21, 2012 5:27:19 PM Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under the following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
Thanks, Gilad.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it mean that a VM already exist in the setup? If I had a VM with 10GB disk, without an OS installed, then exported it, then installed an OS into it (so now the disk is a bit full, as opposed to the emptied exported one). Does it means that an identical entity already exist in the setup or not? (think of overwriting files).
not. We need to think how to portray it to the user, it a bit tricky.
The design should (ALWAYS?) start with the user flow.
I'll change it.
2. 'clone' doesn't strike me as a great parameter name in the API. Not in the UI either (but I don't have a better suggestion - yet).
Other suggestions are welcomed, Omer has one.
3. What is the equivalent to 'suffix' in the API? Or do we expect to provide a name when we import? I'm not sure how the API works in the case of an existing VM, really. Only after we fetch via the API the fact it has an existing VM, we give it a new suffix?
In fact it's the same (just need to clarify that), the suffix is GUI only, and the client passes the vm name in the vm's vm_name field (old_name + suffix). In REST the vm name will be passed a part of the action parameters: <action> <cluster id="afsdasdf"/> <storage_domain id="5@#$^234634^"/> <clone>true</clone> //This is the new value <vm> <name>new_name</name> </vm> </action> note: in case the clone flag is true the vm.name is mandatory. (will update the wiki for all the above)
4. Small typos (I'll fix them later directly in the wiki, except for the mockups, which I can't fix). Y.