[ovirt-devel] Re: RHV and oVirt CBT issue

On Fri, Jul 30, 2021 at 5:47 AM luwen.zhang <luwen.zhang(a)vinchin.com&gt; wrote: Why do you need the snapshot list when doing incremental backup? What you need is the list of disks in the vms, accessible via: GET /vms/{vm-id}/diskattachments For each disk attachment, get the disk using the diskattachment.disk.id: GET /disks/{disk-id}/ Please check how we do this in backup_vm.py example: https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/backup... We need a much more detailed steps. This is a typical backup flow: 1. Start incremental backup 2. Wait until backup is ready (phase == READY) 3. Start image transfer for incremental backup 4. Wait until image transfer is ready (phase == TRANSFERRING) 5. Download disk incremental data 6. Finalize transfer 7. Wait until transfer is finished (phase == FINISHED_SUCCESS/FINISHED_FAILURE) This is not easy, see this example: https://github.com/oVirt/ovirt-engine-sdk/blob/ac6f05bb5dcd8fdee2a67b2a29... 8. Finalize backup 9. Wait until backup is finished (phase == FINISHED/FAILED) This is easier, but possible only since 4.4.7: https://github.com/oVirt/ovirt-engine-sdk/blob/ac6f05bb5dcd8fdee2a67b2a29... 10. Rebase backup image on previous backup (if you store backup as qcow2 layers) Where in this flow you get the snapshot list (and other stuff?) Getting snapshots list is likely not needed for backup, but we need to fix it in case it is broken while running backups or image transfers. Do you run this flow in a loop? Maybe you do not wait until the previous image transfer was finished before starting a new backup? Thanks, we will check the logs next week.