Hi Eli,
The patch was merged yesterday yet master is still failing.
Could you please take a look?
Link to job with patch merged:
On Tue, Apr 25, 2017 at 4:53 PM, Gil Shinar <gshinar(a)redhat.com> wrote:
Hi Eli,
When was it merged? I looked at the patch in your former message and it is
not merged.
Master is still failing on add_secondary_storage_domains
Thanks
Gil
On Tue, Apr 25, 2017 at 5:19 PM, Eli Mesika <emesika(a)redhat.com> wrote:
> The fix for that regression was merged to master, please sync and check
> again
>
> On Tue, Apr 25, 2017 at 5:14 PM, Eli Mesika <emesika(a)redhat.com> wrote:
>
>> Hi
>>
>> Please review the fixing patch
>>
https://gerrit.ovirt.org/#/c/76013/2
>>
>> On Tue, Apr 25, 2017 at 3:00 PM, Fred Rolland <frolland(a)redhat.com>
>> wrote:
>>
>>> Eli hi,
>>>
>>> It seems there is some issue in the squash patch [1].
>>>
>>> Regarding the issue found by the OST, if you start from a fresh DB,
>>> wrong values will be inserted in the "spec_params" column in the
vm_device
>>> table. [2]
>>> We will get '58ca7b19-0071-00c0-01d6-000000000212' instead of a map
>>> like { "vram" : "65536" }
>>>
>>> It will fail the creation of the AddVmTemplateCommand that we see in
>>> the log.
>>>
>>> Regards,
>>>
>>> Freddy
>>>
>>> [1]
https://gerrit.ovirt.org/#/c/74382/
>>> [2]
https://gerrit.ovirt.org/#/c/74382/8/packaging/dbscripts/dat
>>> a/01200_insert_vm_device.sql
>>>
>>> On Tue, Apr 25, 2017 at 12:13 PM, Fred Rolland <frolland(a)redhat.com>
>>> wrote:
>>>
>>>> Looking at it
>>>>
>>>> On Tue, Apr 25, 2017 at 12:11 AM, Nadav Goldin
<ngoldin(a)redhat.com>
>>>> wrote:
>>>>
>>>>> Test failed: add_secondary_storage_domains/
>>>>> import_template_from_glance
>>>>>
>>>>> Link to suspected patches:
https://gerrit.ovirt.org/#/c/74382/
>>>>>
>>>>> Link to Job:
http://jenkins.ovirt.org/job/t
>>>>> est-repo_ovirt_experimental_master/6456/
>>>>> (started in 6451)
>>>>>
>>>>> Link to all logs:
>>>>>
http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_ma
>>>>> ster/6456/artifact/exported-artifacts/basic-suit-master-el7/
>>>>> test_logs/basic-suite-master/post-002_bootstrap.py/
>>>>>
>>>>> Engine log:
http://jenkins.ovirt.org/job/t
>>>>> est-repo_ovirt_experimental_master/6456/artifact/exported-ar
>>>>> tifacts/basic-suit-master-el7/test_logs/basic-suite-master/p
>>>>> ost-002_bootstrap.py/lago-basic-suite-master-engine/_var_log
>>>>> /ovirt-engine/engine.log
>>>>>
>>>>> Error snippet from the test log:
>>>>>
>>>>> <error>
>>>>>
>>>>> lago.utils: ERROR: Error while running thread
>>>>> Traceback (most recent call last):
>>>>> File "/usr/lib/python2.7/site-packages/lago/utils.py",
line 58, in
>>>>> _ret_via_queue
>>>>> queue.put({'return': func()})
>>>>> File
"/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bo
>>>>> otstrap.py",
>>>>> line 803, in import_template_from_glance
>>>>> generic_import_from_glance(api, image_name=CIRROS_IMAGE_NAME,
>>>>> image_ext='_glance_template', as_template=True)
>>>>> File
"/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bo
>>>>> otstrap.py",
>>>>> line 641, in generic_import_from_glance
>>>>> lambda: api.disks.get(disk_name).status.state == 'ok',
>>>>> File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>>> 264, in assert_true_within_long
>>>>> assert_equals_within_long(func, True, allowed_exceptions)
>>>>> File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>>> 251, in assert_equals_within_long
>>>>> func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exceptions
>>>>> File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>>> 230, in assert_equals_within
>>>>> '%s != %s after %s seconds' % (res, value, timeout)
>>>>> AssertionError: False != True after 600 seconds
>>>>>
>>>>>
>>>>> </error>
>>>>>
>>>>>
>>>>> the engine.log has this sequence repeating(apparently at the end of
>>>>> the task - 199ed356):
>>>>>
>>>>> 2017-04-24 13:34:50,079-04 INFO
>>>>> [org.ovirt.engine.core.bll.storage.repoimage.ImportRepoImageCommand]
>>>>> (DefaultQuartzScheduler10) [199ed356-0960-4ef4-9637-09c76a07c932]
>>>>> Ending command 'org.ovirt.engine.core.bll.sto
>>>>> rage.repoimage.ImportRepoImageCommand'
>>>>> successfully.
>>>>> 2017-04-24 13:34:50,090-04 ERROR
>>>>> [org.ovirt.engine.core.bll.CommandsFactory]
>>>>> (DefaultQuartzScheduler10)
>>>>> [] An exception has occurred while trying to create a command object
>>>>> for command 'AddVmTemplate' with parameters
>>>>> 'AddVmTemplateParameters:{commandId='a6d45092-dfe0-4a65-bdc4
>>>>> -4c23a68fe7d5',
>>>>> user='admin', commandType='Unknown'}':
WELD-000049: Unable to invoke
>>>>> protected final void
>>>>> org.ovirt.engine.core.bll.CommandBase.postConstruct() on
>>>>> org.ovirt.engine.core.bll.AddVmTemplateCommand@35c1cbd5
>>>>> 2017-04-24 13:34:50,095-04 INFO
>>>>> [org.ovirt.engine.core.utils.transaction.TransactionSupport]
>>>>> (DefaultQuartzScheduler10) [] transaction rolled back
>>>>> 2017-04-24 13:34:50,123-04 INFO
>>>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLo
>>>>> gDirector]
>>>>> (DefaultQuartzScheduler10) [] EVENT_ID:
>>>>> USER_IMPORT_IMAGE_AS_TEMPLATE_FINISHED_SUCCESS(3,018), Correlation
>>>>> ID:
>>>>> 199ed356-0960-4ef4-9637-09c76a07c932, Job ID:
>>>>> 0b91fec3-97be-493f-9dfb-af1230e4d3ee, Call Stack: null, Custom Event
>>>>> ID: -1, Message: User admin@internal-authz successfully imported
>>>>> image
>>>>> CirrOS_0.3.4_for_x86_64_glance_template as template
>>>>> CirrOS_0.3.4_for_x86_64_glance_template to domain iscsi.
>>>>> 2017-04-24 13:34:50,123-04 ERROR
>>>>> [org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller]
>>>>> (DefaultQuartzScheduler10) [] Failed invoking callback end method
>>>>> 'onSucceeded' for command
'25028c51-d877-44e3-b1ef-40b315b469d3' with
>>>>> exception 'null', the callback is marked for end method
retries
>>>>>
>>>>> Thanks,
>>>>> Nadav.
>>>>> _______________________________________________
>>>>> Devel mailing list
>>>>> Devel(a)ovirt.org
>>>>>
http://lists.ovirt.org/mailman/listinfo/devel
>>>>>
>>>>
>>>>
>>>
>>
>
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/infra
>
>
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel