I like the idea but I have the same feelings as Francesco. I think that we need to make sure that functional tests for each vertical are stable before enabling this process. On Sun, Dec 13, 2015 at 8:34 AM, Eyal Edri <eedri@redhat.com> wrote:
adding also infra team for visibility on the change in CI. also inline.
On Fri, Dec 11, 2015 at 4:19 PM, Francesco Romani <fromani@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: devel@ovirt.org, "Francesco Romani" <fromani@redhat.com>, "Nir Soffer" <nsoffer@redhat.com>, "Piotr Kliczewski" <pkliczew@redhat.com> Cc: "danken" <danken@redhat.com>, "David Caro" <dcaroest@redhat.com>, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, December 10, 2015 6:46:37 PM Subject: Automation CI for vdsm
[...]
We want to allow developers to trigger the script once reviews and verification are ready (last step before merge). To do so we agreed to add Continues Integration flag for each vdsm patch.
This flag will be called 'Workflow' or we can name it otherwise, we just need to choose what makes sense. David/Yaniv - Please correct me if I'm wrong.
signed with +1 it will trigger Jenkins CI to run the check-merged script (adding new button to gerrit is not an option - you can image that flag as a trigger button), on success Jenkins CI flag will turn to +2. on fail we'll get -1 and once new patchset is ready the developer will remove
Once this flag will be the
+1 and add it back to the Continues Integration flag to re-trigger the job.
Please ack the process before we move on with that
Sounds good, even though I'm a little scared (just gut feeling, no evidence whatsoever) that this could add even more complexity and fragility to the jenkins fleet.
In the long run, when this is reliable, it will help greatly. In the short term, I'm scared because this can lead to false positives and bogus failures.
Let me stress I don't have concrete item to share or specific flaws.
As action item on me, I will find some time next week to check virt functional tests, to see if they need some fixes, work reliably and so forth
The patch for those scripts still under review and testing - https://gerrit.ovirt.org/#/c/48268
Will review asap.
-- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani
-- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)