
29 Jun
2017
29 Jun
'17
3:16 p.m.
Do we have or follow a standard on patch granularity? When I started, I picked up on the culture that we do small, logical commits -- as much as possible, each commit should be focused on a specific purpose. I've perceived some reviewers prefer to have all orthogonal changes (fix a random spelling error, remove a duplicate semicolon) extracted to other patches for clarity. Others don't seem to mind. I feel like I always want to ask, but I feel bad because it's a hassle. Also, when you are asked to extract something, do you have a trick to make it as easy as possible? Best wishes, Greg -- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com