IMO, we have too many classes that do the same (useless) thing - org.ovirt.engine.core.utils.linq.LinqUtils and org.ovirt.engine.core.common.utils.ListUtils, which both have no place in oVirt-engine. Why not scrap both of them, upgrade commons-collections to the modern 4.0 and use org.apache.commons.collections4.CollectionUtils which has all of their functionality, fully-tested, and maintained by someone else? ----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, August 21, 2014 9:04:05 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, August 21, 2014 5:50:44 AM Subject: [ovirt-devel] [ENGINE] thoughts about LinqUtils
Hi Engine developers (and others :) ), I would like to share some thoughts & questions with you about the future of LinqUtils
1. Location of LinqUtils
Currently LinqUtils resides at utils. However, as LinqUtils contains some non engine related code, I think it should be moved to the new uutils (universal utils) project. uutils was introduced during the work on AAA, in order to provide a set of utilities that are not engine related, and hopefully in the future will be published as a separate artifcat on maven central (Alon, feel free to correct me here :) )
+1 You'd probably have to address the entire org.ovirt.engine.core.utils.linq package and not just that specific class. A sort of a clean-up is also required (i.e. remove IDE generated comments), seems like a good chance to do it.
2. The name LinqUtils - Linq comes from c#. I think these days are way behind us (3 years or so now?) i would like to suggest renaming the class. CollectionUtils? Any other suggestions are more than welcome
+1
Thanks, Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel