Re: [ovirt-devel] [ACTION REQUIRED] engine-setup broken on master due to missing SysPrep2K3Path

On 25 Nov 2014, at 17:26, Mooli Tayer <mtayer(a)redhat.com&gt; wrote: > > > ----- Original Message ----- >> Il 13/11/2014 11:59, Michal Skrivanek ha scritto: >>> >>> On Nov 6, 2014, at 14:30 , Martin Betak <mbetak(a)redhat.com&gt; wrote: >>> >>>> ----- Original Message ----- >>>>> From: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; >>>>> To: mbetak(a)redhat.com >>>>> Cc: devel(a)ovirt.org, "Yedidyah Bar David" <didi(a)redhat.com&gt;, "Lev Veyde" >>>>> <lveyde(a)redhat.com&gt;, "Simone Tiraboschi" >>>>> <stirabos(a)redhat.com&gt; >>>>> Sent: Thursday, November 6, 2014 1:48:21 PM >>>>> Subject: [ACTION REQUIRED] engine-setup broken on master due to missing >>>>> SysPrep2K3Path >>>>> >>>>> 2014-11-06 13:38:41 DEBUG otopi.ovirt_engine_setup.engine_common.database >>>>> database.execute:164 Database: 'None', Statement: ' >>>>> select version, option_value >>>>> from vdc_options >>>>> where option_name = %(name)s >>>>> ', args: {'name': 'SysPrep2K3Path'} >>>>> 2014-11-06 13:38:41 DEBUG otopi.ovirt_engine_setup.engine_common.database >>>>> database.execute:214 Result: [] >>>>> 2014-11-06 13:38:41 DEBUG otopi.context context._executeMethod:152 method >>>>> exception >>>>> Traceback (most recent call last): >>>>> File "/usr/lib/python2.7/site-packages/otopi/context.py", line 142, in >>>>> _executeMethod >>>>> method['method']() >>>>> File >>>>> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py", >>>>> line 88, in _misc >>>>> ).getVdcOption(name=vdco) >>>>> File >>>>> "/usr/share/ovirt-engine/setup/ovirt_engine_setup/engine/vdcoption.py", >>>>> line 88, in getVdcOption >>>>> ownConnection=ownConnection, >>>>> File >>>>> "/usr/share/ovirt-engine/setup/ovirt_engine_setup/engine/vdcoption.py", >>>>> line 63, in getVdcOptionVersions >>>>> name=name, >>>>> RuntimeError: Cannot locate application option SysPrep2K3Path >>>>> >>>>> Looks like >>>>> commit 4a02e12ac9a4f2e18340c177c5f656ddf753694e >>>>> Author: Martin Betak <mbetak(a)redhat.com&gt; >>>>> Date: Wed Nov 5 15:00:47 2014 +0100 >>>>> >>>>> core: Drop legacy SysPrep paths from config >>>>> >>>>> Change-Id: I675340ae90aa724b935b0cf0a25544c06b0177eb >>>>> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1086768 >>>>> Signed-off-by: Martin Betak <mbetak(a)redhat.com&gt; >>>>> >>>>> >>>>> Broke the setup. >>>>> Can you please advise about what the setup should do now? >>>> >>>> The upgrade script 0000_config.sql now deletes the values from DB. >>>> Is it possible to make this python script run before the DB upgrade >>>> scripts are run? >>> >>> the correct solution is to remove the osinfo handling from >>> ovirt-engine-setup; it has no use since 3.4. it can only make things >>> worse:) >>> all dbs should already be upgraded/transitioned to use osinfo so the >>> sysprep vars in config are useless for a long time already >> >> Ok, can you please open a bz on setup and block 1086768 or push a patch? > > Any progress with this issue? master should be ok > I see it happening on 3.5 as well. How could it be on 3.5? The removal was merged to master only 3 weeks ago, not to 3.5. Are tou seeing the same problem?

Thanks, michal > >>> >>> Thanks, >>> michal >>> >>> >>>> We really don't want to keep this unused values in the database after the >>>> correct migration >>>> to osinfo is performed. >>>> >>>>> >>>>> -- >>>>> Sandro Bonazzola >>>>> Better technology. Faster innovation. Powered by community collaboration. >>>>> See how it works at redhat.com >>>> _______________________________________________ >>>> Devel mailing list >>>> Devel(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/devel >> >> >> -- >> Sandro Bonazzola >> Better technology. Faster innovation. Powered by community collaboration. >> See how it works at redhat.com >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >>