7:34 a.m.
--/QKKmeG/X/bPShih
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 02/23, Nir Soffer wrote:
----- Original Message -----
> From: "David Caro" <dcaroest(a)redhat.com>
> To: devel(a)ovirt.org
> Sent: Monday, February 23, 2015 12:54:26 PM
> Subject: Re: [ovirt-devel] Gerrit restart
>=20
>=20
> I've done a few tests now and everything seems to work as expected, can
> anyone
> confirm that it's working for him?
=20
It seem to work but there are few issues:
=20
1. Vertical and horizontal scrolling in the commit message pane
The new version assume that the commit message is limited to
about 70 characters, which is not true practically.
The commit message must include sometimes much wider content,
and the view should display correctly our data instead of=20
trying to force the views of the tool authors.
Example: http://gerrit.ovirt.org/36593
This has always been like that as far as I remember. Not a new issue. Actua=
lly
now it allows you to scroll instead of letting the text go all the way out =
the
screen, I think it's an improvement.
=20
2. The changes view (http://gerrit.ovirt.org/#/dashboard/self)
Show a new "Status" column, which has two issues:
- Showing "Draft" or "Merge Conflict" - these are separate
concepts
That's a design decision, nothing we can do about. Feel free to develop a ui
plugin to hide it if it bothers you, this new version allows it (the old did
not).
- Showing "Merge Conflict" when there is no merge
conflict
Example: http://gerrit.ovirt.org/38044
You can't cherry-pick that patch into master directly (vdsm project submit
type is cherry-pick):
01:16 PM ~/Work/redhat/ovirt/vdsm (master|=E2=9C=94)=20
dcaro@brete$ git fetch ssh://dcaro@gerrit.ovirt.org:29418/vdsm refs/changes=
/28/38028/1
remote: Counting objects: 745, done
remote: Finding sources: 100% (29/29)
remote: Total 29 (delta 3), reused 9 (delta 3)
Unpacking objects: 100% (29/29), done.
=46rom ssh://gerrit.ovirt.org:29418/vdsm
* branch refs/changes/28/38028/1 -> FETCH_HEAD
01:16 PM ~/Work/redhat/ovirt/vdsm (master|=E2=9C=94)=20
dcaro@brete$ git cherry-pick FETCH_HEAD
error: could not apply 53f59a7... virt: Extract Vm.__extendDriveReplica met=
hod
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
01:17 PM ~/Work/redhat/ovirt/vdsm (master|=E2=9C=96 1=E2=9C=9A 1)=20
dcaro@brete$
=20
3. The new "Conflict with" pane seems incorrect about patches
which do not conflict (at least not when merged in the correct
order of dependencies).
Example: http://gerrit.ovirt.org/37727
I don't think it's taking into account the deps, the conflict seems to be
calculated from path to path directly. Feel free to open a but to gerrit if=
you
think any of those issues should not be there or it's a bug.
https://code.google.com/p/gerrit/issues/list
=20
So this seems to be a regression. Can we test such upgrades
with our data before we deploy them?
=20
Sure, I'll ping you to do the testing next time we plan an upgrade, I'll ha=
ve
to trim down some of the data but I'll gladly spend some time on it to prov=
ide
you with a working dataset you can install and test before the upgrade.
=20
Nir
=20
>=20
> If noone replies, I'll consider it solved
>=20
> cheers
>=20
> On 02/23, David Caro wrote:
> >=20
> > Hi!
> >=20
> > After this morning upgrade, gerrit http access has stopped working, I=
'm
> > trying
> > to solve it but in the meantime I might have to restart gerrit a coup=
le
of
> > times, you can still use git or ssh to clone repos.
> >=20
> >=20
> > I'll update when finished.
> >=20
> >=20
> >=20
> >=20
> > --
> > David Caro
> >=20
> > Red Hat S.L.
> > Continuous Integration Engineer - EMEA ENG Virtualization R&D
> >=20
> > Tel.: +420 532 294 605
> > Email: dcaro(a)redhat.com
> > Web: www.redhat.com
> > RHT Global #: 82-62605
>=20
>=20
>=20
> --
> David Caro
>=20
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>=20
> Tel.: +420 532 294 605
> Email: dcaro(a)redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
>=20
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--/QKKmeG/X/bPShih
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJU6x47AAoJEEBxx+HSYmnDPhYH/1EWyp10Jnv3uZOdgfWhC2cO
TjBz9V2BMA+ELcAapDnFIFqpSFd6WX2b+rQH6Uhkpjs1oadM0Te8+aNMwxvqoBnM
AYVJhqgOJSfUtZToTNlm9n6nYCw6f7EFizoZUlp2rA8reYkMjFpI7BvebFaxlfud
1K7LoyUXUVQtqnn7Oabr87KxBvY6HIx+US1CRG6s9rzNOHvHebrrar0bHJ0CY4bm
o9diu/L7U3saKyFfehvM8qooBU4dePQmVHcQgmAwfhK7Cuv8TjIT78O9oaml3TME
NYYFdkQ15BEeM/z4W4dbWR3c93WiFNBu4T6Z/FJYFOpLOKG3bycXwQMn+B9hvc8=
=d1Le
-----END PGP SIGNATURE-----
--/QKKmeG/X/bPShih--