settings.xml is consumed by maven only, while other programs such as IDE, Jboss, etc consume environment variables set in other ways such as .bashrc. Thus we need them both - and this is why I think it's better to re-use the configuration from .bashrc in settings.xml. ----- Original Message ----- From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "Alissa Bonas" <abonas@redhat.com> Cc: engine-devel@ovirt.org Sent: Monday, November 26, 2012 6:52:52 PM Subject: Re: [Engine-devel] maven settings.xml in building ovirt engine wiki Hi, That too could work, but once it already needs to be in the settings.xml, why would you want another configuration file (like .bashrc)? ----- Original Message -----
From: "Alissa Bonas" <abonas@redhat.com> To: engine-devel@ovirt.org Sent: Monday, November 26, 2012 10:15:14 AM Subject: [Engine-devel] maven settings.xml in building ovirt engine wiki
Hi,
In this wiki http://wiki.ovirt.org/wiki/Building_oVirt_engine
The suggested maven settings.xml contains hardcoded paths to jboss_home and java_home. IMHO it's better to use environment variables to take the above settings from there, instead of managing those settings twice in 2 different places.
The current settings look like this (note that java path is incorrect anyway, including /bin/java)
<jbossHome>/usr/share/jboss-as</jbossHome> <JAVA_HOME>/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.0.x86_64/bin/java</JAVA_HOME>
How about changing settings.xml to something like:
<jbossHome>${env.JBOSS_HOME}</jbossHome> <JAVA_HOME>${env.JAVA_HOME}</JAVA_HOME>
Does anyone see a problem with the suggested approach?
Thanks
Alissa
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel