Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote: > Thanks to you too for checking. > > Martin > Fix is pending review [1]. We moved the main views to a different class hierarchy and it wasn't inheriting the methods to add the buttons. Alexander [1] https://gerrit.ovirt.org/c/84901/ > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta <gshereme(a)redhat.com&gt; wrote: > > Discussed with Alexander, and yep this is an issue. > > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724 > > > > Thanks for checking and reporting! > > > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <gshereme(a)redhat.com&gt; > > > > wrote: > >> +Alexander, can you take a look? > >> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak <msivak(a)redhat.com&gt; wrote: > >>> Hi, > >>> > >>> I think I found one issue.. I do not see the extra menu items that were > >>> supposed to be added to VMs (used to be available in context menu as > >>> well). > >>> > >>> You can check it with > >>> > >>> http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa > >>> tch-el7-x86_64/65/ > >>> > >>> Martin > >>> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <gshereme(a)redhat.com > > >>> > >>> wrote: > >>>> Hey, > >>>> > >>>> We haven't changed the API, so everything should still work. For > >>>> example, I just installed 4.1 versions of dashboard and support-plugin > >>>> in > >>>> master, and all's well [*]: > >>>> > >>>> API: > >>>> > >>>> api.addSubTab('Template', 'Red Hat Documentation', > >>>> 'my-host-subtab-template', '<url snip>', {alignRight: true}); > >>>> api.setTabAccessible('my-host-subtab-template', true); > >>>> > >>>> [image: Inline image 1] > >>>> > >>>> [*] however, note that "alignRight" is now ignored > >>>> > >>>> And dashboard 4.1.8 installed in master engine: > >>>> > >>>> [image: Inline image 2] > >>>> > >>>> > >>>> That said, we probably should have sent some announcement about making > >>>> sure the plugins actually look good with the new theme. If some plugins > >>>> are > >>>> greenish, that will look bad. > >>>> > >>>> To help with styling external things, we've started exposing more CSS > >>>> via a new SASS brand module: > >>>> https://github.com/oVirt/ovirt-engine/tree/master/frontend/b > >>>> rands/ovirt-brand/src/main/sass > >>>> Also, we're heavily relying on base PatternFly styles, and plugins > >>>> should do the same. For example, the new dialog styles are completely > >>>> PatternFly [http://www.patternfly.org/pattern-library/forms-and- control > >>>> s/modal-overlay/] and we don't do anything extra on top of that. > >>>> > >>>> Let us know if something doesn't work, or you need help styling > >>>> something. > >>>> > >>>> Greg > >>>> > >>>> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <msivak(a)redhat.com&gt; > >>>> > >>>> wrote: > >>>>> Hi, > >>>>> > >>>>> I just got a question from an ovirt-optimizer user about the support > >>>>> in 4.2. And I realized I haven't heard anything about how UI plugins > >>>>> should be updated to work with the new UI. > >>>>> > >>>>> Is there anything special that needs to be done to make the plugin > >>>>> functional? Or will everything still work somehow? > >>>>> > >>>>> Best regards > >>>>> > >>>>> Martin Sivak > >>>>> _______________________________________________ > >>>>> Devel mailing list > >>>>> Devel(a)ovirt.org > >>>>> http://lists.ovirt.org/mailman/listinfo/devel > >> > >> -- > >> > >> GREG SHEREMETA > >> > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX > >> > >> Red Hat NA > >> > >> <https://www.redhat.com/> > >> > >> gshereme(a)redhat.com IRC: gshereme > >> <https://red.ht/sig> > > > > -- > > > > GREG SHEREMETA > > > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX > > > > Red Hat NA > > > > <https://www.redhat.com/> > > > > gshereme(a)redhat.com IRC: gshereme > > <https://red.ht/sig>