Re: [Engine-devel] Development process wiki page
----- Original Message -----
From: "Moti Asayag" <masayag(a)redhat.com>
To: engine-devel(a)ovirt.org
Sent: Monday, January 30, 2012 10:30:01 AM
Subject: Re: [Engine-devel] Development process wiki page
We should add some guideline for the review process as well to ease
the
process for the reviewers.
When pushing a newer version of a patch to gerrit we can distinguish
between a patch which was already reviewed to non-reviewed patch:
1. A reviewed patch: the previous patch-set contains reviewer
comments,
therefore the expected change should be described there, as part of
the
conversation around a specific piece of code (either as a reply or
using
the 'Done' button).
2. A new reviewed patch: A general message should be added on the
patch
level describing what have changed since previous patch-set.
Thoughts ?
Sounds good to me.
In case a newer patch version is needed due to gerrit asking you to fetch+rebase, it adds
such a general comment message on its own, so in that case one won't need to do it
explicitly.
I'll update the oVirt gerrit wiki page with these details (will wait a while for other
people to comment...).
On 01/30/2012 09:45 AM, Oved Ourfalli wrote:
> Hey all,
>
> I've wrote a wiki page on the oVirt development process.
> It contains mostly information on the patch review process, patch
> submission and some git guidelines.
>
> http://www.ovirt.org/wiki/DevProcess
>
> I added a link to it from the main wiki page.
>
> Your comments are welcome.
>
> Thank you,
> Oved
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel