Re: [Engine-devel] [vdsm] stale gerrit patches
On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Monday, September 23, 2013 1:50:35 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>>
>>
>> ----- Original Message -----
>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>> To: "David Caro" <dcaroest(a)redhat.com>
>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
>>> vdsm-devel(a)lists.fedorahosted.org
>>> Sent: Monday, September 23, 2013 1:47:47 PM
>>> Subject: Re: [vdsm] stale gerrit patches
>>>
>>> On 09/23/2013 01:46 PM, David Caro wrote:
>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>>> we have some very old gerrit patches.
>>>>> I'm for abandoning patches which were not touched over 60 days
(to
>>>>> begin with, I think the number should actually be lower).
>>>>> they can always be re-opened by any interested party post their
closure.
>>>>>
>>>>> i.e., looking at gerrit, the patch list should actually get
attention,
>>>>> and not be a few worth looking at, with a "lot of old
patches"
>>>>>
>>>>> thoughts?
>>>>>
>>>>> Thanks,
>>>>> Itamar
>>>>> _______________________________________________
>>>>> vdsm-devel mailing list
>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>>
>>>> It might helpful to have a cron-like script that checks the age of the
>>>> posts and first notifies the sender, the reviewers and the maintainer,
>>>> and if the patch is not updated in a certain period just abandons it.
>>>>
>>>
>>> yep - warn after X days via email to just owner (or all subscribed to
>>> the patch), and close if no activity for X+14 days or something like that.
>>
>> This will be annoying.
>>
>> And there are patches that pending with good reason.
>
> pending for 60 days with zero activity on them (no comment, no rebase,
> nothing)?
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever
>
>>
>> Maintainers can close patches that are no interest nor progress.
>>
>> Alon
>>
>
>