Re: [Engine-devel] [vdsm] Strange input from oVirt-engine for create (VM) API
On Mon, Oct 22, 2012 at 02:22:18PM -0500, Adam Litke wrote:
Hi all,
Today I was watching the vdsm log as ovirt-engine started a VM and I saw
something peculiar with how VM device addresses were specified. Here is a
sample of the python dictionary for the VM from vdsm.log (I reformatted it with
pprint for readability):
{'address': {' bus': '1',
' controller': '0',
' target': '0',
' type': 'drive',
'unit': '0'},
Notice the whitespace in the 'controller', 'target', and 'type'
keys. Could
someone explain why this is happening? Is it deliberate or a bug?
I'm ashamed to see that I've taken a patch stripping these whitespaces
without discussion
http://gerrit.ovirt.org/#/c/3107/1/vdsm/libvirtvm.py
Igor, do you remember why this was not fixed properly, at the Engine
side?
Vdsm's schema should not be as lenient as the current code.
Dan.