[Engine-devel] REST API - where did bookmarks go?
Hi guys, as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with. I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API? Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something? Thanks, Vojtech
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them. -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here: https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
Hi Guys, Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-) Thanks, Gilad. ----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks. [keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it] As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API. ---- Thanks, Einav ----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Hi Einav, I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case). Thanks, Gilad. ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
So iiuc, we are going to develop a known obsolete feature :-) ? Can we break it in 4.0? Thanks, Gilad. ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:55:20 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > Hi guys, > > as part of prototyping new JavaScript binding for oVirt REST API, > we chose a couple of business entities (resources) to experiment > with. > > I just realized that requesting /ovirt-engine/api doesn't return > any information about bookmarks. Where did bookmarks go? Is it > possible to manage bookmarks through REST API? > > Note: WebAdmin currently gets bookmarks through GWT RPC by > calling > GetAllBookmarksQuery. Bookmark seems like proper backend business > entity (with DAO and everything) so it should be exposed also via > REST API.. or am I missing something? > > Thanks, > Vojtech >
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:58:01 AM
So iiuc, we are going to develop a known obsolete feature :-) ? Can we break it in 4.0?
well, since they were never exposed, we can also decide that we are not implementing them at all, but this means that we are losing the server-side bookmarks once we move the GUI to work with the REST-API. question is if everyone are OK with that... to be on the safe side and to not lose any functionality/data, I suggest to add them to the REST API, and for 4.0 - discuss whether they should be removed (and possibly replaced with client-side bookmarks in the GUI)
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:55:20 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- > From: "Juan Hernandez" <jhernand@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Cc: "Einav Cohen" <ecohen@redhat.com> > Sent: Tuesday, March 11, 2014 7:22:35 PM > Subject: Re: REST API - where did bookmarks go? > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > > Hi guys, > > > > as part of prototyping new JavaScript binding for oVirt REST > > API, > > we chose a couple of business entities (resources) to > > experiment > > with. > > > > I just realized that requesting /ovirt-engine/api doesn't > > return > > any information about bookmarks. Where did bookmarks go? Is it > > possible to manage bookmarks through REST API? > > > > Note: WebAdmin currently gets bookmarks through GWT RPC by > > calling > > GetAllBookmarksQuery. Bookmark seems like proper backend > > business > > entity (with DAO and everything) so it should be exposed also > > via > > REST API.. or am I missing something? > > > > Thanks, > > Vojtech > > > > The didn't go anywhere, just never existed in the API. Please > open > a > RFE > to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
> > -- > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, > planta > 3ºD, 28016 Madrid, Spain > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red > Hat > S.L. > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 03/24/2014 05:17 PM, Einav Cohen wrote:
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:58:01 AM
So iiuc, we are going to develop a known obsolete feature :-) ? Can we break it in 4.0?
well, since they were never exposed, we can also decide that we are not implementing them at all, but this means that we are losing the server-side bookmarks once we move the GUI to work with the REST-API. question is if everyone are OK with that...
to be on the safe side and to not lose any functionality/data, I suggest to add them to the REST API, and for 4.0 - discuss whether they should be removed (and possibly replaced with client-side bookmarks in the GUI)
Actually adding support for bookmarks has been targeted for 4.0, and work is about to start (if not started yet). Martin, please, don't start working on this till it is decided if we will have or not the bookmarks in 4.0.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:55:20 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message ----- > From: "Vojtech Szocs" <vszocs@redhat.com> > To: "Juan Hernandez" <jhernand@redhat.com> > Cc: "engine-devel" <engine-devel@ovirt.org> > Sent: Wednesday, March 12, 2014 1:27:19 PM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > > > ----- Original Message ----- >> From: "Juan Hernandez" <jhernand@redhat.com> >> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" >> <engine-devel@ovirt.org> >> Cc: "Einav Cohen" <ecohen@redhat.com> >> Sent: Tuesday, March 11, 2014 7:22:35 PM >> Subject: Re: REST API - where did bookmarks go? >> >> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: >>> Hi guys, >>> >>> as part of prototyping new JavaScript binding for oVirt REST >>> API, >>> we chose a couple of business entities (resources) to >>> experiment >>> with. >>> >>> I just realized that requesting /ovirt-engine/api doesn't >>> return >>> any information about bookmarks. Where did bookmarks go? Is it >>> possible to manage bookmarks through REST API? >>> >>> Note: WebAdmin currently gets bookmarks through GWT RPC by >>> calling >>> GetAllBookmarksQuery. Bookmark seems like proper backend >>> business >>> entity (with DAO and everything) so it should be exposed also >>> via >>> REST API.. or am I missing something? >>> >>> Thanks, >>> Vojtech >>> >> >> The didn't go anywhere, just never existed in the API. Please >> open >> a >> RFE >> to add them. > > Thanks, Juan. The RFE is here: > > https://bugzilla.redhat.com/1075556 >
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Einav Cohen" <ecohen@redhat.com>, "Gilad Chaplik" <gchaplik@redhat.com>, "Martin Perina" <mperina@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:33:49 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On 03/24/2014 05:17 PM, Einav Cohen wrote:
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:58:01 AM
So iiuc, we are going to develop a known obsolete feature :-) ? Can we break it in 4.0?
well, since they were never exposed, we can also decide that we are not implementing them at all, but this means that we are losing the server-side bookmarks once we move the GUI to work with the REST-API. question is if everyone are OK with that...
to be on the safe side and to not lose any functionality/data, I suggest to add them to the REST API, and for 4.0 - discuss whether they should be removed (and possibly replaced with client-side bookmarks in the GUI)
Actually adding support for bookmarks has been targeted for 4.0, and work is about to start (if not started yet).
Martin, please, don't start working on this till it is decided if we will have or not the bookmarks in 4.0.
Ok, I will wait until decision is made.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:55:20 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message ----- > From: "Gilad Chaplik" <gchaplik@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com> > Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Sent: Monday, March 24, 2014 11:28:02 AM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > Hi Guys, > > Why we need bookmarks in API? a single liner that points out to > another > single liner? > I know that we need it for 'UI over REST' migration, but... > IMHO bookmarks should be saved in client side, maybe inject the > search > string > in the url, and get 'real' bookmarks/favorites... I don't know :-) > > Thanks, > Gilad. > > ----- Original Message ----- >> From: "Vojtech Szocs" <vszocs@redhat.com> >> To: "Juan Hernandez" <jhernand@redhat.com> >> Cc: "engine-devel" <engine-devel@ovirt.org> >> Sent: Wednesday, March 12, 2014 1:27:19 PM >> Subject: Re: [Engine-devel] REST API - where did bookmarks go? >> >> >> >> ----- Original Message ----- >>> From: "Juan Hernandez" <jhernand@redhat.com> >>> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" >>> <engine-devel@ovirt.org> >>> Cc: "Einav Cohen" <ecohen@redhat.com> >>> Sent: Tuesday, March 11, 2014 7:22:35 PM >>> Subject: Re: REST API - where did bookmarks go? >>> >>> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: >>>> Hi guys, >>>> >>>> as part of prototyping new JavaScript binding for oVirt REST >>>> API, >>>> we chose a couple of business entities (resources) to >>>> experiment >>>> with. >>>> >>>> I just realized that requesting /ovirt-engine/api doesn't >>>> return >>>> any information about bookmarks. Where did bookmarks go? Is it >>>> possible to manage bookmarks through REST API? >>>> >>>> Note: WebAdmin currently gets bookmarks through GWT RPC by >>>> calling >>>> GetAllBookmarksQuery. Bookmark seems like proper backend >>>> business >>>> entity (with DAO and everything) so it should be exposed also >>>> via >>>> REST API.. or am I missing something? >>>> >>>> Thanks, >>>> Vojtech >>>> >>> >>> The didn't go anywhere, just never existed in the API. Please >>> open >>> a >>> RFE >>> to add them. >> >> Thanks, Juan. The RFE is here: >> >> https://bugzilla.redhat.com/1075556 >>
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:58:01 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
So iiuc, we are going to develop a known obsolete feature :-) ? Can we break it in 4.0?
We should consider whether bookmarks should be persisted/managed through Engine, or whether they should be handled by clients instead (and Engine wouldn't care about them). Sounds more like design decision to me.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:55:20 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- From: "Gilad Chaplik" <gchaplik@redhat.com> Sent: Monday, March 24, 2014 11:46:04 AM
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
the REST API should not be designed according to UI's needs - but the REST API should allow to retrieve all engine-managed business entities. Bookmarks is one of them. There is a chance that creating Bookmarks as an engine-managed business-entity in the first place was a bad design decision, but they are there now, as managed business-entities, and as such - should be exposed via the REST API.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- > From: "Juan Hernandez" <jhernand@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Cc: "Einav Cohen" <ecohen@redhat.com> > Sent: Tuesday, March 11, 2014 7:22:35 PM > Subject: Re: REST API - where did bookmarks go? > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > > Hi guys, > > > > as part of prototyping new JavaScript binding for oVirt REST > > API, > > we chose a couple of business entities (resources) to > > experiment > > with. > > > > I just realized that requesting /ovirt-engine/api doesn't > > return > > any information about bookmarks. Where did bookmarks go? Is it > > possible to manage bookmarks through REST API? > > > > Note: WebAdmin currently gets bookmarks through GWT RPC by > > calling > > GetAllBookmarksQuery. Bookmark seems like proper backend > > business > > entity (with DAO and everything) so it should be exposed also > > via > > REST API.. or am I missing something? > > > > Thanks, > > Vojtech > > > > The didn't go anywhere, just never existed in the API. Please > open > a > RFE > to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
> > -- > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, > planta > 3ºD, 28016 Madrid, Spain > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red > Hat > S.L. > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:46:04 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
I think that API should accomodate general/common needs of its clients. After all, the usefulness of API can be measured by its usability from client's perspective. At one extreme, API adapts to each specific client, which in turn bloats the API. At another extreme, API lives in isolated bubble and doesn't care for its clients. Each of these extremes is dangerous :)
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 03/24/2014 12:40 PM, Vojtech Szocs wrote:
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:46:04 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
I think that API should accomodate general/common needs of its clients. After all, the usefulness of API can be measured by its usability from client's perspective.
At one extreme, API adapts to each specific client, which in turn bloats the API. At another extreme, API lives in isolated bubble and doesn't care for its clients. Each of these extremes is dangerous :)
I find shared bookmarks useful. i do actually think they should have had permissions: - who can see my bookmarks - who can share their bookmarks with others
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > Hi guys, > > as part of prototyping new JavaScript binding for oVirt REST API, > we chose a couple of business entities (resources) to experiment > with. > > I just realized that requesting /ovirt-engine/api doesn't return > any information about bookmarks. Where did bookmarks go? Is it > possible to manage bookmarks through REST API? > > Note: WebAdmin currently gets bookmarks through GWT RPC by calling > GetAllBookmarksQuery. Bookmark seems like proper backend business > entity (with DAO and everything) so it should be exposed also via > REST API.. or am I missing something? > > Thanks, > Vojtech >
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, March 25, 2014 12:17:48 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On 03/24/2014 12:40 PM, Vojtech Szocs wrote:
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:46:04 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
I think that API should accomodate general/common needs of its clients. After all, the usefulness of API can be measured by its usability from client's perspective.
At one extreme, API adapts to each specific client, which in turn bloats the API. At another extreme, API lives in isolated bubble and doesn't care for its clients. Each of these extremes is dangerous :)
I find shared bookmarks useful. i do actually think they should have had permissions: - who can see my bookmarks - who can share their bookmarks with others
I think that nowadays bookmarks are a client side feature only. You can add bookmarks in your browser, and it will exist everywhere (mobile/smartphone/etc) - I use it on a daily basis on 4 different devices. so you are getting these features for free. In 'UI over REST' migration process I suggest to leave bookmarks to last, and reassess then.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- > From: "Juan Hernandez" <jhernand@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Cc: "Einav Cohen" <ecohen@redhat.com> > Sent: Tuesday, March 11, 2014 7:22:35 PM > Subject: Re: REST API - where did bookmarks go? > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote: >> Hi guys, >> >> as part of prototyping new JavaScript binding for oVirt REST API, >> we chose a couple of business entities (resources) to experiment >> with. >> >> I just realized that requesting /ovirt-engine/api doesn't return >> any information about bookmarks. Where did bookmarks go? Is it >> possible to manage bookmarks through REST API? >> >> Note: WebAdmin currently gets bookmarks through GWT RPC by calling >> GetAllBookmarksQuery. Bookmark seems like proper backend business >> entity (with DAO and everything) so it should be exposed also via >> REST API.. or am I missing something? >> >> Thanks, >> Vojtech >> > > The didn't go anywhere, just never existed in the API. Please open a > RFE > to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
> > -- > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta > 3ºD, 28016 Madrid, Spain > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat > S.L. > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 03/25/2014 10:52 AM, Gilad Chaplik wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, March 25, 2014 12:17:48 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On 03/24/2014 12:40 PM, Vojtech Szocs wrote:
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:46:04 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
I think that API should accomodate general/common needs of its clients. After all, the usefulness of API can be measured by its usability from client's perspective.
At one extreme, API adapts to each specific client, which in turn bloats the API. At another extreme, API lives in isolated bubble and doesn't care for its clients. Each of these extremes is dangerous :)
I find shared bookmarks useful. i do actually think they should have had permissions: - who can see my bookmarks - who can share their bookmarks with others
I think that nowadays bookmarks are a client side feature only. You can add bookmarks in your browser, and it will exist everywhere (mobile/smartphone/etc) - I use it on a daily basis on 4 different devices. so you are getting these features for free.
that's multiple devices, not multiple users.
In 'UI over REST' migration process I suggest to leave bookmarks to last, and reassess then.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message ----- > From: "Vojtech Szocs" <vszocs@redhat.com> > To: "Juan Hernandez" <jhernand@redhat.com> > Cc: "engine-devel" <engine-devel@ovirt.org> > Sent: Wednesday, March 12, 2014 1:27:19 PM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > > > ----- Original Message ----- >> From: "Juan Hernandez" <jhernand@redhat.com> >> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" >> <engine-devel@ovirt.org> >> Cc: "Einav Cohen" <ecohen@redhat.com> >> Sent: Tuesday, March 11, 2014 7:22:35 PM >> Subject: Re: REST API - where did bookmarks go? >> >> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: >>> Hi guys, >>> >>> as part of prototyping new JavaScript binding for oVirt REST API, >>> we chose a couple of business entities (resources) to experiment >>> with. >>> >>> I just realized that requesting /ovirt-engine/api doesn't return >>> any information about bookmarks. Where did bookmarks go? Is it >>> possible to manage bookmarks through REST API? >>> >>> Note: WebAdmin currently gets bookmarks through GWT RPC by calling >>> GetAllBookmarksQuery. Bookmark seems like proper backend business >>> entity (with DAO and everything) so it should be exposed also via >>> REST API.. or am I missing something? >>> >>> Thanks, >>> Vojtech >>> >> >> The didn't go anywhere, just never existed in the API. Please open a >> RFE >> to add them. > > Thanks, Juan. The RFE is here: > > https://bugzilla.redhat.com/1075556 > >> >> -- >> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta >> 3ºD, 28016 Madrid, Spain >> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat >> S.L. >> > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org>, "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 25, 2014 4:55:29 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On 03/25/2014 10:52 AM, Gilad Chaplik wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, March 25, 2014 12:17:48 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On 03/24/2014 12:40 PM, Vojtech Szocs wrote:
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Einav Cohen" <ecohen@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:46:04 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Einav,
I agree with every word. also thought about it, that's why I wrote a possible solution. Not sure we need to design the RESTful API according to UI's needs (add features in this case).
I think that API should accomodate general/common needs of its clients. After all, the usefulness of API can be measured by its usability from client's perspective.
At one extreme, API adapts to each specific client, which in turn bloats the API. At another extreme, API lives in isolated bubble and doesn't care for its clients. Each of these extremes is dangerous :)
I find shared bookmarks useful. i do actually think they should have had permissions: - who can see my bookmarks - who can share their bookmarks with others
I think that nowadays bookmarks are a client side feature only. You can add bookmarks in your browser, and it will exist everywhere (mobile/smartphone/etc) - I use it on a daily basis on 4 different devices. so you are getting these features for free.
that's multiple devices, not multiple users.
* Have you heard of a user who wants it? I think it's a rare use case, but maybe(/usually) I'm wrong. * Google search: share browser bookmarks, About 12,700,000 results
In 'UI over REST' migration process I suggest to leave bookmarks to last, and reassess then.
Thanks, Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 5:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion, however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
---- Thanks, Einav
----- Original Message ----- > From: "Gilad Chaplik" <gchaplik@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com> > Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Sent: Monday, March 24, 2014 11:28:02 AM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > Hi Guys, > > Why we need bookmarks in API? a single liner that points out to > another > single liner? > I know that we need it for 'UI over REST' migration, but... > IMHO bookmarks should be saved in client side, maybe inject the search > string > in the url, and get 'real' bookmarks/favorites... I don't know :-) > > Thanks, > Gilad. > > ----- Original Message ----- >> From: "Vojtech Szocs" <vszocs@redhat.com> >> To: "Juan Hernandez" <jhernand@redhat.com> >> Cc: "engine-devel" <engine-devel@ovirt.org> >> Sent: Wednesday, March 12, 2014 1:27:19 PM >> Subject: Re: [Engine-devel] REST API - where did bookmarks go? >> >> >> >> ----- Original Message ----- >>> From: "Juan Hernandez" <jhernand@redhat.com> >>> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" >>> <engine-devel@ovirt.org> >>> Cc: "Einav Cohen" <ecohen@redhat.com> >>> Sent: Tuesday, March 11, 2014 7:22:35 PM >>> Subject: Re: REST API - where did bookmarks go? >>> >>> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: >>>> Hi guys, >>>> >>>> as part of prototyping new JavaScript binding for oVirt REST API, >>>> we chose a couple of business entities (resources) to experiment >>>> with. >>>> >>>> I just realized that requesting /ovirt-engine/api doesn't return >>>> any information about bookmarks. Where did bookmarks go? Is it >>>> possible to manage bookmarks through REST API? >>>> >>>> Note: WebAdmin currently gets bookmarks through GWT RPC by calling >>>> GetAllBookmarksQuery. Bookmark seems like proper backend business >>>> entity (with DAO and everything) so it should be exposed also via >>>> REST API.. or am I missing something? >>>> >>>> Thanks, >>>> Vojtech >>>> >>> >>> The didn't go anywhere, just never existed in the API. Please open a >>> RFE >>> to add them. >> >> Thanks, Juan. The RFE is here: >> >> https://bugzilla.redhat.com/1075556 >> >>> >>> -- >>> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, >>> planta >>> 3ºD, 28016 Madrid, Spain >>> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat >>> S.L. >>> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel@ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 4:38:33 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Gilad, "client-side Bookmarks" is a great suggestion
+1 My understanding is that bookmarks are just named search queries, whose main advantage is the ability to put (potentially complex) search query behind a friendly-named bookmark. Bookmarks exist in WebAdmin GUI (as it provides the search panel) and as far as I can tell, there are no permissions involved when dealing with bookmarks via BookmarkDAO. So it seems that bookmark data could be persisted locally (in browser) via HTML local storage. However, the disadvantage (as mentioned by Einav below) is per-browser persistence, instead of today's per-Engine persistence. If we are OK with per-browser persistence of bookmarks, I'm for it.
however it is a (non-related) RFE, which may be implemented instead of, or in addition to, the already-existing server-side Bookmarks.
[keep in mind that server-side bookmarks allow you to add bookmarks that may be used by other users; it is also a feature that exists for a long time in oVirt, so need to think a little bit before removing it]
As long as we have server-side Bookmarks (i.e. as long as Bookmark is an engine-managed business entity), they need to be exposed via the REST API.
Indeed, this was the reason behind RFE https://bugzilla.redhat.com/1075556 - even after migrating to REST API, bookmark functionality should be preserved. (But we can also decide if we want to change that, if necessary.)
---- Thanks, Einav
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Juan Hernandez" <jhernand@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 11:28:02 AM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Actually, the ability to put search string in WebAdmin URL is a *VERY* interesting idea! For example: - assume you login and land on WebAdmin.html#vms - you change URL to WebAdmin.html#search;q=Host%3A%20name%20%3D%20asdasd [*] - WebAdmin applies requested search string, performs place change to WebAdmin.html#hosts [*] encodeURIComponent('Host: name = asdasd') Not only would users be able to navigate WebAdmin through search string in URL, but UI plugins could do this too via some plugin API function. Gilad, could you please create RFE for this? (it's a very good idea, IMHO)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side. David On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: djasa@redhat.com Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 2:27:41 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
If this means embedding search string in WebAdmin's URL like [1], I'm for it. [1] WebAdmin.html#search;q={uri-encoded-search-string} This could be done as RFE on top of (existing) bookmark functionality, giving people more choice.
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
thank you Vojtech! fyi, if we hadn't have the 3.X compatibility issues, I'm for removing current bookmarks. Thanks, Gilad. ----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: djasa@redhat.com, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 3:36:35 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: djasa@redhat.com Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 2:27:41 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
If this means embedding search string in WebAdmin's URL like [1], I'm for it.
[1] WebAdmin.html#search;q={uri-encoded-search-string}
This could be done as RFE on top of (existing) bookmark functionality, giving people more choice.
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > Hi guys, > > as part of prototyping new JavaScript binding for oVirt REST API, > we chose a couple of business entities (resources) to experiment > with. > > I just realized that requesting /ovirt-engine/api doesn't return > any information about bookmarks. Where did bookmarks go? Is it > possible to manage bookmarks through REST API? > > Note: WebAdmin currently gets bookmarks through GWT RPC by > calling > GetAllBookmarksQuery. Bookmark seems like proper backend business > entity (with DAO and everything) so it should be exposed also via > REST API.. or am I missing something? > > Thanks, > Vojtech >
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: djasa@redhat.com, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 2:51:01 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
thank you Vojtech!
fyi, if we hadn't have the 3.X compatibility issues, I'm for removing current bookmarks.
I've created RFE for this: https://bugzilla.redhat.com/show_bug.cgi?id=1081028 This could be a complement of (but not necessarily a replacement of) server-side bookmarks.
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: djasa@redhat.com, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 3:36:35 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: djasa@redhat.com Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 2:27:41 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
If this means embedding search string in WebAdmin's URL like [1], I'm for it.
[1] WebAdmin.html#search;q={uri-encoded-search-string}
This could be done as RFE on top of (existing) bookmark functionality, giving people more choice.
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message ----- > From: "Juan Hernandez" <jhernand@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Cc: "Einav Cohen" <ecohen@redhat.com> > Sent: Tuesday, March 11, 2014 7:22:35 PM > Subject: Re: REST API - where did bookmarks go? > > On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > > Hi guys, > > > > as part of prototyping new JavaScript binding for oVirt REST > > API, > > we chose a couple of business entities (resources) to > > experiment > > with. > > > > I just realized that requesting /ovirt-engine/api doesn't > > return > > any information about bookmarks. Where did bookmarks go? Is it > > possible to manage bookmarks through REST API? > > > > Note: WebAdmin currently gets bookmarks through GWT RPC by > > calling > > GetAllBookmarksQuery. Bookmark seems like proper backend > > business > > entity (with DAO and everything) so it should be exposed also > > via > > REST API.. or am I missing something? > > > > Thanks, > > Vojtech > > > > The didn't go anywhere, just never existed in the API. Please > open > a > RFE > to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
> > -- > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, > planta > 3ºD, 28016 Madrid, Spain > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red > Hat > S.L. > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On St, 2014-03-26 at 09:27 -0400, Gilad Chaplik wrote:
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
OK, that's an argument for no bookmarks in webadmin. My point was for client-side vs. server-side webadmin bookmarks. Actually, my point is also valid for webadmin bookmarks vs. browser bookmarks - imagine you have to do something urgent and the only thing is say private browser tab of your colleaugues machine. With webadmin bookmarks, you have everything at hand. With browser-based bookmarks, you essentially lose them till you come to some sync'd browser. David
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote:
Hi guys,
as part of prototyping new JavaScript binding for oVirt REST API, we chose a couple of business entities (resources) to experiment with.
I just realized that requesting /ovirt-engine/api doesn't return any information about bookmarks. Where did bookmarks go? Is it possible to manage bookmarks through REST API?
Note: WebAdmin currently gets bookmarks through GWT RPC by calling GetAllBookmarksQuery. Bookmark seems like proper backend business entity (with DAO and everything) so it should be exposed also via REST API.. or am I missing something?
Thanks, Vojtech
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Thanks, Gilad. ----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, March 27, 2014 1:55:36 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
On St, 2014-03-26 at 09:27 -0400, Gilad Chaplik wrote:
----- Original Message -----
From: "David Jaša" <djasa@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Vojtech Szocs" <vszocs@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 26, 2014 1:59:46 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
I don't use bookmarks in RHEV-M but if I did, I wouldn't be pleased if I had to use another computer when things go wrong and in addition, engine wouldn't give me my bookmarks... IMO if bookmarks are to stay, they should be server-side.
I think that browser's bookmarks are much more advanced, sophisticated and native; i.e. I'd rather have in my browser a bookmark to down HA VMs search, instead of: - opening the application - open the bookmarks tab - searching the bookmark * and that's after I know how to use it (I've read the manual[??]/wasted time in playing with it), and remember how to use it from time to time.
OK, that's an argument for no bookmarks in webadmin. My point was for client-side vs. server-side webadmin bookmarks.
Actually, my point is also valid for webadmin bookmarks vs. browser bookmarks - imagine you have to do something urgent and the only thing is say private browser tab of your colleaugues machine. With webadmin bookmarks, you have everything at hand. With browser-based bookmarks, you essentially lose them till you come to some sync'd browser.
David
Again I think it's a really rare use-case, we shouldn't base our UI on that.
David
On Po, 2014-03-24 at 11:28 -0400, Gilad Chaplik wrote:
Hi Guys,
Why we need bookmarks in API? a single liner that points out to another single liner? I know that we need it for 'UI over REST' migration, but... IMHO bookmarks should be saved in client side, maybe inject the search string in the url, and get 'real' bookmarks/favorites... I don't know :-)
Thanks, Gilad.
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, March 12, 2014 1:27:19 PM Subject: Re: [Engine-devel] REST API - where did bookmarks go?
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Cc: "Einav Cohen" <ecohen@redhat.com> Sent: Tuesday, March 11, 2014 7:22:35 PM Subject: Re: REST API - where did bookmarks go?
On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > Hi guys, > > as part of prototyping new JavaScript binding for oVirt REST API, > we chose a couple of business entities (resources) to experiment > with. > > I just realized that requesting /ovirt-engine/api doesn't return > any information about bookmarks. Where did bookmarks go? Is it > possible to manage bookmarks through REST API? > > Note: WebAdmin currently gets bookmarks through GWT RPC by > calling > GetAllBookmarksQuery. Bookmark seems like proper backend business > entity (with DAO and everything) so it should be exposed also via > REST API.. or am I missing something? > > Thanks, > Vojtech >
The didn't go anywhere, just never existed in the API. Please open a RFE to add them.
Thanks, Juan. The RFE is here:
https://bugzilla.redhat.com/1075556
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (7)
-
David Jaša -
Einav Cohen -
Gilad Chaplik -
Itamar Heim -
Juan Hernandez -
Martin Perina -
Vojtech Szocs