[Engine-devel] unit tests failing
Don't know what change exactly caused this: Tests in error: canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
I'll need to fix those tests, sorry. Working on it right now. -- Federico ----- Original Message -----
From: "Alon Bar-Lev" <alonbl@redhat.com> To: "engine-devel" <engine-devel@ovirt.org>, "Federico Simoncelli" <fsimonce@redhat.com>, "Ofri Masad" <omasad@redhat.com> Sent: Tuesday, January 29, 2013 3:53:36 PM Subject: unit tests failing
Don't know what change exactly caused this:
Tests in error: canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
Probably it is not yours, I removed ff64900b7ae1b2d92e40bb290c61354d846d7d30 and still failing. ----- Original Message -----
From: "Federico Simoncelli" <fsimonce@redhat.com> To: "Alon Bar-Lev" <alonbl@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:05:10 PM Subject: Re: [Engine-devel] unit tests failing
I'll need to fix those tests, sorry. Working on it right now.
-- Federico
----- Original Message -----
From: "Alon Bar-Lev" <alonbl@redhat.com> To: "engine-devel" <engine-devel@ovirt.org>, "Federico Simoncelli" <fsimonce@redhat.com>, "Ofri Masad" <omasad@redhat.com> Sent: Tuesday, January 29, 2013 3:53:36 PM Subject: unit tests failing
Don't know what change exactly caused this:
Tests in error: canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well. First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test. git bisect start BAD GOOD git bisect run mvn test Now it will do a binary search in your history trying to find the commit that broke mvn test. On Tue, Jan 29, 2013 at 10:13:20AM -0500, Laszlo Hornyak wrote:
Probably it is not yours, I removed ff64900b7ae1b2d92e40bb290c61354d846d7d30 and still failing.
----- Original Message -----
From: "Federico Simoncelli" <fsimonce@redhat.com> To: "Alon Bar-Lev" <alonbl@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:05:10 PM Subject: Re: [Engine-devel] unit tests failing
I'll need to fix those tests, sorry. Working on it right now.
-- Federico
----- Original Message -----
From: "Alon Bar-Lev" <alonbl@redhat.com> To: "engine-devel" <engine-devel@ovirt.org>, "Federico Simoncelli" <fsimonce@redhat.com>, "Ofri Masad" <omasad@redhat.com> Sent: Tuesday, January 29, 2013 3:53:36 PM Subject: unit tests failing
Don't know what change exactly caused this:
Tests in error: canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt@kohlvanwijngaarden.nl> To: "Laszlo Hornyak" <lhornyak@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 5:36:35 PM Subject: Re: [Engine-devel] unit tests failing
May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well.
This is way too time consuming from unrelated party that needs to progress with his own tasks.
First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test.
git bisect start BAD GOOD git bisect run mvn test
Now it will do a binary search in your history trying to find the commit that broke mvn test.
On Tue, Jan 29, 2013 at 10:13:20AM -0500, Laszlo Hornyak wrote:
Probably it is not yours, I removed ff64900b7ae1b2d92e40bb290c61354d846d7d30 and still failing.
----- Original Message -----
From: "Federico Simoncelli" <fsimonce@redhat.com> To: "Alon Bar-Lev" <alonbl@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:05:10 PM Subject: Re: [Engine-devel] unit tests failing
I'll need to fix those tests, sorry. Working on it right now.
-- Federico
----- Original Message -----
From: "Alon Bar-Lev" <alonbl@redhat.com> To: "engine-devel" <engine-devel@ovirt.org>, "Federico Simoncelli" <fsimonce@redhat.com>, "Ofri Masad" <omasad@redhat.com> Sent: Tuesday, January 29, 2013 3:53:36 PM Subject: unit tests failing
Don't know what change exactly caused this:
Tests in error: canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest)
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt@kohlvanwijngaarden.nl> To: "Laszlo Hornyak" <lhornyak@redhat.com> Cc: "Federico Simoncelli" <fsimonce@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:36:35 PM Subject: Re: [Engine-devel] unit tests failing
May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well.
First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test.
git bisect start BAD GOOD git bisect run mvn test
Now it will do a binary search in your history trying to find the commit that broke mvn test.
It's ff64900b7ae1b2d92e40bb290c61354d846d7d30 I'm working on it as we speak. -- Federico
----- Original Message -----
From: "Federico Simoncelli" <fsimonce@redhat.com> To: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt@kohlvanwijngaarden.nl> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:45:43 PM Subject: Re: [Engine-devel] unit tests failing
----- Original Message -----
From: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt@kohlvanwijngaarden.nl> To: "Laszlo Hornyak" <lhornyak@redhat.com> Cc: "Federico Simoncelli" <fsimonce@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, January 29, 2013 4:36:35 PM Subject: Re: [Engine-devel] unit tests failing
May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well.
First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test.
git bisect start BAD GOOD git bisect run mvn test
Now it will do a binary search in your history trying to find the commit that broke mvn test.
It's ff64900b7ae1b2d92e40bb290c61354d846d7d30 I'm working on it as we speak.
This is a quick fix: http://gerrit.ovirt.org/#/c/11510/ I'm sure there's a lot to improve, please review it so we can push it as fast as we can. Thanks. -- Federico
Hey Ewoud, +1 for bisect, what's up Ewoud?, this email reminds me good old rhevm-api days. On 01/29/2013 05:36 PM, Ewoud Kohl van Wijngaarden wrote:
May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well.
First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test.
git bisect start BAD GOOD git bisect run mvn test
Now it will do a binary search in your history trying to find the commit that broke mvn test.
-- Michael Pasternak RedHat, ENG-Virtualization R&D
participants (5)
-
Alon Bar-Lev -
Ewoud Kohl van Wijngaarden -
Federico Simoncelli -
Laszlo Hornyak -
Michael Pasternak