From: "Federico Simoncelli" <fsimonce(a)redhat.com&gt; To: "Alon Bar-Lev" <alonbl(a)redhat.com&gt; Cc: "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Tuesday, January 29, 2013 4:05:10 PM Subject: Re: [Engine-devel] unit tests failing I'll need to fix those tests, sorry. Working on it right now. -- Federico ----- Original Message ----- > From: "Alon Bar-Lev" <alonbl(a)redhat.com&gt; > To: "engine-devel" <engine-devel(a)ovirt.org&gt;, "Federico Simoncelli" > <fsimonce(a)redhat.com&gt;, "Ofri Masad" > <omasad(a)redhat.com&gt; > Sent: Tuesday, January 29, 2013 3:53:36 PM > Subject: unit tests failing > > Don't know what change exactly caused this: > > Tests in error: > canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) > moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) > moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt(a)kohlvanwijngaarden.nl&gt; To: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt; Cc: "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Tuesday, January 29, 2013 5:36:35 PM Subject: Re: [Engine-devel] unit tests failing May I recommend git bisect? See http://lwn.net/Articles/317154/ or http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation as well.

First you find a known BAD, for example master. Then you find a known GOOD (for example 100 commits ago in master: master~100). Then we can use a script to determine if it's good. I'm assuming mvn test will be sufficient, but maybe you can refine this to only test for a specific unit test. git bisect start BAD GOOD git bisect run mvn test Now it will do a binary search in your history trying to find the commit that broke mvn test. On Tue, Jan 29, 2013 at 10:13:20AM -0500, Laszlo Hornyak wrote: > Probably it is not yours, I removed > ff64900b7ae1b2d92e40bb290c61354d846d7d30 and still failing. > > ----- Original Message ----- > > From: "Federico Simoncelli" <fsimonce(a)redhat.com&gt; > > To: "Alon Bar-Lev" <alonbl(a)redhat.com&gt; > > Cc: "engine-devel" <engine-devel(a)ovirt.org&gt; > > Sent: Tuesday, January 29, 2013 4:05:10 PM > > Subject: Re: [Engine-devel] unit tests failing > > > > I'll need to fix those tests, sorry. > > Working on it right now. > > > > -- > > Federico > > > > ----- Original Message ----- > > > From: "Alon Bar-Lev" <alonbl(a)redhat.com&gt; > > > To: "engine-devel" <engine-devel(a)ovirt.org&gt;, "Federico > > > Simoncelli" > > > <fsimonce(a)redhat.com&gt;, "Ofri Masad" > > > <omasad(a)redhat.com&gt; > > > Sent: Tuesday, January 29, 2013 3:53:36 PM > > > Subject: unit tests failing > > > > > > Don't know what change exactly caused this: > > > > > > Tests in error: > > > canDoActionInvalidVmStatus(org.ovirt.engine.core.bll.MoveDisksCommandTest) > > > moveDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > > > liveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > > > liveMigrateDiskBasedOnTemplate(org.ovirt.engine.core.bll.MoveDisksCommandTest) > > > moveDiskAndLiveMigrateDisk(org.ovirt.engine.core.bll.MoveDisksCommandTest) > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Federico Simoncelli" <fsimonce(a)redhat.com&gt; To: "Ewoud Kohl van Wijngaarden" <ewoud+ovirt(a)kohlvanwijngaarden.nl&gt; Cc: "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Tuesday, January 29, 2013 4:45:43 PM Subject: Re: [Engine-devel] unit tests failing ----- Original Message ----- > From: "Ewoud Kohl van Wijngaarden" > <ewoud+ovirt(a)kohlvanwijngaarden.nl&gt; > To: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt; > Cc: "Federico Simoncelli" <fsimonce(a)redhat.com&gt;, "engine-devel" > <engine-devel(a)ovirt.org&gt; > Sent: Tuesday, January 29, 2013 4:36:35 PM > Subject: Re: [Engine-devel] unit tests failing > > May I recommend git bisect? See http://lwn.net/Articles/317154/ or > http://clock.co.uk/tech-blogs/git-bisect-simple-examples-and-automation > as well. > > First you find a known BAD, for example master. Then you find a > known > GOOD (for example 100 commits ago in master: master~100). Then we > can > use a script to determine if it's good. I'm assuming mvn test will > be > sufficient, but maybe you can refine this to only test for a > specific > unit test. > > git bisect start BAD GOOD > git bisect run mvn test > > Now it will do a binary search in your history trying to find the > commit > that broke mvn test. It's ff64900b7ae1b2d92e40bb290c61354d846d7d30 I'm working on it as we speak.