[ENGINE] Question about refresh parameter of GetConfigurationValueQuery
Hi all, Can anyone think of an issue with changing the default value of the refresh parameter to false for the query mentioned at $Subject? Cheers, Yair
If you can find all locations that assume the value is true and don't explicitly set it, and you change them to explicitly set them, then there should be no problem. Otherwise things that are expected to refresh the session will no longer do so, which will result in some unpredictable behavior. On Friday, January 09, 2015 04:52:15 AM Yair Zaslavsky wrote:
Hi all, Can anyone think of an issue with changing the default value of the refresh parameter to false for the query mentioned at $Subject?
Cheers, Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09.01.2015 14:00, Alexander Wels wrote:
If you can find all locations that assume the value is true and don't explicitly set it, and you change them to explicitly set them, then there should be no problem. Otherwise things that are expected to refresh the session will no longer do so, which will result in some unpredictable behavior.
I smell breakage here.
On Friday, January 09, 2015 04:52:15 AM Yair Zaslavsky wrote:
Hi all, Can anyone think of an issue with changing the default value of the refresh parameter to false for the query mentioned at $Subject?
You should at least provide a reason why you want to change it, imho. kind regards Sven -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQGcBAEBAgAGBQJUr9IaAAoJEAq0kGAWDrqlwxEMAJirB5rBVYod8jlYFX0yH9g5 R+kqjs+ApplJOD/GcOk6H1+bcWh3SoLIz3iAcS0JODNrvPcaItlWh7JNTrN1IYgM WZQD1xL/ctCVfCumNq6ZjGKsHNk2eDKuCXyKWPw6nG0mqe4HXpJ8+YeckC17+9C0 rKpw9qEQJHuyaanpsuu8nKwxkW7QpNy61OX5BEJ3KobJI9wuBshX3rJiPR774InD 1RDHgnnwCG4dsttEZHFug8Ckom4rvZrBPua4I4RP93RVDfgDIaqKPD8VFlA29iC8 nndZwsIEmYfSECpcrBzEHSOzRnCMyN4AGrvjTkChVcSSWINWqEqMWG2e7NPWmM9A ipBTsAXIJQfxf8D938If8CDnsCW6b4cz6UXd8+kBUXEACZtNf3MNqbJY8Lt5SzHO YrDqht6vkFrS6Rq1ExoaSVcS3qzJ6R+vcAeHw1HlpZwmRUArlOoDxhh40cStwZma XUZrnd9CqKeL9d0B6XEdOVx8Bg93G9hoFYyhX2uHZQ== =L6LV -----END PGP SIGNATURE-----
----- Original Message -----
From: "Sven Kieske" <svenkieske@gmail.com> To: devel@ovirt.org Sent: Friday, January 9, 2015 2:05:30 PM Subject: Re: [ovirt-devel] [ENGINE] Question about refresh parameter of GetConfigurationValueQuery
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09.01.2015 14:00, Alexander Wels wrote:
If you can find all locations that assume the value is true and don't explicitly set it, and you change them to explicitly set them, then there should be no problem. Otherwise things that are expected to refresh the session will no longer do so, which will result in some unpredictable behavior.
I smell breakage here.
On Friday, January 09, 2015 04:52:15 AM Yair Zaslavsky wrote:
Hi all, Can anyone think of an issue with changing the default value of the refresh parameter to false for the query mentioned at $Subject?
You should at least provide a reason why you want to change it, imho.
The motivation behind this is that HTTP GET /ovirt-engine/api should not refresh Engine user session, i.e. such request should not prevent the Engine user session from expiring. /ovirt-engine/api is not a resource/collection on its own, it's an entry point to REST interface that lists top-level resource collections (DCs, VMs, etc.) plus some additional REST metadata, so it can be considered as "meta resource"; any activity on it should not be considered as activity on "real" resources. Well, this is my understanding. Anyway, as far as I understand, the "refresh" flag on queries was designed to support use case when GUI (client) polls the Engine for data but still allows user to be auto-logged-out of GUI due to user's inactivity.
kind regards
Sven
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQGcBAEBAgAGBQJUr9IaAAoJEAq0kGAWDrqlwxEMAJirB5rBVYod8jlYFX0yH9g5 R+kqjs+ApplJOD/GcOk6H1+bcWh3SoLIz3iAcS0JODNrvPcaItlWh7JNTrN1IYgM WZQD1xL/ctCVfCumNq6ZjGKsHNk2eDKuCXyKWPw6nG0mqe4HXpJ8+YeckC17+9C0 rKpw9qEQJHuyaanpsuu8nKwxkW7QpNy61OX5BEJ3KobJI9wuBshX3rJiPR774InD 1RDHgnnwCG4dsttEZHFug8Ckom4rvZrBPua4I4RP93RVDfgDIaqKPD8VFlA29iC8 nndZwsIEmYfSECpcrBzEHSOzRnCMyN4AGrvjTkChVcSSWINWqEqMWG2e7NPWmM9A ipBTsAXIJQfxf8D938If8CDnsCW6b4cz6UXd8+kBUXEACZtNf3MNqbJY8Lt5SzHO YrDqht6vkFrS6Rq1ExoaSVcS3qzJ6R+vcAeHw1HlpZwmRUArlOoDxhh40cStwZma XUZrnd9CqKeL9d0B6XEdOVx8Bg93G9hoFYyhX2uHZQ== =L6LV -----END PGP SIGNATURE----- _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (4)
-
Alexander Wels -
Sven Kieske -
Vojtech Szocs -
Yair Zaslavsky