Hello, After updating my Centos7 VM, the unit tests are failing on check_imports. Some kind of recursion. https://paste.fedoraproject.org/paste/lcjYudT50AJDLJnw9SH3vw I have not seen this on CI. Any ideas?

Thanks, Edy. _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

Nir, I have not run `make check` locally for a while. It fails here, too, but completely differently: https://paste.fedoraproject.org/paste/jF-TlI4Dpe7d~2ZboXZ89Q Any idea where the following is coming from? ImportError while importing test module '/home/danken/redhat/vdsm.git/tests/storage/asyncevent_test.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/python.py:408: in _importtestmodule mod = self.fspath.pyimport(ensuresyspath=importmode) ../.tox/storage-py35/lib/python3.5/site-packages/py/_path/local.py:662: in pyimport __import__(modname) ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:215: in load_module py.builtin.exec_(co, mod.__dict__) storage/asyncevent_test.py:33: in <module> from testlib import VdsmTestCase testlib.py:35: in <module> from six.moves import configparser E ImportError: No module named 'six' On Sun, Sep 24, 2017 at 11:00 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: > On Sun, Sep 24, 2017 at 5:37 PM Edward Haas <ehaas(a)redhat.com&gt; wrote: >> >> Hello, >> >> After updating my Centos7 VM, the unit tests are failing on check_imports. >> Some kind of recursion. >> >> https://paste.fedoraproject.org/paste/lcjYudT50AJDLJnw9SH3vw >> >> I have not seen this on CI. >> Any ideas? > > > You have old __cache__ directory or something similar. > > git clean -dxf; ./autogen.sh --system && make > > will probably fix this. > > Also filing a pytest bug would be a good idea. > >> >> >> Thanks, >> Edy. >> >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel

nope. $ rpm -qa |grep -- -six python2-six-1.10.0-9.fc26.noarch python3-six-1.10.0-9.fc26.noarch On Mon, Sep 25, 2017 at 1:46 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: > Missing six in your system? > > > On יום ב׳, 25 בספט׳ 2017, 13:28 Dan Kenigsberg <danken(a)redhat.com&gt; wrote: >> >> Nir, >> >> I have not run `make check` locally for a while. It fails here, too, >> but completely differently: >> >> https://paste.fedoraproject.org/paste/jF-TlI4Dpe7d~2ZboXZ89Q >> >> Any idea where the following is coming from? >> >> ImportError while importing test module >> '/home/danken/redhat/vdsm.git/tests/storage/asyncevent_test.py'. >> Hint: make sure your test modules/packages have valid Python names. >> Traceback: >> ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/python.py:408: >> in _importtestmodule >> mod = self.fspath.pyimport(ensuresyspath=importmode) >> ../.tox/storage-py35/lib/python3.5/site-packages/py/_path/local.py:662: >> in pyimport >> __import__(modname) >> >> ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:215: >> in load_module >> py.builtin.exec_(co, mod.__dict__) >> storage/asyncevent_test.py:33: in <module> >> from testlib import VdsmTestCase >> testlib.py:35: in <module> >> from six.moves import configparser >> E ImportError: No module named 'six' >> >> On Sun, Sep 24, 2017 at 11:00 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: >> > On Sun, Sep 24, 2017 at 5:37 PM Edward Haas <ehaas(a)redhat.com&gt; wrote: >> >> >> >> Hello, >> >> >> >> After updating my Centos7 VM, the unit tests are failing on >> >> check_imports. >> >> Some kind of recursion. >> >> >> >> https://paste.fedoraproject.org/paste/lcjYudT50AJDLJnw9SH3vw >> >> >> >> I have not seen this on CI. >> >> Any ideas? >> > >> > >> > You have old __cache__ directory or something similar. >> > >> > git clean -dxf; ./autogen.sh --system && make >> > >> > will probably fix this. >> > >> > Also filing a pytest bug would be a good idea. >> > >> >> >> >> >> >> Thanks, >> >> Edy. >> >> >> >> _______________________________________________ >> >> Devel mailing list >> >> Devel(a)ovirt.org >> >> http://lists.ovirt.org/mailman/listinfo/devel >> > >> > >> > _______________________________________________ >> > Devel mailing list >> > Devel(a)ovirt.org >> > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

Right; this what makes the issue more odd. On my host .tox/storage-py35 fails, while .tox/storage-py36 passes; while both pass on jenkins.

On Tue, Sep 26, 2017 at 10:34 AM, Martin Sivak <msivak(a)redhat.com&gt; wrote: > Well.. isn't tox using virtualenv by any chance? The Python path in > the traceback does not look like the standard one > > Martin > > On Mon, Sep 25, 2017 at 12:48 PM, Dan Kenigsberg <danken(a)redhat.com&gt; wrote: >> nope. >> >> $ rpm -qa |grep -- -six >> python2-six-1.10.0-9.fc26.noarch >> python3-six-1.10.0-9.fc26.noarch >> >> On Mon, Sep 25, 2017 at 1:46 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: >>> Missing six in your system? >>> >>> >>> On יום ב׳, 25 בספט׳ 2017, 13:28 Dan Kenigsberg <danken(a)redhat.com&gt; wrote: >>>> >>>> Nir, >>>> >>>> I have not run `make check` locally for a while. It fails here, too, >>>> but completely differently: >>>> >>>> https://paste.fedoraproject.org/paste/jF-TlI4Dpe7d~2ZboXZ89Q >>>> >>>> Any idea where the following is coming from? >>>> >>>> ImportError while importing test module >>>> '/home/danken/redhat/vdsm.git/tests/storage/asyncevent_test.py'. >>>> Hint: make sure your test modules/packages have valid Python names. >>>> Traceback: >>>> ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/python.py:408: >>>> in _importtestmodule >>>> mod = self.fspath.pyimport(ensuresyspath=importmode) >>>> ../.tox/storage-py35/lib/python3.5/site-packages/py/_path/local.py:662: >>>> in pyimport >>>> __import__(modname) >>>> >>>> ../.tox/storage-py35/lib/python3.5/site-packages/_pytest/assertion/rewrite.py:215: >>>> in load_module >>>> py.builtin.exec_(co, mod.__dict__) >>>> storage/asyncevent_test.py:33: in <module> >>>> from testlib import VdsmTestCase >>>> testlib.py:35: in <module> >>>> from six.moves import configparser >>>> E ImportError: No module named 'six' >>>> >>>> On Sun, Sep 24, 2017 at 11:00 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: >>>> > On Sun, Sep 24, 2017 at 5:37 PM Edward Haas <ehaas(a)redhat.com&gt; wrote: >>>> >> >>>> >> Hello, >>>> >> >>>> >> After updating my Centos7 VM, the unit tests are failing on >>>> >> check_imports. >>>> >> Some kind of recursion. >>>> >> >>>> >> https://paste.fedoraproject.org/paste/lcjYudT50AJDLJnw9SH3vw >>>> >> >>>> >> I have not seen this on CI. >>>> >> Any ideas? >>>> > >>>> > >>>> > You have old __cache__ directory or something similar. >>>> > >>>> > git clean -dxf; ./autogen.sh --system && make >>>> > >>>> > will probably fix this. >>>> > >>>> > Also filing a pytest bug would be a good idea. >>>> > >>>> >> >>>> >> >>>> >> Thanks, >>>> >> Edy. >>>> >> >>>> >> _______________________________________________ >>>> >> Devel mailing list >>>> >> Devel(a)ovirt.org >>>> >> http://lists.ovirt.org/mailman/listinfo/devel >>>> > >>>> > >>>> > _______________________________________________ >>>> > Devel mailing list >>>> > Devel(a)ovirt.org >>>> > http://lists.ovirt.org/mailman/listinfo/devel >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel