Engine build fails: "found duplicate key "when" with value "collectd_default_files|d(true)"
I'm trying to build engine on new VM, installed based on README and it fails in ansible-lint on: /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml Is this a known issue? any workaround? Nir --- $ make clean install-dev PREFIX="$HOME/ovirt-engine" ... + /usr/bin/ansible-lint -c build/ansible-lint.conf packaging/playbooks/install-skydive.yml packaging/playbooks/ovirt-provider-ovn-driver.yml packaging/ansible-runner-service-project/project/create-brick.yml packaging/ansible-runner-service-project/project/ovirt-fetch-he-config.yml packaging/ansible-runner-service-project/project/ovirt-host-check-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-host-deploy.yml packaging/ansible-runner-service-project/project/ovirt-host-enroll-certificate.yml packaging/ansible-runner-service-project/project/ovirt-host-remove.yml packaging/ansible-runner-service-project/project/ovirt-host-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-image-measure.yml packaging/ansible-runner-service-project/project/ovirt-ova-export.yml packaging/ansible-runner-service-project/project/ovirt-ova-import.yml packaging/ansible-runner-service-project/project/ovirt-ova-query.yml packaging/ansible-runner-service-project/project/ovirt-vnc-sasl.yml packaging/ansible-runner-service-project/project/ovirt_host_upgrade_vars.yml packaging/ansible-runner-service-project/project/replace-gluster.yml packaging/ansible-runner-service-project/project/roles packaging/ansible-runner-service-project/project/roles/gluster-brick-create packaging/ansible-runner-service-project/project/roles/gluster-replace-peers packaging/ansible-runner-service-project/project/roles/hc-gluster-cgroups packaging/ansible-runner-service-project/project/roles/ovirt-host-check-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-firewalld packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-hosted-engine packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-iptables packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kdump packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-libvirt-guests packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-misc packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-spice-encryption packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vnc-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy packaging/ansible-runner-service-project/project/roles/ovirt-host-enroll-certificate packaging/ansible-runner-service-project/project/roles/ovirt-host-setup-vnc-sasl packaging/ansible-runner-service-project/project/roles/ovirt-host-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-image-measure packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-post-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-pre-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-extract packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-query packaging/ansible-runner-service-project/project/roles/ovirt-provider-ovn-driver packaging/ansible-runner-service-project/project/roles/ovirt-to-vdsm-network packaging/ansible-runner-service-project/project/roles/python-ver-detect [WARNING]: While constructing a mapping from /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml, line 118, column 7, found a duplicate dict key (when). Using last defined value only. [WARNING]: While constructing a mapping from <unicode string>, line 118, column 7, found a duplicate dict key (when). Using last defined value only. Traceback (most recent call last): File "/usr/bin/ansible-lint", line 11, in <module> load_entry_point('ansible-lint==4.1.0', 'console_scripts', 'ansible-lint')() File "/usr/lib/python3.6/site-packages/ansiblelint/__main__.py", line 187, in main matches.extend(runner.run()) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 282, in run skip_list=self.skip_list)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 174, in run matches.extend(rule.matchtasks(playbookfile, text)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 84, in matchtasks yaml = ansiblelint.utils.append_skipped_rules(yaml, text, file['type']) File "/usr/lib/python3.6/site-packages/ansiblelint/utils.py", line 604, in append_skipped_rules ruamel_data = yaml.load(file_text) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/main.py", line 266, in load return constructor.get_single_data() File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 105, in get_single_data return self.construct_document(node) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 115, in construct_document for dummy in generator: File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1357, in construct_yaml_map self.construct_mapping(node, data) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1266, in construct_mapping self.check_mapping_key(node, key_node, maptyp, key, value) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 265, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 118, column 7: - name: Populate logging_outputs d ... ^ (line: 118) " (original value: "collect_ovirt_engine_log or collect_ovirt_vdsm_log") in "<unicode string>", line 135, column 7: when: collectd_default_files|d(true) ^ (line: 135) To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys Duplicate keys will become and error in future releases, and are errors by default when using the new API. make[1]: *** [Makefile:366: validations] Error 1 make[1]: Leaving directory '/home/nsoffer/src/ovirt-engine' make: *** [Makefile:545: all-dev] Error 2
On Wed, Sep 23, 2020 at 5:08 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to build engine on new VM, installed based on README and it fails in ansible-lint on: /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml
Is this a known issue? any workaround?
On another machine I can be build engine, and python3-ansible-lint is not installed, so this seems to be an easy workaround.
Nir
---
$ make clean install-dev PREFIX="$HOME/ovirt-engine" ... + /usr/bin/ansible-lint -c build/ansible-lint.conf packaging/playbooks/install-skydive.yml packaging/playbooks/ovirt-provider-ovn-driver.yml packaging/ansible-runner-service-project/project/create-brick.yml packaging/ansible-runner-service-project/project/ovirt-fetch-he-config.yml packaging/ansible-runner-service-project/project/ovirt-host-check-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-host-deploy.yml packaging/ansible-runner-service-project/project/ovirt-host-enroll-certificate.yml packaging/ansible-runner-service-project/project/ovirt-host-remove.yml packaging/ansible-runner-service-project/project/ovirt-host-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-image-measure.yml packaging/ansible-runner-service-project/project/ovirt-ova-export.yml packaging/ansible-runner-service-project/project/ovirt-ova-import.yml packaging/ansible-runner-service-project/project/ovirt-ova-query.yml packaging/ansible-runner-service-project/project/ovirt-vnc-sasl.yml packaging/ansible-runner-service-project/project/ovirt_host_upgrade_vars.yml packaging/ansible-runner-service-project/project/replace-gluster.yml packaging/ansible-runner-service-project/project/roles packaging/ansible-runner-service-project/project/roles/gluster-brick-create packaging/ansible-runner-service-project/project/roles/gluster-replace-peers packaging/ansible-runner-service-project/project/roles/hc-gluster-cgroups packaging/ansible-runner-service-project/project/roles/ovirt-host-check-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-firewalld packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-hosted-engine packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-iptables packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kdump packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-libvirt-guests packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-misc packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-spice-encryption packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vnc-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy packaging/ansible-runner-service-project/project/roles/ovirt-host-enroll-certificate packaging/ansible-runner-service-project/project/roles/ovirt-host-setup-vnc-sasl packaging/ansible-runner-service-project/project/roles/ovirt-host-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-image-measure packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-post-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-pre-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-extract packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-query packaging/ansible-runner-service-project/project/roles/ovirt-provider-ovn-driver packaging/ansible-runner-service-project/project/roles/ovirt-to-vdsm-network packaging/ansible-runner-service-project/project/roles/python-ver-detect [WARNING]: While constructing a mapping from /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml, line 118, column 7, found a duplicate dict key (when). Using last defined value only. [WARNING]: While constructing a mapping from <unicode string>, line 118, column 7, found a duplicate dict key (when). Using last defined value only. Traceback (most recent call last): File "/usr/bin/ansible-lint", line 11, in <module> load_entry_point('ansible-lint==4.1.0', 'console_scripts', 'ansible-lint')() File "/usr/lib/python3.6/site-packages/ansiblelint/__main__.py", line 187, in main matches.extend(runner.run()) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 282, in run skip_list=self.skip_list)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 174, in run matches.extend(rule.matchtasks(playbookfile, text)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 84, in matchtasks yaml = ansiblelint.utils.append_skipped_rules(yaml, text, file['type']) File "/usr/lib/python3.6/site-packages/ansiblelint/utils.py", line 604, in append_skipped_rules ruamel_data = yaml.load(file_text) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/main.py", line 266, in load return constructor.get_single_data() File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 105, in get_single_data return self.construct_document(node) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 115, in construct_document for dummy in generator: File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1357, in construct_yaml_map self.construct_mapping(node, data) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1266, in construct_mapping self.check_mapping_key(node, key_node, maptyp, key, value) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 265, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 118, column 7: - name: Populate logging_outputs d ... ^ (line: 118)
" (original value: "collect_ovirt_engine_log or collect_ovirt_vdsm_log") in "<unicode string>", line 135, column 7: when: collectd_default_files|d(true) ^ (line: 135)
To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
Duplicate keys will become and error in future releases, and are errors by default when using the new API.
make[1]: *** [Makefile:366: validations] Error 1 make[1]: Leaving directory '/home/nsoffer/src/ovirt-engine' make: *** [Makefile:545: all-dev] Error 2
Remove ovirt-engine-metrics, it's completely unneeded for development environment On Wed, Sep 23, 2020 at 4:27 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Sep 23, 2020 at 5:08 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to build engine on new VM, installed based on README and it fails in ansible-lint on: /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml
Is this a known issue? any workaround?
On another machine I can be build engine, and python3-ansible-lint is not installed, so this seems to be an easy workaround.
Nir
---
$ make clean install-dev PREFIX="$HOME/ovirt-engine" ... + /usr/bin/ansible-lint -c build/ansible-lint.conf packaging/playbooks/install-skydive.yml packaging/playbooks/ovirt-provider-ovn-driver.yml packaging/ansible-runner-service-project/project/create-brick.yml
packaging/ansible-runner-service-project/project/ovirt-fetch-he-config.yml
packaging/ansible-runner-service-project/project/ovirt-host-check-upgrade.yml
packaging/ansible-runner-service-project/project/ovirt-host-deploy.yml
packaging/ansible-runner-service-project/project/ovirt-host-enroll-certificate.yml
packaging/ansible-runner-service-project/project/ovirt-host-remove.yml packaging/ansible-runner-service-project/project/ovirt-host-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-image-measure.yml packaging/ansible-runner-service-project/project/ovirt-ova-export.yml packaging/ansible-runner-service-project/project/ovirt-ova-import.yml packaging/ansible-runner-service-project/project/ovirt-ova-query.yml packaging/ansible-runner-service-project/project/ovirt-vnc-sasl.yml
packaging/ansible-runner-service-project/project/ovirt_host_upgrade_vars.yml
packaging/ansible-runner-service-project/project/replace-gluster.yml packaging/ansible-runner-service-project/project/roles
packaging/ansible-runner-service-project/project/roles/gluster-brick-create
packaging/ansible-runner-service-project/project/roles/gluster-replace-peers
packaging/ansible-runner-service-project/project/roles/hc-gluster-cgroups
packaging/ansible-runner-service-project/project/roles/ovirt-host-check-upgrade
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-firewalld
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-hosted-engine
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-iptables
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kdump
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-libvirt-guests
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-misc
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-spice-encryption
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm-certificates
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console-certificates
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vnc-certificates
packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy
packaging/ansible-runner-service-project/project/roles/ovirt-host-enroll-certificate
packaging/ansible-runner-service-project/project/roles/ovirt-host-setup-vnc-sasl
packaging/ansible-runner-service-project/project/roles/ovirt-host-upgrade
packaging/ansible-runner-service-project/project/roles/ovirt-image-measure
packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-post-pack
packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-pre-pack
packaging/ansible-runner-service-project/project/roles/ovirt-ova-extract packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-query
packaging/ansible-runner-service-project/project/roles/ovirt-provider-ovn-driver
packaging/ansible-runner-service-project/project/roles/ovirt-to-vdsm-network
packaging/ansible-runner-service-project/project/roles/python-ver-detect [WARNING]: While constructing a mapping from
/usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml,
line 118, column 7, found a duplicate dict key (when). Using last defined value only. [WARNING]: While constructing a mapping from <unicode string>, line 118, column 7, found a duplicate dict key (when). Using last defined value only. Traceback (most recent call last): File "/usr/bin/ansible-lint", line 11, in <module> load_entry_point('ansible-lint==4.1.0', 'console_scripts', 'ansible-lint')() File "/usr/lib/python3.6/site-packages/ansiblelint/__main__.py", line 187, in main matches.extend(runner.run()) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 282, in run skip_list=self.skip_list)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 174, in run matches.extend(rule.matchtasks(playbookfile, text)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 84, in matchtasks yaml = ansiblelint.utils.append_skipped_rules(yaml, text, file['type']) File "/usr/lib/python3.6/site-packages/ansiblelint/utils.py", line 604, in append_skipped_rules ruamel_data = yaml.load(file_text) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/main.py", line 266, in load return constructor.get_single_data() File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 105, in get_single_data return self.construct_document(node) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 115, in construct_document for dummy in generator: File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1357, in construct_yaml_map self.construct_mapping(node, data) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1266, in construct_mapping self.check_mapping_key(node, key_node, maptyp, key, value) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 265, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 118, column 7: - name: Populate logging_outputs d ... ^ (line: 118)
" (original value: "collect_ovirt_engine_log or collect_ovirt_vdsm_log") in "<unicode string>", line 135, column 7: when: collectd_default_files|d(true) ^ (line: 135)
To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
Duplicate keys will become and error in future releases, and are errors by default when using the new API.
make[1]: *** [Makefile:366: validations] Error 1 make[1]: Leaving directory '/home/nsoffer/src/ovirt-engine' make: *** [Makefile:545: all-dev] Error 2
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
On Wed, Sep 23, 2020 at 5:32 PM Martin Perina <mperina@redhat.com> wrote:
Remove ovirt-engine-metrics, it's completely unneeded for development environment
Thanks. Should we remove it from README.adoc, or add a note that it is an optional package?
On Wed, Sep 23, 2020 at 4:27 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Sep 23, 2020 at 5:08 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to build engine on new VM, installed based on README and it fails in ansible-lint on: /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml
Is this a known issue? any workaround?
On another machine I can be build engine, and python3-ansible-lint is not installed, so this seems to be an easy workaround.
Nir
---
$ make clean install-dev PREFIX="$HOME/ovirt-engine" ... + /usr/bin/ansible-lint -c build/ansible-lint.conf packaging/playbooks/install-skydive.yml packaging/playbooks/ovirt-provider-ovn-driver.yml packaging/ansible-runner-service-project/project/create-brick.yml packaging/ansible-runner-service-project/project/ovirt-fetch-he-config.yml packaging/ansible-runner-service-project/project/ovirt-host-check-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-host-deploy.yml packaging/ansible-runner-service-project/project/ovirt-host-enroll-certificate.yml packaging/ansible-runner-service-project/project/ovirt-host-remove.yml packaging/ansible-runner-service-project/project/ovirt-host-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-image-measure.yml packaging/ansible-runner-service-project/project/ovirt-ova-export.yml packaging/ansible-runner-service-project/project/ovirt-ova-import.yml packaging/ansible-runner-service-project/project/ovirt-ova-query.yml packaging/ansible-runner-service-project/project/ovirt-vnc-sasl.yml packaging/ansible-runner-service-project/project/ovirt_host_upgrade_vars.yml packaging/ansible-runner-service-project/project/replace-gluster.yml packaging/ansible-runner-service-project/project/roles packaging/ansible-runner-service-project/project/roles/gluster-brick-create packaging/ansible-runner-service-project/project/roles/gluster-replace-peers packaging/ansible-runner-service-project/project/roles/hc-gluster-cgroups packaging/ansible-runner-service-project/project/roles/ovirt-host-check-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-firewalld packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-hosted-engine packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-iptables packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kdump packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-libvirt-guests packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-misc packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-spice-encryption packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vnc-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy packaging/ansible-runner-service-project/project/roles/ovirt-host-enroll-certificate packaging/ansible-runner-service-project/project/roles/ovirt-host-setup-vnc-sasl packaging/ansible-runner-service-project/project/roles/ovirt-host-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-image-measure packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-post-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-pre-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-extract packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-query packaging/ansible-runner-service-project/project/roles/ovirt-provider-ovn-driver packaging/ansible-runner-service-project/project/roles/ovirt-to-vdsm-network packaging/ansible-runner-service-project/project/roles/python-ver-detect [WARNING]: While constructing a mapping from /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml, line 118, column 7, found a duplicate dict key (when). Using last defined value only. [WARNING]: While constructing a mapping from <unicode string>, line 118, column 7, found a duplicate dict key (when). Using last defined value only. Traceback (most recent call last): File "/usr/bin/ansible-lint", line 11, in <module> load_entry_point('ansible-lint==4.1.0', 'console_scripts', 'ansible-lint')() File "/usr/lib/python3.6/site-packages/ansiblelint/__main__.py", line 187, in main matches.extend(runner.run()) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 282, in run skip_list=self.skip_list)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 174, in run matches.extend(rule.matchtasks(playbookfile, text)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 84, in matchtasks yaml = ansiblelint.utils.append_skipped_rules(yaml, text, file['type']) File "/usr/lib/python3.6/site-packages/ansiblelint/utils.py", line 604, in append_skipped_rules ruamel_data = yaml.load(file_text) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/main.py", line 266, in load return constructor.get_single_data() File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 105, in get_single_data return self.construct_document(node) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 115, in construct_document for dummy in generator: File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1357, in construct_yaml_map self.construct_mapping(node, data) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1266, in construct_mapping self.check_mapping_key(node, key_node, maptyp, key, value) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 265, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 118, column 7: - name: Populate logging_outputs d ... ^ (line: 118)
" (original value: "collect_ovirt_engine_log or collect_ovirt_vdsm_log") in "<unicode string>", line 135, column 7: when: collectd_default_files|d(true) ^ (line: 135)
To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
Duplicate keys will become and error in future releases, and are errors by default when using the new API.
make[1]: *** [Makefile:366: validations] Error 1 make[1]: Leaving directory '/home/nsoffer/src/ovirt-engine' make: *** [Makefile:545: all-dev] Error 2
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
On Wed, Sep 23, 2020 at 4:40 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Sep 23, 2020 at 5:32 PM Martin Perina <mperina@redhat.com> wrote:
Remove ovirt-engine-metrics, it's completely unneeded for development
environment
Thanks.
Should we remove it from README.adoc, or add a note that it is an optional package?
Yes, it should be marked as optional: https://gerrit.ovirt.org/#/c/111423/
On Wed, Sep 23, 2020 at 4:27 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Sep 23, 2020 at 5:08 PM Nir Soffer <nsoffer@redhat.com> wrote:
I'm trying to build engine on new VM, installed based on README and it fails in ansible-lint on:
Is this a known issue? any workaround?
On another machine I can be build engine, and python3-ansible-lint is not installed, so this seems to be an easy workaround.
Nir
---
$ make clean install-dev PREFIX="$HOME/ovirt-engine" ... + /usr/bin/ansible-lint -c build/ansible-lint.conf packaging/playbooks/install-skydive.yml packaging/playbooks/ovirt-provider-ovn-driver.yml packaging/ansible-runner-service-project/project/create-brick.yml
packaging/ansible-runner-service-project/project/ovirt-host-deploy.yml
packaging/ansible-runner-service-project/project/ovirt-host-remove.yml
packaging/ansible-runner-service-project/project/ovirt-ova-export.yml packaging/ansible-runner-service-project/project/ovirt-ova-import.yml packaging/ansible-runner-service-project/project/ovirt-ova-query.yml packaging/ansible-runner-service-project/project/ovirt-vnc-sasl.yml
packaging/ansible-runner-service-project/project/replace-gluster.yml packaging/ansible-runner-service-project/project/roles
packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-query
/usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml packaging/ansible-runner-service-project/project/ovirt-fetch-he-config.yml packaging/ansible-runner-service-project/project/ovirt-host-check-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-host-enroll-certificate.yml packaging/ansible-runner-service-project/project/ovirt-host-upgrade.yml packaging/ansible-runner-service-project/project/ovirt-image-measure.yml packaging/ansible-runner-service-project/project/ovirt_host_upgrade_vars.yml packaging/ansible-runner-service-project/project/roles/gluster-brick-create packaging/ansible-runner-service-project/project/roles/gluster-replace-peers packaging/ansible-runner-service-project/project/roles/hc-gluster-cgroups packaging/ansible-runner-service-project/project/roles/ovirt-host-check-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-firewalld packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-hosted-engine packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-iptables packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kdump packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-libvirt-guests packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-misc packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-spice-encryption packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vm-console packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-vnc-certificates packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy packaging/ansible-runner-service-project/project/roles/ovirt-host-enroll-certificate packaging/ansible-runner-service-project/project/roles/ovirt-host-setup-vnc-sasl packaging/ansible-runner-service-project/project/roles/ovirt-host-upgrade packaging/ansible-runner-service-project/project/roles/ovirt-image-measure packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-post-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-export-pre-pack packaging/ansible-runner-service-project/project/roles/ovirt-ova-extract packaging/ansible-runner-service-project/project/roles/ovirt-provider-ovn-driver packaging/ansible-runner-service-project/project/roles/ovirt-to-vdsm-network packaging/ansible-runner-service-project/project/roles/python-ver-detect
[WARNING]: While constructing a mapping from
/usr/share/ansible/roles/oVirt.metrics/roles/oVirt.logging/tasks/main.yml,
line 118, column 7, found a duplicate dict key (when). Using last defined value only. [WARNING]: While constructing a mapping from <unicode string>, line 118, column 7, found a duplicate dict key (when). Using last defined value only. Traceback (most recent call last): File "/usr/bin/ansible-lint", line 11, in <module> load_entry_point('ansible-lint==4.1.0', 'console_scripts', 'ansible-lint')() File "/usr/lib/python3.6/site-packages/ansiblelint/__main__.py", line 187, in main matches.extend(runner.run()) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 282, in run skip_list=self.skip_list)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 174, in run matches.extend(rule.matchtasks(playbookfile, text)) File "/usr/lib/python3.6/site-packages/ansiblelint/__init__.py", line 84, in matchtasks yaml = ansiblelint.utils.append_skipped_rules(yaml, text, file['type']) File "/usr/lib/python3.6/site-packages/ansiblelint/utils.py", line 604, in append_skipped_rules ruamel_data = yaml.load(file_text) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/main.py", line 266, in load return constructor.get_single_data() File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 105, in get_single_data return self.construct_document(node) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 115, in construct_document for dummy in generator: File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1357, in construct_yaml_map self.construct_mapping(node, data) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 1266, in construct_mapping self.check_mapping_key(node, key_node, maptyp, key, value) File "/usr/lib64/python3.6/site-packages/ruamel/yaml/constructor.py", line 265, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 118, column 7: - name: Populate logging_outputs d ... ^ (line: 118)
" (original value: "collect_ovirt_engine_log or
collect_ovirt_vdsm_log") >> > in "<unicode string>", line 135, column 7: >> > when: collectd_default_files|d(true) >> > ^ (line: 135) >> > >> > To suppress this check see: >> > http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys >> > >> > Duplicate keys will become and error in future releases, and are errors >> > by default when using the new API. >> > >> > make[1]: *** [Makefile:366: validations] Error 1 >> > make[1]: Leaving directory '/home/nsoffer/src/ovirt-engine' >> > make: *** [Makefile:545: all-dev] Error 2 >> > > > -- > Martin Perina > Manager, Software Engineering > Red Hat Czech s.r.o.
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
participants (2)
-
Martin Perina -
Nir Soffer