7:30 p.m.
--_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the=
transferred data format because of the xmlrpc limitations. So could you pl=
ease review them again?
Hi Dan,
I have modified your comments for some of the above patches. Could you plea=
se take a look and merge those if no more comments?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi@hp.com<mailto:shiguo.li@hp.com
--_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml"
xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word"
=
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml"
xmlns=3D"http:=
//www.w3.org/TR/REC-html40" <head <meta http-equiv=3D"Content-Type"
content=3D"text/html; charset=3Dus-ascii"=
<meta name=3D"Generator" content=3D"Microsoft
Word 14 (filtered medium)" <style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" / </xml><![endif]--><!--[if gte mso
9]><xml <o:shapelayout
v:ext=3D"edit" <o:idmap v:ext=3D"edit"
data=3D"1" /
</o:shapelayout></xml><![endif]--
</head <body lang=3D"EN-US"
link=3D"blue" vlink=3D"purple" <div
class=3D"WordSection1" <p
class=3D"MsoNormal">Hi Martin,<o:p></o:p></p <p class=3D"MsoNormal">Could you help to review
these numa vdsm patches:<o:=
p></o:p></p <p
class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27399/">http:=
//gerrit.ovirt.org/#/c/27399/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27090/">http:=
//gerrit.ovirt.org/#/c/27090/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27403/">http:=
//gerrit.ovirt.org/#/c/27403/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/26876/">http:=
//gerrit.ovirt.org/#/c/26876/</a><o:p></o:p></p <p class=3D"MsoNormal">You had already reviewed
some of the patches, but af=
ter that I modified the transferred data format because of the xmlrpc limit=
ations. So could you please review them again?<o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal">Hi
Dan,<o:p></o:p></p <p
class=3D"MsoNormal">I have modified your comments for some of the above =
patches. Could you please take a look and merge those if no more comments?<=
o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt">Thanks & Best Regards</span></b><span
style=3D"font-size:=
12.0pt"><o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Shi, Xiao-Lei
(Bruce)<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt"><o:p> </o:p></span></b></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt;color:black">Hewlett-Packard Co., Ltd.<br HP Servers Core Platform Software
China</span></b><b><span style=3D"font-si=
ze:12.0pt"
<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Telephone</span></b><span
style=3D"font-size:12.0pt"> +86=
23 65683093<o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Mobile
</span></b><span style=3D"font-size:12.0pt">+86
18696583447<o:p></o:p><=
/span></p <p
class=3D"MsoNormal"><b><span
style=3D"font-size:12.0pt">Email </span></b=
<p
class=3D"MsoNormal"><o:p> </o:p></p </div
</body </html
--_000_08AA403C8399104A89AF710307FA78AE24404869G5W2743americas_--
<span style=3D"font-size:12.0pt"><a
href=3D"mailto:shiguo.li@hp.com"><span=
style=3D"color:blue">xiao-lei.shi@hp.com</span></a></span><o:p></o:p></p
7:35 p.m.
--_000_859B26A348D7AF42A791481A47A8B41A01043C7DG1W3640americas_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi Dan,
I heard that Martin is in TPO now, would you please take a look on these pa=
tches and merge it, thanks.
Best regards,
David Liang
From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Thursday, May 08, 2014 10:31 AM
To: Martin Sivak (msivak(a)redhat.com); Dan Kenigsberg (danken(a)redhat.com)
Cc: Gilad Chaplik <gchaplik(a)redhat.com> (gchaplik(a)redhat.com); Doron Fediuc=
k (dfediuck(a)redhat.com); Liang, Shang-Chun (David Liang, HPservers-Core-OE-=
PSC); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); devel(a)ovirt.org
Subject: Vdsm patches need review and merge
Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the=
transferred data format because of the xmlrpc limitations. So could you pl=
ease review them again?
Hi Dan,
I have modified your comments for some of the above patches. Could you plea=
se take a look and merge those if no more comments?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi@hp.com<mailto:shiguo.li@hp.com
--_000_859B26A348D7AF42A791481A47A8B41A01043C7DG1W3640americas_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml"
xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word"
=
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml"
xmlns=3D"http:=
//www.w3.org/TR/REC-html40" <head <meta http-equiv=3D"Content-Type"
content=3D"text/html; charset=3Dus-ascii"=
<meta name=3D"Generator" content=3D"Microsoft
Word 15 (filtered medium)" <style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" / </xml><![endif]--><!--[if gte mso
9]><xml <o:shapelayout
v:ext=3D"edit" <o:idmap v:ext=3D"edit"
data=3D"1" /
</o:shapelayout></xml><![endif]--
</head <body lang=3D"EN-US"
link=3D"blue" vlink=3D"purple" <div
class=3D"WordSection1" <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">Hi
Dan,<o:p></o:p></sp=
an></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">I heard
that Martin is=
in TPO now, would you please take a look on these patches and merge it, th=
anks.<o:p></o:p></span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">Best
regards,<o:p></o:=
p></span></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">David
Liang<o:p></o:p>=
</span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <div
style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt" <div <div
style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in" <p
class=3D"MsoNormal"><b>From:</b> Shi, Xiao-Lei (Bruce, HP
Servers-PSC-CQ=
) <br <b>Sent:</b> Thursday,
May 08, 2014 10:31 AM<br <b>To:</b> Martin Sivak
(msivak(a)redhat.com); Dan Kenigsberg (danken(a)redhat.=
com)<br <b>Cc:</b> Gilad Chaplik
&lt;gchaplik(a)redhat.com&gt; (gchaplik(a)redhat.com);=
Doron Fediuck (dfediuck(a)redhat.com); Liang, Shang-Chun (David Liang, HPser=
vers-Core-OE-PSC); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); devel@o=
virt.org<br <b>Subject:</b> Vdsm
patches need review and merge<o:p></o:p></p
</div </div <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal">Hi
Martin,<o:p></o:p></p <p
class=3D"MsoNormal">Could you help to review these numa vdsm patches:<o:=
p></o:p></p <p
class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27399/">http:=
//gerrit.ovirt.org/#/c/27399/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27090/">http:=
//gerrit.ovirt.org/#/c/27090/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27403/">http:=
//gerrit.ovirt.org/#/c/27403/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/26876/">http:=
//gerrit.ovirt.org/#/c/26876/</a><o:p></o:p></p <p class=3D"MsoNormal">You had already reviewed
some of the patches, but af=
ter that I modified the transferred data format because of the xmlrpc limit=
ations. So could you please review them again?<o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal">Hi
Dan,<o:p></o:p></p <p
class=3D"MsoNormal">I have modified your comments for some of the above =
patches. Could you please take a look and merge those if no more comments?<=
o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt">Thanks & Best Regards</span></b><span
style=3D"font-size:=
12.0pt"><o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Shi, Xiao-Lei
(Bruce)<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt"><o:p> </o:p></span></b></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt;color:black">Hewlett-Packard Co., Ltd.<br HP Servers Core Platform Software
China</span></b><b><span style=3D"font-si=
ze:12.0pt"
<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Telephone</span></b><span
style=3D"font-size:12.0pt"> +86=
23 65683093<o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Mobile
</span></b><span style=3D"font-size:12.0pt">+86
18696583447<o:p></o:p><=
/span></p <p
class=3D"MsoNormal"><b><span
style=3D"font-size:12.0pt">Email </span></b=
<p
class=3D"MsoNormal"><o:p> </o:p></p </div
</div </body </html
--_000_859B26A348D7AF42A791481A47A8B41A01043C7DG1W3640americas_--
<span style=3D"font-size:12.0pt"><a
href=3D"mailto:shiguo.li@hp.com">xiao-=
lei.shi@hp.com</a></span><o:p></o:p></p
5:33 a.m.
--_000_08AA403C8399104A89AF710307FA78AE24404AC1G5W2743americas_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi Dan/Francesco,
Could you help to review and merge these patches:
http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since so=
me comments in that patch need to modify caps module)
http://gerrit.ovirt.org/#/c/26876/
http://gerrit.ovirt.org/#/c/27403/
I didn't modify some comments in 26876 since I think they are related with =
codes refactor and literal syntax. I will submit a separate patch to modify=
these kinds of comments of numa feature altogether later. Could you please=
now focus on the functionality since we need to merge these patches ASAP?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi@hp.com<mailto:shiguo.li@hp.com
From: Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC)
Sent: Thursday, May 08, 2014 10:35 AM
To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Martin Sivak (msivak(a)redhat.c=
om); Dan Kenigsberg (danken(a)redhat.com)
Cc: Gilad Chaplik <gchaplik(a)redhat.com> (gchaplik(a)redhat.com); Doron Fediuc=
k (dfediuck(a)redhat.com); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); d=
evel(a)ovirt.org
Subject: RE: Vdsm patches need review and merge
Hi Dan,
I heard that Martin is in TPO now, would you please take a look on these pa=
tches and merge it, thanks.
Best regards,
David Liang
From: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Sent: Thursday, May 08, 2014 10:31 AM
To: Martin Sivak (msivak@redhat.com<mailto:msivak@redhat.com>); Dan Kenigsb=
erg (danken@redhat.com<mailto:danken@redhat.com>)
Cc: Gilad Chaplik <gchaplik@redhat.com<mailto:gchaplik@redhat.com>> (gchapl=
ik@redhat.com<mailto:gchaplik@redhat.com>); Doron Fediuck (dfediuck(a)redhat.=
com<mailto:dfediuck@redhat.com>); Liang, Shang-Chun (David Liang, HPservers=
-Core-OE-PSC); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); devel@ovirt=
.org<mailto:devel@ovirt.org Subject: Vdsm patches need review
and merge
Hi Martin,
Could you help to review these numa vdsm patches:
http://gerrit.ovirt.org/#/c/27399/
http://gerrit.ovirt.org/#/c/27090/
http://gerrit.ovirt.org/#/c/27403/
http://gerrit.ovirt.org/#/c/26876/
You had already reviewed some of the patches, but after that I modified the=
transferred data format because of the xmlrpc limitations. So could you pl=
ease review them again?
Hi Dan,
I have modified your comments for some of the above patches. Could you plea=
se take a look and merge those if no more comments?
Thanks & Best Regards
Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd.
HP Servers Core Platform Software China
Telephone +86 23 65683093
Mobile +86 18696583447
Email xiao-lei.shi@hp.com<mailto:shiguo.li@hp.com
--_000_08AA403C8399104A89AF710307FA78AE24404AC1G5W2743americas_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml"
xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word"
=
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml"
xmlns=3D"http:=
//www.w3.org/TR/REC-html40" <head <meta http-equiv=3D"Content-Type"
content=3D"text/html; charset=3Dus-ascii"=
<meta name=3D"Generator" content=3D"Microsoft
Word 14 (filtered medium)" <style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" / </xml><![endif]--><!--[if gte mso
9]><xml <o:shapelayout
v:ext=3D"edit" <o:idmap v:ext=3D"edit"
data=3D"1" /
</o:shapelayout></xml><![endif]--
</head <body lang=3D"EN-US"
link=3D"blue" vlink=3D"purple" <div
class=3D"WordSection1" <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">Hi
Dan/Francesco,<o:p>=
</o:p></span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">Could you
help to revi=
ew and merge these patches:<o:p></o:p></span></p <p class=3D"MsoNormal"><span
style=3D"color:#1F497D"><a href=3D"http://gerr=
it.ovirt.org/#/c/27515/">http://gerrit.ovirt.org/#/c/27515/</a...;
(This=
patch is needed by 26876 since some comments in that patch need to modify =
caps module)<o:p></o:p></span></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D"><a
href=3D"http://gerr=
it.ovirt.org/#/c/26876/">http://gerrit.ovirt.org/#/c/26876/</a...
/span></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D"><a
href=3D"http://gerr=
it.ovirt.org/#/c/27403/">http://gerrit.ovirt.org/#/c/27403/</a...
/span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">I
didn’t modify =
some comments in 26876 since I think they are related with codes refactor a=
nd literal syntax. I will submit a separate patch to modify these kinds of =
comments of numa feature altogether later.
Could you please now focus on the functionality since we need to merge the=
se patches ASAP?<o:p></o:p></span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <div <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt;color:#1F497D">Thanks & Best
Regards</span></b><span style=
=3D"font-size:12.0pt;color:#1F497D"><o:p></o:p></span></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt;color:#1F497D">Shi, Xiao-Lei
(Bruce)<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt;color:#1F497D"><o:p> </o:p></span></b></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt;color:black">Hewlett-Packard Co., Ltd.<br HP Servers Core Platform Software
China</span></b><b><span style=3D"font-si=
ze:12.0pt;color:#1F497D"
<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt;color:#1F497D">Telephone</span></b><span
style=3D"font-size:12=
.0pt;color:#1F497D"> +86 23
65683093<o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt;color:#1F497D">Mobile
</span></b><span
style=3D"font-size:12.0pt;color:#1F497D">+86 186965834=
47<o:p></o:p></span></p <p
class=3D"MsoNormal"><b><span
style=3D"font-size:12.0pt;color:#1F497D">Em=
ail </span </b><span
style=3D"font-size:12.0pt;color:#1F497D"><a href=3D"mailto:shiguo=
.li@hp.com">xiao-lei.shi(a)hp.com</a></span><span
style=3D"color:#1F497D"><o:=
p></o:p></span></p
</div <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <div <div
style=3D"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in =
0in 0in" <p
class=3D"MsoNormal"><b><span
style=3D"font-size:10.0pt;font-family:"=
;Tahoma","sans-serif"">From:</span></b><span
style=3D"font-s=
ize:10.0pt;font-family:"Tahoma","sans-serif"">
Liang, S=
hang-Chun (David Liang, HPservers-Core-OE-PSC)
<br <b>Sent:</b> Thursday, May 08, 2014 10:35
AM<br <b>To:</b> Shi, Xiao-Lei
(Bruce, HP Servers-PSC-CQ); Martin Sivak (msivak@r=
edhat.com); Dan Kenigsberg (danken(a)redhat.com)<br
<b>Cc:</b> Gilad Chaplik &lt;gchaplik(a)redhat.com&gt;
(gchaplik(a)redhat.com);=
Doron Fediuck (dfediuck(a)redhat.com); Liao, Chuan (Jason Liao, HPservers-Co=
re-OE-PSC); devel(a)ovirt.org<br <b>Subject:</b> RE: Vdsm
patches need review and merge<o:p></o:p></span></p=
</div
</div <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal"><span
style=3D"color:#1F497D">Hi Dan,<o:p></o:p></sp=
an></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">I heard
that Martin is=
in TPO now, would you please take a look on these patches and merge it, th=
anks.<o:p></o:p></span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">Best
regards,<o:p></o:=
p></span></p <p
class=3D"MsoNormal"><span style=3D"color:#1F497D">David
Liang<o:p></o:p>=
</span></p <p
class=3D"MsoNormal"><span
style=3D"color:#1F497D"><o:p> </o:p></spa=
n></p <div
style=3D"border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt" <div <div
style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in =
0in 0in" <p
class=3D"MsoNormal"><b>From:</b> Shi, Xiao-Lei (Bruce, HP
Servers-PSC-CQ=
) <br <b>Sent:</b> Thursday,
May 08, 2014 10:31 AM<br <b>To:</b> Martin Sivak
(<a href=3D"mailto:msivak@redhat.com">msivak@redhat=
.com</a>); Dan Kenigsberg (<a
href=3D"mailto:danken@redhat.com">danken@redh=
at.com</a>)<br <b>Cc:</b> Gilad Chaplik
<<a href=3D"mailto:gchaplik@redhat.com">gchapli=
k(a)redhat.com</a>&gt; (<a
href=3D"mailto:gchaplik@redhat.com">gchaplik@redha=
t.com</a>); Doron Fediuck (<a
href=3D"mailto:dfediuck@redhat.com">dfediuck@=
redhat.com</a>); Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); <=
a href=3D"mailto:devel@ovirt.org"
devel(a)ovirt.org</a><br
<b>Subject:</b> Vdsm patches need review and
merge<o:p></o:p></p </div </div <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal">Hi
Martin,<o:p></o:p></p <p
class=3D"MsoNormal">Could you help to review these numa vdsm patches:<o:=
p></o:p></p <p
class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27399/">http:=
//gerrit.ovirt.org/#/c/27399/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27090/">http:=
//gerrit.ovirt.org/#/c/27090/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/27403/">http:=
//gerrit.ovirt.org/#/c/27403/</a><o:p></o:p></p <p class=3D"MsoNormal"><a
href=3D"http://gerrit.ovirt.org/#/c/26876/">http:=
//gerrit.ovirt.org/#/c/26876/</a><o:p></o:p></p <p class=3D"MsoNormal">You had already reviewed
some of the patches, but af=
ter that I modified the transferred data format because of the xmlrpc limit=
ations. So could you please review them again?<o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal">Hi
Dan,<o:p></o:p></p <p
class=3D"MsoNormal">I have modified your comments for some of the above =
patches. Could you please take a look and merge those if no more comments?<=
o:p></o:p></p <p
class=3D"MsoNormal"><o:p> </o:p></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt">Thanks & Best Regards</span></b><span
style=3D"font-size:=
12.0pt"><o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Shi, Xiao-Lei
(Bruce)<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt"><o:p> </o:p></span></b></p <p class=3D"MsoNormal"
style=3D"text-autospace:none"><b><span style=3D"font=
-size:12.0pt;color:black">Hewlett-Packard Co., Ltd.<br HP Servers Core Platform Software
China</span></b><b><span style=3D"font-si=
ze:12.0pt"
<o:p></o:p></span></b></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Telephone</span></b><span
style=3D"font-size:12.0pt"> +86=
23 65683093<o:p></o:p></span></p <p
class=3D"MsoNormal" style=3D"text-autospace:none"><b><span
style=3D"font=
-size:12.0pt">Mobile
</span></b><span style=3D"font-size:12.0pt">+86
18696583447<o:p></o:p><=
/span></p <p
class=3D"MsoNormal"><b><span
style=3D"font-size:12.0pt">Email </span></b=
<p
class=3D"MsoNormal"><o:p> </o:p></p </div
</div </body </html
--_000_08AA403C8399104A89AF710307FA78AE24404AC1G5W2743americas_--
<span style=3D"font-size:12.0pt"><a
href=3D"mailto:shiguo.li@hp.com">xiao-=
lei.shi@hp.com</a></span><o:p></o:p></p
5:48 a.m.
----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Dan Kenigsberg (danken(a)redhat.com)" <danken(a)redhat.com>,
"Francesco Romani" <fromani(a)redhat.com>
Cc: "Gilad Chaplik <gchaplik(a)redhat.com> (gchaplik(a)redhat.com)"
<gchaplik(a)redhat.com>, "Doron Fediuck
(dfediuck(a)redhat.com)" <dfediuck(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
devel(a)ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
Sent: Thursday, May 8, 2014 2:33:14 PM
Subject: RE: Vdsm patches need review and merge
Hi Dan/Francesco,
Could you help to review and merge these patches:
http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since some
comments in that patch need to modify caps module)
http://gerrit.ovirt.org/#/c/26876/
http://gerrit.ovirt.org/#/c/27403/
I didn't modify some comments in 26876 since I think they are related with
codes refactor and literal syntax. I will submit a separate patch to modify
these kinds of comments of numa feature altogether later. Could you please
now focus on the functionality since we need to merge these patches ASAP?
http://gerrit.ovirt.org/#/c/27403
I'm OK with it (gave +1)
http://gerrit.ovirt.org/#/c/26876
I don't have objections and I don't see blockers for the functionality.
I'm not 100% happy with the implementation, but the existing one is on par
with most of code, and if we're in hurry, I guess refinements can wait.
http://gerrit.ovirt.org/#/c/27515
good enough for the same reasons above (gave +1)
Bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
7:02 a.m.
On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote:
----- Original Message -----
> From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> To: "Dan Kenigsberg (danken(a)redhat.com)" <danken(a)redhat.com>,
"Francesco Romani" <fromani(a)redhat.com>
> Cc: "Gilad Chaplik <gchaplik(a)redhat.com> (gchaplik(a)redhat.com)"
<gchaplik(a)redhat.com>, "Doron Fediuck
> (dfediuck(a)redhat.com)" <dfediuck(a)redhat.com>, "Chuan Liao (Jason
Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
> devel(a)ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
> Sent: Thursday, May 8, 2014 2:33:14 PM
> Subject: RE: Vdsm patches need review and merge
>
> Hi Dan/Francesco,
>
> Could you help to review and merge these patches:
> http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since some
> comments in that patch need to modify caps module)
> http://gerrit.ovirt.org/#/c/26876/
> http://gerrit.ovirt.org/#/c/27403/
>
> I didn't modify some comments in 26876 since I think they are related with
> codes refactor and literal syntax. I will submit a separate patch to modify
> these kinds of comments of numa feature altogether later. Could you please
> now focus on the functionality since we need to merge these patches ASAP?
http://gerrit.ovirt.org/#/c/27403
I'm OK with it (gave +1)
http://gerrit.ovirt.org/#/c/26876
I don't have objections and I don't see blockers for the functionality.
I'm not 100% happy with the implementation, but the existing one is on par
with most of code, and if we're in hurry, I guess refinements can wait.
http://gerrit.ovirt.org/#/c/27515
good enough for the same reasons above (gave +1)
Puritans would suggest to squash this into 26876, or fix the commit
message - prior to 26876 nothing uses these private methods. But never
mind, taken.
7:32 a.m.
Hi,
Unfortunately, we just found
https://bugzilla.redhat.com/show_bug.cgi?id=1098539
This looks like an engine bug, however.
Can someone please check and help with a fix?
Thanks,
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Francesco Romani" <fromani(a)redhat.com>
Cc: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com>,
"Gilad Chaplik(gchaplik(a)redhat.com)"
<gchaplik(a)redhat.com>, "Doron Fediuck (dfediuck(a)redhat.com)"
<dfediuck(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>, devel(a)ovirt.org, "Shang-Chun
Liang (David Liang,
HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com>
Sent: Thursday, May 8, 2014 4:02:44 PM
Subject: Re: Vdsm patches need review and merge
On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote:
>
> ----- Original Message -----
> > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
> > To: "Dan Kenigsberg (danken(a)redhat.com)" <danken(a)redhat.com>,
"Francesco
> > Romani" <fromani(a)redhat.com>
> > Cc: "Gilad Chaplik <gchaplik(a)redhat.com>
(gchaplik(a)redhat.com)"
> > <gchaplik(a)redhat.com>, "Doron Fediuck
> > (dfediuck(a)redhat.com)" <dfediuck(a)redhat.com>, "Chuan Liao
(Jason Liao,
> > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
> > devel(a)ovirt.org, "Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)"
> > <shangchun.liang(a)hp.com>
> > Sent: Thursday, May 8, 2014 2:33:14 PM
> > Subject: RE: Vdsm patches need review and merge
> >
> > Hi Dan/Francesco,
> >
> > Could you help to review and merge these patches:
> > http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since
> > some
> > comments in that patch need to modify caps module)
> > http://gerrit.ovirt.org/#/c/26876/
> > http://gerrit.ovirt.org/#/c/27403/
> >
> > I didn't modify some comments in 26876 since I think they are related
> > with
> > codes refactor and literal syntax. I will submit a separate patch to
> > modify
> > these kinds of comments of numa feature altogether later. Could you
> > please
> > now focus on the functionality since we need to merge these patches ASAP?
>
> http://gerrit.ovirt.org/#/c/27403
> I'm OK with it (gave +1)
>
> http://gerrit.ovirt.org/#/c/26876
> I don't have objections and I don't see blockers for the functionality.
> I'm not 100% happy with the implementation, but the existing one is on par
> with most of code, and if we're in hurry, I guess refinements can wait.
>
> http://gerrit.ovirt.org/#/c/27515
> good enough for the same reasons above (gave +1)
Puritans would suggest to squash this into 26876, or fix the commit
message - prior to 26876 nothing uses these private methods. But never
mind, taken.
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
3633
days inactive
3641
days old
5 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Francesco Romani -
Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC) -
Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)