On Mon, Nov 30, 2015 at 01:20:57AM +0200, Nir Soffer wrote:

Since we merged https://gerrit.ovirt.org/48446, pyflakes is complaining:

./lib/vdsm/constants.py.in:26:29: invalid syntax GLUSTER_MGMT_ENABLED = bool(@GLUSTER_MGMT@) ^ Pyflakes is right the syntax, but is not Python module.

Why pflakes is looking in .in files?

I do not recall. It might have been because we wanted to run it prior to "make", or because expanding @MACROS@ tended to make lines pass the 80 char mark. Neither excuse flies to far.