Re: [Engine-devel] [Spice-devel] RFC: spice-server default listen behaviour change

Gerd Hoffmann píše v Pá 15. 06. 2012 v 10:36 +0200:
Hi,
This is pretty important wrt dual-stack configurations because they can be implemented with just slight changes to spice server (unlike the old RFE requesting listening on multiple addresses):
* when no addr= or ipvx options are set, listen on ::0
spice-server sets "ai.ai_flags = AI_PASSIVE | AI_ADDRCONFIG", which should make getaddrinfo() pick something reasonable, specifically listen on ipv6 only if the machine actually has ipv6 connectivity.
I don't think that listening on IPv6 exclusively is good when the host has both IPv4 and IPv6 connectivity. Think about dual stack setups where the spice-server host is defined by host name that can resolve to both IPv6 and IPv4 addresses. David
I think this is the behavior we want here.
* when ipv4 and no addr= option is set, listen on 0.0.0.0
Works today.
* when ipv6 is set, set IPV6_ONLY to 1 to make sure that spice server won't listen on ipv4
Trivially to add, see patch.
* when conflicting ipvx and addr= options are set, error out (this already works fine)
Works today indeed.
cheers, Gerd _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
-- David Jaša, RHCE SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24

On 06/15/12 11:02, David Jaša wrote:
Gerd Hoffmann píše v Pá 15. 06. 2012 v 10:36 +0200:
Hi,
This is pretty important wrt dual-stack configurations because they can be implemented with just slight changes to spice server (unlike the old RFE requesting listening on multiple addresses):
* when no addr= or ipvx options are set, listen on ::0
spice-server sets "ai.ai_flags = AI_PASSIVE | AI_ADDRCONFIG", which should make getaddrinfo() pick something reasonable, specifically listen on ipv6 only if the machine actually has ipv6 connectivity.
I don't think that listening on IPv6 exclusively is good when the host has both IPv4 and IPv6 connectivity.
Huh? Oh, I see you can read the sentence two ways: (1) specifically listen on ipv6 only, if the machine actually has ipv6 connectivity (2) specifically listen on ipv6, only if the machine actually has ipv6 connectivity I mean (2), i.e. do not create a ipv6 socket if the machine has no ipv6 connectivity. When creating a ipv6 socket IPV6_ONLY should be clear by default indeed, so both ipv4 and ipv6 will work. cheers, Gerd
participants (2)
-
David Jaša
-
Gerd Hoffmann