[VDSM] CentOS 8 build on Travis - only 3 tests fail
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8 And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609 After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36: lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%] Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/ I'm not sue why the hook test fail. Please review: https://gerrit.ovirt.org/q/topic:py3+is:open+owner:%2522Nir+Soffer+%253Cnsof... Nir
Hi, On 10/10/19 10:42 PM, Nir Soffer wrote:
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8
And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609
After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36:
lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%]
Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/
I'm not sue why the hook test fail. The fix for the hooks test is here: https://gerrit.ovirt.org/#/c/102455/
Please review: https://gerrit.ovirt.org/q/topic:py3+is:open+owner:%2522Nir+Soffer+%253Cnsof...
Nir
On 10/10/19 10:42 PM, Nir Soffer wrote:
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8
And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609
After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36:
lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%]
Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/
I'm not sue why the hook test fail.
I *guess* incompatible pickle format between python versions? Bests, -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
On 10/11/19 10:07 AM, Francesco Romani wrote:
On 10/10/19 10:42 PM, Nir Soffer wrote:
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8
And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609
After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36:
lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%]
Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/
I'm not sue why the hook test fail.
I *guess* incompatible pickle format between python versions?
Nope, the pickling and unpickling is done with the same interpreter version. I already posted that the patch for the issue is here and the explanation is in the commit message (tldr it's about some environments using ascii locale): https://gerrit.ovirt.org/#/c/102455/
Bests,
-- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7PEGPUT2VVI5M6...
On 10/11/19 10:21 AM, Marcin Sobczyk wrote:
On 10/11/19 10:07 AM, Francesco Romani wrote:
On 10/10/19 10:42 PM, Nir Soffer wrote:
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8
And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609
After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36:
lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%]
Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/
I'm not sue why the hook test fail.
I *guess* incompatible pickle format between python versions?
Nope, the pickling and unpickling is done with the same interpreter version. I already posted that the patch for the issue is here and the explanation is in the commit message (tldr it's about some environments using ascii locale):
Yep, seen the patch and LGTM Thanks! -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
On Thu, Oct 10, 2019 at 11:42 PM Nir Soffer <nsoffer@redhat.com> wrote:
I added centos-8 docker image: https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8
And centos-8 build in Travis: https://travis-ci.org/nirs/vdsm/jobs/596270609
After fixing 22 tests trying to run /usr/bin/python2, we have only 3 failing tests in lib-py36:
lib/hooks_test.py .....................x......F.............. [ 50%] ssl_test.py ...........FF... [100%]
Marcin already handled the ssl tests in: https://gerrit.ovirt.org/c/103812/
I'm not sue why the hook test fail.
Please review: https://gerrit.ovirt.org/q/topic:py3+is:open+owner:%2522Nir+Soffer+%253Cnsof...
Merged everything expect the storage and gluster scripts, since "/usr/bin/env python" does not work in Fedora 30. I updated the patches using sys.executable which seems to be the only sane way to run python code with multiple versions. Please review/merge: - https://gerrit.ovirt.org/c/104046/ - https://gerrit.ovirt.org/c/104047/ Nir
participants (3)
-
Francesco Romani -
Marcin Sobczyk -
Nir Soffer