Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures). I am quite sure I saw patches containing both approaches. Yair
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
You are right I think old should be kept until we have the time to do a global find/replace of all old names. The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
You are right I think old should be kept until we have the time to do a global find/replace of all old names. The only place in which I encourage new names are application log/audit messages
+1 Note that in the UI we're using new names since I can remember, so less re-factoring ;-)
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review. That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names. Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews. I don't think this task should have specific task force allocated for that. As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches). Thanks Barak Azulay
The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On 05/18/2014 08:42 PM, Barak Azulay wrote:
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
worth checking for alignment/planning with the gui move to rest api, which will disentangle it from the backend business entities. (doesn't have to wait until GUI finishes the move, just communicated)
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 : StoragePool => DC VdsGroup => Cluster Vds => Host
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: devel@ovirt.org Sent: Thursday, May 15, 2014 3:20:18 PM Subject: [ovirt-devel] Entity names in DB scripts
Hi all, I have a feeling there is some inconsistency in using entity names in the DB scripts. For example, should we use Host or VDS? I am not talking about existing tables or columns but about new ones (and new stored procedures).
I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster Vds => Host
I would prefer DataCenter instead of DC for class name. But +1 for starting the process.
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
The only place in which I encourage new names are application log/audit messages
Yair _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: devel@ovirt.org Sent: Thursday, May 15, 2014 4:56:50 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > To: devel@ovirt.org > Sent: Thursday, May 15, 2014 3:20:18 PM > Subject: [ovirt-devel] Entity names in DB scripts > > Hi all, > I have a feeling there is some inconsistency in using entity > names > in > the > DB > scripts. > For example, should we use Host or VDS? > I am not talking about existing tables or columns but about new > ones > (and > new > stored procedures). > > I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
You are right I think old should be kept until we have the time to do a global find/replace of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
The only place in which I encourage new names are application log/audit messages
> > Yair > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org Sent: Thursday, May 15, 2014 7:33:06 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > Cc: devel@ovirt.org > Sent: Thursday, May 15, 2014 4:56:50 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > To: devel@ovirt.org > > Sent: Thursday, May 15, 2014 3:20:18 PM > > Subject: [ovirt-devel] Entity names in DB scripts > > > > Hi all, > > I have a feeling there is some inconsistency in using entity > > names > > in > > the > > DB > > scripts. > > For example, should we use Host or VDS? > > I am not talking about existing tables or columns but about new > > ones > > (and > > new > > stored procedures). > > > > I am quite sure I saw patches containing both approaches.
I guess that includes any recent patches around the network area.
> > You are right > I think old should be kept until we have the time to do a global > find/replace > of all old names.
Without enabling the "new" (or more appropriate) naming to new code we: 1. Increase the amount of 'old' code in the system (gaining more debts) 2. As a result - more work when and if global change will take affect. 3. Double the entire work flow: code + review.
That change should start at some point, and having it incrementally is a valid approach to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2]. Thanks, Gilad. [1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
> The only place in which I encourage new names are application > log/audit > messages > > > > > Yair > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Sunday, May 18, 2014 4:08:45 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Moti Asayag" <masayag@redhat.com> > To: "Eli Mesika" <emesika@redhat.com> > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org > Sent: Thursday, May 15, 2014 7:33:06 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Eli Mesika" <emesika@redhat.com> > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > Cc: devel@ovirt.org > > Sent: Thursday, May 15, 2014 4:56:50 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > To: devel@ovirt.org > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > Hi all, > > > I have a feeling there is some inconsistency in using entity > > > names > > > in > > > the > > > DB > > > scripts. > > > For example, should we use Host or VDS? > > > I am not talking about existing tables or columns but about > > > new > > > ones > > > (and > > > new > > > stored procedures). > > > > > > I am quite sure I saw patches containing both approaches. > > I guess that includes any recent patches around the network area. > > > > > You are right > > I think old should be kept until we have the time to do a > > global > > find/replace > > of all old names. > > Without enabling the "new" (or more appropriate) naming to new > code > we: > 1. Increase the amount of 'old' code in the system (gaining more > debts) > 2. As a result - more work when and if global change will take > affect. > 3. Double the entire work flow: code + review. > > That change should start at some point, and having it > incrementally > is > a > valid approach > to achieve that goal.
I basically agree, but first someone (that can say that) should say that we are going to do that and allocate resources to this tasks , unless , you are left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI. I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times. Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
> > > The only place in which I encourage new names are application > > log/audit > > messages > > > > > > > > Yair > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "Moti Asayag" <masayag@redhat.com> > Cc: devel@ovirt.org > Sent: Sunday, May 18, 2014 4:08:45 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Moti Asayag" <masayag@redhat.com> > > To: "Eli Mesika" <emesika@redhat.com> > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org > > Sent: Thursday, May 15, 2014 7:33:06 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika@redhat.com> > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > Cc: devel@ovirt.org > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > To: devel@ovirt.org > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > Hi all, > > > > I have a feeling there is some inconsistency in using > > > > entity > > > > names > > > > in > > > > the > > > > DB > > > > scripts. > > > > For example, should we use Host or VDS? > > > > I am not talking about existing tables or columns but about > > > > new > > > > ones > > > > (and > > > > new > > > > stored procedures). > > > > > > > > I am quite sure I saw patches containing both approaches. > > > > I guess that includes any recent patches around the network > > area. > > > > > > > > You are right > > > I think old should be kept until we have the time to do a > > > global > > > find/replace > > > of all old names. > > > > Without enabling the "new" (or more appropriate) naming to new > > code > > we: > > 1. Increase the amount of 'old' code in the system (gaining > > more > > debts) > > 2. As a result - more work when and if global change will take > > affect. > > 3. Double the entire work flow: code + review. > > > > That change should start at some point, and having it > > incrementally > > is > > a > > valid approach > > to achieve that goal. > > I basically agree, but first someone (that can say that) should > say > that > we > are going to do that and allocate resources to this tasks , > unless > , > you > are > left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
> > > > > > The only place in which I encourage new names are application > > > log/audit > > > messages > > > > > > > > > > > Yair > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:44:07 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Barak Azulay" <bazulay@redhat.com> > To: "Eli Mesika" <emesika@redhat.com> > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > Sent: Sunday, May 18, 2014 8:42:47 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Eli Mesika" <emesika@redhat.com> > > To: "Moti Asayag" <masayag@redhat.com> > > Cc: devel@ovirt.org > > Sent: Sunday, May 18, 2014 4:08:45 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Moti Asayag" <masayag@redhat.com> > > > To: "Eli Mesika" <emesika@redhat.com> > > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org > > > Sent: Thursday, May 15, 2014 7:33:06 PM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > Cc: devel@ovirt.org > > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > To: devel@ovirt.org > > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > Hi all, > > > > > I have a feeling there is some inconsistency in using > > > > > entity > > > > > names > > > > > in > > > > > the > > > > > DB > > > > > scripts. > > > > > For example, should we use Host or VDS? > > > > > I am not talking about existing tables or columns but > > > > > about > > > > > new > > > > > ones > > > > > (and > > > > > new > > > > > stored procedures). > > > > > > > > > > I am quite sure I saw patches containing both approaches. > > > > > > I guess that includes any recent patches around the network > > > area. > > > > > > > > > > > You are right > > > > I think old should be kept until we have the time to do a > > > > global > > > > find/replace > > > > of all old names. > > > > > > Without enabling the "new" (or more appropriate) naming to > > > new > > > code > > > we: > > > 1. Increase the amount of 'old' code in the system (gaining > > > more > > > debts) > > > 2. As a result - more work when and if global change will > > > take > > > affect. > > > 3. Double the entire work flow: code + review. > > > > > > That change should start at some point, and having it > > > incrementally > > > is > > > a > > > valid approach > > > to achieve that goal. > > > > I basically agree, but first someone (that can say that) should > > say > > that > > we > > are going to do that and allocate resources to this tasks , > > unless > > , > > you > > are > > left in hybrid ugly condition > > > > Guys please post the list of Entities and let's agree on new > names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
+1
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
again, you only re-enforcing my argument, it named 'Gluster Cluster', so we should name it VM Cluster, not Cluster.
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
> > Once this is done - each maintainer/reviewer should start > enforcing > that > policy in his reviews. > > I don't think this task should have specific task force allocated > for > that. > > As a guide line - Those patches (rename patches) should be > separated > from > the > logic change (on top of the name change patches). > > > Thanks > Barak Azulay > > > > > > > > > > > > > The only place in which I encourage new names are > > > > application > > > > log/audit > > > > messages > > > > > > > > > > > > > > Yair > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: "Oved Ourfalli" <ovedo@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:46:48 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:44:07 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "Barak Azulay" <bazulay@redhat.com> > Cc: devel@ovirt.org > Sent: Monday, May 19, 2014 11:37:23 AM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Barak Azulay" <bazulay@redhat.com> > > To: "Eli Mesika" <emesika@redhat.com> > > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > > Sent: Sunday, May 18, 2014 8:42:47 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika@redhat.com> > > > To: "Moti Asayag" <masayag@redhat.com> > > > Cc: devel@ovirt.org > > > Sent: Sunday, May 18, 2014 4:08:45 PM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Moti Asayag" <masayag@redhat.com> > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org > > > > Sent: Thursday, May 15, 2014 7:33:06 PM > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > Cc: devel@ovirt.org > > > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > To: devel@ovirt.org > > > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > Hi all, > > > > > > I have a feeling there is some inconsistency in using > > > > > > entity > > > > > > names > > > > > > in > > > > > > the > > > > > > DB > > > > > > scripts. > > > > > > For example, should we use Host or VDS? > > > > > > I am not talking about existing tables or columns but > > > > > > about > > > > > > new > > > > > > ones > > > > > > (and > > > > > > new > > > > > > stored procedures). > > > > > > > > > > > > I am quite sure I saw patches containing both > > > > > > approaches. > > > > > > > > I guess that includes any recent patches around the network > > > > area. > > > > > > > > > > > > > > You are right > > > > > I think old should be kept until we have the time to do a > > > > > global > > > > > find/replace > > > > > of all old names. > > > > > > > > Without enabling the "new" (or more appropriate) naming to > > > > new > > > > code > > > > we: > > > > 1. Increase the amount of 'old' code in the system (gaining > > > > more > > > > debts) > > > > 2. As a result - more work when and if global change will > > > > take > > > > affect. > > > > 3. Double the entire work flow: code + review. > > > > > > > > That change should start at some point, and having it > > > > incrementally > > > > is > > > > a > > > > valid approach > > > > to achieve that goal. > > > > > > I basically agree, but first someone (that can say that) > > > should > > > say > > > that > > > we > > > are going to do that and allocate resources to this tasks , > > > unless > > > , > > > you > > > are > > > left in hybrid ugly condition > > > > > > > > Guys please post the list of Entities and let's agree on new > > names. > > Top 3 : > > StoragePool => DC > VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
+1
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
again, you only re-enforcing my argument, it named 'Gluster Cluster', so we should name it VM Cluster, not Cluster.
Some clusters are both virt and gluster clusters..... I suggest leaving the Cluster name as is.
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
> Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
> > > > > > Once this is done - each maintainer/reviewer should start > > enforcing > > that > > policy in his reviews. > > > > I don't think this task should have specific task force > > allocated > > for > > that. > > > > As a guide line - Those patches (rename patches) should be > > separated > > from > > the > > logic change (on top of the name change patches). > > > > > > Thanks > > Barak Azulay > > > > > > > > > > > > > > > > > > > > The only place in which I encourage new names are > > > > > application > > > > > log/audit > > > > > messages > > > > > > > > > > > > > > > > > Yair > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > Devel@ovirt.org > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:51:44 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: "Oved Ourfalli" <ovedo@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:46:48 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:44:07 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Martin Perina" <mperina@redhat.com> > To: "Eli Mesika" <emesika@redhat.com> > Cc: devel@ovirt.org > Sent: Monday, May 19, 2014 12:43:32 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Eli Mesika" <emesika@redhat.com> > > To: "Barak Azulay" <bazulay@redhat.com> > > Cc: devel@ovirt.org > > Sent: Monday, May 19, 2014 11:37:23 AM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Barak Azulay" <bazulay@redhat.com> > > > To: "Eli Mesika" <emesika@redhat.com> > > > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > > > Sent: Sunday, May 18, 2014 8:42:47 PM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > To: "Moti Asayag" <masayag@redhat.com> > > > > Cc: devel@ovirt.org > > > > Sent: Sunday, May 18, 2014 4:08:45 PM > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Moti Asayag" <masayag@redhat.com> > > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, > > > > > devel@ovirt.org > > > > > Sent: Thursday, May 15, 2014 7:33:06 PM > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > Cc: devel@ovirt.org > > > > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > > To: devel@ovirt.org > > > > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > Hi all, > > > > > > > I have a feeling there is some inconsistency in using > > > > > > > entity > > > > > > > names > > > > > > > in > > > > > > > the > > > > > > > DB > > > > > > > scripts. > > > > > > > For example, should we use Host or VDS? > > > > > > > I am not talking about existing tables or columns but > > > > > > > about > > > > > > > new > > > > > > > ones > > > > > > > (and > > > > > > > new > > > > > > > stored procedures). > > > > > > > > > > > > > > I am quite sure I saw patches containing both > > > > > > > approaches. > > > > > > > > > > I guess that includes any recent patches around the > > > > > network > > > > > area. > > > > > > > > > > > > > > > > > You are right > > > > > > I think old should be kept until we have the time to do > > > > > > a > > > > > > global > > > > > > find/replace > > > > > > of all old names. > > > > > > > > > > Without enabling the "new" (or more appropriate) naming > > > > > to > > > > > new > > > > > code > > > > > we: > > > > > 1. Increase the amount of 'old' code in the system > > > > > (gaining > > > > > more > > > > > debts) > > > > > 2. As a result - more work when and if global change will > > > > > take > > > > > affect. > > > > > 3. Double the entire work flow: code + review. > > > > > > > > > > That change should start at some point, and having it > > > > > incrementally > > > > > is > > > > > a > > > > > valid approach > > > > > to achieve that goal. > > > > > > > > I basically agree, but first someone (that can say that) > > > > should > > > > say > > > > that > > > > we > > > > are going to do that and allocate resources to this tasks , > > > > unless > > > > , > > > > you > > > > are > > > > left in hybrid ugly condition > > > > > > > > > > > > Guys please post the list of Entities and let's agree on new > > > names. > > > > Top 3 : > > > > StoragePool => DC > > VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1].
-1
cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
+1
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
again, you only re-enforcing my argument, it named 'Gluster Cluster', so we should name it VM Cluster, not Cluster.
Some clusters are both virt and gluster clusters..... I suggest leaving the Cluster name as is.
+1
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
> > Vds => Host > > I would prefer DataCenter instead of DC for class name. > > But +1 for starting the process. >
+1 for DataCenter (and other proposed names)
> > > > > > > > > > Once this is done - each maintainer/reviewer should start > > > enforcing > > > that > > > policy in his reviews. > > > > > > I don't think this task should have specific task force > > > allocated > > > for > > > that. > > > > > > As a guide line - Those patches (rename patches) should be > > > separated > > > from > > > the > > > logic change (on top of the name change patches). > > > > > > > > > Thanks > > > Barak Azulay > > > > > > > > > > > > > > > > > > > > > > > > > > > The only place in which I encourage new names are > > > > > > application > > > > > > log/audit > > > > > > messages > > > > > > > > > > > > > > > > > > > > Yair > > > > > > > _______________________________________________ > > > > > > > Devel mailing list > > > > > > > Devel@ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > Devel@ovirt.org > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 2:01:02 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:51:44 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: "Oved Ourfalli" <ovedo@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:46:48 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:44:07 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Moti Asayag" <masayag@redhat.com> > To: "Martin Perina" <mperina@redhat.com> > Cc: devel@ovirt.org > Sent: Monday, May 26, 2014 12:39:17 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Martin Perina" <mperina@redhat.com> > > To: "Eli Mesika" <emesika@redhat.com> > > Cc: devel@ovirt.org > > Sent: Monday, May 19, 2014 12:43:32 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika@redhat.com> > > > To: "Barak Azulay" <bazulay@redhat.com> > > > Cc: devel@ovirt.org > > > Sent: Monday, May 19, 2014 11:37:23 AM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Barak Azulay" <bazulay@redhat.com> > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > > > > Sent: Sunday, May 18, 2014 8:42:47 PM > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > To: "Moti Asayag" <masayag@redhat.com> > > > > > Cc: devel@ovirt.org > > > > > Sent: Sunday, May 18, 2014 4:08:45 PM > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Moti Asayag" <masayag@redhat.com> > > > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, > > > > > > devel@ovirt.org > > > > > > Sent: Thursday, May 15, 2014 7:33:06 PM > > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > > Cc: devel@ovirt.org > > > > > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > > > To: devel@ovirt.org > > > > > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > Hi all, > > > > > > > > I have a feeling there is some inconsistency in > > > > > > > > using > > > > > > > > entity > > > > > > > > names > > > > > > > > in > > > > > > > > the > > > > > > > > DB > > > > > > > > scripts. > > > > > > > > For example, should we use Host or VDS? > > > > > > > > I am not talking about existing tables or columns > > > > > > > > but > > > > > > > > about > > > > > > > > new > > > > > > > > ones > > > > > > > > (and > > > > > > > > new > > > > > > > > stored procedures). > > > > > > > > > > > > > > > > I am quite sure I saw patches containing both > > > > > > > > approaches. > > > > > > > > > > > > I guess that includes any recent patches around the > > > > > > network > > > > > > area. > > > > > > > > > > > > > > > > > > > > You are right > > > > > > > I think old should be kept until we have the time to > > > > > > > do > > > > > > > a > > > > > > > global > > > > > > > find/replace > > > > > > > of all old names. > > > > > > > > > > > > Without enabling the "new" (or more appropriate) naming > > > > > > to > > > > > > new > > > > > > code > > > > > > we: > > > > > > 1. Increase the amount of 'old' code in the system > > > > > > (gaining > > > > > > more > > > > > > debts) > > > > > > 2. As a result - more work when and if global change > > > > > > will > > > > > > take > > > > > > affect. > > > > > > 3. Double the entire work flow: code + review. > > > > > > > > > > > > That change should start at some point, and having it > > > > > > incrementally > > > > > > is > > > > > > a > > > > > > valid approach > > > > > > to achieve that goal. > > > > > > > > > > I basically agree, but first someone (that can say that) > > > > > should > > > > > say > > > > > that > > > > > we > > > > > are going to do that and allocate resources to this tasks > > > > > , > > > > > unless > > > > > , > > > > > you > > > > > are > > > > > left in hybrid ugly condition > > > > > > > > > > > > > > > > Guys please post the list of Entities and let's agree on > > > > new > > > > names. > > > > > > Top 3 : > > > > > > StoragePool => DC > > > VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1].
-1
Think of the time spent on that, let's take a conversation as an example: oVirt guy: 'create a cluster' oVirt newcomer: 'what is a cluster?' oVirt guy: 'cluster is a migration domain' Takes 5 seconds right? Now multiply that by every guy that had ever used/worked/heard/already forgot/ (newcomer) about oVirt. let the scoring begin: I'm -1 on Cluster.
cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
+1
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
again, you only re-enforcing my argument, it named 'Gluster Cluster', so we should name it VM Cluster, not Cluster.
Some clusters are both virt and gluster clusters..... I suggest leaving the Cluster name as is.
+1
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
> > > Vds => Host > > > > I would prefer DataCenter instead of DC for class name. > > > > But +1 for starting the process. > > > > +1 for DataCenter (and other proposed names) > > > > > > > > > > > > > > > Once this is done - each maintainer/reviewer should start > > > > enforcing > > > > that > > > > policy in his reviews. > > > > > > > > I don't think this task should have specific task force > > > > allocated > > > > for > > > > that. > > > > > > > > As a guide line - Those patches (rename patches) should be > > > > separated > > > > from > > > > the > > > > logic change (on top of the name change patches). > > > > > > > > > > > > Thanks > > > > Barak Azulay > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The only place in which I encourage new names are > > > > > > > application > > > > > > > log/audit > > > > > > > messages > > > > > > > > > > > > > > > > > > > > > > > Yair > > > > > > > > _______________________________________________ > > > > > > > > Devel mailing list > > > > > > > > Devel@ovirt.org > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > Devel mailing list > > > > > > > Devel@ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
further more, given the terminology of today it's not sure if "cluster" means gluster cluster or migration domain. also look at my example for "host" a "host" can be everything: a) the machine engine runs on b) a machine in a "cluster", running vms c) a machine in a "cluster", as storage backend d) some network equipment (may be virtualized) in short: don't use any term which has to broad usage (like "host" or "cluster"): use: "compute node" for machines running vms use: "migration domain" (or similar narrowed down specifc term) for a bunch of hosts between which a vm can be migrated. Just my opinion of course. PS: It's no argument at all to say: "but we did this always this way, we can't change it" I know this can introduce a lot of work, but nameing schemes can be converted over time or via scripts/automatism. Am 27.05.2014 13:15, schrieb Gilad Chaplik:
Think of the time spent on that, let's take a conversation as an example:
oVirt guy: 'create a cluster' oVirt newcomer: 'what is a cluster?' oVirt guy: 'cluster is a migration domain'
Takes 5 seconds right? Now multiply that by every guy that had ever used/worked/heard/already forgot/ (newcomer) about oVirt.
let the scoring begin: I'm -1 on Cluster.
-- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
----- Original Message -----
From: "Sven Kieske" <S.Kieske@mittwald.de> To: devel@ovirt.org Sent: Tuesday, May 27, 2014 3:11:18 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
further more, given the terminology of today it's not sure if "cluster" means gluster cluster or migration domain.
also look at my example for "host" a "host" can be everything: a) the machine engine runs on b) a machine in a "cluster", running vms c) a machine in a "cluster", as storage backend d) some network equipment (may be virtualized)
in short: don't use any term which has to broad usage (like "host" or "cluster"):
use: "compute node" for machines running vms
I think Host (=server) is the right term. compute node can be a rack as well, it's all a matter of POV :-)
use: "migration domain" (or similar narrowed down specifc term) for a bunch of hosts between which a vm can be migrated.
Just my opinion of course.
PS: It's no argument at all to say: "but we did this always this way, we can't change it"
I know this can introduce a lot of work, but nameing schemes can be converted over time or via scripts/automatism.
Am 27.05.2014 13:15, schrieb Gilad Chaplik:
Think of the time spent on that, let's take a conversation as an example:
oVirt guy: 'create a cluster' oVirt newcomer: 'what is a cluster?' oVirt guy: 'cluster is a migration domain'
Takes 5 seconds right? Now multiply that by every guy that had ever used/worked/heard/already forgot/ (newcomer) about oVirt.
let the scoring begin: I'm -1 on Cluster.
-- Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 2:01:02 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:51:44 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: "Oved Ourfalli" <ovedo@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:46:48 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Oved Ourfalli" <ovedo@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:44:07 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Moti Asayag" <masayag@redhat.com> > To: "Martin Perina" <mperina@redhat.com> > Cc: devel@ovirt.org > Sent: Monday, May 26, 2014 12:39:17 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Martin Perina" <mperina@redhat.com> > > To: "Eli Mesika" <emesika@redhat.com> > > Cc: devel@ovirt.org > > Sent: Monday, May 19, 2014 12:43:32 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika@redhat.com> > > > To: "Barak Azulay" <bazulay@redhat.com> > > > Cc: devel@ovirt.org > > > Sent: Monday, May 19, 2014 11:37:23 AM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Barak Azulay" <bazulay@redhat.com> > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > > > > Sent: Sunday, May 18, 2014 8:42:47 PM > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > To: "Moti Asayag" <masayag@redhat.com> > > > > > Cc: devel@ovirt.org > > > > > Sent: Sunday, May 18, 2014 4:08:45 PM > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Moti Asayag" <masayag@redhat.com> > > > > > > To: "Eli Mesika" <emesika@redhat.com> > > > > > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, > > > > > > devel@ovirt.org > > > > > > Sent: Thursday, May 15, 2014 7:33:06 PM > > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Eli Mesika" <emesika@redhat.com> > > > > > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > > Cc: devel@ovirt.org > > > > > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > > > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > > > > > To: devel@ovirt.org > > > > > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > > > > > Hi all, > > > > > > > > I have a feeling there is some inconsistency in > > > > > > > > using > > > > > > > > entity > > > > > > > > names > > > > > > > > in > > > > > > > > the > > > > > > > > DB > > > > > > > > scripts. > > > > > > > > For example, should we use Host or VDS? > > > > > > > > I am not talking about existing tables or columns > > > > > > > > but > > > > > > > > about > > > > > > > > new > > > > > > > > ones > > > > > > > > (and > > > > > > > > new > > > > > > > > stored procedures). > > > > > > > > > > > > > > > > I am quite sure I saw patches containing both > > > > > > > > approaches. > > > > > > > > > > > > I guess that includes any recent patches around the > > > > > > network > > > > > > area. > > > > > > > > > > > > > > > > > > > > You are right > > > > > > > I think old should be kept until we have the time to > > > > > > > do > > > > > > > a > > > > > > > global > > > > > > > find/replace > > > > > > > of all old names. > > > > > > > > > > > > Without enabling the "new" (or more appropriate) naming > > > > > > to > > > > > > new > > > > > > code > > > > > > we: > > > > > > 1. Increase the amount of 'old' code in the system > > > > > > (gaining > > > > > > more > > > > > > debts) > > > > > > 2. As a result - more work when and if global change > > > > > > will > > > > > > take > > > > > > affect. > > > > > > 3. Double the entire work flow: code + review. > > > > > > > > > > > > That change should start at some point, and having it > > > > > > incrementally > > > > > > is > > > > > > a > > > > > > valid approach > > > > > > to achieve that goal. > > > > > > > > > > I basically agree, but first someone (that can say that) > > > > > should > > > > > say > > > > > that > > > > > we > > > > > are going to do that and allocate resources to this tasks > > > > > , > > > > > unless > > > > > , > > > > > you > > > > > are > > > > > left in hybrid ugly condition > > > > > > > > > > > > > > > > Guys please post the list of Entities and let's agree on > > > > new > > > > names. > > > > > > Top 3 : > > > > > > StoragePool => DC > > > VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1].
-1
cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
Also named Cluster in the restapi and in the sdk.
+1
+1 as well
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
In addition, Gluster Cluster doesn't fall into migration domain category.
again, you only re-enforcing my argument, it named 'Gluster Cluster', so we should name it VM Cluster, not Cluster.
Some clusters are both virt and gluster clusters..... I suggest leaving the Cluster name as is.
+1
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
> > > Vds => Host > > > > I would prefer DataCenter instead of DC for class name. > > > > But +1 for starting the process. > > > > +1 for DataCenter (and other proposed names) > > > > > > > > > > > > > > > Once this is done - each maintainer/reviewer should start > > > > enforcing > > > > that > > > > policy in his reviews. > > > > > > > > I don't think this task should have specific task force > > > > allocated > > > > for > > > > that. > > > > > > > > As a guide line - Those patches (rename patches) should be > > > > separated > > > > from > > > > the > > > > logic change (on top of the name change patches). > > > > > > > > > > > > Thanks > > > > Barak Azulay > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The only place in which I encourage new names are > > > > > > > application > > > > > > > log/audit > > > > > > > messages > > > > > > > > > > > > > > > > > > > > > > > Yair > > > > > > > > _______________________________________________ > > > > > > > > Devel mailing list > > > > > > > > Devel@ovirt.org > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > Devel mailing list > > > > > > > Devel@ovirt.org > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Sunday, May 18, 2014 8:42:47 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "Moti Asayag" <masayag@redhat.com> > Cc: devel@ovirt.org > Sent: Sunday, May 18, 2014 4:08:45 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- > > From: "Moti Asayag" <masayag@redhat.com> > > To: "Eli Mesika" <emesika@redhat.com> > > Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org > > Sent: Thursday, May 15, 2014 7:33:06 PM > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > ----- Original Message ----- > > > From: "Eli Mesika" <emesika@redhat.com> > > > To: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > Cc: devel@ovirt.org > > > Sent: Thursday, May 15, 2014 4:56:50 PM > > > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Yair Zaslavsky" <yzaslavs@redhat.com> > > > > To: devel@ovirt.org > > > > Sent: Thursday, May 15, 2014 3:20:18 PM > > > > Subject: [ovirt-devel] Entity names in DB scripts > > > > > > > > Hi all, > > > > I have a feeling there is some inconsistency in using > > > > entity > > > > names > > > > in > > > > the > > > > DB > > > > scripts. > > > > For example, should we use Host or VDS? > > > > I am not talking about existing tables or columns but about > > > > new > > > > ones > > > > (and > > > > new > > > > stored procedures). > > > > > > > > I am quite sure I saw patches containing both approaches. > > > > I guess that includes any recent patches around the network > > area. > > > > > > > > You are right > > > I think old should be kept until we have the time to do a > > > global > > > find/replace > > > of all old names. > > > > Without enabling the "new" (or more appropriate) naming to new > > code > > we: > > 1. Increase the amount of 'old' code in the system (gaining > > more > > debts) > > 2. As a result - more work when and if global change will take > > affect. > > 3. Double the entire work flow: code + review. > > > > That change should start at some point, and having it > > incrementally > > is > > a > > valid approach > > to achieve that goal. > > I basically agree, but first someone (that can say that) should > say > that > we > are going to do that and allocate resources to this tasks , > unless > , > you > are > left in hybrid ugly condition
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
I think the UI name it 'racimo' in Spanish, and समूह in Hindi, and not 'Cluster', you have a point on REST though.
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
You only re-enforcing my argument :) MigrationDomain fits better than Cluster.
Thanks, Oved
Thanks, Gilad.
[1] http://www.webopedia.com/TERM/D/domain_migration.html [2] http://en.wikipedia.org/wiki/Cluster
Vds => Host
I would prefer DataCenter instead of DC for class name.
But +1 for starting the process.
+1 for DataCenter (and other proposed names)
Once this is done - each maintainer/reviewer should start enforcing that policy in his reviews.
I don't think this task should have specific task force allocated for that.
As a guide line - Those patches (rename patches) should be separated from the logic change (on top of the name change patches).
Thanks Barak Azulay
> > > > > > The only place in which I encourage new names are application > > > log/audit > > > messages > > > > > > > > > > > Yair > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On 05/27/2014 06:44 AM, Gilad Chaplik wrote:
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 11:37:23 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Barak Azulay" <bazulay@redhat.com> > To: "Eli Mesika" <emesika@redhat.com> > Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org > Sent: Sunday, May 18, 2014 8:42:47 PM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- >> From: "Eli Mesika" <emesika@redhat.com> >> To: "Moti Asayag" <masayag@redhat.com> >> Cc: devel@ovirt.org >> Sent: Sunday, May 18, 2014 4:08:45 PM >> Subject: Re: [ovirt-devel] Entity names in DB scripts >> >> >> >> ----- Original Message ----- >>> From: "Moti Asayag" <masayag@redhat.com> >>> To: "Eli Mesika" <emesika@redhat.com> >>> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org >>> Sent: Thursday, May 15, 2014 7:33:06 PM >>> Subject: Re: [ovirt-devel] Entity names in DB scripts >>> >>> >>> >>> ----- Original Message ----- >>>> From: "Eli Mesika" <emesika@redhat.com> >>>> To: "Yair Zaslavsky" <yzaslavs@redhat.com> >>>> Cc: devel@ovirt.org >>>> Sent: Thursday, May 15, 2014 4:56:50 PM >>>> Subject: Re: [ovirt-devel] Entity names in DB scripts >>>> >>>> >>>> >>>> ----- Original Message ----- >>>>> From: "Yair Zaslavsky" <yzaslavs@redhat.com> >>>>> To: devel@ovirt.org >>>>> Sent: Thursday, May 15, 2014 3:20:18 PM >>>>> Subject: [ovirt-devel] Entity names in DB scripts >>>>> >>>>> Hi all, >>>>> I have a feeling there is some inconsistency in using >>>>> entity >>>>> names >>>>> in >>>>> the >>>>> DB >>>>> scripts. >>>>> For example, should we use Host or VDS? >>>>> I am not talking about existing tables or columns but about >>>>> new >>>>> ones >>>>> (and >>>>> new >>>>> stored procedures). >>>>> >>>>> I am quite sure I saw patches containing both approaches. >>> >>> I guess that includes any recent patches around the network >>> area. >>> >>>> >>>> You are right >>>> I think old should be kept until we have the time to do a >>>> global >>>> find/replace >>>> of all old names. >>> >>> Without enabling the "new" (or more appropriate) naming to new >>> code >>> we: >>> 1. Increase the amount of 'old' code in the system (gaining >>> more >>> debts) >>> 2. As a result - more work when and if global change will take >>> affect. >>> 3. Double the entire work flow: code + review. >>> >>> That change should start at some point, and having it >>> incrementally >>> is >>> a >>> valid approach >>> to achieve that goal. >> >> I basically agree, but first someone (that can say that) should >> say >> that >> we >> are going to do that and allocate resources to this tasks , >> unless >> , >> you >> are >> left in hybrid ugly condition > > > > Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
I think the UI name it 'racimo' in Spanish, and समूह in Hindi, and not 'Cluster', you have a point on REST though.
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
You only re-enforcing my argument :) MigrationDomain fits better than Cluster.
not when we are considering more granular migration domains inside clusters in the future as the scheduler gets more sophisticated. a cluster is a group of hosts providing a set of services. so far it was a migration domain. it may not be in the future.
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com>, "Oved Ourfalli" <ovedo@redhat.com> Cc: devel@ovirt.org Sent: Thursday, June 12, 2014 11:19:42 AM Subject: Re: [ovirt-devel] Entity names in DB scripts
On 05/27/2014 06:44 AM, Gilad Chaplik wrote:
----- Original Message -----
From: "Oved Ourfalli" <ovedo@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org Sent: Tuesday, May 27, 2014 1:30:43 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 1:27:10 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 26, 2014 12:39:17 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: devel@ovirt.org Sent: Monday, May 19, 2014 12:43:32 PM Subject: Re: [ovirt-devel] Entity names in DB scripts
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "Barak Azulay" <bazulay@redhat.com> > Cc: devel@ovirt.org > Sent: Monday, May 19, 2014 11:37:23 AM > Subject: Re: [ovirt-devel] Entity names in DB scripts > > > > ----- Original Message ----- >> From: "Barak Azulay" <bazulay@redhat.com> >> To: "Eli Mesika" <emesika@redhat.com> >> Cc: "Moti Asayag" <masayag@redhat.com>, devel@ovirt.org >> Sent: Sunday, May 18, 2014 8:42:47 PM >> Subject: Re: [ovirt-devel] Entity names in DB scripts >> >> >> >> ----- Original Message ----- >>> From: "Eli Mesika" <emesika@redhat.com> >>> To: "Moti Asayag" <masayag@redhat.com> >>> Cc: devel@ovirt.org >>> Sent: Sunday, May 18, 2014 4:08:45 PM >>> Subject: Re: [ovirt-devel] Entity names in DB scripts >>> >>> >>> >>> ----- Original Message ----- >>>> From: "Moti Asayag" <masayag@redhat.com> >>>> To: "Eli Mesika" <emesika@redhat.com> >>>> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, devel@ovirt.org >>>> Sent: Thursday, May 15, 2014 7:33:06 PM >>>> Subject: Re: [ovirt-devel] Entity names in DB scripts >>>> >>>> >>>> >>>> ----- Original Message ----- >>>>> From: "Eli Mesika" <emesika@redhat.com> >>>>> To: "Yair Zaslavsky" <yzaslavs@redhat.com> >>>>> Cc: devel@ovirt.org >>>>> Sent: Thursday, May 15, 2014 4:56:50 PM >>>>> Subject: Re: [ovirt-devel] Entity names in DB scripts >>>>> >>>>> >>>>> >>>>> ----- Original Message ----- >>>>>> From: "Yair Zaslavsky" <yzaslavs@redhat.com> >>>>>> To: devel@ovirt.org >>>>>> Sent: Thursday, May 15, 2014 3:20:18 PM >>>>>> Subject: [ovirt-devel] Entity names in DB scripts >>>>>> >>>>>> Hi all, >>>>>> I have a feeling there is some inconsistency in using >>>>>> entity >>>>>> names >>>>>> in >>>>>> the >>>>>> DB >>>>>> scripts. >>>>>> For example, should we use Host or VDS? >>>>>> I am not talking about existing tables or columns but about >>>>>> new >>>>>> ones >>>>>> (and >>>>>> new >>>>>> stored procedures). >>>>>> >>>>>> I am quite sure I saw patches containing both approaches. >>>> >>>> I guess that includes any recent patches around the network >>>> area. >>>> >>>>> >>>>> You are right >>>>> I think old should be kept until we have the time to do a >>>>> global >>>>> find/replace >>>>> of all old names. >>>> >>>> Without enabling the "new" (or more appropriate) naming to new >>>> code >>>> we: >>>> 1. Increase the amount of 'old' code in the system (gaining >>>> more >>>> debts) >>>> 2. As a result - more work when and if global change will take >>>> affect. >>>> 3. Double the entire work flow: code + review. >>>> >>>> That change should start at some point, and having it >>>> incrementally >>>> is >>>> a >>>> valid approach >>>> to achieve that goal. >>> >>> I basically agree, but first someone (that can say that) should >>> say >>> that >>> we >>> are going to do that and allocate resources to this tasks , >>> unless >>> , >>> you >>> are >>> left in hybrid ugly condition >> >> >> >> Guys please post the list of Entities and let's agree on new names. > > Top 3 : > > StoragePool => DC > VdsGroup => Cluster
IMO VdsGroup should be named MigrationDomain[1]. cluster is too general[2].
IMHO we should name it Cluster, just like it is in the UI.
I think the UI name it 'racimo' in Spanish, and समूह in Hindi, and not 'Cluster', you have a point on REST though.
I wouldn't change it into MigrationDomain. Moreover, in some cases VMs might not be able to migrate to all the hosts in the cluster, depending on your configuration, so it isn't even true at all times.
You only re-enforcing my argument :) MigrationDomain fits better than Cluster.
not when we are considering more granular migration domains inside clusters in the future as the scheduler gets more sophisticated. a cluster is a group of hosts providing a set of services. so far it was a migration domain. it may not be in the future.
How do you understand by the word 'cluster' that cluster is a group of hosts providing a set of services? As for granular migration domains, you can take an example from groups of users, there are also groups of groups; they're still called groups, I think it's pretty understandable. by introducing 'migration domain' for granularity your simply maintaining the virtual 'datacenter' notion, but lowering down its level (s/data center -> clusters/cluster-> migration domains/g), so the complexity sticks, and the recursion may break some when in the future: clusters/cluster-> migration domains -> ??? -> ???. anyway Eli ACKed cluster, so I rested my case anyway (a while ago).
Am 19.05.2014 11:37, schrieb Eli Mesika:
Top 3 :
StoragePool => DC VdsGroup => Cluster Vds => Host
Please don't use "Host" for anything, because it is used today for _everything_ making it very complicated to sort out who means what when talking about a "host" Examples: "the host went down and no vms worked" was it the "host" which runs the vms or the "host" which runs the engine or the "host" which runs the software defined network? I'd stick with "computenode" for "vm hosts" It's at least more precise. a host could be anything, but ymmv :) -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
On 05/19/2014 12:37 PM, Eli Mesika wrote: ...
Guys please post the list of Entities and let's agree on new names.
Top 3 :
StoragePool => DC
well, except when its really the Storage Pool and not the DC? so this one needs to be reviewed for correctness/refactoring during the rename.
VdsGroup => Cluster Vds => Host
participants (10)
-
Barak Azulay -
Eli Mesika -
Gilad Chaplik -
Itamar Heim -
Martin Perina -
Moti Asayag -
Omer Frenkel -
Oved Ourfalli -
Sven Kieske -
Yair Zaslavsky