Master ovirt-engine build broken
Hi, I see failing tests regarding to missing translations (e.g. [1]). [...] Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..) [...] Best Regards, Roman [1] http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way ----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1] http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
I wonder, how come the CI didn't catch that? On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Roman Mohr" <rmohr@redhat.com>, "devel" <devel@ovirt.org>, "Scott Dickerson" <sdickers@redhat.com> Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
right, and we can't enable lang permutation since it takes a very long time to run. On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Roman Mohr" <rmohr@redhat.com>, "devel" <devel@ovirt.org>, "Scott Dickerson" <sdickers@redhat.com> Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com>
wrote:
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
Roman - did you build the langs in order to find the issue? Eyal - can we monitor a list of files that i changed will result in also building all the languages? On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <eedri@redhat.com> wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Roman Mohr" <rmohr@redhat.com>, "devel" <devel@ovirt.org>, "Scott Dickerson" <sdickers@redhat.com> Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com>
wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <oourfali@redhat.com> wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error. Looking at https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+... two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <eedri@redhat.com> wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Roman Mohr" <rmohr@redhat.com>, "devel" <devel@ovirt.org>, "Scott Dickerson" <sdickers@redhat.com> Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com>
wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
------=_Part_25044383_789341931.1462354195750 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The fix is here: https://gerrit.ovirt.org/#/c/57007/ ----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com >
To: "Tomas Jelinek" < tjelinek@redhat.com >
Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com >
Sent: Wednesday, May 4, 2016 9:55:40 AM
Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com
wrote:
hmmm,
regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message -----
> From: "Roman Mohr" < rmohr@redhat.com >
> To: "devel" < devel@ovirt.org >
> Sent: Wednesday, May 4, 2016 9:34:53 AM
> Subject: [ovirt-devel] Master ovirt-engine build broken
>
> Hi,
>
> I see failing tests regarding to missing translations (e.g. [1]).
>
> [...]
>
> Failed tests: > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> cpuInfoLabel does not match the number of parameters in
> UIMessages_zh_CN.properties(..)
>
> [...]
>
> Best Regards,
>
> Roman
>
> [1]
>
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
>
> _______________________________________________
> Devel mailing list
> Devel@ovirt.org
_______________________________________________
Devel mailing list
Devel@ovirt.org
_______________________________________________
Devel mailing list
Devel@ovirt.org
--
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________
Devel mailing list
Devel@ovirt.org
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ------=_Part_25044383_789341931.1462354195750 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
<html><body><div style=3D"font-family: times new roman, new york, times, se= rif; font-size: 12pt; color: #000000"><div>The fix is here: https://gerrit.= ovirt.org/#/c/57007/<br></div><div><br></div><hr id=3D"zwchr"><blockquote s= tyle=3D"border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;colo= r:#000;font-weight:normal;font-style:normal;text-decoration:none;font-famil= y:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style=3D"border-left= : 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font= -weight: normal; font-style: normal; text-decoration: none; font-family: He= lvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Roman Mohr" <r= mohr@redhat.com><br><b>To: </b>"Oved Ourfali" <oourfali@redhat.com>= ;<br><b>Cc: </b>"devel" <devel@ovirt.org><br><b>Sent: </b>Wednesday, = May 4, 2016 10:27:51 AM<br><b>Subject: </b>Re: [ovirt-devel] Master ovirt-e= ngine build broken<br><div><br></div><div dir=3D"ltr"><br><div class=3D"gma= il_extra"><br><div class=3D"gmail_quote">On Wed, May 4, 2016 at 10:24 AM, O= ved Ourfali <span dir=3D"ltr"><<a href=3D"mailto:oourfali@redhat.com" ta= rget=3D"_blank" data-mce-href=3D"mailto:oourfali@redhat.com">oourfali@redha= t.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"m= argin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204= ,204);border-left-style:solid;padding-left:1ex" data-mce-style=3D"margin: 0= px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; borde= r-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr">Roman - did you b= uild the langs in order to find the issue?</div></blockquote><div><div><br>= </div><div>I just ran 'mvn clean verify', so I saw it on my machine. = On gerrit not all of my builds showed that error.</div><div><br></div><div>= Looking at</div><div><br></div><div> <a href=3D"https://gerrit= .ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integra= tion" target=3D"_blank" data-mce-href=3D"https://gerrit.ovirt.org/#/q/statu= s:open+project:ovirt-engine+branch:master+topic:integration">https://gerrit= .ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integra= tion</a><br data-mce-bogus=3D"1"></div><div><br></div><div>two patches pass= ed and two failed after a topic rebase.</div></div><div> </div><= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;pa= dding-left:1ex" data-mce-style=3D"margin: 0px 0px 0px 0.8ex; border-left-wi= dth: 1px; border-left-color: #cccccc; border-left-style: solid; padding-lef= t: 1ex;"><div dir=3D"ltr"><div>Eyal - can we monitor a list of files that i= changed will result in also building all the languages?</div><div><br></di= v></div></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px = 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);bord= er-left-style:solid;padding-left:1ex" data-mce-style=3D"margin: 0px 0px 0px= 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-sty= le: solid; padding-left: 1ex;"><div dir=3D"ltr"><div><br></div></div><div c= lass=3D""><div class=3D"h5"><div class=3D"gmail_extra"><br><div class=3D"gm= ail_quote">On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <span dir=3D"ltr"><= ;<a href=3D"mailto:eedri@redhat.com" target=3D"_blank" data-mce-href=3D"mai= lto:eedri@redhat.com">eedri@redhat.com</a>></span> wrote:<br><blockquote= class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:= 1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left= :1ex" data-mce-style=3D"margin: 0px 0px 0px 0.8ex; border-left-width: 1px; = border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;"><= div dir=3D"ltr">right, and we can't enable lang permutation since it takes = a very long time to run.</div><div class=3D"gmail_extra"><div><div><br><div= class=3D"gmail_quote">On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <span= dir=3D"ltr"><<a href=3D"mailto:tjelinek@redhat.com" target=3D"_blank" d= ata-mce-href=3D"mailto:tjelinek@redhat.com">tjelinek@redhat.com</a>></sp= an> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px= 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left= -style:solid;padding-left:1ex" data-mce-style=3D"margin: 0px 0px 0px 0.8ex;= border-left-width: 1px; border-left-color: #cccccc; border-left-style: sol= id; padding-left: 1ex;"><span><br> <br> ----- Original Message -----<br> &g= t; From: "Oved Ourfali" <<a href=3D"mailto:oourfali@redhat.com" target= =3D"_blank" data-mce-href=3D"mailto:oourfali@redhat.com">oourfali@redhat.co= m</a>><br> > To: "Tomas Jelinek" <<a href=3D"mailto:tjelinek@redha= t.com" target=3D"_blank" data-mce-href=3D"mailto:tjelinek@redhat.com">tjeli= nek@redhat.com</a>><br> > Cc: "Roman Mohr" <<a href=3D"mailto:rmoh= r@redhat.com" target=3D"_blank" data-mce-href=3D"mailto:rmohr@redhat.com">r= mohr@redhat.com</a>>, "devel" <<a href=3D"mailto:devel@ovirt.org" tar= get=3D"_blank" data-mce-href=3D"mailto:devel@ovirt.org">devel@ovirt.org</a>= >, "Scott Dickerson" <<a href=3D"mailto:sdickers@redhat.com" target= =3D"_blank" data-mce-href=3D"mailto:sdickers@redhat.com">sdickers@redhat.co= m</a>><br> > Sent: Wednesday, May 4, 2016 9:55:40 AM<br> > Subject= : Re: [ovirt-devel] Master ovirt-engine build broken<br> ><br> > I wo= nder, how come the CI didn't catch that?<br> <br> </span>because this happe= ns only when you compile with language permutations<br><div><div><br> ><= br> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <<a href=3D"mail= to:tjelinek@redhat.com" target=3D"_blank" data-mce-href=3D"mailto:tjelinek@= redhat.com">tjelinek@redhat.com</a>> wrote:<br> ><br> > > hmmm,= <br> > > regression introduced yesterday by <a href=3D"https://gerrit= .ovirt.org/#/c/56720/" rel=3D"noreferrer" target=3D"_blank" data-mce-href= =3D"https://gerrit.ovirt.org/#/c/56720/">https://gerrit.ovirt.org/#/c/56720= /</a><br> > > fix on the way<br> > ><br> > > ----- Origin= al Message -----<br> > > > From: "Roman Mohr" <<a href=3D"mailt= o:rmohr@redhat.com" target=3D"_blank" data-mce-href=3D"mailto:rmohr@redhat.= com">rmohr@redhat.com</a>><br> > > > To: "devel" <<a href=3D= "mailto:devel@ovirt.org" target=3D"_blank" data-mce-href=3D"mailto:devel@ov= irt.org">devel@ovirt.org</a>><br> > > > Sent: Wednesday, May 4,= 2016 9:34:53 AM<br> > > > Subject: [ovirt-devel] Master ovirt-eng= ine build broken<br> > > ><br> > > > Hi,<br> > > &g= t;<br> > > > I see failing tests regarding to missing translations= (e.g. [1]).<br> > > ><br> > > > [...]<br> > > >= <br> > > > Failed tests: doTest(org.ovirt.engine.ui.ui= compat.UIMessagesTest):<br> > > > cpuInfoLabel does not match the = number of parameters in<br> > > > UIMessages_zh_CN.properties(..)<= br> > > ><br> > > > [...]<br> > > ><br> > >= ; > Best Regards,<br> > > ><br> > > > Roman<br> > &= gt; ><br> > > > [1]<br> > > ><br> > > <a href=3D= "http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4= 07/console" rel=3D"noreferrer" target=3D"_blank" data-mce-href=3D"http://je= nkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console= ">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/= 407/console</a><br> > > ><br> > > > _____________________= __________________________<br> > > > Devel mailing list<br> > &= gt; > <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" data-mce-href= =3D"mailto:Devel@ovirt.org">Devel@ovirt.org</a><br> > > > <a href= =3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" targe= t=3D"_blank" data-mce-href=3D"http://lists.ovirt.org/mailman/listinfo/devel= ">http://lists.ovirt.org/mailman/listinfo/devel</a><br> > > _________= ______________________________________<br> > > Devel mailing list<br>= > > <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" data-mce-hr= ef=3D"mailto:Devel@ovirt.org">Devel@ovirt.org</a><br> > > <a href=3D"= http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" target=3D= "_blank" data-mce-href=3D"http://lists.ovirt.org/mailman/listinfo/devel">ht= tp://lists.ovirt.org/mailman/listinfo/devel</a><br> > ><br> > >= <br> > ><br> ><br> _______________________________________________= <br> Devel mailing list<br> <a href=3D"mailto:Devel@ovirt.org" target=3D"_b= lank" data-mce-href=3D"mailto:Devel@ovirt.org">Devel@ovirt.org</a><br> <a h= ref=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" ta= rget=3D"_blank" data-mce-href=3D"http://lists.ovirt.org/mailman/listinfo/de= vel">http://lists.ovirt.org/mailman/listinfo/devel</a><br> <br> <br></div><= /div></blockquote></div><br><br clear=3D"all"><div><br></div></div></div><s= pan><span><span style=3D"color: #888888;" data-mce-style=3D"color: #888888;= " color=3D"#888888">-- <br></span></span></span><div><div dir=3D"ltr"><div>= <div dir=3D"ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<= br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><div><br></div>phon= e: <a href=3D"tel:%2B972-9-7692018" target=3D"_blank" data-mce-href=3D"tel:= %2B972-9-7692018">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev= -integ)</div></div></div></div></div></div></blockquote></div><br></div></d= iv></div><br>_______________________________________________<br> Devel mail= ing list<br> <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" data-mce-= href=3D"mailto:Devel@ovirt.org">Devel@ovirt.org</a><br> <a href=3D"http://l= ists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" target=3D"_blank"= data-mce-href=3D"http://lists.ovirt.org/mailman/listinfo/devel">http://lis= ts.ovirt.org/mailman/listinfo/devel</a><br></blockquote></div><br></div></d= iv><br>_______________________________________________<br>Devel mailing lis= t<br>Devel@ovirt.org<br>http://lists.ovirt.org/mailman/listinfo/devel</bloc= kquote><div><br></div></div></body></html> ------=_Part_25044383_789341931.1462354195750--
------=_Part_25116957_1425524505.1462357878257 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit There are issues on other keys as well. I'm rebuilding for all locales locally now. ----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com>
To: "Oved Ourfali" <oourfali@redhat.com>
Cc: "devel" <devel@ovirt.org>
Sent: Wednesday, May 4, 2016 10:27:51 AM
Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com >
To: "Tomas Jelinek" < tjelinek@redhat.com >
Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com >
Sent: Wednesday, May 4, 2016 9:55:40 AM
Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
> hmmm,
> regression introduced yesterday by > https://gerrit.ovirt.org/#/c/56720/
> fix on the way
>
> ----- Original Message -----
> > From: "Roman Mohr" < rmohr@redhat.com >
> > To: "devel" < devel@ovirt.org >
> > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > Subject: [ovirt-devel] Master ovirt-engine build broken
> >
> > Hi,
> >
> > I see failing tests regarding to missing translations (e.g. > > [1]).
> >
> > [...]
> >
> > Failed tests: > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > cpuInfoLabel does not match the number of parameters in
> > UIMessages_zh_CN.properties(..)
> >
> > [...]
> >
> > Best Regards,
> >
> > Roman
> >
> > [1]
> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> >
> > _______________________________________________
> > Devel mailing list
> > Devel@ovirt.org
> _______________________________________________
> Devel mailing list
> Devel@ovirt.org
>
>
>
_______________________________________________
Devel mailing list
Devel@ovirt.org
--
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R&D
Red Hat Israel
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________
Devel mailing list
Devel@ovirt.org
_______________________________________________
Devel mailing list
Devel@ovirt.org
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ------=_Part_25116957_1425524505.1462357878257 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
>, "Scott Dickerson" <<a href=3D"mailto:sdickers@redhat.com" target= =3D"_blank">sdickers@redhat.com</a>><br> > Sent: Wednesday, May 4, 20= 16 9:55:40 AM<br> > Subject: Re: [ovirt-devel] Master ovirt-engine build= broken<br> ><br> > I wonder, how come the CI didn't catch that?<br> = <br> </span>because this happens only when you compile with language permut= ations<br><div><div><br> ><br> > On Wed, May 4, 2016 at 10:44 AM, Tom= as Jelinek <<a href=3D"mailto:tjelinek@redhat.com" target=3D"_blank">tje=
Devel@ovirt.org</a><br> > > <a href=3D"http://lists.ovirt.org/mailma= n/listinfo/devel" rel=3D"noreferrer" target=3D"_blank">http://lists.ovirt.o= rg/mailman/listinfo/devel</a><br> > ><br> > ><br> > ><br>= ><br> _______________________________________________<br> Devel mailing=
Devel mailing list<br> <a href=3D"mailto:Devel@ovirt.org" target=3D"_blan= k">Devel@ovirt.org</a><br> <a href=3D"http://lists.ovirt.org/mailman/listin= fo/devel" rel=3D"noreferrer" target=3D"_blank">http://lists.ovirt.org/mailm= an/listinfo/devel</a><br></blockquote></div><br></div></div><br>___________= ____________________________________<br>Devel mailing list<br>Devel@ovirt.o= rg<br>http://lists.ovirt.org/mailman/listinfo/devel</blockquote><div><br></=
<html><body><div style=3D"font-family: times new roman, new york, times, se= rif; font-size: 12pt; color: #000000"><div>There are issues on other keys a= s well.</div><div>I'm rebuilding for all locales locally now. <br></div><di= v><br></div><div><br></div><hr id=3D"zwchr"><blockquote style=3D"border-lef= t:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight= :normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,= sans-serif;font-size:12pt;"><b>From: </b>"Marek Libra" <mlibra@redhat.co= m><br><b>To: </b>"devel" <devel@ovirt.org><br><b>Sent: </b>Wednesd= ay, May 4, 2016 11:29:55 AM<br><b>Subject: </b>Re: [ovirt-devel] Master ovi= rt-engine build broken<br><div><br></div><div style=3D"font-family: times n= ew roman, new york, times, serif; font-size: 12pt; color: #000000"><div>The= fix is here: https://gerrit.ovirt.org/#/c/57007/<br></div><div><br></div><= hr id=3D"zwchr"><blockquote style=3D"border-left:2px solid #1010FF;margin-l= eft:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;te= xt-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;">= <b>From: </b>"Roman Mohr" <rmohr@redhat.com><br><b>To: </b>"Oved Ourf= ali" <oourfali@redhat.com><br><b>Cc: </b>"devel" <devel@ovirt.org&= gt;<br><b>Sent: </b>Wednesday, May 4, 2016 10:27:51 AM<br><b>Subject: </b>R= e: [ovirt-devel] Master ovirt-engine build broken<br><div><br></div><div di= r=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On = Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <span dir=3D"ltr"><<a href=3D= "mailto:oourfali@redhat.com" target=3D"_blank">oourfali@redhat.com</a>><= /span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px = 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-l= eft-style:solid;padding-left:1ex"><div dir=3D"ltr">Roman - did you build th= e langs in order to find the issue?</div></blockquote><div><div><br></div><= div>I just ran 'mvn clean verify', so I saw it on my machine. On gerr= it not all of my builds showed that error.</div><div><br></div><div>Looking= at</div><div><br></div><div> <a href=3D"https://gerrit.ovirt.= org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration" t= arget=3D"_blank">https://gerrit.ovirt.org/#/q/status:open+project:ovirt-eng= ine+branch:master+topic:integration</a><br></div><div><br></div><div>two pa= tches passed and two failed after a topic rebase.</div></div><div>&nb= sp;</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-styl= e:solid;padding-left:1ex"><div dir=3D"ltr"><div>Eyal - can we monitor a lis= t of files that i changed will result in also building all the languages?</= div><div><br></div></div></blockquote><blockquote class=3D"gmail_quote" sty= le=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(= 204,204,204);border-left-style:solid;padding-left:1ex"><div dir=3D"ltr"><di= v><br></div></div><div class=3D""><div class=3D"h5"><div class=3D"gmail_ext= ra"><br><div class=3D"gmail_quote">On Wed, May 4, 2016 at 11:22 AM, Eyal Ed= ri <span dir=3D"ltr"><<a href=3D"mailto:eedri@redhat.com" target=3D"_bla= nk">eedri@redhat.com</a>></span> wrote:<br><blockquote class=3D"gmail_qu= ote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-co= lor:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir=3D"= ltr">right, and we can't enable lang permutation since it takes a very long= time to run.</div><div class=3D"gmail_extra"><div><div><br><div class=3D"g= mail_quote">On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <span dir=3D"ltr= "><<a href=3D"mailto:tjelinek@redhat.com" target=3D"_blank">tjelinek@red= hat.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D= "margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,2= 04,204);border-left-style:solid;padding-left:1ex"><span><br> <br> ----- Ori= ginal Message -----<br> > From: "Oved Ourfali" <<a href=3D"mailto:oou= rfali@redhat.com" target=3D"_blank">oourfali@redhat.com</a>><br> > To= : "Tomas Jelinek" <<a href=3D"mailto:tjelinek@redhat.com" target=3D"_bla= nk">tjelinek@redhat.com</a>><br> > Cc: "Roman Mohr" <<a href=3D"ma= ilto:rmohr@redhat.com" target=3D"_blank">rmohr@redhat.com</a>>, "devel" = <<a href=3D"mailto:devel@ovirt.org" target=3D"_blank">devel@ovirt.org</a= linek@redhat.com</a>> wrote:<br> ><br> > > hmmm,<br> > > = regression introduced yesterday by <a href=3D"https://gerrit.ovirt.org/#/c/= 56720/" rel=3D"noreferrer" target=3D"_blank">https://gerrit.ovirt.org/#/c/5= 6720/</a><br> > > fix on the way<br> > ><br> > > ----- Or= iginal Message -----<br> > > > From: "Roman Mohr" <<a href=3D"m= ailto:rmohr@redhat.com" target=3D"_blank">rmohr@redhat.com</a>><br> >= > > To: "devel" <<a href=3D"mailto:devel@ovirt.org" target=3D"_bl= ank">devel@ovirt.org</a>><br> > > > Sent: Wednesday, May 4, 201= 6 9:34:53 AM<br> > > > Subject: [ovirt-devel] Master ovirt-engine = build broken<br> > > ><br> > > > Hi,<br> > > ><b= r> > > > I see failing tests regarding to missing translations (e.= g. [1]).<br> > > ><br> > > > [...]<br> > > ><br>= > > > Failed tests: doTest(org.ovirt.engine.ui.uicomp= at.UIMessagesTest):<br> > > > cpuInfoLabel does not match the numb= er of parameters in<br> > > > UIMessages_zh_CN.properties(..)<br> = > > ><br> > > > [...]<br> > > ><br> > > &g= t; Best Regards,<br> > > ><br> > > > Roman<br> > > = ><br> > > > [1]<br> > > ><br> > > <a href=3D"htt= p://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/c= onsole" rel=3D"noreferrer" target=3D"_blank">http://jenkins.ovirt.org/job/o= virt-engine_master_check-patch-fc23-x86_64/407/console</a><br> > > &g= t;<br> > > > _______________________________________________<br> &= gt; > > Devel mailing list<br> > > > <a href=3D"mailto:Devel= @ovirt.org" target=3D"_blank">Devel@ovirt.org</a><br> > > > <a hre= f=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" targ= et=3D"_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br> > &g= t; _______________________________________________<br> > > Devel mail= ing list<br> > > <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank"= list<br> <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank">Devel@ovirt.= org</a><br> <a href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel= =3D"noreferrer" target=3D"_blank">http://lists.ovirt.org/mailman/listinfo/d= evel</a><br> <br> <br></div></div></blockquote></div><br><br clear=3D"all">= <div><br></div></div></div><span><span><span style=3D"color: #888888;">-- <= br></span></span></span><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div>Ey= al Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualizati= on R&D<br>Red Hat Israel<br><div><br></div>phone: <a href=3D"tel:%2B972= -9-7692018" target=3D"_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rh= ev-dev #rhev-integ)</div></div></div></div></div></div></blockquote></div><= br></div></div></div><br>_______________________________________________<br= div></div><br>_______________________________________________<br>Devel mail= ing list<br>Devel@ovirt.org<br>http://lists.ovirt.org/mailman/listinfo/deve= l</blockquote><div><br></div></div></body></html> ------=_Part_25116957_1425524505.1462357878257--
Got it also, different error : Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): unreachableGlusterHosts does not match the number of parameters in UIMessages_pt_BR.properties On Wed, May 4, 2016 at 1:31 PM, Marek Libra <mlibra@redhat.com> wrote:
There are issues on other keys as well. I'm rebuilding for all locales locally now.
------------------------------
*From: *"Marek Libra" <mlibra@redhat.com> *To: *"devel" <devel@ovirt.org> *Sent: *Wednesday, May 4, 2016 11:29:55 AM
*Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
------------------------------
*From: *"Roman Mohr" <rmohr@redhat.com> *To: *"Oved Ourfali" <oourfali@redhat.com> *Cc: *"devel" <devel@ovirt.org> *Sent: *Wednesday, May 4, 2016 10:27:51 AM *Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <oourfali@redhat.com> wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <eedri@redhat.com> wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Roman Mohr" <rmohr@redhat.com>, "devel" <devel@ovirt.org>, "Scott Dickerson" <sdickers@redhat.com> Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek@redhat.com>
wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message ----- > From: "Roman Mohr" <rmohr@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 9:34:53 AM > Subject: [ovirt-devel] Master ovirt-engine build broken > > Hi, > > I see failing tests regarding to missing translations (e.g. [1]). > > [...] > > Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > cpuInfoLabel does not match the number of parameters in > UIMessages_zh_CN.properties(..) > > [...] > > Best Regards, > > Roman > > [1] >
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
(top-posting) Hi, root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code. For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders. 4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code. I suggest to simply revert the offending patch: translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/ and create new one which doesn't introduce conflicts. We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation). I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below. Regards, Vojtech ----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way
----- Original Message -----
From: "Roman Mohr" < rmohr@redhat.com > To: "devel" < devel@ovirt.org > Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Okay. Makes sense. Thanks Vojtech - please also revert this one. Oved On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long
time
to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message -----
From: "Roman Mohr" < rmohr@redhat.com > To: "devel" < devel@ovirt.org > Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something? Perhaps oVirt gerrit maintainers can advise here? (adding David)
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long
time
to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message -----
From: "Roman Mohr" < rmohr@redhat.com > To: "devel" < devel@ovirt.org > Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert: https://gerrit.ovirt.org/#/c/57031/ Can someone please ack?
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long
time
to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com
wrote:
hmmm, regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
fix on the way
----- Original Message ----- > From: "Roman Mohr" < rmohr@redhat.com > > To: "devel" < devel@ovirt.org > > Sent: Wednesday, May 4, 2016 9:34:53 AM > Subject: [ovirt-devel] Master ovirt-engine build broken > > Hi, > > I see failing tests regarding to missing translations (e.g. [1]). > > [...] > > Failed tests: > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > cpuInfoLabel does not match the number of parameters in > UIMessages_zh_CN.properties(..) > > [...] > > Best Regards, > > Roman > > [1] >
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Wed, May 4, 2016 at 3:24 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" < dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert:
https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
done.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com>
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On
gerrit not all
of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com >
wrote:
right, and we can't enable lang permutation since it takes a very
long time
to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org , "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language
wrote: permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <
tjelinek@redhat.com
> wrote:
> hmmm, > regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ > fix on the way > > ----- Original Message ----- > > From: "Roman Mohr" < rmohr@redhat.com > > > To: "devel" < devel@ovirt.org > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > Hi, > > > > I see failing tests regarding to missing translations (e.g. [1]). > > > > [...] > > > > Failed tests: > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > cpuInfoLabel does not match the number of parameters in > > UIMessages_zh_CN.properties(..) > > > > [...] > > > > Best Regards, > > > > Roman > > > > [1] > > >
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert:
https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourfali@redhat.com > wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result in also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long
time
to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com
wrote:
----- Original Message -----
From: "Oved Ourfali" < oourfali@redhat.com > To: "Tomas Jelinek" < tjelinek@redhat.com > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott Dickerson" < sdickers@redhat.com > Sent: Wednesday, May 4, 2016 9:55:40 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
I wonder, how come the CI didn't catch that?
because this happens only when you compile with language permutations
On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
> hmmm, > regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
> fix on the way > > ----- Original Message ----- > > From: "Roman Mohr" < rmohr@redhat.com > > > To: "devel" < devel@ovirt.org > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > Hi, > > > > I see failing tests regarding to missing translations (e.g. > > [1]). > > > > [...] > > > > Failed tests: > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > cpuInfoLabel does not match the number of parameters in > > UIMessages_zh_CN.properties(..) > > > > [...] > > > > Best Regards, > > > > Roman > > > > [1] > > > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407... > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ? The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there. e. On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert:
https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com>
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 12:31:18 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
There are issues on other keys as well. I'm rebuilding for all locales locally now.
From: "Marek Libra" <mlibra@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 11:29:55 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
The fix is here: https://gerrit.ovirt.org/#/c/57007/
From: "Roman Mohr" <rmohr@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 10:27:51 AM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
wrote:
Roman - did you build the langs in order to find the issue?
I just ran 'mvn clean verify', so I saw it on my machine. On
gerrit
not all of my builds showed that error.
Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
two patches passed and two failed after a topic rebase.
Eyal - can we monitor a list of files that i changed will result
in
also building all the languages?
On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > wrote:
right, and we can't enable lang permutation since it takes a very long time to run.
On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > wrote:
----- Original Message ----- > From: "Oved Ourfali" < oourfali@redhat.com > > To: "Tomas Jelinek" < tjelinek@redhat.com > > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott > Dickerson" < sdickers@redhat.com > > Sent: Wednesday, May 4, 2016 9:55:40 AM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > I wonder, how come the CI didn't catch that?
because this happens only when you compile with language
wrote: permutations
> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > tjelinek@redhat.com > > > wrote: > > > hmmm, > > regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
> > fix on the way > > > > ----- Original Message ----- > > > From: "Roman Mohr" < rmohr@redhat.com > > > > To: "devel" < devel@ovirt.org > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > Hi, > > > > > > I see failing tests regarding to missing translations (e.g. > > > [1]). > > > > > > [...] > > > > > > Failed tests: > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > cpuInfoLabel does not match the number of parameters in > > > UIMessages_zh_CN.properties(..) > > > > > > [...] > > > > > > Best Regards, > > > > > > Roman > > > > > > [1] > > > > >
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ?
The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there.
e.
Eyal, I wrote a unit test specifically to catch this particular issue without having to compile all the permutations. This is what failed the build, I don't understand why it wasn't run during CI.
On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert: https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com>
wrote:
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch: translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message -----
> From: "Marek Libra" <mlibra@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 12:31:18 PM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > There are issues on other keys as well. > I'm rebuilding for all locales locally now. > > > > > > From: "Marek Libra" <mlibra@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 11:29:55 AM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > The fix is here: https://gerrit.ovirt.org/#/c/57007/ > > > > > From: "Roman Mohr" <rmohr@redhat.com> > To: "Oved Ourfali" <oourfali@redhat.com> > Cc: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 10:27:51 AM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
wrote: > Roman - did you build the langs in order to find the issue? > > I just ran 'mvn clean verify', so I saw it on my machine. On
gerrit
> not
all
> of my builds showed that error. > > Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste r+topic:integration>
> two patches passed and two failed after a topic rebase. > > > > Eyal - can we monitor a list of files that i changed will result
in
> also > building all the languages? > > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > > wrote: > > > > right, and we can't enable lang permutation since it takes a > very > long
time
> to run. > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <
tjelinek@redhat.com
wrote: > ----- Original Message ----- > > > From: "Oved Ourfali" < oourfali@redhat.com > > > To: "Tomas Jelinek" < tjelinek@redhat.com > > > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" <
devel@ovirt.org >,
"Scott
> > Dickerson" < sdickers@redhat.com > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > I wonder, how come the CI didn't catch that? > > because this happens only when you compile with language
permutations
> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > tjelinek@redhat.com > > > > wrote: > > > hmmm, > > > regression introduced yesterday by
https://gerrit.ovirt.org/#/c/56720/
> > > fix on the way > > > > > > ----- Original Message ----- > > > > > > > From: "Roman Mohr" < rmohr@redhat.com > > > > > To: "devel" < devel@ovirt.org > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > Hi, > > > > > > > > I see failing tests regarding to missing translations > > > > (e.g. > > > > [1]). > > > > > > > > [...] > > > > > > > > Failed tests: > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > cpuInfoLabel does not match the number of parameters in > > > > UIMessages_zh_CN.properties(..) > > > > > > > > [...] > > > > > > > > Best Regards, > > > > > > > > Roman > > > > > > > > [1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4 07/console>
> > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > -- > Eyal Edri > Associate Manager > RHEV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <awels@redhat.com> wrote:
On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ?
The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there.
e.
Eyal,
I wrote a unit test specifically to catch this particular issue without having to compile all the permutations. This is what failed the build, I don't understand why it wasn't run during CI.
Does it run on specific code change/path/file? I can't check why unfortunately since the history is gone, but if you can reproduce the patch we can check.
On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert: https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com
wrote:
> (top-posting) > > Hi, > > root cause is wrong number of message parameters (placeholders) > in translated properties files, compared to message definitions > in Java code. > > For example, UIMessages#cpuInfoLabel method has 4 parameters, > but the corresponding message in `UIMessages_de_DE.properties` > only contains 3 placeholders. > > 4.0 String Freeze is May 25 so it's still OK to modify message > definitions in Java code. > > I suggest to simply revert the offending patch: > translations update from zanata ovirt-3.6 > https://gerrit.ovirt.org/#/c/56720/ > > and create new one which doesn't introduce conflicts. > > We have unit tests to detect these kinds of errors, this is > to ensure the build fails early on (before GWT compilation). > > I'm not sure why `check-patch` job for above mentioned patch > didn't report the problem, since UIMessagesTest should fail, > as Roman wrote below. > > Regards, > Vojtech > > > ----- Original Message ----- > > > From: "Marek Libra" <mlibra@redhat.com> > > To: "devel" <devel@ovirt.org> > > Sent: Wednesday, May 4, 2016 12:31:18 PM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > There are issues on other keys as well. > > I'm rebuilding for all locales locally now. > > > > > > > > > > > > From: "Marek Libra" <mlibra@redhat.com> > > To: "devel" <devel@ovirt.org> > > Sent: Wednesday, May 4, 2016 11:29:55 AM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/ > > > > > > > > > > From: "Roman Mohr" <rmohr@redhat.com> > > To: "Oved Ourfali" <oourfali@redhat.com> > > Cc: "devel" <devel@ovirt.org> > > Sent: Wednesday, May 4, 2016 10:27:51 AM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
> wrote: > > Roman - did you build the langs in order to find the issue? > > > > I just ran 'mvn clean verify', so I saw it on my machine. On
gerrit
> > not > > all > > > of my builds showed that error. > > > > Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste
r+topic:integration>
> > two patches passed and two failed after a topic rebase. > > > > > > > > Eyal - can we monitor a list of files that i changed will result
in
> > also > > building all the languages? > > > > > > > > > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > > > wrote: > > > > > > > > right, and we can't enable lang permutation since it takes a > > very > > long > > time > > > to run. > > > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <
tjelinek@redhat.com
> wrote: > > ----- Original Message ----- > > > > > From: "Oved Ourfali" < oourfali@redhat.com > > > > To: "Tomas Jelinek" < tjelinek@redhat.com > > > > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" <
devel@ovirt.org >,
> "Scott > > > > Dickerson" < sdickers@redhat.com > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > I wonder, how come the CI didn't catch that? > > > > because this happens only when you compile with language
permutations
> > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > > tjelinek@redhat.com > > > > > > wrote: > > > > hmmm, > > > > regression introduced yesterday by > > https://gerrit.ovirt.org/#/c/56720/ > > > > > fix on the way > > > > > > > > ----- Original Message ----- > > > > > > > > > From: "Roman Mohr" < rmohr@redhat.com > > > > > > To: "devel" < devel@ovirt.org > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > Hi, > > > > > > > > > > I see failing tests regarding to missing translations > > > > > (e.g. > > > > > [1]). > > > > > > > > > > [...] > > > > > > > > > > Failed tests: > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > > cpuInfoLabel does not match the number of parameters in > > > > > UIMessages_zh_CN.properties(..) > > > > > > > > > > [...] > > > > > > > > > > Best Regards, > > > > > > > > > > Roman > > > > > > > > > > [1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4
07/console>
> > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > -- > > Eyal Edri > > Associate Manager > > RHEV DevOps > > EMEA ENG Virtualization R&D > > Red Hat Israel > > > > phone: +972-9-7692018 > > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wednesday, May 04, 2016 03:48:27 PM Eyal Edri wrote:
On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <awels@redhat.com> wrote:
On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ?
The original patch didn't fail on unit tests (though I can't see info
since
the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like
to
monitor it and see if CI catch any issues there.
e.
Eyal,
I wrote a unit test specifically to catch this particular issue without having to compile all the permutations. This is what failed the build, I don't understand why it wasn't run during CI.
Does it run on specific code change/path/file? I can't check why unfortunately since the history is gone, but if you can reproduce the patch we can check.
Its a standard unit test that is run during the test suite.
On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
> From: "Oved Ourfali" <oourfali@redhat.com> > To: "Vojtech Szocs" <vszocs@redhat.com> > Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 2:07:19 PM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > Okay. > Makes sense. > Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert: https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
> Oved > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com
wrote:
> > (top-posting) > > > > Hi, > > > > root cause is wrong number of message parameters > > (placeholders) > > in translated properties files, compared to message > > definitions > > in Java code. > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters, > > but the corresponding message in `UIMessages_de_DE.properties` > > only contains 3 placeholders. > > > > 4.0 String Freeze is May 25 so it's still OK to modify message > > definitions in Java code. > > > > I suggest to simply revert the offending patch: > > translations update from zanata ovirt-3.6 > > https://gerrit.ovirt.org/#/c/56720/ > > > > and create new one which doesn't introduce conflicts. > > > > We have unit tests to detect these kinds of errors, this is > > to ensure the build fails early on (before GWT compilation). > > > > I'm not sure why `check-patch` job for above mentioned patch > > didn't report the problem, since UIMessagesTest should fail, > > as Roman wrote below. > > > > Regards, > > Vojtech > > > > > > ----- Original Message ----- > > > > > From: "Marek Libra" <mlibra@redhat.com> > > > To: "devel" <devel@ovirt.org> > > > Sent: Wednesday, May 4, 2016 12:31:18 PM > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > There are issues on other keys as well. > > > I'm rebuilding for all locales locally now. > > > > > > > > > > > > > > > > > > From: "Marek Libra" <mlibra@redhat.com> > > > To: "devel" <devel@ovirt.org> > > > Sent: Wednesday, May 4, 2016 11:29:55 AM > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/ > > > > > > > > > > > > > > > From: "Roman Mohr" <rmohr@redhat.com> > > > To: "Oved Ourfali" <oourfali@redhat.com> > > > Cc: "devel" <devel@ovirt.org> > > > Sent: Wednesday, May 4, 2016 10:27:51 AM > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
> > wrote: > > > Roman - did you build the langs in order to find the issue? > > > > > > I just ran 'mvn clean verify', so I saw it on my machine. On
gerrit
> > > not > > > > all > > > > > of my builds showed that error. > > > > > > Looking at
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste
r+topic:integration>
> > > two patches passed and two failed after a topic rebase. > > > > > > > > > > > > Eyal - can we monitor a list of files that i changed will
result
in
> > > also > > > building all the languages? > > > > > > > > > > > > > > > > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <
eedri@redhat.com >
> > > wrote: > > > > > > > > > > > > right, and we can't enable lang permutation since it takes a > > > very > > > long > > > > time > > > > > to run. > > > > > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <
tjelinek@redhat.com
> > wrote: > > > ----- Original Message ----- > > > > > > > From: "Oved Ourfali" < oourfali@redhat.com > > > > > To: "Tomas Jelinek" < tjelinek@redhat.com > > > > > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" <
devel@ovirt.org >,
> > "Scott > > > > > > Dickerson" < sdickers@redhat.com > > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build > > > > broken > > > > > > > > I wonder, how come the CI didn't catch that? > > > > > > because this happens only when you compile with language
permutations
> > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > > > tjelinek@redhat.com > > > > > > > > wrote: > > > > > hmmm, > > > > > regression introduced yesterday by > > > > https://gerrit.ovirt.org/#/c/56720/ > > > > > > > fix on the way > > > > > > > > > > ----- Original Message ----- > > > > > > > > > > > From: "Roman Mohr" < rmohr@redhat.com > > > > > > > To: "devel" < devel@ovirt.org > > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > > > Subject: [ovirt-devel] Master ovirt-engine build > > > > > > broken > > > > > > > > > > > > Hi, > > > > > > > > > > > > I see failing tests regarding to missing translations > > > > > > (e.g. > > > > > > [1]). > > > > > > > > > > > > [...] > > > > > > > > > > > > Failed tests: > > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > > > cpuInfoLabel does not match the number of parameters > > > > > > in > > > > > > UIMessages_zh_CN.properties(..) > > > > > > > > > > > > [...] > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Roman > > > > > > > > > > > > [1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4
07/console>
> > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > Devel@ovirt.org > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > Devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > -- > > > Eyal Edri > > > Associate Manager > > > RHEV DevOps > > > EMEA ENG Virtualization R&D > > > Red Hat Israel > > > > > > phone: +972-9-7692018 > > > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Oved Ourfali" <oourfali@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:38:40 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ?
We already have Java unit tests for these issues: org.ovirt.engine.ui.uicompat.UIMessagesTest org.ovirt.engine.ui.common.CommonApplicationMessagesTest org.ovirt.engine.ui.userportal.ApplicationMessagesTest org.ovirt.engine.ui.webadmin.ApplicationMessagesTest they were added like 1 year ago by Alexander [1]. [1] https://gerrit.ovirt.org/#/c/32995/ I'm not sure why `check-patch` didn't report errors, because above mentioned unit tests should be executed just like any other Engine unit tests.
The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it).
I don't know why above mentioned unit tests didn't fail when `check-patch` was executed. If this happens again, we can investigate test logs for that build.
Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there.
OK, we'll let you know.
e.
On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:24:21 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Oved Ourfali" <oourfali@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:19:09 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
----- Original Message -----
From: "Oved Ourfali" <oourfali@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "Marek Libra" <mlibra@redhat.com>, "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 2:07:19 PM Subject: Re: [ovirt-devel] Master ovirt-engine build broken
Okay. Makes sense. Thanks Vojtech - please also revert this one.
Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something?
Perhaps oVirt gerrit maintainers can advise here? (adding David)
Sorry for the noise, I did it manually with git revert:
https://gerrit.ovirt.org/#/c/57031/
Can someone please ack?
Merged, this should fix the master build.
Oved
On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vszocs@redhat.com>
(top-posting)
Hi,
root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code.
For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders.
4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code.
I suggest to simply revert the offending patch:
translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/
and create new one which doesn't introduce conflicts.
We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation).
I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below.
Regards, Vojtech
----- Original Message ----- > From: "Marek Libra" <mlibra@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 12:31:18 PM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > There are issues on other keys as well. > I'm rebuilding for all locales locally now. > > > > > > From: "Marek Libra" <mlibra@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 11:29:55 AM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > The fix is here: https://gerrit.ovirt.org/#/c/57007/ > > > > > From: "Roman Mohr" <rmohr@redhat.com> > To: "Oved Ourfali" <oourfali@redhat.com> > Cc: "devel" <devel@ovirt.org> > Sent: Wednesday, May 4, 2016 10:27:51 AM > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
oourfali@redhat.com >
wrote: > > > > Roman - did you build the langs in order to find the issue? > > I just ran 'mvn clean verify', so I saw it on my machine. On gerrit > not all > of my builds showed that error. > > Looking at > >
https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+...
> > two patches passed and two failed after a topic rebase. > > > > Eyal - can we monitor a list of files that i changed will result in > also > building all the languages? > > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < eedri@redhat.com > > wrote: > > > > right, and we can't enable lang permutation since it takes a very > long time > to run. > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjelinek@redhat.com > > wrote: > > > > > ----- Original Message ----- > > From: "Oved Ourfali" < oourfali@redhat.com > > > To: "Tomas Jelinek" < tjelinek@redhat.com > > > Cc: "Roman Mohr" < rmohr@redhat.com >, "devel" < devel@ovirt.org >, "Scott > > Dickerson" < sdickers@redhat.com > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > I wonder, how come the CI didn't catch that? > > because this happens only when you compile with language
wrote: permutations
> > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > tjelinek@redhat.com > > > > > wrote: > > > > > hmmm, > > > regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ > > > fix on the way > > > > > > ----- Original Message ----- > > > > From: "Roman Mohr" < rmohr@redhat.com > > > > > To: "devel" < devel@ovirt.org > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > Hi, > > > > > > > > I see failing tests regarding to missing translations (e.g. > > > > [1]). > > > > > > > > [...] > > > > > > > > Failed tests: > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > cpuInfoLabel does not match the number of parameters in > > > > UIMessages_zh_CN.properties(..) > > > > > > > > [...] > > > > > > > > Best Regards, > > > > > > > > Roman > > > > > > > > [1] > > > > > > >
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
> > > > > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > > > Devel mailing list > > > Devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > -- > Eyal Edri > Associate Manager > RHEV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wed, May 4, 2016 at 9:44 AM, Tomas Jelinek <tjelinek@redhat.com> wrote:
hmmm, regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ fix on the way
Thx
----- Original Message -----
From: "Roman Mohr" <rmohr@redhat.com> To: "devel" <devel@ovirt.org> Sent: Wednesday, May 4, 2016 9:34:53 AM Subject: [ovirt-devel] Master ovirt-engine build broken
Hi,
I see failing tests regarding to missing translations (e.g. [1]).
[...]
Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): cpuInfoLabel does not match the number of parameters in UIMessages_zh_CN.properties(..)
[...]
Best Regards,
Roman
[1]
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407...
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (8)
-
Alexander Wels -
Eli Mesika -
Eyal Edri -
Marek Libra -
Oved Ourfali -
Roman Mohr -
Tomas Jelinek -
Vojtech Szocs