I wonder, how come the CI didn't catch that? On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjelinek(a)redhat.com&gt; wrote:

right, and we can't enable lang permutation since it takes a very long time to run. On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjelinek(a)redhat.com&gt; wrote: -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <oourfali(a)redhat.com&gt; wrote: I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all of my builds showed that error. Looking at https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:mast... two patches passed and two failed after a topic rebase.

------=_Part_25116957_1425524505.1462357878257 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit There are issues on other keys as well. I'm rebuilding for all locales locally now. ----- Original Message ----- > > > > > > > > > > > > > > > > > > > > From: "Oved Ourfali" < oourfali(a)redhat.com > > > > > > > > > > > > > > > > > To: "Tomas Jelinek" < tjelinek(a)redhat.com > > > > > > > > > > > > > > > > > Cc: "Roman Mohr" < rmohr(a)redhat.com >, "devel" < devel(a)ovirt.org >, > > > > > > "Scott > > > > > > Dickerson" < sdickers(a)redhat.com > > > > > > > > > > > > > > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > > > > > > > > > > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I wonder, how come the CI didn't catch that? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > > > > > tjelinek(a)redhat.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > hmmm, > > > > > > > > > > > > > > > > > regression introduced yesterday by > > > > > > > https://gerrit.ovirt.org/#/c/56720/ > > > > > > > > > > > > > > > > > fix on the way > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: "Roman Mohr" < rmohr(a)redhat.com > > > > > > > > > > > > > > > > > > > To: "devel" < devel(a)ovirt.org > > > > > > > > > > > > > > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > > > > > > > > > > > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I see failing tests regarding to missing translations (e.g. > > > > > > > > [1]). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Failed tests: > > > > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > > > > > > > > > > > > > > > cpuInfoLabel does not match the number of parameters in > > > > > > > > > > > > > > > > > > UIMessages_zh_CN.properties(..) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Roman > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/... > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > > > > Devel mailing list > > > > > > > > > > > > > > > > > > Devel(a)ovirt.org > > > > > > > > > > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > > > Devel mailing list > > > > > > > > > > > > > > > > > Devel(a)ovirt.org > > > > > > > > > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > Devel mailing list > > > > > > > > > > > > > > > Devel(a)ovirt.org > > > > > > > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > ------=_Part_25116957_1425524505.1462357878257 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div style=3D"font-family: times new roman, new york, times, se= rif; font-size: 12pt; color: #000000"><div>There are issues on other keys a= s well.</div><div>I'm rebuilding for all locales locally now. <br></div><di= v><br></div><div><br></div><hr id=3D"zwchr"><blockquote style=3D"border-lef= t:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight= :normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,= sans-serif;font-size:12pt;"><b>From: </b>"Marek Libra" &amp;lt;mlibra(a)redhat.co= m&gt;<br><b>To: </b>"devel" &amp;lt;devel(a)ovirt.org&amp;gt;&lt;br&gt;&lt;b&gt;Sent: </b>Wednesd= ay, May 4, 2016 11:29:55 AM<br><b>Subject: </b>Re: [ovirt-devel] Master ovi= rt-engine build broken<br><div><br></div><div style=3D"font-family: times n= ew roman, new york, times, serif; font-size: 12pt; color: #000000"><div>The= fix is here: https://gerrit.ovirt.org/#/c/57007/<br></div><div><b... hr id=3D"zwchr"><blockquote style=3D"border-left:2px solid #1010FF;margin-l= eft:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;te= xt-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;">= <b>From: </b>"Roman Mohr" &amp;lt;rmohr(a)redhat.com&amp;gt;&lt;br&gt;&lt;b&gt;To: </b>"Oved Ourf= ali" &amp;lt;oourfali(a)redhat.com&amp;gt;&lt;br&gt;&lt;b&gt;Cc: </b>"devel" &amp;lt;devel(a)ovirt.org&amp;= gt;<br><b>Sent: </b>Wednesday, May 4, 2016 10:27:51 AM<br><b>Subject: </b>R= e: [ovirt-devel] Master ovirt-engine build broken<br><div><br></div><div di= r=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On = Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <span dir=3D"ltr">&lt;<a href=3D= "mailto:oourfali@redhat.com" target=3D&quot;_blank&quot;&gt;oourfali(a)redhat.com&lt;/a&gt;&amp;gt;&lt;= /span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px = 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-l= eft-style:solid;padding-left:1ex"><div dir=3D"ltr">Roman - did you build th= e langs in order to find the issue?</div></blockquote><div><div><br></div><= div>I just ran 'mvn clean &nbsp;verify', so I saw it on my machine. On gerr= it not all of my builds showed that error.</div><div><br></div><div>Looking= at</div><div><br></div><div>&nbsp; &nbsp; <a href=3D"https://gerrit.ovirt.= org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration" t= arget=3D"_blank">https://gerrit.ovirt.org/#/q/status:open+pr... ine+branch:master+topic:integration</a><br></div><div><br></div><div>two pa= tches passed and two failed after &nbsp;a topic rebase.</div></div><div>&nb= sp;</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-styl= e:solid;padding-left:1ex"><div dir=3D"ltr"><div>Eyal - can we monitor a lis= t of files that i changed will result in also building all the languages?</= div><div><br></div></div></blockquote><blockquote class=3D"gmail_quote" sty= le=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(= 204,204,204);border-left-style:solid;padding-left:1ex"><div dir=3D"ltr"><di= v><br></div></div><div class=3D""><div class=3D"h5"><div class=3D"gmail_ext= ra"><br><div class=3D"gmail_quote">On Wed, May 4, 2016 at 11:22 AM, Eyal Ed= ri <span dir=3D"ltr">&lt;<a href=3D"mailto:eedri@redhat.com" target=3D"_bla= nk&quot;&gt;eedri(a)redhat.com&lt;/a&gt;&amp;gt;&lt;/span&gt; wrote:<br><blockquote class=3D"gmail_qu= ote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-co= lor:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir=3D"= ltr">right, and we can't enable lang permutation since it takes a very long= time to run.</div><div class=3D"gmail_extra"><div><div><br><div class=3D"g= mail_quote">On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <span dir=3D"ltr= ">&lt;<a href=3D"mailto:tjelinek@redhat.com" target=3D"_blank">tjelinek@red= hat.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D= "margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,2= 04,204);border-left-style:solid;padding-left:1ex"><span><br> <br> ----- Ori= ginal Message -----<br> &gt; From: "Oved Ourfali" &lt;<a href=3D"mailto:oou= rfali(a)redhat.com&quot; target=3D&quot;_blank&quot;&gt;oourfali(a)redhat.com&lt;/a&gt;&amp;gt;&lt;br&gt; &gt; To= : "Tomas Jelinek" &lt;<a href=3D"mailto:tjelinek@redhat.com" target=3D"_bla= nk&quot;&gt;tjelinek(a)redhat.com&lt;/a&gt;&amp;gt;&lt;br&gt; &gt; Cc: "Roman Mohr" &lt;<a href=3D"ma= ilto:rmohr@redhat.com" target=3D&quot;_blank&quot;&gt;rmohr(a)redhat.com&lt;/a&gt;&amp;gt;, "devel" = &lt;<a href=3D"mailto:devel@ovirt.org" target=3D&quot;_blank&quot;&gt;devel(a)ovirt.org&lt;/a= =3D&quot;_blank&quot;&gt;sdickers(a)redhat.com&lt;/a&gt;&amp;gt;&lt;br&gt; &gt; Sent: Wednesday, May 4, 20= 16 9:55:40 AM<br> &gt; Subject: Re: [ovirt-devel] Master ovirt-engine build= broken<br> &gt;<br> &gt; I wonder, how come the CI didn't catch that?<br> = <br> </span>because this happens only when you compile with language permut= ations<br><div><div><br> &gt;<br> &gt; On Wed, May 4, 2016 at 10:44 AM, Tom= as Jelinek &lt;<a href=3D"mailto:tjelinek@redhat.com" target=3D"_blank">tje= linek(a)redhat.com&lt;/a&gt;&amp;gt; wrote:<br> &gt;<br> &gt; &gt; hmmm,<br> &gt; &gt; = regression introduced yesterday by <a href=3D"https://gerrit.ovirt.org/#/c/= 56720/" rel=3D"noreferrer" target=3D"_blank">https://gerrit.ovirt.org/#/c/5= 6720/</a><br> &gt; &gt; fix on the way<br> &gt; &gt;<br> &gt; &gt; ----- Or= iginal Message -----<br> &gt; &gt; &gt; From: "Roman Mohr" &lt;<a href=3D"m= ailto:rmohr@redhat.com" target=3D&quot;_blank&quot;&gt;rmohr(a)redhat.com&lt;/a&gt;&amp;gt;&lt;br&gt; &gt;= &gt; &gt; To: "devel" &lt;<a href=3D"mailto:devel@ovirt.org" target=3D"_bl= ank&quot;&gt;devel(a)ovirt.org&lt;/a&gt;&amp;gt;&lt;br&gt; &gt; &gt; &gt; Sent: Wednesday, May 4, 201= 6 9:34:53 AM<br> &gt; &gt; &gt; Subject: [ovirt-devel] Master ovirt-engine = build broken<br> &gt; &gt; &gt;<br> &gt; &gt; &gt; Hi,<br> &gt; &gt; &gt;<b= r> &gt; &gt; &gt; I see failing tests regarding to missing translations (e.= g. [1]).<br> &gt; &gt; &gt;<br> &gt; &gt; &gt; [...]<br> &gt; &gt; &gt;<br>= &gt; &gt; &gt; Failed tests:&nbsp; &nbsp;doTest(org.ovirt.engine.ui.uicomp= at.UIMessagesTest):<br> &gt; &gt; &gt; cpuInfoLabel does not match the numb= er of parameters in<br> &gt; &gt; &gt; UIMessages_zh_CN.properties(..)<br> = &gt; &gt; &gt;<br> &gt; &gt; &gt; [...]<br> &gt; &gt; &gt;<br> &gt; &gt; &g= t; Best Regards,<br> &gt; &gt; &gt;<br> &gt; &gt; &gt; Roman<br> &gt; &gt; = &gt;<br> &gt; &gt; &gt; [1]<br> &gt; &gt; &gt;<br> &gt; &gt; <a href=3D"htt= p://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/c= onsole" rel=3D"noreferrer" target=3D"_blank">http://jenkins.ovirt.org/job/o= virt-engine_master_check-patch-fc23-x86_64/407/console</a><br> &gt; &gt; &g= t;<br> &gt; &gt; &gt; _______________________________________________<br> &= gt; &gt; &gt; Devel mailing list<br> &gt; &gt; &gt; <a href=3D"mailto:Devel= @ovirt.org" target=3D&quot;_blank&quot;&gt;Devel(a)ovirt.org&lt;/a&gt;&lt;br&gt; &gt; &gt; &gt; <a hre= f=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" targ= et=3D"_blank">http://lists.ovirt.org/mailman/listinfo/devel&... &gt; &g= t; _______________________________________________<br> &gt; &gt; Devel mail= ing list<br> &gt; &gt; <a href=3D"mailto:Devel@ovirt.org" target=3D"_blank"= n/listinfo/devel" rel=3D"noreferrer" target=3D"_blank">http://lists.ovirt.o= rg/mailman/listinfo/devel</a><br> &gt; &gt;<br> &gt; &gt;<br> &gt; &gt;<br>= &gt;<br> _______________________________________________<br> Devel mailing= list<br> <a href=3D"mailto:Devel@ovirt.org" target=3D&quot;_blank&quot;&gt;Devel(a)ovirt.= org</a><br> <a href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel= =3D"noreferrer" target=3D"_blank">http://lists.ovirt.org/mailman/listinfo/d= evel</a><br> <br> <br></div></div></blockquote></div><br><br clear=3D"all">= <div><br></div></div></div><span><span><span style=3D"color: #888888;">-- <= br></span></span></span><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div>Ey= al Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualizati= on R&amp;D<br>Red Hat Israel<br><div><br></div>phone: <a href=3D"tel:%2B972= -9-7692018" target=3D"_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rh= ev-dev #rhev-integ)</div></div></div></div></div></div></blockquote></div><= br></div></div></div><br>_______________________________________________<br= k&quot;&gt;Devel(a)ovirt.org&lt;/a&gt;&lt;br&gt; <a href=3D"http://lists.ovirt.org/mailman/listin= fo/devel" rel=3D"noreferrer" target=3D"_blank">http://lists.ovirt.org/mailm= an/listinfo/devel</a><br></blockquote></div><br></div></div><br>___________= ____________________________________<br>Devel mailing list&lt;br&gt;Devel(a)ovirt.o= rg<br>http://lists.ovirt.org/mailman/listinfo/devel</blockquote&... div></div><br>_______________________________________________<br>Devel mail= ing list<br>Devel@ovirt.org<br>http://lists.ovirt.org/mailman/listinfo/deve= l</blockquote><div><br></div></div></body></html> ------=_Part_25116957_1425524505.1462357878257--

(top-posting) Hi, root cause is wrong number of message parameters (placeholders) in translated properties files, compared to message definitions in Java code. For example, UIMessages#cpuInfoLabel method has 4 parameters, but the corresponding message in `UIMessages_de_DE.properties` only contains 3 placeholders. 4.0 String Freeze is May 25 so it's still OK to modify message definitions in Java code. I suggest to simply revert the offending patch: translations update from zanata ovirt-3.6 https://gerrit.ovirt.org/#/c/56720/ and create new one which doesn't introduce conflicts. We have unit tests to detect these kinds of errors, this is to ensure the build fails early on (before GWT compilation). I'm not sure why `check-patch` job for above mentioned patch didn't report the problem, since UIMessagesTest should fail, as Roman wrote below. Regards, Vojtech ----- Original Message -----

----- Original Message ----- Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ gives me "500 Internal server error" -- am I missing something? Perhaps oVirt gerrit maintainers can advise here? (adding David)

On Wed, May 4, 2016 at 3:24 PM, Vojtech Szocs <vszocs(a)redhat.com&gt; wrote: done.

Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ? The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there. e. On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vszocs(a)redhat.com&gt; wrote: -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <awels(a)redhat.com&gt; wrote: Does it run on specific code change/path/file? I can't check why unfortunately since the history is gone, but if you can reproduce the patch we can check. -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

----- Original Message ----- We already have Java unit tests for these issues: org.ovirt.engine.ui.uicompat.UIMessagesTest org.ovirt.engine.ui.common.CommonApplicationMessagesTest org.ovirt.engine.ui.userportal.ApplicationMessagesTest org.ovirt.engine.ui.webadmin.ApplicationMessagesTest they were added like 1 year ago by Alexander [1]. [1] https://gerrit.ovirt.org/#/c/32995/ I'm not sure why `check-patch` didn't report errors, because above mentioned unit tests should be executed just like any other Engine unit tests. I don't know why above mentioned unit tests didn't fail when `check-patch` was executed. If this happens again, we can investigate test logs for that build. OK, we'll let you know.