[Engine-devel] Forking unit tests
Hi guys, If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others. Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes. The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings. -Allon
Hi guys,
If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others.
Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes.
+1 - great job! Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?
The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings.
-Allon
On 06/13/2012 01:28 PM, Mike Kolesnik wrote:
Hi guys,
If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others.
Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes.
+1 - great job! +1
Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?+ +1 - good idea.
The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings.
-Allon
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
We can just move the surefire config to a higher level in the pom hierarchy, but that makes the tests slower globaly. It is more work, but we could help Allon to rewrite the Powermock tests :-) And then the surefire settings could be removed and the tests will run quick again. ----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: "Mike Kolesnik" <mkolesni@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, June 13, 2012 1:44:39 PM Subject: Re: [Engine-devel] Forking unit tests
On 06/13/2012 01:28 PM, Mike Kolesnik wrote:
Hi guys,
If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others.
Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes.
+1 - great job! +1
Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?+ +1 - good idea.
The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings.
-Allon
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 06/13/2012 03:41 PM, Laszlo Hornyak wrote:
We can just move the surefire config to a higher level in the pom hierarchy, but that makes the tests slower globaly. It is more work, but we could help Allon to rewrite the Powermock tests :-) And then the surefire settings could be removed and the tests will run quick again.
great job. I think that any further effort we want to put in refactoring the tests must be in abstracting the code *first* i.e creating facade + interfaces + getters instead of static calling classes (Backend, Config, DbFacade ...) . that way we can avoid a lot of mocking code (mkublin we can remove a lot of code here!)
----- Original Message -----
From: "Yair Zaslavsky"<yzaslavs@redhat.com> To: "Mike Kolesnik"<mkolesni@redhat.com> Cc: "engine-devel"<engine-devel@ovirt.org> Sent: Wednesday, June 13, 2012 1:44:39 PM Subject: Re: [Engine-devel] Forking unit tests
On 06/13/2012 01:28 PM, Mike Kolesnik wrote:
Hi guys,
If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others.
Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes. +1 - great job! +1 Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?+ +1 - good idea.
The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings.
-Allon
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Roy Golan" <rgolan@redhat.com> To: engine-devel@ovirt.org Sent: Wednesday, June 13, 2012 4:14:06 PM Subject: Re: [Engine-devel] Forking unit tests
On 06/13/2012 03:41 PM, Laszlo Hornyak wrote:
We can just move the surefire config to a higher level in the pom hierarchy, but that makes the tests slower globaly. It is more work, but we could help Allon to rewrite the Powermock tests :-) And then the surefire settings could be removed and the tests will run quick again.
great job. I think that any further effort we want to put in refactoring the tests must be in abstracting the code *first* i.e creating facade + interfaces + getters instead of static calling classes (Backend, Config, DbFacade ...) . that way we can avoid a lot of mocking code (mkublin we can remove a lot of code here!) +gazilion.
----- Original Message -----
From: "Yair Zaslavsky"<yzaslavs@redhat.com> To: "Mike Kolesnik"<mkolesni@redhat.com> Cc: "engine-devel"<engine-devel@ovirt.org> Sent: Wednesday, June 13, 2012 1:44:39 PM Subject: Re: [Engine-devel] Forking unit tests
On 06/13/2012 01:28 PM, Mike Kolesnik wrote:
Hi guys,
If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others.
Over the past month or so I've been working on removing PowerMock from as many places as possible (many thanks to mkolesni and lhornyak!), and we've got to the stage that forking is only needed in to subprojects - bll and resttypes. +1 - great job! +1 Would it be possible to have this as a parameter (defaul true) that can be overridden, such as -Dengine.forkTests=false ?+ +1 - good idea.
The forking was defined explicitly in those two projects, so if you want to speed up your tests, just take the latest version of settings.xml from http://ovirt.org/wiki/Building_oVirt_engine#Maven_personal_settings.
-Allon
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (5)
-
Allon Mureinik -
Laszlo Hornyak -
Mike Kolesnik -
Roy Golan -
Yair Zaslavsky