vdsm make rpm & make check on fe vs el
Isn't this odd? Fedora release 20 (Heisenbug) ============================= $ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.006s Ran 1 test in 0.070s Ran 691 tests in 63.504s $ make rpm 2>&1 | grep -E "^Ran" | tail -f Ran 2 tests in 1.005s Ran 1 test in 0.069s Ran 691 tests in 63.937s $ Red Hat Enterprise Linux Server release 6.6 (Santiago) ====================================================== $ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.003s Ran 1 test in 0.082s Ran 691 tests in 61.114s $ make rpm 2>&1 | grep -E "^Ran" $ I've also saw a different numbers of tests running for make rpm on el. Thanks, Mooli Tayer.
----- Original Message -----
From: "Mooli Tayer" <mtayer@redhat.com> To: devel@ovirt.org Sent: Monday, October 27, 2014 11:16:41 AM Subject: [ovirt-devel] vdsm make rpm & make check on fe vs el
Isn't this odd?
Fedora release 20 (Heisenbug) ============================= $ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.006s Ran 1 test in 0.070s Ran 691 tests in 63.504s $ make rpm 2>&1 | grep -E "^Ran" | tail -f Ran 2 tests in 1.005s Ran 1 test in 0.069s Ran 691 tests in 63.937s $
Red Hat Enterprise Linux Server release 6.6 (Santiago) ======================================================
$ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.003s Ran 1 test in 0.082s Ran 691 tests in 61.114s $ make rpm 2>&1 | grep -E "^Ran" $
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests. It would be nice if take a look at this. Nir
----- Original Message -----
From: "Mooli Tayer" <mtayer@redhat.com> To: devel@ovirt.org Sent: Monday, October 27, 2014 11:16:41 AM Subject: [ovirt-devel] vdsm make rpm & make check on fe vs el
Isn't this odd?
Fedora release 20 (Heisenbug) ============================= $ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.006s Ran 1 test in 0.070s Ran 691 tests in 63.504s $ make rpm 2>&1 | grep -E "^Ran" | tail -f Ran 2 tests in 1.005s Ran 1 test in 0.069s Ran 691 tests in 63.937s $
Red Hat Enterprise Linux Server release 6.6 (Santiago) ======================================================
$ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.003s Ran 1 test in 0.082s Ran 691 tests in 61.114s $ make rpm 2>&1 | grep -E "^Ran" $
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests.
It would be nice if take a look at this.
It was made on purposes: # Skips check since rhel default repos lack pep8 and pyflakes %if ! 0%{?rhel} %global with_check 1 %endif http://gerrit.ovirt.org/#/c/29213/ I believe time has come for a more robust solution -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani
----- Original Message -----
From: "Francesco Romani" <fromani@redhat.com> To: devel@ovirt.org Cc: "Mooli Tayer" <mtayer@redhat.com>, "Nir Soffer" <nsoffer@redhat.com> Sent: Monday, October 27, 2014 1:11:45 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
----- Original Message -----
From: "Mooli Tayer" <mtayer@redhat.com> To: devel@ovirt.org Sent: Monday, October 27, 2014 11:16:41 AM Subject: [ovirt-devel] vdsm make rpm & make check on fe vs el
Isn't this odd?
Fedora release 20 (Heisenbug) ============================= $ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.006s Ran 1 test in 0.070s Ran 691 tests in 63.504s $ make rpm 2>&1 | grep -E "^Ran" | tail -f Ran 2 tests in 1.005s Ran 1 test in 0.069s Ran 691 tests in 63.937s $
Red Hat Enterprise Linux Server release 6.6 (Santiago) ======================================================
$ make check 2>&1 | grep -E "^Ran" Ran 2 tests in 1.003s Ran 1 test in 0.082s Ran 691 tests in 61.114s $ make rpm 2>&1 | grep -E "^Ran" $
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests.
It would be nice if take a look at this.
It was made on purposes:
# Skips check since rhel default repos lack pep8 and pyflakes %if ! 0%{?rhel} %global with_check 1 %endif
http://gerrit.ovirt.org/#/c/29213/
I believe time has come for a more robust solution
As first aid, we should log something like "Skipping tests because ..." in this case. I think we need to change that so we disable only pep8 in make rpm. Nir
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Francesco Romani" <fromani@redhat.com> Cc: devel@ovirt.org, "Mooli Tayer" <mtayer@redhat.com> Sent: Monday, October 27, 2014 12:16:11 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
[...]
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests.
It would be nice if take a look at this.
It was made on purposes:
# Skips check since rhel default repos lack pep8 and pyflakes %if ! 0%{?rhel} %global with_check 1 %endif
http://gerrit.ovirt.org/#/c/29213/
I believe time has come for a more robust solution
As first aid, we should log something like "Skipping tests because ..." in this case.
I think we need to change that so we disable only pep8 in make rpm.
Nir
+1 we can afford to skip local checks (pep8/pyflakes), but the core test suite should run anyway. I'll post a patch today(ish) if noone is faster/disagrees with the above :) -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani
----- Original Message -----
From: "Francesco Romani" <fromani@redhat.com> To: devel@ovirt.org Sent: Monday, October 27, 2014 12:20:17 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Francesco Romani" <fromani@redhat.com> Cc: devel@ovirt.org, "Mooli Tayer" <mtayer@redhat.com> Sent: Monday, October 27, 2014 12:16:11 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
[...]
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests.
It would be nice if take a look at this.
It was made on purposes:
# Skips check since rhel default repos lack pep8 and pyflakes %if ! 0%{?rhel} %global with_check 1 %endif
http://gerrit.ovirt.org/#/c/29213/
I believe time has come for a more robust solution
As first aid, we should log something like "Skipping tests because ..." in this case.
I think we need to change that so we disable only pep8 in make rpm.
Nir
+1
we can afford to skip local checks (pep8/pyflakes), but the core test suite should run anyway.
I'll post a patch today(ish) if noone is faster/disagrees with the above :)
I don't think the tests should run on make rpm. In make check, sure. In make rpm... It's a last resort for making people realize something is broken when they are not running make check.
-- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Antoni Segura Puimedon" <asegurap@redhat.com> To: "Francesco Romani" <fromani@redhat.com> Cc: devel@ovirt.org Sent: Monday, October 27, 2014 1:26:47 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
----- Original Message -----
From: "Francesco Romani" <fromani@redhat.com> To: devel@ovirt.org Sent: Monday, October 27, 2014 12:20:17 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Francesco Romani" <fromani@redhat.com> Cc: devel@ovirt.org, "Mooli Tayer" <mtayer@redhat.com> Sent: Monday, October 27, 2014 12:16:11 PM Subject: Re: [ovirt-devel] vdsm make rpm & make check on fe vs el
[...]
I've also saw a different numbers of tests running for make rpm on el.
I have seen this on several 6.5 machines - make rpm on does *not* run the tests.
It would be nice if take a look at this.
It was made on purposes:
# Skips check since rhel default repos lack pep8 and pyflakes %if ! 0%{?rhel} %global with_check 1 %endif
http://gerrit.ovirt.org/#/c/29213/
I believe time has come for a more robust solution
As first aid, we should log something like "Skipping tests because ..." in this case.
I think we need to change that so we disable only pep8 in make rpm.
Nir
+1
we can afford to skip local checks (pep8/pyflakes), but the core test suite should run anyway.
I'll post a patch today(ish) if noone is faster/disagrees with the above :)
I don't think the tests should run on make rpm. In make check, sure. In make rpm... It's a last resort for making people realize something is broken when they are not running make check.
In a perfect world, make rpm would only make rpm and we would be happy. But in our world, the tests run in make rpm may fail even if they succeed in make check. This may happen if you forgot to update the makefiles after adding new test modules or libraries. So the safest way to make sure that the test would run from source rpm is to run them in make rpm. Nir
participants (4)
-
Antoni Segura Puimedon -
Francesco Romani -
Mooli Tayer -
Nir Soffer