[URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine. Please fix the automated versioning system vdsm is currently using or get rid of it. Thanks, -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch? Nir
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects: stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b So when new stable package is released, we will raise versions to: stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b Martin
Nir
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Fri, Mar 04, 2016 at 04:28:30AM -0500, Martin Perina wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
Or alternatively, tag 4-parts versions in the 3.6.z branch, so that raising the snapshot version can be done only once: before tagging a new stable version, bump the snapshot version, and use 4.17.23.1 to the stable one.
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right? Francesco, Yaniv, what do you think? Nir
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>, "devel" <devel@ovirt.org> Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise this again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23 On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com> wrote:
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>, "devel" < devel@ovirt.org> Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola <
sbonazzo@redhat.com >
wrote:
Hi, I think I already raised the issue several times, but let me raise
again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on
----- Original Message ----- this the
3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version) So if we don't get to vdsm packages versioning to the status: stable version <= stable snapshot version <= master snapshot version we can't do upgrade testing in our CI. [1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com> wrote:
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>, "devel" < devel@ovirt.org> Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola <
sbonazzo@redhat.com >
wrote:
Hi, I think I already raised the issue several times, but let me raise
again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on
----- Original Message ----- this the
3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
On Mon, Mar 7, 2016 at 10:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" < sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" < devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
but its not vdsm-4.17.24 snapshot - its 4.17.19 snapshot .. :/ a bit misleading, no?
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
So if we don't get to vdsm packages versioning to the status:
stable version <= stable snapshot version <= master snapshot version
we can't do upgrade testing in our CI.
[1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>,
"devel" <
Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm
versioning
system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise
again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on
devel@ovirt.org> this the
3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
-- *Yaniv Bronhaim.*
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 9:12:38 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Mon, Mar 7, 2016 at 10:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" < sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" < devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
but its not vdsm-4.17.24 snapshot - its 4.17.19 snapshot .. :/ a bit misleading, no?
No, stable snapshot is always snapshot of the next stable version
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
So if we don't get to vdsm packages versioning to the status:
stable version <= stable snapshot version <= master snapshot version
we can't do upgrade testing in our CI.
[1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>,
"devel" <
Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message ----- > From: "Nir Soffer" <nsoffer@redhat.com> > To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" > <fromani@redhat.com>, "Dan Kenigsberg" > <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> > Cc: "devel" <devel@ovirt.org> > Sent: Friday, March 4, 2016 10:20:30 AM > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm
versioning
> system need to be fixed > > On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > > wrote: > > > > Hi, > I think I already raised the issue several times, but let me raise
> again. > VDSM building / automated versioning is badly broken. > Currently, 3.6 snapshot is building: > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on
devel@ovirt.org> this the
> 3.6 > branch was 4.17.19 and new tags have been created in different branches. > This make impossible to upgrade from stable (4.17.23) to latest snapshot. > This also break dependencies on other projects requiring the latest > released > version like hosted engine. > > How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
-- *Yaniv Bronhaim.*
On Mon, Mar 7, 2016 at 10:12 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
On Mon, Mar 7, 2016 at 10:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
but its not vdsm-4.17.24 snapshot - its 4.17.19 snapshot .. :/ a bit misleading, no?
And having a stable version 4.17.23 and a snapshot 4.17.19 is not misleading?
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
So if we don't get to vdsm packages versioning to the status:
stable version <= stable snapshot version <= master snapshot version
we can't do upgrade testing in our CI.
[1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com> wrote:
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>, "devel" < devel@ovirt.org> Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message ----- > From: "Nir Soffer" <nsoffer@redhat.com> > To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" > <fromani@redhat.com>, "Dan Kenigsberg" > <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> > Cc: "devel" <devel@ovirt.org> > Sent: Friday, March 4, 2016 10:20:30 AM > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm > versioning > system need to be fixed > > On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola <
sbonazzo@redhat.com >
> wrote: > > > > Hi, > I think I already raised the issue several times, but let me > raise
> again. > VDSM building / automated versioning is badly broken. > Currently, 3.6 snapshot is building: > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last > tag on
----- Original Message ----- this the
> 3.6 > branch was 4.17.19 and new tags have been created in different branches. > This make impossible to upgrade from stable (4.17.23) to latest snapshot. > This also break dependencies on other projects requiring the > latest > released > version like hosted engine. > > How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
-- Yaniv Bronhaim.
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Didi
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" < sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" < devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
So if we don't get to vdsm packages versioning to the status:
stable version <= stable snapshot version <= master snapshot version
we can't do upgrade testing in our CI.
[1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>,
"devel" <
Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Friday, March 4, 2016 10:20:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm
versioning
system need to be fixed
On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
Hi, I think I already raised the issue several times, but let me raise
again. VDSM building / automated versioning is badly broken. Currently, 3.6 snapshot is building: vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last tag on
devel@ovirt.org> this the
3.6 branch was 4.17.19 and new tags have been created in different branches. This make impossible to upgrade from stable (4.17.23) to latest snapshot. This also break dependencies on other projects requiring the latest released version like hosted engine.
How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
+1 On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
So if we don't get to vdsm packages versioning to the status:
stable version <= stable snapshot version <= master snapshot version
we can't do upgrade testing in our CI.
[1] http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/noarch/ [2] http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/el7/noarch/ [3] http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/noarch/
On Mon, Mar 7, 2016 at 7:33 AM, Martin Perina <mperina@redhat.com> wrote:
From: "Nir Soffer" <nsoffer@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" < fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com>, "devel" < devel@ovirt.org> Sent: Sunday, March 6, 2016 6:35:53 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
On Fri, Mar 4, 2016 at 11:28 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message ----- > From: "Nir Soffer" <nsoffer@redhat.com> > To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" > <fromani@redhat.com>, "Dan Kenigsberg" > <danken@redhat.com>, "Yaniv Bronheim" <ybronhei@redhat.com> > Cc: "devel" <devel@ovirt.org> > Sent: Friday, March 4, 2016 10:20:30 AM > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm > versioning > system need to be fixed > > On Fri, Mar 4, 2016 at 10:29 AM, Sandro Bonazzola <
sbonazzo@redhat.com >
> wrote: > > > > Hi, > I think I already raised the issue several times, but let me > raise
> again. > VDSM building / automated versioning is badly broken. > Currently, 3.6 snapshot is building: > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm because the last > tag on
----- Original Message ----- this the
> 3.6 > branch was 4.17.19 and new tags have been created in different branches. > This make impossible to upgrade from stable (4.17.23) to latest snapshot. > This also break dependencies on other projects requiring the > latest > released > version like hosted engine. > > How do you suggest to version the 3.6 branch?
I think we usually do something like this in other engine projects:
stable released: 4.17.23-1 stable snapshot: 4.17.24-0.git171584b
So when new stable package is released, we will raise versions to:
stable released: 4.17.24-1 stable snapshot: 4.17.25-0.git171584b
This means that snapshot version must be bumped when creating a release branch, right?
Yes, after release of each stable version we need also to increase stable snapshot version.
Francesco, Yaniv, what do you think?
Nir
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19 So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have now, getting back to the origin mail that Sandro sent: """ snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches. this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3 """ Yaniv Bronhaim. On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" <devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently
do.
Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable. Let's make it simple, try install stable and then try to upgrade to snapshot. You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" <sbonazzo@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>,
"devel"
<devel@ovirt.org> Sent: Monday, March 7, 2016 8:16:05 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
I don't understand what's the different .. that's what we currently do. Sandro complains that he can't upgrade latest stable which can be 4.17.23 to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't consider that as an upgrade and 4.17.19.88 can't fill HE requirement for 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com>
wrote:
----- Original Message ----- > From: "Yaniv Bronheim" <ybronhei@redhat.com> > To: "Martin Perina" <mperina@redhat.com> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" > <sbonazzo@redhat.com>, "Francesco Romani" > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>,
"devel"
> <devel@ovirt.org> > Sent: Monday, March 7, 2016 8:16:05 AM > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning > system need to be fixed > > I don't understand what's the different .. that's what we currently do. > Sandro complains that he can't upgrade latest stable which can be > 4.17.23 > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't > consider that as an upgrade and 4.17.19.88 can't fill HE requirement for > 4.17.23
oVirt 3.6 stable release: - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm
oVirt 3.6 stable snapshot: - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm
oVirt master snapshot: - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm (not sure what will be oVirt 4 vdsm version)
+1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com>
wrote:
> > > > ----- Original Message ----- > > From: "Yaniv Bronheim" <ybronhei@redhat.com> > > To: "Martin Perina" <mperina@redhat.com> > > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" > > <sbonazzo@redhat.com>, "Francesco Romani" > > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" > > <devel@ovirt.org> > > Sent: Monday, March 7, 2016 8:16:05 AM > > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning > > system need to be fixed > > > > I don't understand what's the different .. that's what we currently do. > > Sandro complains that he can't upgrade latest stable which can be > > 4.17.23 > > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't > > consider that as an upgrade and 4.17.19.88 can't fill HE requirement for > > 4.17.23 > > oVirt 3.6 stable release: > - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm > - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm > > oVirt 3.6 stable snapshot: > - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm > - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm > > oVirt master snapshot: > - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm > - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or > vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm > (not sure what will be oVirt 4 vdsm version) >
+1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:
+1
On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com> wrote: > > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote: >> >> >> >> ----- Original Message ----- >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> >> > To: "Martin Perina" <mperina@redhat.com> >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" >> > <sbonazzo@redhat.com>, "Francesco Romani" >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" >> > <devel@ovirt.org> >> > Sent: Monday, March 7, 2016 8:16:05 AM >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning >> > system need to be fixed >> > >> > I don't understand what's the different .. that's what we currently do. >> > Sandro complains that he can't upgrade latest stable which can be >> > 4.17.23 >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't >> > consider that as an upgrade and 4.17.19.88 can't fill HE requirement for >> > 4.17.23 >> >> oVirt 3.6 stable release: >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm >> >> oVirt 3.6 stable snapshot: >> - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm >> - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm >> >> oVirt master snapshot: >> - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm >> - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or >> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm >> (not sure what will be oVirt 4 vdsm version) >> > > > +1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com> Cc: "Dan Kenigsberg" <danken@redhat.com>, "Nir Soffer" <nsoffer@redhat.com>, "Martin Perina" <mperina@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "devel" <devel@ovirt.org> Sent: Tuesday, March 8, 2016 9:45:40 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it
Sorry, but that seems crazy to me :-( How can stable release in ovirt-3.6.3 branch has higher version number than nighly build from ovirt-3.6 branch which is the base for future 3.6.5 release?
On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote: > +1 > > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com> wrote: > > > > > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote: > >> > >> > >> > >> ----- Original Message ----- > >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> > >> > To: "Martin Perina" <mperina@redhat.com> > >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" > >> > <sbonazzo@redhat.com>, "Francesco Romani" > >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" > >> > <devel@ovirt.org> > >> > Sent: Monday, March 7, 2016 8:16:05 AM > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning > >> > system need to be fixed > >> > > >> > I don't understand what's the different .. that's what we currently do. > >> > Sandro complains that he can't upgrade latest stable which can be > >> > 4.17.23 > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't > >> > consider that as an upgrade and 4.17.19.88 can't fill HE requirement for > >> > 4.17.23 > >> > >> oVirt 3.6 stable release: > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm > >> > >> oVirt 3.6 stable snapshot: > >> - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm > >> - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm > >> > >> oVirt master snapshot: > >> - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm > >> - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or > >> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm > >> (not sure what will be oVirt 4 vdsm version) > >> > > > > > > +1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
On Tue, Mar 8, 2016 at 9:45 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it
Yaniv, when you release 4.17.23, other projects like Hosted Engine will require it. And if it's not available in snapshot repository you'll end up with a broken dependency there, since you're requiring >= 4.17.23-0 and you have only 4.17.19-39 which should be the one you're supposed to test. Note that enabling the stable repo will provide 4.17.23 required by Hosted engine but won't allow you to test new code since the upgrade won't be possible. If you don't want new vdsm code to be tested, just let me know, I'll add stable repository to all projects requiring vdsm and I'll solve the dependency breakage.
On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because
""" snip the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote: > +1 > > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < sbonazzo@redhat.com> wrote: > > > > > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <mperina@redhat.com> wrote: > >> > >> > >> > >> ----- Original Message ----- > >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> > >> > To: "Martin Perina" <mperina@redhat.com> > >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" > >> > <sbonazzo@redhat.com>, "Francesco Romani" > >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, "devel" > >> > <devel@ovirt.org> > >> > Sent: Monday, March 7, 2016 8:16:05 AM > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning > >> > system need to be fixed > >> > > >> > I don't understand what's the different .. that's what we currently do. > >> > Sandro complains that he can't upgrade latest stable which can be > >> > 4.17.23 > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum can't > >> > consider that as an upgrade and 4.17.19.88 can't fill HE requirement for > >> > 4.17.23 > >> > >> oVirt 3.6 stable release: > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm > >> > >> oVirt 3.6 stable snapshot: > >> - current [2]: vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm > >> - desired: vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm > >> > >> oVirt master snapshot: > >> - current [3]: vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm > >> - desired: vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or > >> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm > >> (not sure what will be oVirt 4 vdsm version) > >> > > > > > > +1
the down side of that is that we'd need to forsake our ability to release a new version by a mere `git tag`, and would have to include a version bump commit instead.
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
latest is 4.17.19 right? so where we test latest 3.6 we checkout ovirt-3.6 branch, build the rpms and install them - can we do it when we disable the stable repository and remove the current installed version? Its either that, or each tag to stable will follow tag to latest 3.6 which will be higher On Tue, Mar 8, 2016 at 10:52 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:45 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it
Yaniv, when you release 4.17.23, other projects like Hosted Engine will require it. And if it's not available in snapshot repository you'll end up with a broken dependency there, since you're requiring >= 4.17.23-0 and you have only 4.17.19-39 which should be the one you're supposed to test. Note that enabling the stable repo will provide 4.17.23 required by Hosted engine but won't allow you to test new code since the upgrade won't be possible.
If you don't want new vdsm code to be tested, just let me know, I'll add stable repository to all projects requiring vdsm and I'll solve the dependency breakage.
On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Again, I should understand the direction you ack here ... and its not clear in any way I try to read it lets summaries current status: master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it hasn't happened yet) ovit-3.6.3 last commit points to v4.17.23 (and also contains in its history 4.17.22 4.17.21 4.17.20 and 4.17.19 ovirt-3.6 == was not tagged since v4.17.19
So, as far as I see - last "official published" version is tagged anyway. once we'll finish with z-streams, we can continue tagging only on ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream releases as I call them) we can continue the tagging only on ovirt-3.6.3 branch
The rest of your suggestions can't help in any way. if you prefer you can use 4th level versioning (4.17.x-y) later on. but currently we just continue to raise the current 4.17 we have
now, getting back to the origin mail that Sandro sent:
""" snip > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> because the last tag on the 3.6 branch was 4.17.19 and new tags have been created in different branches.
this is correct - no problem with that approach, new tag still will be higher then 4.17.19 as we see with 4.17.23
> This make impossible to upgrade from stable (4.17.23) to latest snapshot.
But we just said that stable (ovirt-3.6) is 4.17.19 and latest is 4.17.23 - so it sounds right to me.
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
> This also break dependencies on other projects requiring the latest released version like hosted engine.
No its not. HE may require 4.17.23 which is the latest we publish as part of 3.6.3
"""
Yaniv Bronhaim.
On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> wrote:
> On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote: > > +1 > > > > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < > sbonazzo@redhat.com> wrote: > > > > > > > > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina < > mperina@redhat.com> wrote: > > >> > > >> > > >> > > >> ----- Original Message ----- > > >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> > > >> > To: "Martin Perina" <mperina@redhat.com> > > >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" > > >> > <sbonazzo@redhat.com>, "Francesco Romani" > > >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, > "devel" > > >> > <devel@ovirt.org> > > >> > Sent: Monday, March 7, 2016 8:16:05 AM > > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm > versioning > > >> > system need to be fixed > > >> > > > >> > I don't understand what's the different .. that's what we > currently do. > > >> > Sandro complains that he can't upgrade latest stable which > can be > > >> > 4.17.23 > > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum > can't > > >> > consider that as an upgrade and 4.17.19.88 can't fill HE > requirement for > > >> > 4.17.23 > > >> > > >> oVirt 3.6 stable release: > > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm > > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm > > >> > > >> oVirt 3.6 stable snapshot: > > >> - current [2]: > vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm > > >> - desired: > vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm > > >> > > >> oVirt master snapshot: > > >> - current [3]: > vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm > > >> - desired: > vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or > > >> > vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm > > >> (not sure what will be oVirt 4 vdsm version) > > >> > > > > > > > > > +1 > > the down side of that is that we'd need to forsake our ability to > release a new version by a mere `git tag`, and would have to include > a > version bump commit instead. >
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com> Cc: "Dan Kenigsberg" <danken@redhat.com>, "Nir Soffer" <nsoffer@redhat.com>, "Martin Perina" <mperina@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "devel" <devel@ovirt.org> Sent: Tuesday, March 8, 2016 12:54:29 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
latest is 4.17.19 right? so where we test latest 3.6 we checkout ovirt-3.6 branch, build the rpms and install them - can we do it when we disable the stable repository and remove the current installed version?
With the above we cannot test upgrades from stable to snapshot ...
Its either that, or each tag to stable will follow tag to latest 3.6 which will be higher
Yes, that would help the CI, there's no other way than having snapshot version higher than stable version.
On Tue, Mar 8, 2016 at 10:52 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:45 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it
Yaniv, when you release 4.17.23, other projects like Hosted Engine will require it. And if it's not available in snapshot repository you'll end up with a broken dependency there, since you're requiring >= 4.17.23-0 and you have only 4.17.19-39 which should be the one you're supposed to test. Note that enabling the stable repo will provide 4.17.23 required by Hosted engine but won't allow you to test new code since the upgrade won't be possible.
If you don't want new vdsm code to be tested, just let me know, I'll add stable repository to all projects requiring vdsm and I'll solve the dependency breakage.
On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which should be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
> Again, I should understand the direction you ack here ... and its not > clear in any way I try to read it > lets summaries current status: > master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it > hasn't happened yet) > ovit-3.6.3 last commit points to v4.17.23 (and also contains in its > history 4.17.22 4.17.21 4.17.20 and 4.17.19 > ovirt-3.6 == was not tagged since v4.17.19 > > So, as far as I see - last "official published" version is tagged > anyway. once we'll finish with z-streams, we can continue tagging only > on > ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream > releases as I call them) we can continue the tagging only on > ovirt-3.6.3 > branch > > The rest of your suggestions can't help in any way. if you prefer you > can use 4th level versioning (4.17.x-y) later on. but currently we > just > continue to raise the current 4.17 we have > > now, getting back to the origin mail that Sandro sent: > > """ snip > > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm > <http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm> > because > the last tag on the 3.6 branch was 4.17.19 and new tags have been > created > in different branches. > > this is correct - no problem with that approach, new tag still will > be higher then 4.17.19 as we see with 4.17.23 > > > This make impossible to upgrade from stable (4.17.23) to latest > snapshot. > > But we just said that stable (ovirt-3.6) is 4.17.19 and latest is > 4.17.23 - so it sounds right to me. >
No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't upgrade from stable to latest, since latest has lower version than stable.
Let's make it simple, try install stable and then try to upgrade to snapshot.
You'll see yourself.
> > > This also break dependencies on other projects requiring the latest > released version like hosted engine. > > No its not. HE may require 4.17.23 which is the latest we publish as > part of 3.6.3 > > """ > > Yaniv Bronhaim. > > On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com> > wrote: > >> On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote: >> > +1 >> > >> > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < >> sbonazzo@redhat.com> wrote: >> > > >> > > >> > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina < >> mperina@redhat.com> wrote: >> > >> >> > >> >> > >> >> > >> ----- Original Message ----- >> > >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> >> > >> > To: "Martin Perina" <mperina@redhat.com> >> > >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" >> > >> > <sbonazzo@redhat.com>, "Francesco Romani" >> > >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com>, >> "devel" >> > >> > <devel@ovirt.org> >> > >> > Sent: Monday, March 7, 2016 8:16:05 AM >> > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm >> versioning >> > >> > system need to be fixed >> > >> > >> > >> > I don't understand what's the different .. that's what we >> currently do. >> > >> > Sandro complains that he can't upgrade latest stable which >> can be >> > >> > 4.17.23 >> > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum >> can't >> > >> > consider that as an upgrade and 4.17.19.88 can't fill HE >> requirement for >> > >> > 4.17.23 >> > >> >> > >> oVirt 3.6 stable release: >> > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm >> > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm >> > >> >> > >> oVirt 3.6 stable snapshot: >> > >> - current [2]: >> vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm >> > >> - desired: >> vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm >> > >> >> > >> oVirt master snapshot: >> > >> - current [3]: >> vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm >> > >> - desired: >> vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or >> > >> >> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm >> > >> (not sure what will be oVirt 4 vdsm version) >> > >> >> > > >> > > >> > > +1 >> >> the down side of that is that we'd need to forsake our ability to >> release a new version by a mere `git tag`, and would have to include >> a >> version bump commit instead. >> > > > > -- > *Yaniv Bronhaim.* >
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- *Yaniv Bronhaim.*
On Tue, Mar 8, 2016 at 2:09 PM, Martin Perina <mperina@redhat.com> wrote:
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com> Cc: "Dan Kenigsberg" <danken@redhat.com>, "Nir Soffer" < nsoffer@redhat.com>, "Martin Perina" <mperina@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "devel" <devel@ovirt.org> Sent: Tuesday, March 8, 2016 12:54:29 PM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed
latest is 4.17.19 right? so where we test latest 3.6 we checkout ovirt-3.6 branch, build the rpms and install them - can we do it when we disable
----- Original Message ----- the
stable repository and remove the current installed version?
With the above we cannot test upgrades from stable to snapshot ...
Its either that, or each tag to stable will follow tag to latest 3.6
which
will be higher
Yes, that would help the CI, there's no other way than having snapshot version higher than stable version.
right. I just tagged ovirt-3.6 (last snapshot) with v4.17.24 ovirt-3.6.3 last tag is v4.17.23 - from now on we'll tag ovirt-3.6.3 with v4.17.23.x util raising latest 3.6 tag
On Tue, Mar 8, 2016 at 10:52 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Tue, Mar 8, 2016 at 9:45 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
No. the jobs alright. ovirt-3.6 build each night will output vdsm 4.17.19. older version than the build for ovirt-3.6.3 which will raise (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end, ovirt-3.6 new tag will be the newer version for users that want it
Yaniv, when you release 4.17.23, other projects like Hosted Engine will require it. And if it's not available in snapshot repository you'll
end up
with a broken dependency there, since you're requiring >= 4.17.23-0 and you have only 4.17.19-39 which should be the one you're supposed to test. Note that enabling the stable repo will provide 4.17.23 required by Hosted engine but won't allow you to test new code since the upgrade won't be possible.
If you don't want new vdsm code to be tested, just let me know, I'll add stable repository to all projects requiring vdsm and I'll solve the dependency breakage.
On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <
sbonazzo@redhat.com>
wrote:
On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it shouldn't be that way.. latest (which afaiu means latest snapshot? ovirt-3.6.3) should get higher numbering than last stable (which
should
be last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must be newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3 and backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6. bottom line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging only there
this breaks automation at several layers. are you saying that we shouldn't put in ovirt-master-snapshot what comes out from ovirt-3.6 branch but push there only the output of 3.6.3 branch? If so, at least 3 new jenkins jobs (check patch, check merge, build artifact) have to be created and the nightly publisher need to be updated. Who's maintaining VDSM jenkins jobs?
On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <
sbonazzo@redhat.com>
wrote:
> > > On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim < ybronhei@redhat.com> > wrote: > >> Again, I should understand the direction you ack here ... and its not >> clear in any way I try to read it >> lets summaries current status: >> master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it >> hasn't happened yet) >> ovit-3.6.3 last commit points to v4.17.23 (and also contains in its >> history 4.17.22 4.17.21 4.17.20 and 4.17.19 >> ovirt-3.6 == was not tagged since v4.17.19 >> >> So, as far as I see - last "official published" version is tagged >> anyway. once we'll finish with z-streams, we can continue tagging only >> on >> ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream >> releases as I call them) we can continue the tagging only on >> ovirt-3.6.3 >> branch >> >> The rest of your suggestions can't help in any way. if you prefer you >> can use 4th level versioning (4.17.x-y) later on. but currently we >> just >> continue to raise the current 4.17 we have >> >> now, getting back to the origin mail that Sandro sent: >> >> """ snip >> > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm >> < http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifac...
>> because >> the last tag on the 3.6 branch was 4.17.19 and new tags have been >> created >> in different branches. >> >> this is correct - no problem with that approach, new tag still will >> be higher then 4.17.19 as we see with 4.17.23 >> >> > This make impossible to upgrade from stable (4.17.23) to latest >> snapshot. >> >> But we just said that stable (ovirt-3.6) is 4.17.19 and latest is >> 4.17.23 - so it sounds right to me. >> > > > No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't > upgrade from stable to latest, since latest has lower version than > stable. > > Let's make it simple, try install stable and then try to upgrade to > snapshot. > > You'll see yourself. > > > > >> >> > This also break dependencies on other projects requiring the latest >> released version like hosted engine. >> >> No its not. HE may require 4.17.23 which is the latest we publish as >> part of 3.6.3 >> >> """ >> >> Yaniv Bronhaim. >> >> On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <danken@redhat.com
>> wrote: >> >>> On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote: >>> > +1 >>> > >>> > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola < >>> sbonazzo@redhat.com> wrote: >>> > > >>> > > >>> > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina < >>> mperina@redhat.com> wrote: >>> > >> >>> > >> >>> > >> >>> > >> ----- Original Message ----- >>> > >> > From: "Yaniv Bronheim" <ybronhei@redhat.com> >>> > >> > To: "Martin Perina" <mperina@redhat.com> >>> > >> > Cc: "Nir Soffer" <nsoffer@redhat.com>, "Sandro Bonazzola" >>> > >> > <sbonazzo@redhat.com>, "Francesco Romani" >>> > >> > <fromani@redhat.com>, "Dan Kenigsberg" <danken@redhat.com , >>> "devel" >>> > >> > <devel@ovirt.org> >>> > >> > Sent: Monday, March 7, 2016 8:16:05 AM >>> > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm >>> versioning >>> > >> > system need to be fixed >>> > >> > >>> > >> > I don't understand what's the different .. that's what we >>> currently do. >>> > >> > Sandro complains that he can't upgrade latest stable which >>> can be >>> > >> > 4.17.23 >>> > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum >>> can't >>> > >> > consider that as an upgrade and 4.17.19.88 can't fill HE >>> requirement for >>> > >> > 4.17.23 >>> > >> >>> > >> oVirt 3.6 stable release: >>> > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm >>> > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm >>> > >> >>> > >> oVirt 3.6 stable snapshot: >>> > >> - current [2]: >>> vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm >>> > >> - desired: >>> vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm >>> > >> >>> > >> oVirt master snapshot: >>> > >> - current [3]: >>> vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm >>> > >> - desired: >>> vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or >>> > >> >>> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm >>> > >> (not sure what will be oVirt 4 vdsm version) >>> > >> >>> > > >>> > > >>> > > +1 >>> >>> the down side of that is that we'd need to forsake our ability to >>> release a new version by a mere `git tag`, and would have to include >>> a >>> version bump commit instead. >>> >> >> >> >> -- >> *Yaniv Bronhaim.* >> > > > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community > collaboration. > See how it works at redhat.com >
-- *Yaniv Bronhaim.*
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community
collaboration. > >>> See how it works at redhat.com > >>> > >> > >> > >> > >> -- > >> *Yaniv Bronhaim.* > >> > > > > > > > > -- > > Sandro Bonazzola > > Better technology. Faster innovation. Powered by community collaboration. > > See how it works at redhat.com > > > > > > -- > *Yaniv Bronhaim.* >
-- *Yaniv Bronhaim.*
participants (6)
-
Dan Kenigsberg -
Martin Perina -
Nir Soffer -
Sandro Bonazzola -
Yaniv Bronheim -
Yedidyah Bar David