On 10/07/2014 11:48 AM, Sandro Bonazzola wrote:

Hi, following patches are pending on 3.5.0 branch:

http://gerrit.ovirt.org/33886 fixing a blocker http://gerrit.ovirt.org/33852 http://gerrit.ovirt.org/33839 http://gerrit.ovirt.org/33745

3.5.0 packages have been already built, since we're going to rebuild I would like to understand if other 3 patches must go in or not. Juan, 3.5.0 has been built, for maven sake, should I bump to 3.5.0.1? Or since we haven't released it, may I keep 3.5.0?

The source code repository should not contain two commits with the same non-snapshot version. So, yes, to do things correctly maven-wise the version in the 3.5.0 branch should currently be 3.5.0.1-SNAPSHOT. Right before building/tagging the -SNAPSHOT suffix should be removed, and right after building/tagging the version number should be bumped and the -SNAPSHOT suffix added again. This would be mandatory if we were publishing artifacts to any maven repository, as any reasonable repository will just refuse to update a non-snapshot artifact. As we aren't publishing artifacts you can keep 3.5.0, however it is bad practice and should be avoided. -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.