[Engine-devel] Share Your Thoughts
Dear Devel Community Members, We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up). The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.). I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments. Thoughts? Thanks, Gilad.
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table. Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters 3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message Eli
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:41:15 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
+1 sounds like a good and simple idea
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Thanks, Gilad. ----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 3:35:28 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:41:15 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
+1 sounds like a good and simple idea
+1, BUT this is completely a different feature, and more difficult (MUCH more, if I may add). IMHO we need both, lets start with the no-brainer.
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 03/23/2014 04:01 PM, Gilad Chaplik wrote:
Thanks, Gilad.
----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 3:35:28 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:41:15 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
+1 sounds like a good and simple idea
+1, BUT this is completely a different feature, and more difficult (MUCH more, if I may add). IMHO we need both, lets start with the no-brainer.
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Thanks, Gilad. ----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com>, "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 4:13:41 PM Subject: Re: [Engine-devel] Share Your Thoughts
On 03/23/2014 04:01 PM, Gilad Chaplik wrote:
Thanks, Gilad.
----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 3:35:28 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:41:15 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
+1 sounds like a good and simple idea
+1, BUT this is completely a different feature, and more difficult (MUCH more, if I may add). IMHO we need both, lets start with the no-brainer.
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
I think we need multiple comments, so we need to think about the RESTful api anyhow. I guess that next feature will be a reason for 'wipe after stop'/any other BE that needs reasoning.
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 23/03/14 10:36 -0400, Gilad Chaplik wrote:
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
I think we need multiple comments, so we need to think about the RESTful api anyhow. I guess that next feature will be a reason for 'wipe after stop'/any other BE that needs reasoning.
What about a new DB table (maybe called Annotations) that takes a business entity type, UUID, action type, timestamp, and reason string. Then the shutdown reason could be entered as a new row in the DB. It can be kept as long as we want it and views can be adjusted to make these fields searchable. -- Adam Litke
On 24/03/14 08:43 -0400, Adam Litke wrote:
On 23/03/14 10:36 -0400, Gilad Chaplik wrote:
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
I think we need multiple comments, so we need to think about the RESTful api anyhow. I guess that next feature will be a reason for 'wipe after stop'/any other BE that needs reasoning.
What about a new DB table (maybe called Annotations) that takes a business entity type, UUID, action type, timestamp, and reason string. Then the shutdown reason could be entered as a new row in the DB. It can be kept as long as we want it and views can be adjusted to make these fields searchable.
I forgot to mention that this idea would make it simple to annotate the reason for moving a host into maintenance mode as well (or any other state change annotations we would want to make in the future). -- Adam Litke
----- Original Message -----
From: "Adam Litke" <alitke@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Monday, March 24, 2014 3:00:20 PM Subject: Re: [Engine-devel] Share Your Thoughts
On 24/03/14 08:43 -0400, Adam Litke wrote:
On 23/03/14 10:36 -0400, Gilad Chaplik wrote:
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
I think we need multiple comments, so we need to think about the RESTful api anyhow. I guess that next feature will be a reason for 'wipe after stop'/any other BE that needs reasoning.
What about a new DB table (maybe called Annotations) that takes a business entity type, UUID, action type, timestamp, and reason string. Then the shutdown reason could be entered as a new row in the DB. It can be kept as long as we want it and views can be adjusted to make these fields searchable.
I forgot to mention that this idea would make it simple to annotate the reason for moving a host into maintenance mode as well (or any other state change annotations we would want to make in the future).
Hi Adam, Sorry for not being clear enough, the change of the comment free-text field should be an infra one, and can be applied for all other comment fields, we will start with VM because it's required for now, and reuse the same code for other entities when needed. I've discusses with Eli off-line and he came up with the same idea as yours (great minds think alike ;) - it's not just in advertising). Personally, I think it's an overhead for now, there no problem adding it later, and it's quite simple actually. 3 comments: * I think Eli's solution is nice to have but not complete. gave +1 because I thought it's a bigger feature that what he wants (a simple write to log), because in order to meet the RFE/bug 's requirements with logging, we need to pin the audit log into the entity itself (flag the entity according to audit log), IMHO logging isn't good enough UX-wise. * Regarding Itamar's comment: 1) Is this field is a tech preview? if not, we can still support strings in that field as well. 2) Saving XML will allow us to get the RESTful API out of the box (just need to format it according to requested user's presentation). 3) We can add the types as part of the API. 4) Did someone say custom properties sheet in REST? :-) * Regarding the cluster level config (requested in the bug, and implemented in the patch), if we are going on it, we need a separate thread on it (and I'm -1 on it, btw), a simple checkbox 'do not show this textbox/message again' in browser's local-data will do the trick. Thanks, Gilad.
-- Adam Litke
On Sun 23 Mar 2014 04:13:41 PM IST, Itamar Heim wrote:
On 03/23/2014 04:01 PM, Gilad Chaplik wrote:
Thanks, Gilad.
----- Original Message -----
From: "Omer Frenkel" <ofrenkel@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Gilad Chaplik" <gchaplik@redhat.com>, "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 3:35:28 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:41:15 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
----- Original Message -----
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts?
I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
Eli
+1 sounds like a good and simple idea
+1 another reason is we should keep Vm dynamic as compact as possible. using dynamic to hold a shutdown reason is an abuse.
+1, BUT this is completely a different feature, and more difficult (MUCH more, if I may add). IMHO we need both, lets start with the no-brainer.
AuditLog gets recycled after 30 days. the reason i stopped my VM may still be relevant. I would not make fields complex/composite. they need to be easily useable via the CLI for example.
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 03/23/2014 08:41 AM, Eli Mesika wrote:
From: "Eli Mesika" <emesika@redhat.com> To: "Gilad Chaplik" <gchaplik@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:36:17 PM Subject: Re: [Engine-devel] Share Your Thoughts
From: "Gilad Chaplik" <gchaplik@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, March 23, 2014 2:06:01 PM Subject: [Engine-devel] Share Your Thoughts
Dear Devel Community Members,
We are having a small discussion on patch: http://gerrit.ovirt.org/#/c/25633/, bug 1065753 - "Maintenance operations on a VM would ask for an optional reason" (adding a note to stop/shutdown VM, that will be cleared when the VM go up).
The proposed solution is to add a free text field in the VM entity, and to update it in command's parameters (StopVmParmas.. etc.).
I think slightly different, my alternative is to enhance the current free text (comment field) into XML, and allow to add multiple comments that include types. You are welcome to read more about it in the patch's comments.
Thoughts? I suggest a third approach We are logging here a reason for a user/admin operation The natural place for such information is the audit log and not the VM
----- Original Message ----- tables. I think that the audit log messages related for the stop/shutdown commands should be enhanced to include a {REASON} field then the command itself will replace this value in the message with the one given by the user and we are done. Again, the required information is a pure logging issue, therefor I suggest to put this information in the correct place for it, there is no point in saving any logging messages in any entity table.
Technically: 1) The option for giving a reason should be configurable (per Cluster if I look at Arthur comment in the BZ) 2) If the option is on than any stop/shutdown will ask for reason and sent it in the command parameters
----- Original Message ----- than=>then
3) If the command succeed and got a non-empty reason , it will set the reason in the command audit log message
4) We gain here additional advantage since we can : a) search for the reason using the search engine b) get the reason in the message text sent to us if we are subscribed for the VM stop/shotdown event ans using engine-notifier
#1 thru #4 have already been implemented in the current patch.
Eli
Thanks, Gilad. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (7)
-
Adam Litke -
Eli Mesika -
Gilad Chaplik -
Itamar Heim -
Omer Frenkel -
Ravi Nori -
Roy Golan