3:51 a.m.
I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending patches to
gerrit more streamlined.
It show you a list of the patches before sending them and also warns you
if you are not rebased.
To have it working you need to have a configured remote for gerrit
already in your git config
In order for git to detect it as a new verb you have to have this in
your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this
version forgoes special gerrit configuration and can support multiple
gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
5:03 a.m.
On Thu, Nov 10, 2011 at 11:51:06AM +0200, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending
patches to gerrit more streamlined.
It show you a list of the patches before sending them and also warns
you if you are not rebased.
To have it working you need to have a configured remote for gerrit
already in your git config
In order for git to detect it as a new verb you have to have this in
your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice
this version forgoes special gerrit configuration and can support
multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
#!/bin/bash
#
# Copyright 2011 Saggi Mizrahi <smizrahi(a)redhat.com>
#
# Licensed to you under the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version. See the files README and
# LICENSE_GPL_v2 which accompany this distribution.
Nothing accompanies your script! Better don't mention it.
#
if [ -z $2 ]; then
here, and everywhere, unquoted bash variable is a syntax error waiting to
happen. if you go over and fix it, better use names for $1 $2.
echo "usage: git request-review <gerrit-remote>
<remote-branch>"
exit 1
wouldn't it be nicer to have a config bit for default gerrit-remote? most people
are going to have only one.
fi
Thanks Saggi for your script, I use it daily.
Dan.
5:55 p.m.
On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
how about a wiki page with this and the script as a file attachment,
linked from here?
http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
For those who are not yet using it it's meant to make sending patches to
gerrit more streamlined.
It show you a list of the patches before sending them and also warns you
if you are not rebased.
To have it working you need to have a configured remote for gerrit
already in your git config
In order for git to detect it as a new verb you have to have this in
your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice this
version forgoes special gerrit configuration and can support multiple
gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
6:39 p.m.
On Wed, Nov 16, 2011 at 12:55 AM, Itamar Heim <iheim(a)redhat.com> wrote:
On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
>
> I just finished a version of my git-request-review script.
how about a wiki page with this and the script as a file attachment, linked
from here?
http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
>
> For those who are not yet using it it's meant to make sending patches to
> gerrit more streamlined.
Have you looked at https://github.com/openstack-ci/git-review ?
If nothing else, it might give us ideas how to optimize workflow with Gerrit.
Openstack's flow is described in http://wiki.openstack.org/GerritWorkflow
Alan
6:25 a.m.
On Wed 16 Nov 2011 02:39:06 AM IST, Alan Pevec wrote:
On Wed, Nov 16, 2011 at 12:55 AM, Itamar Heim<iheim(a)redhat.com>
wrote:
> On 11/10/2011 11:51 AM, Saggi Mizrahi wrote:
>>
>> I just finished a version of my git-request-review script.
>
> how about a wiki page with this and the script as a file attachment, linked
> from here?
> http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit
>
>>
>> For those who are not yet using it it's meant to make sending patches to
>> gerrit more streamlined.
Have you looked at https://github.com/openstack-ci/git-review ?
If nothing else, it might give us ideas how to optimize workflow with Gerrit.
Openstack's flow is described in http://wiki.openstack.org/GerritWorkflow
Alan
The open-stack scripts are superior and there is no reason not to join
forces.
I just switched to using them.
I had issues with the output so If you like colors and branch\tag names
in your output you can use the branch I posted for pull request.
https://github.com/openstack-ci/git-review/pull/2
6:36 p.m.
On Thu, 2011-11-10 at 11:51 +0200, Saggi Mizrahi wrote:
I just finished a version of my git-request-review script.
For those who are not yet using it it's meant to make sending patches
to gerrit more streamlined.
It show you a list of the patches before sending them and also warns
you if you are not rebased.
To have it working you need to have a configured remote for gerrit
already in your git config
In order for git to detect it as a new verb you have to have this in
your path
usage: git request-review <gerrit-remote> <remote-branch>
eg. git request-review gerrit master
For those of you who are using the old version will probably notice
this version forgoes special gerrit configuration and can support
multiple gerrit servers (just configure more remotes).
Fixes, features and comments are always welcome.
Happy reviewing.
Very nice. Copying node-devel as well. This is much more convenient
than manually typing the push command.
Mike
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
4544
days inactive
4550
days old
5 comments
5 participants
participants (5)
-
Alan Pevec -
Dan Kenigsberg -
Itamar Heim -
Mike Burns -
Saggi Mizrahi