Re: Bug 1522926 - [RFE] Integrate lvm filter configuration in vdsm-tool configure step
I am not sure how "vdsm-tool config-lvm-filter -y" should be carried as part of host-deployment as it is not part of the configurators executed by "vdsm-tool configure". Should it be another task in ansible or an addition to host deploy package[1] after doing configuration? [1] https://github.com/oVirt/ovirt-host-deploy/blob/master/src/plugins/ovirt-hos... On Tue, Jun 23, 2020 at 4:30 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 4:28 PM Yedidyah Bar David <didi@redhat.com> wrote:
On Tue, Jun 23, 2020 at 4:11 PM Amit Bawer <abawer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 2:55 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 2:47 PM Tal Nisan <tnisan@redhat.com> wrote:
BTW: Nir wrote somewhere that it can be done in a day so it
On Tue, Jun 23, 2020 at 2:02 PM Tal Nisan <tnisan@redhat.com>
wrote:
Hey guys, I've talked to Michal and we have to get this change in 4.4.1 so
we'll need to start to work on it ASAP, I've asked Amit to take it so let's
shouldn't be a problem ;) try and understand together what we need to do here
I think we should:
- fix the exit code of the tool, currently it always exits with 0, so there is no way to handle errors. I commented about it in the bug
- run the tool when deploying a host, after or before we run "vdsm-tool configure --force" I don't know where is the code running when deploying a host, it may be in some ansible script. Best ask on devel and CC Didi.
Probably invoked from playbook for ovirt-host-deploy.yml, calling the following package code:
https://github.com/oVirt/ovirt-host-deploy/blob/master/src/plugins/ovirt-hos...
+Yedidyah Bar David could you confirm?
Yes, AFAIK - but this code is maintained by Infra team, not Integration. Adding Dana, who is the main/original author (and probably main maintainer?).
Great.
Amit, please continue the technical discussion on devel.
From ovirt-host-deploy log in engine:
2020-05-25 16:49:32 EDT - TASK [ovirt-host-deploy-vdsm : Verify minimum vdsm version exists] ************* 2020-05-25 16:49:32 EDT - TASK [ovirt-host-deploy-vdsm : Reconfigure vdsm tool] ************************** 2020-05-25 16:50:08 EDT - changed: [10.35.18.187] 2020-05-25 16:50:08 EDT - { "status" : "OK", "msg" : "", "data" : { "uuid" : "13daab0a-a4d8-4a67-8266-3a350efeb36a", "counter" : 52, "stdout" : "changed: [10.35.18.187]", "start_line" : 46, "end_line" : 47, "runner_ident" : "2ef6527a-9ec9-11ea-82a6-525400200635", "event" : "runner_on_ok", "pid" : 30013, "created" : "2020-05-25T20:50:06.341271", "parent_uuid" : "52540020-0635-d1d2-2820-000000000199", "event_data" : { "playbook" : "ovirt-host-deploy.yml", "playbook_uuid" : "b9cdaec8-402d-4705-81d0-973775a69e18", "play" : "all", "play_uuid" : "52540020-0635-d1d2-2820-000000000006", "play_pattern" : "all", "task" : "Reconfigure vdsm tool", "task_uuid" : "52540020-0635-d1d2-2820-000000000199", "task_action" : "command", "task_args" : "", "task_path" : "/usr/share/ovirt-engine/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm/tasks/packages.yml:18", "role" : "ovirt-host-deploy-vdsm", "host" : "10.35.18.187", "remote_addr" : "10.35.18.187", "res" : { "cmd" : "vdsm-tool configure --force", "stdout" : "\nChecking configuration status...\n\nCurrent revision of multipath.conf detected, preserving\nabrt is already configured for vdsm\nlvm is configured for vdsm\nManaged volume database is already configured\nlibvirt is already configured for vdsm\nSUCCESS: ssl configured to true. No conflicts\n\nRunning configure...\nReconfiguration of abrt is done.\nReconfiguration of passwd is done.\nReconfiguration of libvirt is done.\n\nDone configuring modules to VDSM.", "stderr" : "", "rc" : 0, "start" : "2020-05-25 16:49:31.421596", "end" : "2020-05-25 16:50:06.225412", "delta" : "0:00:34.803816", "changed" : true, "invocation" : { "module_args" : { "_raw_params" : "vdsm-tool configure --force", "_uses_shell" : true, "warn" : true, "stdin_add_newline" : true, "strip_empty_ends" : true, "argv" : null, "chdir" : null, "executable" : null, "creates" : null, "removes" : null, "stdin" : null } }, "stdout_lines" : [ "", "Checking configuration status...", "", "Current revision of multipath.conf detected, preserving", "abrt is already configured for vdsm", "lvm is configured for vdsm", "Managed volume database is already configured", "libvirt is already configured for vdsm", "SUCCESS: ssl configured to true. No conflicts", "", "Running configure...", "Reconfiguration of abrt is done.", "Reconfiguration of passwd is done.", "Reconfiguration of libvirt is done.", "", "Done configuring modules to VDSM." ], "stderr_lines" : [ ], "_ansible_no_log" : false },
The one day estimate did not include fixing the exit code and testing
:-)
-- Didi
On Tue, Jun 23, 2020 at 6:39 PM Amit Bawer <abawer@redhat.com> wrote:
I am not sure how "vdsm-tool config-lvm-filter -y" should be carried as part of host-deployment as it is not part of the configurators executed by "vdsm-tool configure". Should it be another task in ansible or an addition to host deploy package[1] after doing configuration?
Yes, it should be another command running before or after vdsm-tool configure --force. The command should be allowed to fail, but we should see the output of the command on failures.
[1] https://github.com/oVirt/ovirt-host-deploy/blob/master/src/plugins/ovirt-hos...
On Tue, Jun 23, 2020 at 4:30 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 4:28 PM Yedidyah Bar David <didi@redhat.com> wrote:
On Tue, Jun 23, 2020 at 4:11 PM Amit Bawer <abawer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 2:55 PM Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Jun 23, 2020 at 2:47 PM Tal Nisan <tnisan@redhat.com> wrote:
BTW: Nir wrote somewhere that it can be done in a day so it shouldn't be a problem ;)
On Tue, Jun 23, 2020 at 2:02 PM Tal Nisan <tnisan@redhat.com> wrote: > > Hey guys, > I've talked to Michal and we have to get this change in 4.4.1 so we'll need to start to work on it ASAP, I've asked Amit to take it so let's try and understand together what we need to do here
I think we should:
- fix the exit code of the tool, currently it always exits with 0, so there is no way to handle errors. I commented about it in the bug
- run the tool when deploying a host, after or before we run "vdsm-tool configure --force" I don't know where is the code running when deploying a host, it may be in some ansible script. Best ask on devel and CC Didi.
Probably invoked from playbook for ovirt-host-deploy.yml, calling the following package code: https://github.com/oVirt/ovirt-host-deploy/blob/master/src/plugins/ovirt-hos...
+Yedidyah Bar David could you confirm?
Yes, AFAIK - but this code is maintained by Infra team, not Integration. Adding Dana, who is the main/original author (and probably main maintainer?).
Great.
Amit, please continue the technical discussion on devel.
From ovirt-host-deploy log in engine:
2020-05-25 16:49:32 EDT - TASK [ovirt-host-deploy-vdsm : Verify minimum vdsm version exists] ************* 2020-05-25 16:49:32 EDT - TASK [ovirt-host-deploy-vdsm : Reconfigure vdsm tool] ************************** 2020-05-25 16:50:08 EDT - changed: [10.35.18.187] 2020-05-25 16:50:08 EDT - { "status" : "OK", "msg" : "", "data" : { "uuid" : "13daab0a-a4d8-4a67-8266-3a350efeb36a", "counter" : 52, "stdout" : "changed: [10.35.18.187]", "start_line" : 46, "end_line" : 47, "runner_ident" : "2ef6527a-9ec9-11ea-82a6-525400200635", "event" : "runner_on_ok", "pid" : 30013, "created" : "2020-05-25T20:50:06.341271", "parent_uuid" : "52540020-0635-d1d2-2820-000000000199", "event_data" : { "playbook" : "ovirt-host-deploy.yml", "playbook_uuid" : "b9cdaec8-402d-4705-81d0-973775a69e18", "play" : "all", "play_uuid" : "52540020-0635-d1d2-2820-000000000006", "play_pattern" : "all", "task" : "Reconfigure vdsm tool", "task_uuid" : "52540020-0635-d1d2-2820-000000000199", "task_action" : "command", "task_args" : "", "task_path" : "/usr/share/ovirt-engine/ansible-runner-service-project/project/roles/ovirt-host-deploy-vdsm/tasks/packages.yml:18", "role" : "ovirt-host-deploy-vdsm", "host" : "10.35.18.187", "remote_addr" : "10.35.18.187", "res" : { "cmd" : "vdsm-tool configure --force", "stdout" : "\nChecking configuration status...\n\nCurrent revision of multipath.conf detected, preserving\nabrt is already configured for vdsm\nlvm is configured for vdsm\nManaged volume database is already configured\nlibvirt is already configured for vdsm\nSUCCESS: ssl configured to true. No conflicts\n\nRunning configure...\nReconfiguration of abrt is done.\nReconfiguration of passwd is done.\nReconfiguration of libvirt is done.\n\nDone configuring modules to VDSM.", "stderr" : "", "rc" : 0, "start" : "2020-05-25 16:49:31.421596", "end" : "2020-05-25 16:50:06.225412", "delta" : "0:00:34.803816", "changed" : true, "invocation" : { "module_args" : { "_raw_params" : "vdsm-tool configure --force", "_uses_shell" : true, "warn" : true, "stdin_add_newline" : true, "strip_empty_ends" : true, "argv" : null, "chdir" : null, "executable" : null, "creates" : null, "removes" : null, "stdin" : null } }, "stdout_lines" : [ "", "Checking configuration status...", "", "Current revision of multipath.conf detected, preserving", "abrt is already configured for vdsm", "lvm is configured for vdsm", "Managed volume database is already configured", "libvirt is already configured for vdsm", "SUCCESS: ssl configured to true. No conflicts", "", "Running configure...", "Reconfiguration of abrt is done.", "Reconfiguration of passwd is done.", "Reconfiguration of libvirt is done.", "", "Done configuring modules to VDSM." ], "stderr_lines" : [ ], "_ansible_no_log" : false },
The one day estimate did not include fixing the exit code and testing :-)
-- Didi
participants (2)
-
Amit Bawer -
Nir Soffer