Hi Tasdik, The indentation is there to show that the second row is a context menu of the first one. In fact, arrangement of menu items did not change, just the colors. Check out the default style on our main Gerrit instance to compare: https://gerrit.ovirt.org/#/q/status:open If you have any ideas on how to improve this, I'd love to hear them. On Wed, May 3, 2017 at 9:11 PM, Tasdik Rahman <prodicus@outlook.com> wrote:

Had quick look and it looks really neat!

Just a quick question.

Would the alignment of “All” and “Open” (so on) be placed like this or is this specific to my browser? Was curious about it. But great work everyone :)

Regards, Tasdik Rahman http://tasdikrahman.me/

On 03-May-2017, at 9:50 PM, Evgheni Dereveanchin <ederevea@redhat.com> wrote:

Hi everyone,

The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit.

Please visit the Staging instance to check it out:

https://gerrit-staging.phx.ovirt.org/

The new design is inspired by oVirt's main website. There is a known glitch that the "Loading Gerrit Code Review" message is overlapped by the logo when the UI is loading. If you spot any other issues or have ideas for improvement feel free to respond to this thread or share your feedback in the following JIRA ticket:

https://ovirt-jira.atlassian.net/browse/OVIRT-912

-- Regards, Evgheni Dereveanchin _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Regards, Evgheni Dereveanchin

I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day. Martin On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> wrote:

Evgheni Dereveanchin <ederevea@redhat.com> writes:

...

The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit.

Please visit the Staging instance to check it out:

https://gerrit-staging.phx.ovirt.org/

Thank you for the preview. While it fits better with oVirt services, there is one thing that makes me uncomfortable with it: low contrast. The top green bar is probably directly violating Web Accessibility Guidelines (AA level; see https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), but I find all the green parts harder to read than in the current version. So it would be nice if the contrast could be improved.

Thanks, Milan _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> wrote:

I agree with Milan and Martin, even after few minutes looking at it, the green with combination of white background just made my eyes burning :-(

Would it be possible to use more darker colors (at least for top banner/menu)? For example darker colors we use in oVirt engine welcome page ...

Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use or specific color codes, otherwise it will be long trial and error process until we'll find something that will suite everyone.

Martin

On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> wrote:

...

I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day.

Martin

On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> wrote:

...

Evgheni Dereveanchin <ederevea@redhat.com> writes:

...

The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit.

Please visit the Staging instance to check it out:

https://gerrit-staging.phx.ovirt.org/

Thank you for the preview. While it fits better with oVirt services, there is one thing that makes me uncomfortable with it: low contrast. The top green bar is probably directly violating Web Accessibility Guidelines (AA level; see https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), but I find all the green parts harder to read than in the current version. So it would be nice if the contrast could be improved.

Thanks, Milan _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

---

Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Eyal edri ASSOCIATE MANAGER RHV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

Thanks everyone for the great feedback! So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently. I've swapped the header background color to #393f45 as used in oVirt for a quick test: https://gerrit-staging.phx.ovirt.org/ Is this more readable? If yes - I can continue working in this direction to add gradients and other patternfly style elements. Otherwise I'll just go with option 1 and stick to the default style we have now. On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> wrote:

...

It will help if someone can suggest an alternate CSS which we can use or specific color codes,

Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue.

Martin

On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> wrote:

...

On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> wrote:

...

I agree with Milan and Martin, even after few minutes looking at it, the green with combination of white background just made my eyes burning :-(

Would it be possible to use more darker colors (at least for top banner/menu)? For example darker colors we use in oVirt engine welcome page ...

Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use or specific color codes, otherwise it will be long trial and error process until we'll find something that will suite everyone.

...

Martin

On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> wrote:

...

I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day.

Martin

On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> wrote:

...

Evgheni Dereveanchin <ederevea@redhat.com> writes:

...

The Infra team is working on customizing the look of Gerrit to make it fit better with other oVirt services. I want to share the result of this effort. Hopefully we can gather some feedback before applying the design to oVirt's instance of Gerrit.

Please visit the Staging instance to check it out:

https://gerrit-staging.phx.ovirt.org/

Thank you for the preview. While it fits better with oVirt services, there is one thing that makes me uncomfortable with it: low contrast. The top green bar is probably directly violating Web Accessibility Guidelines (AA level; see https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), but I find all the green parts harder to read than in the current version. So it would be nice if the contrast could be improved.

Thanks, Milan _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

---

Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

--

Eyal edri

ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D

Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Regards, Evgheni Dereveanchin

On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer@redhat.com> wrote:

On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin <ederevea@redhat.com> wrote:

...

Thanks everyone for the great feedback!

So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently.

I've swapped the header background color to #393f45 as used in oVirt for a quick test: https://gerrit-staging.phx.ovirt.org/

Looks good!

​Much better for my eyes now, thanks a lot! ​

The oVirt logo needs little more space around it, and it also should be centered vertically. Modifying the logo margin to 8px and width to 108px works for me using chrome, see attached screenshot.

[image: Screenshot from 2017-05-04 20-11-39.png]

Nir

Is this more readable? If yes - I can continue working in this direction

...

to add gradients and other patternfly style elements.

Otherwise I'll just go with option 1 and stick to the default style we

...

have now.

On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> wrote:

...

...

It will help if someone can suggest an alternate CSS which we can use or specific color codes,

Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue.

Martin

On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> wrote:

...

On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> wrote:

...

I agree with Milan and Martin, even after few minutes looking at it, the green with combination of white background just made my eyes burning :-(

Would it be possible to use more darker colors (at least for top banner/menu)? For example darker colors we use in oVirt engine welcome page ...

Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use or specific color codes, otherwise it will be long trial and error process until we'll find something that will suite everyone.

...

Martin

On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> wrote:

...

I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day.

Martin

On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> wrote: > Evgheni Dereveanchin <ederevea@redhat.com> writes: > >> The Infra team is working on customizing the look of Gerrit to make it fit >> better with other oVirt services. I want to share the result of this >> effort. Hopefully we can gather some feedback before applying the design to >> oVirt's instance of Gerrit. >> >> Please visit the Staging instance to check it out: >> >> https://gerrit-staging.phx.ovirt.org/ > > Thank you for the preview. While it fits better with oVirt services, > there is one thing that makes me uncomfortable with it: low contrast. > The top green bar is probably directly violating Web Accessibility > Guidelines (AA level; see > https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), but I > find all the green parts harder to read than in the current version. > So it would be nice if the contrast could be improved. > > Thanks, > Milan > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

--

Eyal edri

ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D

Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Regards, Evgheni Dereveanchin _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

Here's my take. The line on the top is a little thicker than I like, but we have the same thickness in oVirt (I checked). I'm ok with shrinking it in both places. I put in the logo from the oVirt login page. I added patternfly and bootstrap. Changed the font to OpenSans. Positioned things and fixed paddings. Changed the button and form field to patternfly type (blue button) Best wishes, Greg On Fri, May 5, 2017 at 2:15 AM, Roy Golan <rgolan@redhat.com> wrote:

Adding UX people +Eldan Hildesheim <info@eldanet.com> +Alexander Wels <awels@redhat.com> +Greg Sheremeta <gshereme@redhat.com>

On Fri, May 5, 2017 at 2:32 AM Martin Perina <mperina@redhat.com> wrote:

...

On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer@redhat.com> wrote:

...

On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin <ederevea@redhat.com> wrote:

...

Thanks everyone for the great feedback!

So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently.

I've swapped the header background color to #393f45 as used in oVirt for a quick test: https://gerrit-staging.phx.ovirt.org/

Looks good!

​Much better for my eyes now, thanks a lot! ​

...

The oVirt logo needs little more space around it, and it also should be centered vertically. Modifying the logo margin to 8px and width to 108px works for me using chrome, see attached screenshot.

[image: Screenshot from 2017-05-04 20-11-39.png]

Nir

Is this more readable? If yes - I can continue working in this direction

...

to add gradients and other patternfly style elements.

Otherwise I'll just go with option 1 and stick to the default style we

...

have now.

On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> wrote:

...

...

It will help if someone can suggest an alternate CSS which we can use or specific color codes,

Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue.

Martin

On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> wrote:

...

On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> wrote:

> I agree with Milan and Martin, even after few minutes looking at it, > the green > with combination of white background just made my eyes burning :-( > > Would it be possible to use more darker colors (at least for top > banner/menu)? > For example darker colors we use in oVirt engine welcome page ... >

Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use or specific color codes, otherwise it will be long trial and error process until we'll find something that will suite everyone.

> > > Martin > > On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> > wrote: > >> I agree with Milan here. The light green background makes the menu >> items to be almost unreadable, the search button (slightly different >> green color) blends with the background and generally the color >> pulls >> my eyes away from the content. I wouldn't feel comfortable looking >> at >> the screen for a whole day. >> >> Martin >> >> On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> >> wrote: >> > Evgheni Dereveanchin <ederevea@redhat.com> writes: >> > >> >> The Infra team is working on customizing the look of Gerrit to >> make it fit >> >> better with other oVirt services. I want to share the result of >> this >> >> effort. Hopefully we can gather some feedback before applying >> the design to >> >> oVirt's instance of Gerrit. >> >> >> >> Please visit the Staging instance to check it out: >> >> >> >> https://gerrit-staging.phx.ovirt.org/ >> > >> > Thank you for the preview. While it fits better with oVirt >> services, >> > there is one thing that makes me uncomfortable with it: low >> contrast. >> > The top green bar is probably directly violating Web Accessibility >> > Guidelines (AA level; see >> > https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), >> but I >> > find all the green parts harder to read than in the current >> version. >> > So it would be nice if the contrast could be improved. >> > >> > Thanks, >> > Milan >> > _______________________________________________ >> > Devel mailing list >> > Devel@ovirt.org >> > http://lists.ovirt.org/mailman/listinfo/devel >> _______________________________________________ >> Devel mailing list >> Devel@ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > > > _______________________________________________ > Infra mailing list > Infra@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > >

--

Eyal edri

ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D

Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Regards, Evgheni Dereveanchin _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com

The current scheme seems a little buggy on FF. See how the top green bar is not stretched to cover the top of the oVirt logo. On 6 May 2017 at 12:49, Yaniv Kaul <ykaul@redhat.com> wrote:

On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta <gshereme@redhat.com> wrote:

...

Here's my take.

The line on the top is a little thicker than I like, but we have the same thickness in oVirt (I checked). I'm ok with shrinking it in both places.

I put in the logo from the oVirt login page. I added patternfly and bootstrap. Changed the font to OpenSans. Positioned things and fixed paddings. Changed the button and form field to patternfly type (blue button)

Looks very good now. I wonder how far are we from being ADA compliant (also a general question to our UI - I know Patternfly should help us there as well). Y.

...

Best wishes, Greg

On Fri, May 5, 2017 at 2:15 AM, Roy Golan <rgolan@redhat.com> wrote:

...

Adding UX people +Eldan Hildesheim <info@eldanet.com> +Alexander Wels <awels@redhat.com> +Greg Sheremeta <gshereme@redhat.com>

On Fri, May 5, 2017 at 2:32 AM Martin Perina <mperina@redhat.com> wrote:

...

On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer@redhat.com> wrote:

...

On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin < ederevea@redhat.com> wrote:

...

Thanks everyone for the great feedback!

So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently.

I've swapped the header background color to #393f45 as used in oVirt for a quick test: https://gerrit-staging.phx.ovirt.org/

Looks good!

​Much better for my eyes now, thanks a lot! ​

...

The oVirt logo needs little more space around it, and it also should be centered vertically. Modifying the logo margin to 8px and width to 108px works for me using chrome, see attached screenshot.

[image: Screenshot from 2017-05-04 20-11-39.png]

Nir

Is this more readable? If yes - I can continue working in this

...

direction to add gradients and other patternfly style elements.

Otherwise I'll just go with option 1 and stick to the default style we

...

have now.

On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> wrote:

> > It will help if someone can suggest an alternate CSS which we can > use or specific color codes, > > Well.. keep it as it is or make it really dark (like the patternfly > menu). I do not care about logos but big area filled with non-neutral color > is always going to be an issue. > > Martin > > On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> wrote: > >> >> >> On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> >> wrote: >> >>> I agree with Milan and Martin, even after few minutes looking at >>> it, the green >>> with combination of white background just made my eyes burning :-( >>> >>> Would it be possible to use more darker colors (at least for top >>> banner/menu)? >>> For example darker colors we use in oVirt engine welcome page ... >>> >> >> Thanks for the feedback, >> It will help if someone can suggest an alternate CSS which we can >> use or specific color codes, >> otherwise it will be long trial and error process until we'll find >> something that will suite everyone. >> >> >> >>> >>> >>> Martin >>> >>> On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> >>> wrote: >>> >>>> I agree with Milan here. The light green background makes the menu >>>> items to be almost unreadable, the search button (slightly >>>> different >>>> green color) blends with the background and generally the color >>>> pulls >>>> my eyes away from the content. I wouldn't feel comfortable >>>> looking at >>>> the screen for a whole day. >>>> >>>> Martin >>>> >>>> On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal < >>>> mzamazal@redhat.com> wrote: >>>> > Evgheni Dereveanchin <ederevea@redhat.com> writes: >>>> > >>>> >> The Infra team is working on customizing the look of Gerrit to >>>> make it fit >>>> >> better with other oVirt services. I want to share the result >>>> of this >>>> >> effort. Hopefully we can gather some feedback before applying >>>> the design to >>>> >> oVirt's instance of Gerrit. >>>> >> >>>> >> Please visit the Staging instance to check it out: >>>> >> >>>> >> https://gerrit-staging.phx.ovirt.org/ >>>> > >>>> > Thank you for the preview. While it fits better with oVirt >>>> services, >>>> > there is one thing that makes me uncomfortable with it: low >>>> contrast. >>>> > The top green bar is probably directly violating Web >>>> Accessibility >>>> > Guidelines (AA level; see >>>> > https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), >>>> but I >>>> > find all the green parts harder to read than in the current >>>> version. >>>> > So it would be nice if the contrast could be improved. >>>> > >>>> > Thanks, >>>> > Milan >>>> > _______________________________________________ >>>> > Devel mailing list >>>> > Devel@ovirt.org >>>> > http://lists.ovirt.org/mailman/listinfo/devel >>>> _______________________________________________ >>>> Devel mailing list >>>> Devel@ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/devel >>>> >>> >>> >>> _______________________________________________ >>> Infra mailing list >>> Infra@ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/infra >>> >>> >> >> >> -- >> >> Eyal edri >> >> >> ASSOCIATE MANAGER >> >> RHV DevOps >> >> EMEA VIRTUALIZATION R&D >> >> >> Red Hat EMEA <https://www.redhat.com/> >> <https://red.ht/sig> TRIED. TESTED. TRUSTED. >> <https://redhat.com/trusted> >> phone: +972-9-7692018 <+972%209-769-2018> >> irc: eedri (on #tlv #rhev-dev #rhev-integ) >> > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >

-- Regards, Evgheni Dereveanchin _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted

On May 7, 2017, at 11:41 PM, Roy Golan <rgolan@redhat.com> wrote: =20 =20 The footer links are useful but the footer itself has no presence. = Most dashboards will fill a page and with such a thin footer nobody is = going to look at what is has to offer. So we can make the footer in a = different color and noticeable etc or move the links to the header. =20 On Sun, May 7, 2017 at 10:35 AM Barak Korren <bkorren@redhat.com = <mailto:bkorren@redhat.com>> wrote: The current scheme seems a little buggy on FF. See how the top green = bar is not stretched to cover the top of the oVirt logo. =20 =20 =20 On 6 May 2017 at 12:49, Yaniv Kaul <ykaul@redhat.com = <mailto:ykaul@redhat.com>> wrote: =20 =20 On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta <gshereme@redhat.com = <mailto:gshereme@redhat.com>> wrote: Here's my take. =20 The line on the top is a little thicker than I like, but we have the = same thickness in oVirt (I checked). I'm ok with shrinking it in both =

=20 I put in the logo from the oVirt login page. I added patternfly and = bootstrap. Changed the font to OpenSans. Positioned things and fixed =

=20 Looks very good now. I wonder how far are we from being ADA compliant = (also a general question to our UI - I know Patternfly should help us =

Y. =20 =20 =20 Best wishes, Greg =20 =20 On Fri, May 5, 2017 at 2:15 AM, Roy Golan <rgolan@redhat.com = <mailto:rgolan@redhat.com>> wrote: =20 Adding UX people +Eldan Hildesheim <mailto:info@eldanet.com> = +Alexander Wels <mailto:awels@redhat.com> +Greg Sheremeta = <mailto:gshereme@redhat.com>=20 =20 On Fri, May 5, 2017 at 2:32 AM Martin Perina <mperina@redhat.com = <mailto:mperina@redhat.com>> wrote: On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer@redhat.com = <mailto:nsoffer@redhat.com>> wrote: =20 =20 On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin = <ederevea@redhat.com <mailto:ederevea@redhat.com>> wrote: Thanks everyone for the great feedback! =20 So there's two options I see now: 1) keep the default header scheme with white background, just add the =

2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI = currently. =20 I've swapped the header background color to #393f45 as used in oVirt = for a quick test: https://gerrit-staging.phx.ovirt.org/ = <https://gerrit-staging.phx.ovirt.org/> =20 Looks good! =20 =E2=80=8BMuch better for my eyes now, thanks a lot! =E2=80=8B =20 =20 The oVirt logo needs little more space around it, and it also should = be centered vertically. Modifying the logo margin to 8px and width to 108px works for me using = chrome, see attached screenshot. =20 <Screenshot from 2017-05-04 20-11-39.png> =20 Nir =20 Is this more readable? If yes - I can continue working in this =

and other patternfly style elements.=20 Otherwise I'll just go with option 1 and stick to the default style we = have now. =20 On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com = <mailto:msivak@redhat.com>> wrote:

...

It will help if someone can suggest an alternate CSS which we can = use or specific color codes, =20 Well.. keep it as it is or make it really dark (like the patternfly =

=20 Martin =20 On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com = <mailto:eedri@redhat.com>> wrote: =20 =20 On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com = <mailto:mperina@redhat.com>> wrote: I agree with Milan and Martin, even after few minutes looking at it, =

with combination of white background just made my eyes burning :-( =20 Would it be possible to use more darker colors (at least for top = banner/menu)? For example darker colors we use in oVirt engine welcome page ... =20 Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use = or specific color codes, otherwise it will be long trial and error process until we'll find = something that will suite everyone. =20 =20 =20 =20 Martin =20 On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com = <mailto:msivak@redhat.com>> wrote: I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day. =20 Martin =20 On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com = <mailto:mzamazal@redhat.com>> wrote:

...

Evgheni Dereveanchin <ederevea@redhat.com = <mailto:ederevea@redhat.com>> writes:

...

The Infra team is working on customizing the look of Gerrit to make = it fit better with other oVirt services. I want to share the result of =

--Apple-Mail=_9FEF5EDD-0E48-4750-9A0E-CDBECAB98EE8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, Can we insert a new css package easily? Perhaps I can merge Patternfly = inside which will be very suitable for this case. E. places. paddings. Changed the button and form field to patternfly type (blue = button) there as well). project logo into the corner direction to add gradients menu). I do not care about logos but big area filled with non-neutral = color is always going to be an issue. the green this

...

...

effort. Hopefully we can gather some feedback before applying the = design to oVirt's instance of Gerrit.

Please visit the Staging instance to check it out:

https://gerrit-staging.phx.ovirt.org/ = <https://gerrit-staging.phx.ovirt.org/>

Thank you for the preview. While it fits better with oVirt = services, there is one thing that makes me uncomfortable with it: low = contrast. The top green bar is probably directly violating Web Accessibility Guidelines (AA level; see https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast = <https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast>), but I find all the green parts harder to read than in the current version. So it would be nice if the contrast could be improved.

Thanks, Milan _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel>

---

Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 =20 _______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra = <http://lists.ovirt.org/mailman/listinfo/infra> =20 =20 =20 =20 --=20 EYAL EDRI =20 ASSOCIATE MANAGER RHV DEVOPS EMEA VIRTUALIZATION R&D =20 Red Hat=C2=A0EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. = <https://redhat.com/trusted> phone: +972-9-7692018 <tel:+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ) =20 =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 =20 =20 --=20 Regards, Evgheni Dereveanchin _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> _______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra = <http://lists.ovirt.org/mailman/listinfo/infra> =20 =20 =20 --=20 Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com <mailto:gshereme@redhat.com> =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 =20 _______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra = <http://lists.ovirt.org/mailman/listinfo/infra> =20 =20 =20 =20 --=20 Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com <http://redhat.com/> | TRIED. TESTED. TRUSTED. | = redhat.com/trusted = <http://redhat.com/trusted>_______________________________________________=

Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra = <http://lists.ovirt.org/mailman/listinfo/infra>

), but I<br class=3D"">> find all the green parts harder to read =

--Apple-Mail=_9FEF5EDD-0E48-4750-9A0E-CDBECAB98EE8 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" = class=3D"">Hi,<div class=3D"">Can we insert a new css package easily? = Perhaps I can merge Patternfly inside which will be very suitable for = this case.</div><div class=3D"">E.</div><div class=3D""><br = class=3D""><div><blockquote type=3D"cite" class=3D""><div class=3D"">On = May 7, 2017, at 11:41 PM, Roy Golan <<a = href=3D"mailto:rgolan@redhat.com" class=3D"">rgolan@redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" style=3D"font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; orphans: auto; text-align: start; text-indent: = 0px; text-transform: none; white-space: normal; widows: auto; = word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><br = class=3D"Apple-interchange-newline">The footer links are useful but the = footer itself has no presence.  Most dashboards will fill a page = and with such a thin footer nobody is going to look at what is has to = offer. So we can make the footer in a different color and noticeable etc = or move the links to the header.<br class=3D""></div><br = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-stroke-width: 0px;" class=3D""><div class=3D"gmail_quote" = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-stroke-width: 0px;"><div dir=3D"ltr" class=3D"">On Sun, May = 7, 2017 at 10:35 AM Barak Korren <<a href=3D"mailto:bkorren@redhat.com"= class=3D"">bkorren@redhat.com</a>> wrote:<br = class=3D""></div><blockquote class=3D"gmail_quote" style=3D"margin: 0px = 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D"">The current scheme seems a little buggy on FF. See how the = top green bar is not stretched to cover the top of the oVirt logo.<br = class=3D""><br class=3D""><br class=3D""></div><div = class=3D"gmail_extra"></div><div class=3D"gmail_extra"><br class=3D""><div= class=3D"gmail_quote">On 6 May 2017 at 12:49, Yaniv Kaul<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:ykaul@redhat.com" target=3D"_blank" = class=3D"">ykaul@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><br class=3D""><div class=3D"gmail_extra"><br class=3D""><div = class=3D"gmail_quote"><span class=3D"">On Fri, May 5, 2017 at 5:33 PM, = Greg Sheremeta<span class=3D"Apple-converted-space"> </span><span = dir=3D"ltr" class=3D""><<a href=3D"mailto:gshereme@redhat.com" = target=3D"_blank" class=3D"">gshereme@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D"">Here's my take.<div class=3D""><br class=3D""></div><div = class=3D"">The line on the top is a little thicker than I like, but we = have the same thickness in oVirt (I checked). I'm ok with shrinking it = in both places.</div><div class=3D""><br class=3D""></div><div = class=3D"">I put in the logo from the oVirt login page. I added = patternfly and bootstrap. Changed the font to OpenSans. Positioned = things and fixed paddings. Changed the button and form field to = patternfly type (blue button)</div></div></blockquote><div class=3D""><br = class=3D""></div></span><div class=3D"">Looks very good now. I wonder = how far are we from being ADA compliant (also a general question to our = UI - I know Patternfly should help us there as well).</div><span = class=3D"m_-3562728657969669923HOEnZb"><font color=3D"#888888" = class=3D""><div class=3D"">Y.</div></font></span><div class=3D""><div = class=3D"m_-3562728657969669923h5"><div class=3D""><br = class=3D""></div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; = border-left-width: 1px; border-left-color: rgb(204, 204, 204); = border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><div class=3D""><br class=3D""></div><div class=3D"">Best = wishes,</div><div class=3D"">Greg</div><div class=3D""><br = class=3D""></div></div><div class=3D"gmail_extra"><div class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172h5"><br = class=3D""><div class=3D"gmail_quote">On Fri, May 5, 2017 at 2:15 AM, = Roy Golan<span class=3D"Apple-converted-space"> </span><span = dir=3D"ltr" class=3D""><<a href=3D"mailto:rgolan@redhat.com" = target=3D"_blank" class=3D"">rgolan@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><br class=3D""><div class=3D"">Adding UX people<span = class=3D"Apple-converted-space"> </span><a = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410GWVZpf = m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7205283= 961653565410gW" = id=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7= 205283961653565410IloFPc-1" href=3D"mailto:info@eldanet.com" = target=3D"_blank">+Eldan Hildesheim</a> <a = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410GWVZpf = m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7205283= 961653565410gW" = id=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7= 205283961653565410IloFPc-2" href=3D"mailto:awels@redhat.com" = target=3D"_blank">+Alexander Wels</a> <a = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410GWVZpf = m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7205283= 961653565410gW" = id=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962m_7= 205283961653565410IloFPc-3" href=3D"mailto:gshereme@redhat.com" = target=3D"_blank">+Greg Sheremeta</a> <br class=3D""><br = class=3D""></div><div class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= h5"><div class=3D""><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"">On Fri, May 5, 2017 at 2:32 AM Martin Perina <<a = href=3D"mailto:mperina@redhat.com" target=3D"_blank" = class=3D"">mperina@redhat.com</a>> wrote:<br = class=3D""></div><blockquote class=3D"gmail_quote" style=3D"margin: 0px = 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><div class=3D"gmail_extra"><div class=3D"gmail_quote">On Thu, = May 4, 2017 at 1:13 PM, Nir Soffer<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:nsoffer@redhat.com" target=3D"_blank" = class=3D"">nsoffer@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><br class=3D""><br class=3D""><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"">On Thu, May 4, 2017 at 4:26 PM Evgheni = Dereveanchin <<a href=3D"mailto:ederevea@redhat.com" target=3D"_blank" = class=3D"">ederevea@redhat.com</a>> wrote:<br = class=3D""></div><blockquote class=3D"gmail_quote" style=3D"margin: 0px = 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D"">Thanks everyone for the great feedback!<div class=3D""><br = class=3D""></div><div class=3D"">So there's two options I see = now:</div><div class=3D"">1) keep the default header scheme with white = background, just add the project logo into the corner</div><div = class=3D"">2) try to adapt to the Patternfly scheme as used in oVirt's = Admin UI currently.</div><div class=3D""><br class=3D""></div><div = class=3D"">I've swapped the header background color to #393f45 as used = in oVirt for a quick test:</div><div class=3D""><a = href=3D"https://gerrit-staging.phx.ovirt.org/" target=3D"_blank" = class=3D"">https://gerrit-staging.phx.ovirt.org/</a></div></div></blockquo= te><div class=3D""><br class=3D""></div><div class=3D"">Looks = good!</div></div></div></blockquote></div></div></div><div dir=3D"ltr" = class=3D""><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D""><br class=3D""><div class=3D"">=E2=80=8BMuch better for my = eyes now, thanks a lot!<br = class=3D"">=E2=80=8B</div> </div></div></div></div><div dir=3D"ltr" = class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin: = 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, = 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><div class=3D"gmail_quote"><div class=3D""><br = class=3D""></div><div class=3D""><div class=3D"">The oVirt logo needs = little more space around it, and it also should be centered = vertically.</div><div class=3D"">Modifying the logo margin to 8px and = width to 108px works for me using chrome,<br class=3D""></div><div = class=3D"">see attached screenshot.</div><div class=3D""><br = class=3D""></div><div class=3D""><span = id=3D"cid:15bd472f669c80ce0602"><Screenshot from 2017-05-04 = 20-11-39.png></span><br class=3D""></div><div class=3D""><br = class=3D""></div><div class=3D"">Nir</div><br = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607inbox-inbox-Apple-interchange-newline"></div><blockquote = class=3D"gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; = border-left-width: 1px; border-left-color: rgb(204, 204, 204); = border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><div class=3D"">Is this more readable? If yes - I can = continue working in this direction to add gradients</div><div = class=3D"">and other patternfly style = elements. </div></div></blockquote><blockquote class=3D"gmail_quote" = style=3D"margin: 0px 0px 0px 0.8ex; border-left-width: 1px; = border-left-color: rgb(204, 204, 204); border-left-style: solid; = padding-left: 1ex;"><div dir=3D"ltr" class=3D""><div class=3D"">Otherwise = I'll just go with option 1 and stick to the default style we have = now.</div></div><div class=3D"gmail_extra"></div><div = class=3D"gmail_extra"><br class=3D""><div class=3D"gmail_quote">On Thu, = May 4, 2017 at 2:45 PM, Martin Sivak<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:msivak@redhat.com" target=3D"_blank" = class=3D"">msivak@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, = 204); border-left-style: solid; padding-left: 1ex;"><div dir=3D"ltr" = class=3D""><span class=3D"">> It will help if someone can suggest an = alternate CSS which we can use or specific color codes,<br class=3D""><div= class=3D"gmail_extra"><br class=3D""></div></span><div = class=3D"gmail_extra">Well.. keep it as it is or make it really dark = (like the patternfly menu). I do not care about logos but big area = filled with non-neutral color is always going to be an issue.</div><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203HOEnZb"><font color=3D"#888888" = class=3D""><div class=3D"gmail_extra"><br class=3D""></div><div = class=3D"gmail_extra">Martin</div></font></span><div class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203h5"><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote">On Thu, May 4, 2017 at 2:15 PM, = Eyal Edri<span class=3D"Apple-converted-space"> </span><span = dir=3D"ltr" class=3D""><<a href=3D"mailto:eedri@redhat.com" = target=3D"_blank" class=3D"">eedri@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote"><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-">On Thu, = May 4, 2017 at 3:05 PM, Martin Perina<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:mperina@redhat.com" target=3D"_blank" = class=3D"">mperina@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = dir=3D"ltr" class=3D""><div style=3D"font-family: arial, helvetica, = sans-serif;" class=3D"">I agree with Milan and Martin, even after few = minutes looking at it, the green<br class=3D"">with combination of white = background just made my eyes burning :-(<br class=3D""><br = class=3D""></div><div style=3D"font-family: arial, helvetica, = sans-serif;" class=3D"">Would it be possible to use more darker colors = (at least for top banner/menu)?<br class=3D"">For example darker colors = we use in oVirt engine welcome page ...</div></div></blockquote><div = class=3D""><br class=3D""></div></span><div class=3D"">Thanks for the = feedback,</div><div class=3D"">It will help if someone can suggest an = alternate CSS which we can use or specific color codes,</div><div = class=3D"">otherwise it will be long trial and error process until we'll = find something that will suite everyone.</div><div class=3D""><br = class=3D""></div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; = border-left-width: 1px; border-left-style: solid; border-left-color: = rgb(204, 204, 204); padding-left: 1ex;"><div class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-h5"><div = dir=3D"ltr" class=3D""><div style=3D"font-family: arial, helvetica, = sans-serif;" class=3D""><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-m_-84263310969= 79698991HOEnZb"><font color=3D"#888888" class=3D""><br class=3D""><br = class=3D""></font></span></div><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-m_-84263310969= 79698991HOEnZb"><font color=3D"#888888" class=3D""><div = style=3D"font-family: arial, helvetica, sans-serif;" class=3D"">Martin<br = class=3D""></div></font></span><div class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-m_-84263310969= 79698991h5"><div class=3D"gmail_extra"><br class=3D""><div = class=3D"gmail_quote">On Thu, May 4, 2017 at 5:53 AM, Martin Sivak<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:msivak@redhat.com" target=3D"_blank" = class=3D"">msivak@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;">I agree with = Milan here. The light green background makes the menu<br class=3D"">items = to be almost unreadable, the search button (slightly different<br = class=3D"">green color) blends with the background and generally the = color pulls<br class=3D"">my eyes away from the content. I wouldn't feel = comfortable looking at<br class=3D"">the screen for a whole day.<br = class=3D""><br class=3D"">Martin<br class=3D""><br class=3D"">On Thu, = May 4, 2017 at 9:57 AM, Milan Zamazal <<a = href=3D"mailto:mzamazal@redhat.com" target=3D"_blank" = class=3D"">mzamazal@redhat.com</a>> wrote:<br class=3D"">> Evgheni = Dereveanchin <<a href=3D"mailto:ederevea@redhat.com" target=3D"_blank" = class=3D"">ederevea@redhat.com</a>> writes:<br class=3D"">><br = class=3D"">>> The Infra team is working on customizing the look of = Gerrit to make it fit<br class=3D"">>> better with other oVirt = services. I want to share the result of this<br class=3D"">>> = effort. Hopefully we can gather some feedback before applying the design = to<br class=3D"">>> oVirt's instance of Gerrit.<br = class=3D"">>><br class=3D"">>> Please visit the Staging = instance to check it out:<br class=3D"">>><br = class=3D"">>>   <a = href=3D"https://gerrit-staging.phx.ovirt.org/" rel=3D"noreferrer" = target=3D"_blank" class=3D"">https://gerrit-staging.phx.ovirt.org/</a><br = class=3D"">><br class=3D"">> Thank you for the preview.  = While it fits better with oVirt services,<br class=3D"">> there is = one thing that makes me uncomfortable with it: low contrast.<br = class=3D"">> The top green bar is probably directly violating Web = Accessibility<br class=3D"">> Guidelines (AA level; see<br = class=3D"">><span class=3D"Apple-converted-space"> </span><a = href=3D"https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast</a= than in the current version.<br class=3D"">> So it would be nice if = the contrast could be improved.<br class=3D"">><br class=3D"">> = Thanks,<br class=3D"">> Milan<br class=3D"">> = _______________________________________________<br class=3D"">> Devel = mailing list<br class=3D"">><span = class=3D"Apple-converted-space"> </span><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D"">><span = class=3D"Apple-converted-space"> </span><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a><br = class=3D"">_______________________________________________<br = class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a><br = class=3D""></blockquote></div><br class=3D""></div></div></div></div><br = class=3D""></div></div><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-">____________= ___________________________________<br class=3D"">Infra mailing list<br = class=3D""><a href=3D"mailto:Infra@ovirt.org" target=3D"_blank" = class=3D"">Infra@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/infra" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/infra</a><br = class=3D""><br class=3D""></span></blockquote></div><br class=3D""><br = clear=3D"all" class=3D""><div class=3D""><br class=3D""></div>--<span = class=3D"Apple-converted-space"> </span><br class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203m_5203219111087275683gmail-m_-84263310969= 79698991gmail_signature"><div dir=3D"ltr" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D""><div = style=3D"font-family: overpass, sans-serif; margin: 0px; padding: 0px; = font-size: 14px; text-transform: uppercase; font-weight: bold;" = class=3D""><font color=3D"#cc0000" class=3D"">EYAL EDRI</font></div><div = style=3D"font-family: overpass, sans-serif; font-weight: bold; margin: = 0px; padding: 0px; font-size: 14px; text-transform: uppercase;" = class=3D""><br class=3D""></div><p style=3D"font-family: overpass, = sans-serif; font-size: 10px; margin: 0px 0px 4px; text-transform: = uppercase;" class=3D"">ASSOCIATE MANAGER</p><p style=3D"font-family: = overpass, sans-serif; font-size: 10px; margin: 0px 0px 4px; = text-transform: uppercase;" class=3D"">RHV DEVOPS</p><p = style=3D"font-family: overpass, sans-serif; font-size: 10px; margin: 0px = 0px 4px; text-transform: uppercase;" class=3D"">EMEA VIRTUALIZATION = R&D</p><p style=3D"font-family: overpass, sans-serif; font-size: = 10px; margin: 0px 0px 4px; text-transform: uppercase;" class=3D""><br = class=3D""></p><div style=3D"font-family: overpass, sans-serif; margin: = 0px; font-size: 10px; color: rgb(153, 153, 153);" class=3D""><a = href=3D"https://www.redhat.com/" target=3D"_blank" style=3D"color: = rgb(0, 136, 206); margin: 0px;" class=3D"">Red = Hat EMEA</a></div><table border=3D"0" style=3D"font-family: = overpass, sans-serif; font-size: inherit;" class=3D""><tbody = class=3D""><tr class=3D""><td width=3D"100px" class=3D""><a = href=3D"https://red.ht/sig" target=3D"_blank" style=3D"color: rgb(17, = 85, 204);" class=3D""><img = src=3D"https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red= -hat-black.png" width=3D"90" height=3D"auto" class=3D""></a></td><td = style=3D"font-size: 10px;" class=3D""><a = href=3D"https://redhat.com/trusted" target=3D"_blank" style=3D"color: = rgb(204, 0, 0); font-weight: bold;" class=3D"">TRIED. TESTED. = TRUSTED.</a></td></tr></tbody></table></div><div class=3D"">phone:<span = class=3D"Apple-converted-space"> </span><a = href=3D"tel:+972%209-769-2018" value=3D"+97297692018" target=3D"_blank" = class=3D"">+972-9-7692018</a><br class=3D"">irc: eedri (on #tlv = #rhev-dev = #rhev-integ)</div></div></div></div></div></div></div></div></div></div></= div></blockquote></div><br class=3D""></div></div></div></div><br = class=3D"">_______________________________________________<br = class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a><br = class=3D""></blockquote></div><br class=3D""><br clear=3D"all" = class=3D""><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747HOEnZb"><f= ont color=3D"#888888" class=3D""><div class=3D""><br = class=3D""></div></font></span></div><span = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747HOEnZb"><f= ont color=3D"#888888" class=3D""><div class=3D"gmail_extra">--<span = class=3D"Apple-converted-space"> </span><br class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_39543766= 73917468607m_-4381485728848953203gmail_signature" = data-smartmail=3D"gmail_signature"><div dir=3D"ltr" class=3D""><div = style=3D"font-size: small;" class=3D"">Regards,</div><div = style=3D"font-size: small;" class=3D"">Evgheni = Dereveanchin</div></div></div></div>______________________________________= _________<br class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a></font></span>= </blockquote></div></div><br = class=3D"">_______________________________________________<br = class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a><br = class=3D""></blockquote></div></div></div>________________________________= _______________<br class=3D"">Infra mailing list<br class=3D""><a = href=3D"mailto:Infra@ovirt.org" target=3D"_blank" = class=3D"">Infra@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/infra" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/infra</a><br = class=3D""></blockquote></div></div></div></div></div></blockquote></div><= br class=3D""><br clear=3D"all" class=3D""><div class=3D""><br = class=3D""></div></div></div><span = class=3D"m_-3562728657969669923m_-7223758443414663172HOEnZb"><font = color=3D"#888888" class=3D"">--<span = class=3D"Apple-converted-space"> </span><br class=3D""><div = class=3D"m_-3562728657969669923m_-7223758443414663172m_6817677305274670962= gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"">Greg Sheremeta, MBA<br class=3D""><span style=3D"font-size: = 12.8px;" class=3D"">Sr. Software Engineer</span><br class=3D""></div><div = class=3D"">Red Hat, Inc.<br class=3D""><a = href=3D"mailto:gshereme@redhat.com" target=3D"_blank" = class=3D"">gshereme@redhat.com</a><br = class=3D""></div></div></div></div></div></font></span></div><br = class=3D"">_______________________________________________<br = class=3D"">Devel mailing list<br class=3D""><a = href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/devel</a><br = class=3D""></blockquote></div></div></div><br class=3D""></div></div><br = class=3D"">_______________________________________________<br = class=3D"">Infra mailing list<br class=3D""><a = href=3D"mailto:Infra@ovirt.org" target=3D"_blank" = class=3D"">Infra@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/infra" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/infra</a><br = class=3D""><br class=3D""></blockquote></div><br class=3D""><br = clear=3D"all" class=3D""><br class=3D""></div><div = class=3D"gmail_extra">--<span = class=3D"Apple-converted-space"> </span><br class=3D""><div = class=3D"m_-3562728657969669923gmail_signature" = data-smartmail=3D"gmail_signature">Barak Korren<br class=3D"">RHV DevOps = team , RHCE, RHCi<br class=3D"">Red Hat EMEA<br class=3D""><a = href=3D"http://redhat.com/" target=3D"_blank" = class=3D"">redhat.com</a><span = class=3D"Apple-converted-space"> </span>| TRIED. TESTED. TRUSTED. = |<span class=3D"Apple-converted-space"> </span><a = href=3D"http://redhat.com/trusted" target=3D"_blank" = class=3D"">redhat.com/trusted</a></div></div>_____________________________= __________________<br class=3D"">Infra mailing list<br class=3D""><a = href=3D"mailto:Infra@ovirt.org" target=3D"_blank" = class=3D"">Infra@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/infra" rel=3D"noreferrer" = target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman/listinfo/infra</a></blockquote><= /div></div></blockquote></div><br class=3D""></div></body></html>= --Apple-Mail=_9FEF5EDD-0E48-4750-9A0E-CDBECAB98EE8--

Hi, it looks nice. Is there any plan * to actually deploy this skin on gerrit.ovirt.org? * skin new gerrit UI (PolyGerrit) as well? * use blue theme as webadmin recently adopted and VM Portal is going to adopt? Thanks Jakub On Wed, May 10, 2017 at 10:56 PM, Phillip Bailey <phbailey@redhat.com> wrote:

It looks great to me, except for one issue. The contrast between the box around the active item on the second row and the header background color is too low to make the active item easily identifiable. The same goes for the box on the first row, but the underline makes it a non-issue. I recommend either adding an underline to the second row active item or selecting a better background color for it.

-Phillip Bailey

On Mon, May 8, 2017 at 2:40 AM, Eldan Hildesheim <info@eldanet.com> wrote:

...

Hi, Can we insert a new css package easily? Perhaps I can merge Patternfly inside which will be very suitable for this case. E.

On May 7, 2017, at 11:41 PM, Roy Golan <rgolan@redhat.com> wrote:

The footer links are useful but the footer itself has no presence. Most dashboards will fill a page and with such a thin footer nobody is going to look at what is has to offer. So we can make the footer in a different color and noticeable etc or move the links to the header.

On Sun, May 7, 2017 at 10:35 AM Barak Korren <bkorren@redhat.com> wrote:

...

The current scheme seems a little buggy on FF. See how the top green bar is not stretched to cover the top of the oVirt logo.

On 6 May 2017 at 12:49, Yaniv Kaul <ykaul@redhat.com> wrote:

...

On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta <gshereme@redhat.com> wrote:

...

Here's my take.

The line on the top is a little thicker than I like, but we have the same thickness in oVirt (I checked). I'm ok with shrinking it in both places.

I put in the logo from the oVirt login page. I added patternfly and bootstrap. Changed the font to OpenSans. Positioned things and fixed paddings. Changed the button and form field to patternfly type (blue button)

Looks very good now. I wonder how far are we from being ADA compliant (also a general question to our UI - I know Patternfly should help us there as well). Y.

...

Best wishes, Greg

On Fri, May 5, 2017 at 2:15 AM, Roy Golan <rgolan@redhat.com> wrote:

...

Adding UX people +Eldan Hildesheim <info@eldanet.com> +Alexander Wels <awels@redhat.com> +Greg Sheremeta <gshereme@redhat.com>

On Fri, May 5, 2017 at 2:32 AM Martin Perina <mperina@redhat.com> wrote:

> On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer@redhat.com> wr > ote: > >> >> >> On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin < >> ederevea@redhat.com> wrote: >> >>> Thanks everyone for the great feedback! >>> >>> So there's two options I see now: >>> 1) keep the default header scheme with white background, just add >>> the project logo into the corner >>> 2) try to adapt to the Patternfly scheme as used in oVirt's Admin >>> UI currently. >>> >>> I've swapped the header background color to #393f45 as used in >>> oVirt for a quick test: >>> https://gerrit-staging.phx.ovirt.org/ >>> >> >> Looks good! >> > > ​Much better for my eyes now, thanks a lot! > ​ > > >> >> The oVirt logo needs little more space around it, and it also >> should be centered vertically. >> Modifying the logo margin to 8px and width to 108px works for me >> using chrome, >> see attached screenshot. >> >> <Screenshot from 2017-05-04 20-11-39.png> >> >> Nir >> >> Is this more readable? If yes - I can continue working in this >>> direction to add gradients >>> and other patternfly style elements. >>> >> Otherwise I'll just go with option 1 and stick to the default style >>> we have now. >>> >>> On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> >>> wrote: >>> >>>> > It will help if someone can suggest an alternate CSS which we >>>> can use or specific color codes, >>>> >>>> Well.. keep it as it is or make it really dark (like the >>>> patternfly menu). I do not care about logos but big area filled with >>>> non-neutral color is always going to be an issue. >>>> >>>> Martin >>>> >>>> On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Thu, May 4, 2017 at 3:05 PM, Martin Perina < >>>>> mperina@redhat.com> wrote: >>>>> >>>>>> I agree with Milan and Martin, even after few minutes looking >>>>>> at it, the green >>>>>> with combination of white background just made my eyes burning >>>>>> :-( >>>>>> >>>>>> Would it be possible to use more darker colors (at least for >>>>>> top banner/menu)? >>>>>> For example darker colors we use in oVirt engine welcome page >>>>>> ... >>>>>> >>>>> >>>>> Thanks for the feedback, >>>>> It will help if someone can suggest an alternate CSS which we >>>>> can use or specific color codes, >>>>> otherwise it will be long trial and error process until we'll >>>>> find something that will suite everyone. >>>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>> Martin >>>>>> >>>>>> On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com >>>>>> > wrote: >>>>>> >>>>>>> I agree with Milan here. The light green background makes the >>>>>>> menu >>>>>>> items to be almost unreadable, the search button (slightly >>>>>>> different >>>>>>> green color) blends with the background and generally the >>>>>>> color pulls >>>>>>> my eyes away from the content. I wouldn't feel comfortable >>>>>>> looking at >>>>>>> the screen for a whole day. >>>>>>> >>>>>>> Martin >>>>>>> >>>>>>> On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal < >>>>>>> mzamazal@redhat.com> wrote: >>>>>>> > Evgheni Dereveanchin <ederevea@redhat.com> writes: >>>>>>> > >>>>>>> >> The Infra team is working on customizing the look of Gerrit >>>>>>> to make it fit >>>>>>> >> better with other oVirt services. I want to share the >>>>>>> result of this >>>>>>> >> effort. Hopefully we can gather some feedback before >>>>>>> applying the design to >>>>>>> >> oVirt's instance of Gerrit. >>>>>>> >> >>>>>>> >> Please visit the Staging instance to check it out: >>>>>>> >> >>>>>>> >> https://gerrit-staging.phx.ovirt.org/ >>>>>>> > >>>>>>> > Thank you for the preview. While it fits better with oVirt >>>>>>> services, >>>>>>> > there is one thing that makes me uncomfortable with it: low >>>>>>> contrast. >>>>>>> > The top green bar is probably directly violating Web >>>>>>> Accessibility >>>>>>> > Guidelines (AA level; see >>>>>>> > https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), >>>>>>> but I >>>>>>> > find all the green parts harder to read than in the current >>>>>>> version. >>>>>>> > So it would be nice if the contrast could be improved. >>>>>>> > >>>>>>> > Thanks, >>>>>>> > Milan >>>>>>> > _______________________________________________ >>>>>>> > Devel mailing list >>>>>>> > Devel@ovirt.org >>>>>>> > http://lists.ovirt.org/mailman/listinfo/devel >>>>>>> _______________________________________________ >>>>>>> Devel mailing list >>>>>>> Devel@ovirt.org >>>>>>> http://lists.ovirt.org/mailman/listinfo/devel >>>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Infra mailing list >>>>>> Infra@ovirt.org >>>>>> http://lists.ovirt.org/mailman/listinfo/infra >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> EYAL EDRI >>>>> >>>>> ASSOCIATE MANAGER >>>>> >>>>> RHV DEVOPS >>>>> >>>>> EMEA VIRTUALIZATION R&D >>>>> >>>>> >>>>> Red Hat EMEA <https://www.redhat.com/> >>>>> <https://red.ht/sig> TRIED. TESTED. TRUSTED. >>>>> <https://redhat.com/trusted> >>>>> phone: +972-9-7692018 <+972%209-769-2018> >>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ) >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Devel mailing list >>>> Devel@ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/devel >>>> >>> >>> >>> >>> -- >>> Regards, >>> Evgheni Dereveanchin >>> _______________________________________________ >>> Devel mailing list >>> Devel@ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >>> >> >> _______________________________________________ >> Devel mailing list >> Devel@ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > _______________________________________________ > Infra mailing list > Infra@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra >

-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

On Wed, Sep 6, 2017 at 3:14 AM, Barak Korren <bkorren@redhat.com> wrote:

On 5 September 2017 at 21:37, Jakub Niedermertl <jniederm@redhat.com> wrote:

...

Hi,

it looks nice.

Is there any plan * to actually deploy this skin on gerrit.ovirt.org?

Given the huge amount of time that was already invested in this, and the endless list of issues raised on this thread, we froze further progress.

It would be great if someone with better UX skills could step up and continue this work. (Which includes actually writing the needed CSS and HTML and not just sending mockups...)

I can do it. But ...

...

* skin new gerrit UI (PolyGerrit) as well?

It a completely new code base, we will need to redo everything from scratch. But we probably aught to do that, because it seems like the way forward for Gerrit.

Shouldn't we just cut over and do the work once?

...

* use blue theme as webadmin recently adopted and VM Portal is going to adopt?

IMO it would look out of place with the other oVirt web assets. Personally I don't like WebAdmin going that way either. oVirt had always been green, its part of its brand. To change this, everything else needs to also change: ovirt.org, Jenkins, Jira, etc.

-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- GREG SHEREMETA SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX Red Hat <https://www.redhat.com/> gshereme@redhat.com IRC: gshereme <https://red.ht/sig>

On Wed, Sep 6, 2017 at 4:17 PM, Greg Sheremeta <gshereme@redhat.com> wrote:

On Wed, Sep 6, 2017 at 3:14 AM, Barak Korren <bkorren@redhat.com> wrote:

...

On 5 September 2017 at 21:37, Jakub Niedermertl <jniederm@redhat.com> wrote:

...

Hi,

it looks nice.

Is there any plan * to actually deploy this skin on gerrit.ovirt.org?

Given the huge amount of time that was already invested in this, and the endless list of issues raised on this thread, we froze further progress.

It would be great if someone with better UX skills could step up and continue this work. (Which includes actually writing the needed CSS and HTML and not just sending mockups...)

I can do it. But ...

...

...

* skin new gerrit UI (PolyGerrit) as well?

It a completely new code base, we will need to redo everything from scratch. But we probably aught to do that, because it seems like the way forward for Gerrit.

Shouldn't we just cut over and do the work once?

+1

...

...

* use blue theme as webadmin recently adopted and VM Portal is going to adopt?

IMO it would look out of place with the other oVirt web assets. Personally I don't like WebAdmin going that way either. oVirt had always been green, its part of its brand. To change this, everything else needs to also change: ovirt.org, Jenkins, Jira, etc.

-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

--

GREG SHEREMETA

SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX

Red Hat

<https://www.redhat.com/>

gshereme@redhat.com IRC: gshereme <https://red.ht/sig>

I really like the colors on the patternfly scheme. Great job! On Thu, May 4, 2017 at 9:25 AM, Evgheni Dereveanchin <ederevea@redhat.com> wrote:

Thanks everyone for the great feedback!

So there's two options I see now: 1) keep the default header scheme with white background, just add the project logo into the corner 2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently.

I've swapped the header background color to #393f45 as used in oVirt for a quick test: https://gerrit-staging.phx.ovirt.org/

Is this more readable? If yes - I can continue working in this direction to add gradients and other patternfly style elements. Otherwise I'll just go with option 1 and stick to the default style we have now.

On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak@redhat.com> wrote:

...

...

It will help if someone can suggest an alternate CSS which we can use or specific color codes,

Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue.

Martin

On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri@redhat.com> wrote:

...

On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina@redhat.com> wrote:

...

I agree with Milan and Martin, even after few minutes looking at it, the green with combination of white background just made my eyes burning :-(

Would it be possible to use more darker colors (at least for top banner/menu)? For example darker colors we use in oVirt engine welcome page ...

Thanks for the feedback, It will help if someone can suggest an alternate CSS which we can use or specific color codes, otherwise it will be long trial and error process until we'll find something that will suite everyone.

...

Martin

On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak@redhat.com> wrote:

...

I agree with Milan here. The light green background makes the menu items to be almost unreadable, the search button (slightly different green color) blends with the background and generally the color pulls my eyes away from the content. I wouldn't feel comfortable looking at the screen for a whole day.

Martin

On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <mzamazal@redhat.com> wrote:

...

Evgheni Dereveanchin <ederevea@redhat.com> writes:

> The Infra team is working on customizing the look of Gerrit to make it fit > better with other oVirt services. I want to share the result of this > effort. Hopefully we can gather some feedback before applying the design to > oVirt's instance of Gerrit. > > Please visit the Staging instance to check it out: > > https://gerrit-staging.phx.ovirt.org/

Thank you for the preview. While it fits better with oVirt services, there is one thing that makes me uncomfortable with it: low contrast. The top green bar is probably directly violating Web Accessibility Guidelines (AA level; see https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast), but I find all the green parts harder to read than in the current version. So it would be nice if the contrast could be improved.

Thanks, Milan _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

---

Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

--

Eyal edri

ASSOCIATE MANAGER

RHV DevOps

EMEA VIRTUALIZATION R&D

Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Regards, Evgheni Dereveanchin

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Adam Litke

On 5 September 2017 at 22:23, Yaniv Lavi (Dary) <ylavi@redhat.com> wrote:

It also doesn't render well on Chrome mobile. Can you fix that?

Gerrit old UI is not meant for mobile devices so no. Try the new (PolyGerrit) UI, there is a link in the bottom-right leading to it. -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted