[review][vdsm] please review https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open
Hi everyone, https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open is ready for review. It is the first part of the series needed to consume the BLOCK_THRESHOLD event available with libvirt >= 3.2.0 and QEMU >= 2.3.0. Once completed, this patchset will allow Vdsm to avoid polling, thus greatly improving the system performance and eventually close https://bugzilla.redhat.com/show_bug.cgi?id=1181665 Please note that: 1. CI fails because the workers are not yet updated to CentOS 7.4 (not yet released AFAIK!) which will provide libvirt >= 3.2.0. 2. Few more simple patches will be needed to enable/disable monitoring in specific flows where we cannot use events (e.g. LSM) 3. I did initial verification successfully, installing fedora 25 on thin provisioned disk without issue. -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
On Mon, Sep 11, 2017 at 2:02 PM, Francesco Romani <fromani@redhat.com> wrote:
Hi everyone,
https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open is ready for review. It is the first part of the series needed
to consume the BLOCK_THRESHOLD event available with libvirt >= 3.2.0 and QEMU >= 2.3.0.
Once completed, this patchset will allow Vdsm to avoid polling, thus greatly improving the system performance and
eventually close https://bugzilla.redhat.com/show_bug.cgi?id=1181665
Please note that:
1. CI fails because the workers are not yet updated to CentOS 7.4 (not yet released AFAIK!) which will provide libvirt >= 3.2.0.
You probably know that already, but just to be sure, please wait for official CentOS 7.4 be out and that we'll verify OST works well with it before merging, otherwise any patch that will be merged afterwards will fail and CI won't work. AFAIK, it should be out this week.
2. Few more simple patches will be needed to enable/disable monitoring in specific flows where we cannot use events (e.g. LSM)
3. I did initial verification successfully, installing fedora 25 on thin provisioned disk without issue.
-- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal edri ASSOCIATE MANAGER RHV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
This is a multi-part message in MIME format. --------------1E2632E836D8A74038541936 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 09/11/2017 01:16 PM, Eyal Edri wrote:
On Mon, Sep 11, 2017 at 2:02 PM, Francesco Romani <fromani@redhat.com <mailto:fromani@redhat.com>> wrote:
Hi everyone,
https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open <https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open> is ready for review. It is the first part of the series needed
to consume the BLOCK_THRESHOLD event available with libvirt >= 3.2.0 and QEMU >= 2.3.0.
Once completed, this patchset will allow Vdsm to avoid polling, thus greatly improving the system performance and
eventually close https://bugzilla.redhat.com/show_bug.cgi?id=1181665 <https://bugzilla.redhat.com/show_bug.cgi?id=1181665>
Please note that:
1. CI fails because the workers are not yet updated to CentOS 7.4 (not yet released AFAIK!) which will provide libvirt >= 3.2.0.
You probably know that already, but just to be sure, please wait for official CentOS 7.4 be out and that we'll verify OST works well with it before merging, otherwise any patch that will be merged afterwards will fail and CI won't work.
AFAIK, it should be out this week.
Sure thing. Will not merge before OST and CI both pass. But it is totally reviewable while we wait! :) Bests, -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh --------------1E2632E836D8A74038541936 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body bgcolor="#FFFFFF" text="#000000"> <br> <div class="moz-cite-prefix">On 09/11/2017 01:16 PM, Eyal Edri wrote:<br> </div> <blockquote type="cite" cite="mid:CACuV_Hoq2i+v+WLYaoGLF1wF1veZRdXzGnJb+b_oyJm5wLiGqQ@mail.gmail.com"> <div dir="ltr"><br> <div class="gmail_extra"><br> <div class="gmail_quote">On Mon, Sep 11, 2017 at 2:02 PM, Francesco Romani <span dir="ltr"><<a href="mailto:fromani@redhat.com" target="_blank" moz-do-not-send="true">fromani@redhat.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi everyone,<br> <br> <br> <a href="https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open" rel="noreferrer" target="_blank" moz-do-not-send="true">https://gerrit.ovirt.org/#/q/<wbr>topic:drivemonitor_event+<wbr>status:open</a> is<br> ready for review. It is the first part of the series needed<br> <br> to consume the BLOCK_THRESHOLD event available with libvirt >= 3.2.0 and<br> QEMU >= 2.3.0.<br> <br> Once completed, this patchset will allow Vdsm to avoid polling, thus<br> greatly improving the system performance and<br> <br> eventually close <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1181665" rel="noreferrer" target="_blank" moz-do-not-send="true">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1181665</a><br> <br> <br> Please note that:<br> <br> 1. CI fails because the workers are not yet updated to CentOS 7.4 (not<br> yet released AFAIK!) which will provide libvirt >= 3.2.0.<br> </blockquote> <div><br> </div> <div>You probably know that already, but just to be sure, please wait for official CentOS 7.4 be out and that we'll verify OST works well with it</div> <div>before merging, otherwise any patch that will be merged afterwards will fail and CI won't work.</div> <div><br> </div> <div>AFAIK, it should be out this week.</div> <div> <br> </div> </div> <br> </div> </div> </blockquote> <br> Sure thing. Will not merge before OST and CI both pass. But it is totally reviewable while we wait! :)<br> <br> Bests,<br> <pre class="moz-signature" cols="72">-- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh</pre> </body> </html> --------------1E2632E836D8A74038541936--
The patches are on my queue for next week. On Mon, Sep 11, 2017 at 2:02 PM Francesco Romani <fromani@redhat.com> wrote:
Hi everyone,
https://gerrit.ovirt.org/#/q/topic:drivemonitor_event+status:open is ready for review. It is the first part of the series needed
to consume the BLOCK_THRESHOLD event available with libvirt >= 3.2.0 and QEMU >= 2.3.0.
Once completed, this patchset will allow Vdsm to avoid polling, thus greatly improving the system performance and
eventually close https://bugzilla.redhat.com/show_bug.cgi?id=1181665
Please note that:
1. CI fails because the workers are not yet updated to CentOS 7.4 (not yet released AFAIK!) which will provide libvirt >= 3.2.0.
2. Few more simple patches will be needed to enable/disable monitoring in specific flows where we cannot use events (e.g. LSM)
3. I did initial verification successfully, installing fedora 25 on thin provisioned disk without issue.
-- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh
participants (3)
-
Eyal Edri -
Francesco Romani -
Nir Soffer