Hi all, After you fetch and rebase, please run the db upgrade script located at ovrit_engine/backend/manager/dbscripts Kind regards, Yair

----- Original Message ----- > From: "Livnat Peer"<lpeer(a)redhat.com> > To: "Yair Zaslavsky"<yzaslavs(a)redhat.com> > Cc: engine-devel(a)ovirt.org > Sent: Sunday, November 20, 2011 11:29:34 AM > Subject: Re: [Engine-devel] Please run the upgrade script > > On 11/20/2011 10:45 AM, Yair Zaslavsky wrote: >> Hi all, >> After you fetch and rebase, please run the db upgrade script >> located at >> >> ovrit_engine/backend/manager/dbscripts >> >> Kind regards, >> >> Yair > > Hi Yair, > > I think that running db upgrade script should be part of the routine > procedure of getting the latest code. > The upgrading script is re-entrant and should not cause issues if > using > it on any fetch. right, actually even right now we can automate it from maven using the Maven EXEC plugin http://mojo.codehaus.org/exec-maven-plugin/ I have thought about it as a part of Flyway integration.

> > I added "getting latest" section in the wiki - > http://www.ovirt.org/wiki/Building_oVirt_engine#Getting_Latest > > > Thanks, Livnat > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

On 11/20/2011 01:35 PM, Eli Mesika wrote: > > > ----- Original Message ----- >> From: "Livnat Peer" <lpeer(a)redhat.com&gt; >> To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; >> Cc: engine-devel(a)ovirt.org >> Sent: Sunday, November 20, 2011 11:29:34 AM >> Subject: Re: [Engine-devel] Please run the upgrade script >> >> On 11/20/2011 10:45 AM, Yair Zaslavsky wrote: >>> Hi all, >>> After you fetch and rebase, please run the db upgrade script >>> located at >>> >>> ovrit_engine/backend/manager/dbscripts >>> >>> Kind regards, >>> >>> Yair >> >> Hi Yair, >> >> I think that running db upgrade script should be part of the routine >> procedure of getting the latest code. >> The upgrading script is re-entrant and should not cause issues if >> using >> it on any fetch. > > right, actually even right now we can automate it from maven using the Maven EXEC plugin > http://mojo.codehaus.org/exec-maven-plugin/ > > I have thought about it as a part of Flyway integration. > > +1 For upgrading DB automatically. I think, that if we plan to update the DB from the maven build command, we should also take in consider adding a parameter indicating when we prefer not to run the upgrade script at each build (same as skipTests). Since after first git fetch, DB should not be changed.

>> >> I added "getting latest" section in the wiki - >> http://www.ovirt.org/wiki/Building_oVirt_engine#Getting_Latest >> >> >> Thanks, Livnat >> >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message ----- > From: "Livnat Peer" <lpeer(a)redhat.com&gt; > To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > Cc: engine-devel(a)ovirt.org > Sent: Sunday, November 20, 2011 11:29:34 AM > Subject: Re: [Engine-devel] Please run the upgrade script > > On 11/20/2011 10:45 AM, Yair Zaslavsky wrote: >> Hi all, >> After you fetch and rebase, please run the db upgrade script >> located at >> >> ovrit_engine/backend/manager/dbscripts >> >> Kind regards, >> >> Yair > > Hi Yair, > > I think that running db upgrade script should be part of the routine > procedure of getting the latest code. > The upgrading script is re-entrant and should not cause issues if > using > it on any fetch. > > I added "getting latest" section in the wiki - > http://www.ovirt.org/wiki/Building_oVirt_engine#Getting_Latest cool, shouldn't it be there: $> cd $OVIRT_HOME/backend/manager/dbscripts/ $> ./upgrade.sh -u postgres (at least until we change it to use maven)

> > > Thanks, Livnat > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >