From: "Oved Ourfali" <ovedo(a)redhat.com&gt; To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; Cc: devel(a)ovirt.org Sent: Thursday, June 25, 2015 11:03:46 AM Subject: Re: [ovirt-devel] engine-setup broken in master? Hi I've just checked-out latest master, built the engine, targeting a new directory, new DB schema, and it worked well. Can you re-test it? Thanks, Oved

----- Original Message ----- > From: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > To: devel(a)ovirt.org > Sent: Thursday, June 25, 2015 10:37:55 AM > Subject: [ovirt-devel] engine-setup broken in master? > > Hi, > on latest master, engine-setup fails for me with: > [ ERROR ] Failed to execute stage 'Setup validation': Failed checking > Engine > database: [u''] > > from the setup log: > > 2015-06-25 10:27:51 DEBUG > otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations > plugin.execute:940 execute-output: > ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu > tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', > '--port=5432', '--database=**FILTERED**', > '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506 > 25102702-nwwazb.log'] stderr: > ERROR: function fn_db_validate_fks(boolean, boolean) does not exist > LINE 3: from fn_db_validate_fks(false, 0 != 0) > ^ > HINT: No function matches the given name and argument types. You might > need > to add explicit type casts. > > 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method > exception > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/otopi/context.py", line 145, in > _executeMethod > method['method']() > File > "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", > line 128, in _validation > violations, issues_found = self._checkDb() > File > "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", > line 91, in _checkDb > output=stdout, > RuntimeError: Failed checking Engine database: > [u''] > > 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed > to > execute stage 'Setup validation': Failed checking Engine database: > [u''] > > ---- > > looks like lately this function (fn_db_validate_fks) was moved, might be > related? > ( https://gerrit.ovirt.org/#/c/42655/ ) > > i even tried to completely remove my ~/ovirt-engine/ folder and create from > scratch > > anyone else experienced this? > > Thanks, > Omer. > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >

Hi, on latest master, engine-setup fails for me with: [ ERROR ] Failed to execute stage 'Setup validation': Failed checking Engine database: [u''] from the setup log: 2015-06-25 10:27:51 DEBUG otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations plugin.execute:940 execute-output: ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', '--port=5432', '--database=**FILTERED**', '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506 25102702-nwwazb.log'] stderr: ERROR: function fn_db_validate_fks(boolean, boolean) does not exist LINE 3: from fn_db_validate_fks(false, 0 != 0) ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts. 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method exception Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/otopi/context.py", line 145, in _executeMethod method['method']() File "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", line 128, in _validation violations, issues_found = self._checkDb() File "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", line 91, in _checkDb output=stdout, RuntimeError: Failed checking Engine database: [u''] 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed to execute stage 'Setup validation': Failed checking Engine database: [u''] ---- looks like lately this function (fn_db_validate_fks) was moved, might be related? ( https://gerrit.ovirt.org/#/c/42655/ ) i even tried to completely remove my ~/ovirt-engine/ folder and create from scratch anyone else experienced this? Thanks, Omer. _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

From: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; To: "Roy Golan" <rgolan(a)redhat.com&gt; Cc: devel(a)ovirt.org Sent: Thursday, June 25, 2015 11:16:23 AM Subject: Re: [ovirt-devel] engine-setup broken in master? ----- Original Message ----- > From: "Roy Golan" <rgolan(a)redhat.com&gt; > To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt;, devel(a)ovirt.org > Sent: Thursday, June 25, 2015 11:07:40 AM > Subject: Re: [ovirt-devel] engine-setup broken in master? > > Dudi hit the same issue. > > On 06/25/2015 10:37 AM, Omer Frenkel wrote: > > Hi, > > on latest master, engine-setup fails for me with: > > [ ERROR ] Failed to execute stage 'Setup validation': Failed checking > > Engine database: [u''] > > > > from the setup log: > > > > 2015-06-25 10:27:51 DEBUG > > otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations > > plugin.execute:940 execute-output: > > ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu > > tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', > > '--port=5432', '--database=**FILTERED**', > > '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506 > > 25102702-nwwazb.log'] stderr: > > ERROR: function fn_db_validate_fks(boolean, boolean) does not exist > > LINE 3: from fn_db_validate_fks(false, 0 != 0) > > ^ > > HINT: No function matches the given name and argument types. You might > > need to add explicit type casts.

> > > > 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method > > exception > > Traceback (most recent call last): > > File "/usr/lib/python2.7/site-packages/otopi/context.py", line 145, in > > _executeMethod > > method['method']() > > File > > "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", > > line 128, in _validation > > violations, issues_found = self._checkDb() > > File > > "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", > > line 91, in _checkDb > > output=stdout, > > RuntimeError: Failed checking Engine database: > > [u''] > > > > 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed > > to execute stage 'Setup validation': Failed checking Engine database: > > [u''] > > > > ---- > > > > looks like lately this function (fn_db_validate_fks) was moved, might be > > related? > > ( https://gerrit.ovirt.org/#/c/42655/ ) > > > > i even tried to completely remove my ~/ovirt-engine/ folder and create > > from > > scratch > > > > anyone else experienced this? > > > > Thanks, > > Omer. > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > manually running the script [1] fixed it, but upgrade is broken [1] psql -f packaging/dbscripts/fkvalidator_sp.sql _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

----- Original Message ----- > From: "Eli Mesika" <emesika(a)redhat.com&gt; > To: "Yedidyah Bar David" <didi(a)redhat.com&gt; > Cc: "Roy Golan" <rgolan(a)redhat.com&gt;, devel(a)ovirt.org, "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > Sent: Thursday, June 25, 2015 3:57:18 PM > Subject: Re: [ovirt-devel] engine-setup broken in master? > > > > ----- Original Message ----- >> From: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; >> To: "Roy Golan" <rgolan(a)redhat.com&gt; >> Cc: devel(a)ovirt.org >> Sent: Thursday, June 25, 2015 11:16:23 AM >> Subject: Re: [ovirt-devel] engine-setup broken in master? >> >> >> >> ----- Original Message ----- >>> From: "Roy Golan" <rgolan(a)redhat.com&gt; >>> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt;, devel(a)ovirt.org >>> Sent: Thursday, June 25, 2015 11:07:40 AM >>> Subject: Re: [ovirt-devel] engine-setup broken in master? >>> >>> Dudi hit the same issue. >>> >>> On 06/25/2015 10:37 AM, Omer Frenkel wrote: >>>> Hi, >>>> on latest master, engine-setup fails for me with: >>>> [ ERROR ] Failed to execute stage 'Setup validation': Failed checking >>>> Engine database: [u''] >>>> >>>> from the setup log: >>>> >>>> 2015-06-25 10:27:51 DEBUG >>>> otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations >>>> plugin.execute:940 execute-output: >>>> ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu >>>> tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', >>>> '--port=5432', '--database=**FILTERED**', >>>> '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506 >>>> 25102702-nwwazb.log'] stderr: >>>> ERROR: function fn_db_validate_fks(boolean, boolean) does not exist >>>> LINE 3: from fn_db_validate_fks(false, 0 != 0) >>>> ^ >>>> HINT: No function matches the given name and argument types. You might >>>> need to add explicit type casts. > > Didi, we concluded that engine-setup is responding for installing the SPs, > can you please check on upgrade scenario if the call for fkvalidaor script > is done before SPs are installed It is, actually. It's called during the validation stage, and the schema is upgraded only later. Now talked with Eli in private and we agreed to patch engine-setup to load them prior to calling it. I'll do that next week.

> >>>> >>>> 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 >>>> method >>>> exception >>>> Traceback (most recent call last): >>>> File "/usr/lib/python2.7/site-packages/otopi/context.py", line 145, >>>> in >>>> _executeMethod >>>> method['method']() >>>> File >>>> "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", >>>> line 128, in _validation >>>> violations, issues_found = self._checkDb() >>>> File >>>> "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", >>>> line 91, in _checkDb >>>> output=stdout, >>>> RuntimeError: Failed checking Engine database: >>>> [u''] >>>> >>>> 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 >>>> Failed >>>> to execute stage 'Setup validation': Failed checking Engine database: >>>> [u''] >>>> >>>> ---- >>>> >>>> looks like lately this function (fn_db_validate_fks) was moved, might >>>> be >>>> related? >>>> ( https://gerrit.ovirt.org/#/c/42655/ ) >>>> >>>> i even tried to completely remove my ~/ovirt-engine/ folder and create >>>> from >>>> scratch >>>> >>>> anyone else experienced this? >>>> >>>> Thanks, >>>> Omer. >>>> _______________________________________________ >>>> Devel mailing list >>>> Devel(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/devel >>> >>> >> >> >> manually running the script [1] fixed it, but upgrade is broken >> >> [1] psql -f packaging/dbscripts/fkvalidator_sp.sql >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> >

From: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; To: "Yedidyah Bar David" <didi(a)redhat.com&gt;, "Eli Mesika" <emesika(a)redhat.com&gt; Cc: devel(a)ovirt.org, "Max Kovgan" <mkovgan(a)redhat.com&gt; Sent: Thursday, June 25, 2015 6:11:30 PM Subject: Re: [ovirt-devel] engine-setup broken in master? Il 25/06/2015 16:47, Yedidyah Bar David ha scritto: > ----- Original Message ----- >> From: "Eli Mesika" <emesika(a)redhat.com&gt; >> To: "Yedidyah Bar David" <didi(a)redhat.com&gt; >> Cc: "Roy Golan" <rgolan(a)redhat.com&gt;, devel(a)ovirt.org, "Omer Frenkel" >> <ofrenkel(a)redhat.com&gt; >> Sent: Thursday, June 25, 2015 3:57:18 PM >> Subject: Re: [ovirt-devel] engine-setup broken in master? >> >> >> >> ----- Original Message ----- >>> From: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; >>> To: "Roy Golan" <rgolan(a)redhat.com&gt; >>> Cc: devel(a)ovirt.org >>> Sent: Thursday, June 25, 2015 11:16:23 AM >>> Subject: Re: [ovirt-devel] engine-setup broken in master? >>> >>> >>> >>> ----- Original Message ----- >>>> From: "Roy Golan" <rgolan(a)redhat.com&gt; >>>> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt;, devel(a)ovirt.org >>>> Sent: Thursday, June 25, 2015 11:07:40 AM >>>> Subject: Re: [ovirt-devel] engine-setup broken in master? >>>> >>>> Dudi hit the same issue. >>>> >>>> On 06/25/2015 10:37 AM, Omer Frenkel wrote: >>>>> Hi, >>>>> on latest master, engine-setup fails for me with: >>>>> [ ERROR ] Failed to execute stage 'Setup validation': Failed checking >>>>> Engine database: [u''] >>>>> >>>>> from the setup log: >>>>> >>>>> 2015-06-25 10:27:51 DEBUG >>>>> otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations >>>>> plugin.execute:940 execute-output: >>>>> ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu >>>>> tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost', >>>>> '--port=5432', '--database=**FILTERED**', >>>>> '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506 >>>>> 25102702-nwwazb.log'] stderr: >>>>> ERROR: function fn_db_validate_fks(boolean, boolean) does not exist >>>>> LINE 3: from fn_db_validate_fks(false, 0 != 0) >>>>> ^ >>>>> HINT: No function matches the given name and argument types. You might >>>>> need to add explicit type casts. >> >> Didi, we concluded that engine-setup is responding for installing the SPs, >> can you please check on upgrade scenario if the call for fkvalidaor script >> is done before SPs are installed > > It is, actually. It's called during the validation stage, and the schema > is upgraded only later. > > Now talked with Eli in private and we agreed to patch engine-setup to > load them prior to calling it. I'll do that next week. Looks like it's hitting more people, we have a BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1235707 Adding Max, not sure this will block 3.6.0 second alpha or not (along with the other issues he already found).

> >> >>>>> >>>>> 2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 >>>>> method >>>>> exception >>>>> Traceback (most recent call last): >>>>> File "/usr/lib/python2.7/site-packages/otopi/context.py", line 145, >>>>> in >>>>> _executeMethod >>>>> method['method']() >>>>> File >>>>> "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", >>>>> line 128, in _validation >>>>> violations, issues_found = self._checkDb() >>>>> File >>>>> "/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py", >>>>> line 91, in _checkDb >>>>> output=stdout, >>>>> RuntimeError: Failed checking Engine database: >>>>> [u''] >>>>> >>>>> 2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 >>>>> Failed >>>>> to execute stage 'Setup validation': Failed checking Engine database: >>>>> [u''] >>>>> >>>>> ---- >>>>> >>>>> looks like lately this function (fn_db_validate_fks) was moved, might >>>>> be >>>>> related? >>>>> ( https://gerrit.ovirt.org/#/c/42655/ ) >>>>> >>>>> i even tried to completely remove my ~/ovirt-engine/ folder and create >>>>> from >>>>> scratch >>>>> >>>>> anyone else experienced this? >>>>> >>>>> Thanks, >>>>> Omer. >>>>> _______________________________________________ >>>>> Devel mailing list >>>>> Devel(a)ovirt.org >>>>> http://lists.ovirt.org/mailman/listinfo/devel >>>> >>>> >>> >>> >>> manually running the script [1] fixed it, but upgrade is broken >>> >>> [1] psql -f packaging/dbscripts/fkvalidator_sp.sql >>> _______________________________________________ >>> Devel mailing list >>> Devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >>> >> > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com