OST broken - looks like https://gerrit.ovirt.org/c/99717 is the reason

Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293 I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717 Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/ 2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34 Dan, can you take a look at this? Nir

On Thu, 2 May 2019, 18:53 Nir Soffer, <nsoffer@redhat.com> wrote:
Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293
I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717
Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/
2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34
Dan, can you take a look at this?
Wat?! I don't understand how it passed vdsm CI. worst case I'll revert.
Nir

if you mean CQ then it did not pass CI - I sent you a mail to look at your patch as it was failing CQ On Thu, May 2, 2019 at 7:29 PM Dan Kenigsberg <danken@redhat.com> wrote:
On Thu, 2 May 2019, 18:53 Nir Soffer, <nsoffer@redhat.com> wrote:
Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293
I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717
Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/
2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34
Dan, can you take a look at this?
Wat?! I don't understand how it passed vdsm CI.
worst case I'll revert.
Nir

On Thu, May 2, 2019 at 7:29 PM Dan Kenigsberg <danken@redhat.com> wrote:
On Thu, 2 May 2019, 18:53 Nir Soffer, <nsoffer@redhat.com> wrote:
Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293
I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717
Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/
2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34
Dan, can you take a look at this?
Wat?! I don't understand how it passed vdsm CI.
Maybe we are not using the same repos? (e.g. testing in CI, stable in OST) It is sad that passing our install check is not accurate enough, and we need to fix it, but lets first revert the patch to unblock other work.
worst case I'll revert.
Nir

Hi, there's one issue with 'python2-enum34' - it's an 'epel' package. I don't know if it's going to land in 'base' repository, but until then I think we should rely on 'python-enum34'. On 5/2/19 6:41 PM, Nir Soffer wrote:
On Thu, May 2, 2019 at 7:29 PM Dan Kenigsberg <danken@redhat.com <mailto:danken@redhat.com>> wrote:
On Thu, 2 May 2019, 18:53 Nir Soffer, <nsoffer@redhat.com <mailto:nsoffer@redhat.com>> wrote:
Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293
I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717
Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/
2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34
Dan, can you take a look at this?
Wat?! I don't understand how it passed vdsm CI.
Maybe we are not using the same repos? (e.g. testing in CI, stable in OST)
It is sad that passing our install check is not accurate enough
Acually everything worked fine in our 'check-install'. If you take a look at a test patch I've made: https://gerrit.ovirt.org/#/c/99809/ You can see that we install 'python2-enum34' when building artifacts with 'yum-builddep' because it's a build dependency - that's the reason it's not listed as a requirement when installing built 'vdsm-*' packages - it's already there. Both 'rpm -q python2-enum34' and 'repoquery -i python2-enum34' succeed - they show 'python2-enum34's origin as 'epel-el7'. We could make OST work by adding 'python2-enum34' to 'pkgs.txt' and rebuilding repository files, but I think we shouldn't for the reason I stated above - we should not depend on 'epel' packages. Regards, Marcin
, and we need to fix it, but lets first revert the patch to unblock other work.
worst case I'll revert.
Nir
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RZUYMEAB4HOE7R...

On Tue, 7 May 2019, 15:55 Marcin Sobczyk, <msobczyk@redhat.com> wrote:
Hi,
there's one issue with 'python2-enum34' - it's an 'epel' package. I don't know if it's going to land in 'base' repository, but until then I think we should rely on 'python-enum34'. On 5/2/19 6:41 PM, Nir Soffer wrote:
On Thu, May 2, 2019 at 7:29 PM Dan Kenigsberg <danken@redhat.com> wrote:
On Thu, 2 May 2019, 18:53 Nir Soffer, <nsoffer@redhat.com> wrote:
Investigating unrelated OST failue with: https://gerrit.ovirt.org/c/99293
I found that This patch fail in OST: https://gerrit.ovirt.org/c/99717
Failed build: https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4630/
2019-05-02 15:46:07,258::ssh.py::ssh::96::lago.ssh::DEBUG::Command 650bdf66 on lago-basic-suite-master-host-0 errors: + yum -y install ovirt-host Error: Package: vdsm-common-4.40.0-202.git9757d7c.el7.noarch (alocalsync) Requires: python2-enum34
Dan, can you take a look at this?
Wat?! I don't understand how it passed vdsm CI.
Maybe we are not using the same repos? (e.g. testing in CI, stable in OST)
It is sad that passing our install check is not accurate enough
Acually everything worked fine in our 'check-install'. If you take a look at a test patch I've made:
https://gerrit.ovirt.org/#/c/99809/
You can see that we install 'python2-enum34' when building artifacts with 'yum-builddep' because it's a build dependency - that's the reason it's not listed as a requirement when installing built 'vdsm-*' packages - it's already there. Both 'rpm -q python2-enum34' and 'repoquery -i python2-enum34' succeed - they show 'python2-enum34's origin as 'epel-el7'.
We could make OST work by adding 'python2-enum34' to 'pkgs.txt' and rebuilding repository files, but I think we shouldn't for the reason I stated above - we should not depend on 'epel' packages.
Ok, I'll keep my ugly revert. Regards, Marcin
, and we need to fix it, but lets first revert the patch to unblock other work.
worst case I'll revert.
Nir
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RZUYMEAB4HOE7R...
participants (4)
-
Dafna Ron
-
Dan Kenigsberg
-
Marcin Sobczyk
-
Nir Soffer