Heads up: VdcAction* classes names have been changed
Hi all, I've merged patches to change the legacy name "VdcAction*" to "Action*", the Vdc prefix is here from long time ago and doesn't make much sense anymore (if it ever did). Please make sure you rebase your patches before submitting and make sure CI passes again even if it passed before rebasing. Changed classes are: VdcActionType -> ActionType VdcActionTypeDeserializer -> ActionTypeDeserializer VdcActionParametersBase -> ActionParametersBase VdcActionUtils -> ActionUtils Thanks for the reviewers that helped review those long and boring patches (amureini, masayah, frolland, ishaby, awels, gsheremeta, oourfali) Next up on my list is VdcQuery*, stay tuned :)
Please note that the engine might fail to start if there are uncompleted commands stored in the *command_entities* table due to (de)serialization issue. If you encountered such exceptions during the engine startup, please delete the entire content of that table. On Mon, Jun 19, 2017 at 4:10 PM, Tal Nisan <tnisan@redhat.com> wrote:
Hi all, I've merged patches to change the legacy name "VdcAction*" to "Action*", the Vdc prefix is here from long time ago and doesn't make much sense anymore (if it ever did). Please make sure you rebase your patches before submitting and make sure CI passes again even if it passed before rebasing.
Changed classes are: VdcActionType -> ActionType VdcActionTypeDeserializer -> ActionTypeDeserializer VdcActionParametersBase -> ActionParametersBase VdcActionUtils -> ActionUtils
Thanks for the reviewers that helped review those long and boring patches (amureini, masayah, frolland, ishaby, awels, gsheremeta, oourfali)
Next up on my list is VdcQuery*, stay tuned :)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Regards, Moti
On Mon, Jun 19, 2017 at 8:57 PM Moti Asayag <masayag@redhat.com> wrote:
Please note that the engine might fail to start if there are uncompleted commands stored in the *command_entities* table due to (de)serialization issue. If you encountered such exceptions during the engine startup, please delete the entire content of that table.
On Mon, Jun 19, 2017 at 4:10 PM, Tal Nisan <tnisan@redhat.com> wrote:
Hi all, I've merged patches to change the legacy name "VdcAction*" to "Action*", the Vdc prefix is here from long time ago and doesn't make much sense anymore (if it ever did). Please make sure you rebase your patches before submitting and make sure CI passes again even if it passed before rebasing.
Changed classes are: VdcActionType -> ActionType VdcActionTypeDeserializer -> ActionTypeDeserializer VdcActionParametersBase -> ActionParametersBase VdcActionUtils -> ActionUtils
Thanks for the reviewers that helped review those long and boring patches (amureini, masayah, frolland, ishaby, awels, gsheremeta, oourfali)
Next up on my list is VdcQuery*, stay tuned :)
I'm just missing a mail prior to this kind of change - can you please give a heads up next time?
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Regards, Moti _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (3)
-
Moti Asayag -
Roy Golan -
Tal Nisan