On Thu, Jan 26, 2017 at 5:59 PM, Arik Hadas <ahadas(a)redhat.com> wrote:
Yesterday we merged the class LibvirtVmXmlBuilder in ovirt-engine.
It does not include the conversion of all the previously supported VM
properties (e.g., payload devices, OVS stuff, cinder disks - any help would
be appreciated btw) or covers all flows (e.g., run once) yet and there is
surely a place for improvement, but in its current state LibvirtVmXmlBuilder
is able to generate a libvirt's domxml on the engine side for many typical
VMs in our development environment.
If you happen to start working on a change that involves changing something
in the domxml, please do it by modifying this class. Our plan is to
deprecate the VM info map/dictionary soon.
That's so nice!
Let me try to motivate you by example:
Let's say that you want to add support for a property of a disk called
You had to patch VmInfoBuilderImpl to add another element to the VM info map
and then modify VDSM to use it when encoding the Disk device into XML.
You need to patch LibvirtVmXmlBuilder so the 'discard' property would be set
on the disk device element in the generated XML.
In order to test such a change you can:
(1) apply  to send the XML generated by the engine to VDSM
(2) apply  to send the XML generated by the engine to libvirt
Devel mailing list