Hi all, A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them. To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums. Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review. -Allon [1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum). On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik <amureini@redhat.com> wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Any removal of entries from AuditLogType enum should be followed by an upgrade script to remove the matching entries from the audit_log table. Without it, there will be NPEs due to AuditLogType.valueOf() On Sun, Dec 13, 2015 at 2:46 PM, Allon Mureinik <amureini@redhat.com> wrote:
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum).
On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik <amureini@redhat.com> wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Regards, Moti
----- Original Message -----
From: "Moti Asayag" <masayag@redhat.com> To: "Allon Mureinik" <amureini@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 4:58:41 PM Subject: Re: [ovirt-devel] AppErrors cleanup
Any removal of entries from AuditLogType enum should be followed by an upgrade script to remove the matching entries from the audit_log table. Without it, there will be NPEs due to AuditLogType.valueOf()
I had reviewed the work in https://gerrit.ovirt.org/#/q/d9a87e52e9727d9bb5a1ca7f7425aaaf4fd97503 It did not remove anything from the AuditLogType enum, so, I expect no issues with this patch
On Sun, Dec 13, 2015 at 2:46 PM, Allon Mureinik < amureini@redhat.com > wrote:
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum).
On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik < amureini@redhat.com > wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Regards, Moti
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Hmmm, I think we should do something similar in UI's i18n mechanism. Vojtech ----- Original Message -----
From: "Allon Mureinik" <amureini@redhat.com> To: "devel" <devel@ovirt.org> Sent: Sunday, December 13, 2015 1:46:01 PM Subject: Re: [ovirt-devel] AppErrors cleanup
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum).
On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik < amureini@redhat.com > wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[changed thread title since it's a new subject]
Hmmm, I think we should do something similar in UI's i18n mechanism.
can you please explain/elaborate? ----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Allon Mureinik" <amureini@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 10:28:27 AM Subject: Re: [ovirt-devel] AppErrors cleanup
Hmmm, I think we should do something similar in UI's i18n mechanism.
Vojtech
----- Original Message -----
From: "Allon Mureinik" <amureini@redhat.com> To: "devel" <devel@ovirt.org> Sent: Sunday, December 13, 2015 1:46:01 PM Subject: Re: [ovirt-devel] AppErrors cleanup
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum).
On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik < amureini@redhat.com > wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 4:33:20 PM Subject: new UI i18n mechanism
[changed thread title since it's a new subject]
Hmmm, I think we should do something similar in UI's i18n mechanism.
can you please explain/elaborate?
Sure :) As we're planning to improve existing oVirt UI i18n mechanism, we could also include unused message key detection into this effort. As Allon wrote, we don't want translators to waste time translating something that isn't used at all at runtime. We have some high-level goals we'd like to accomplish within this "UI i18n overhaul" effort, in short: - improve GWT compile performance (should make all-langs + all-user-agents builds faster) - externalize i18n messages out of GWT permutations (UI properties deployed on Engine for better handling) - improve UI translation process (make life easier for translators, we have many ideas) Scott and me should be driving this effort so if you have any other ideas, we'd love to hear them. Vojtech
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Allon Mureinik" <amureini@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 10:28:27 AM Subject: Re: [ovirt-devel] AppErrors cleanup
Hmmm, I think we should do something similar in UI's i18n mechanism.
Vojtech
----- Original Message -----
From: "Allon Mureinik" <amureini@redhat.com> To: "devel" <devel@ovirt.org> Sent: Sunday, December 13, 2015 1:46:01 PM Subject: Re: [ovirt-devel] AppErrors cleanup
Same has been done for AuditLogMessages.properties (vs. the AuditLogType enum).
On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik < amureini@redhat.com > wrote:
Hi all,
A recent bug [1] reported as part of the translation effort alerted me to the fact that we have a lot (and I mean a LOT - over 100 per file) of deprecated, unused keys in the various AppErrors files that serve no purpose and just take up space and waste translators time when they examine them.
To make a long story short - I've just merged a patch to remove all these useless messages, and enforce via unit tests that EVERY key there should have a corresponding constant in the EngineMessage or EngineError enums.
Many thanks to my reviewers! I know this was an tedious patch that couldn't have been too fun to review.
-Allon
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (5)
-
Allon Mureinik -
Einav Cohen -
Eli Mesika -
Moti Asayag -
Vojtech Szocs