Re: [CQ]: 111471,2 (ovirt-engine) failed "ovirt-master" system tests
On Wed, Oct 14, 2020 at 7:06 PM oVirt Jenkins <jenkins@ovirt.org> wrote:
Change 111471,2 (ovirt-engine) is probably the reason behind recent system test failures in the "ovirt-master" change queue and needs to be fixed.
This change had been removed from the testing queue. Artifacts build from this change will not be released until it is fixed.
For further details about the change see: https://gerrit.ovirt.org/#/c/111471/2
This fails compilation. Liran already commented there with details, posting this for visibility. Is anyone handling this? Should we revert? Thanks and best regards, -- Didi
This fails compilation.
It used to compile;> Most likely problem after rebase/merge.
Is anyone handling this? Should we revert?
I can fix this right away. Not sure how long it will take for the build. If it's a blocker then please just revert and I will resubmit. best regards, radek On Thu, Oct 15, 2020 at 8:42 AM Yedidyah Bar David <didi@redhat.com> wrote:
On Wed, Oct 14, 2020 at 7:06 PM oVirt Jenkins <jenkins@ovirt.org> wrote:
Change 111471,2 (ovirt-engine) is probably the reason behind recent system test failures in the "ovirt-master" change queue and needs to be fixed.
This change had been removed from the testing queue. Artifacts build from this change will not be released until it is fixed.
For further details about the change see: https://gerrit.ovirt.org/#/c/111471/2
This fails compilation. Liran already commented there with details, posting this for visibility.
Is anyone handling this? Should we revert?
Thanks and best regards, -- Didi
Fixed in https://gerrit.ovirt.org/#/c/111741/ My local build was successful but let wait for the CI +1. Problem was caused by the conflict between 2 of my patches: https://gerrit.ovirt.org/#/c/111119/ and https://gerrit.ovirt.org/#/c/111471/ Each of them passed the CI test but when applied to master the conflict occurred. Sorry for that. best regards, radek
On Thu, Oct 15, 2020 at 10:47 AM Radoslaw Szwajkowski <rszwajko@redhat.com> wrote:
Fixed in https://gerrit.ovirt.org/#/c/111741/
Thanks for the quick patch!
My local build was successful but let wait for the CI +1. Problem was caused by the conflict between 2 of my patches: https://gerrit.ovirt.org/#/c/111119/ and https://gerrit.ovirt.org/#/c/111471/ Each of them passed the CI test but when applied to master the conflict occurred. Sorry for that.
NP. Next time, better make up your mind, decide which patch should go first, and rebase the other on top of it. You can do this also before merging the first, and then check-patch should have failed on it. Best regards, -- Didi
On Thu, Oct 15, 2020 at 10:21 AM Yedidyah Bar David <didi@redhat.com> wrote:
NP. Next time, better make up your mind, decide which patch should go first, and rebase the other on top of it.
That works if we have conflicts between patches authored by one person (suffering a mild dementia:P) It seems to me that we need a global automated solution to prevent this happening between patches authored by different persons. Perhaps some auto-rebase and ci test on gerrit? best regards, radek
On Thu, Oct 15, 2020 at 11:54 AM Radoslaw Szwajkowski <rszwajko@redhat.com> wrote:
On Thu, Oct 15, 2020 at 10:21 AM Yedidyah Bar David <didi@redhat.com> wrote:
NP. Next time, better make up your mind, decide which patch should go first, and rebase the other on top of it.
That works if we have conflicts between patches authored by one person (suffering a mild dementia:P) It seems to me that we need a global automated solution to prevent this happening between patches authored by different persons. Perhaps some auto-rebase and ci test on gerrit?
This subject comes up once every year or two... And we change something, then usually things start breaking, so we refine... I think the current status is ok. Please note that https://jenkins.ovirt.org/job/ovirt-engine_standard-on-merge/1581/ did fail and left a comment in gerrit on your change. We should simply all pay a bit more attention to the result of standard-on-merge. If it fails, handle - fix or revert. Best regards, -- Didi
On Thu, Oct 15, 2020 at 8:43 AM Yedidyah Bar David <didi@redhat.com> wrote:
On Wed, Oct 14, 2020 at 7:06 PM oVirt Jenkins <jenkins@ovirt.org> wrote:
Change 111471,2 (ovirt-engine) is probably the reason behind recent
system test
failures in the "ovirt-master" change queue and needs to be fixed.
This change had been removed from the testing queue. Artifacts build from this change will not be released until it is fixed.
For further details about the change see: https://gerrit.ovirt.org/#/c/111471/2
We didn't detect the build issue on Jenkins CI, because we don't build frontend unless there is a change under frontend directory to save resources on Jenkins. So for these rare cases where a backend only change breaks frontend we don't have a warning and that's why it was revealed only after merging ...
This fails compilation. Liran already commented there with details, posting this for visibility.
Is anyone handling this? Should we revert?
Thanks and best regards, -- Didi _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BT3EGYHZFLAMZ5...
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
On 15 Oct 2020, at 11:08, Martin Perina <mperina@redhat.com> wrote:
On Thu, Oct 15, 2020 at 8:43 AM Yedidyah Bar David <didi@redhat.com <mailto:didi@redhat.com>> wrote: On Wed, Oct 14, 2020 at 7:06 PM oVirt Jenkins <jenkins@ovirt.org <mailto:jenkins@ovirt.org>> wrote:
Change 111471,2 (ovirt-engine) is probably the reason behind recent system test failures in the "ovirt-master" change queue and needs to be fixed.
This change had been removed from the testing queue. Artifacts build from this change will not be released until it is fixed.
For further details about the change see: https://gerrit.ovirt.org/#/c/111471/2 <https://gerrit.ovirt.org/#/c/111471/2>
We didn't detect the build issue on Jenkins CI, because we don't build frontend unless there is a change under frontend directory to save resources on Jenkins. So for these rare cases where a backend only change breaks frontend we don't have a warning and that's why it was revealed only after merging ...
Yeah. It seems it brings more trouble than it helps…. looking at recent CI data it does add 15-20 minutes to the build….but since we recently added an actually useful UI tests it seems worth it to me maybe with another “ci build quick” to skip GWT explicitly if someone really wants it fast…..though this “fast” still means ~45 minutes. ? And we can save plenty of resources by disabling fc30:)
This fails compilation. Liran already commented there with details, posting this for visibility.
Is anyone handling this? Should we revert?
Thanks and best regards, -- Didi _______________________________________________ Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> Privacy Statement: https://www.ovirt.org/privacy-policy.html <https://www.ovirt.org/privacy-policy.html> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ <https://www.ovirt.org/community/about/community-guidelines/> List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BT3EGYHZFLAMZ5... <https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BT3EGYHZFLAMZ5T3ICEXCDZQDZ4ZLLJX/>
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UNA5CZOMOYOMWX...
On Thu, Oct 15, 2020 at 12:25 PM Michal Skrivanek <michal.skrivanek@redhat.com> wrote:
On 15 Oct 2020, at 11:08, Martin Perina <mperina@redhat.com> wrote:
On Thu, Oct 15, 2020 at 8:43 AM Yedidyah Bar David <didi@redhat.com> wrote:
On Wed, Oct 14, 2020 at 7:06 PM oVirt Jenkins <jenkins@ovirt.org> wrote:
Change 111471,2 (ovirt-engine) is probably the reason behind recent system test failures in the "ovirt-master" change queue and needs to be fixed.
This change had been removed from the testing queue. Artifacts build from this change will not be released until it is fixed.
For further details about the change see: https://gerrit.ovirt.org/#/c/111471/2
We didn't detect the build issue on Jenkins CI, because we don't build frontend unless there is a change under frontend directory to save resources on Jenkins. So for these rare cases where a backend only change breaks frontend we don't have a warning and that's why it was revealed only after merging ...
Yeah. It seems it brings more trouble than it helps…. looking at recent CI data it does add 15-20 minutes to the build….but since we recently added an actually useful UI tests it seems worth it to me maybe with another “ci build quick” to skip GWT explicitly if someone really wants it fast…..though this “fast” still means ~45 minutes. ?
And we can save plenty of resources by disabling fc30:)
That's EOL for 4.5 months now [1]. Does anyone still use it? I know we have people using dev-env on newer fedora, but for this we do not need to build the engine, only some deps (of which at least otopi isn't built, I wonder what those people do...). [1] https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
This fails compilation. Liran already commented there with details, posting this for visibility.
Is anyone handling this? Should we revert?
Thanks and best regards, -- Didi _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BT3EGYHZFLAMZ5...
-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UNA5CZOMOYOMWX...
-- Didi
participants (4)
-
Martin Perina -
Michal Skrivanek -
Radoslaw Szwajkowski -
Yedidyah Bar David