--sV6E+871crhbObqU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This was done because it was requested some time ago. That will also remind devels that they should not merge any patches that ha= ve not finished running the jenkins jobs yet. In a (hopefully) near future, that will not be needed as jobs will become a gateway to merge, meaning that the regular merge flow will require passing = the jenkins jobs. In the meantime, it's just a remainder. On 03/25, Martin Perina wrote:

...

From: "Greg Sheremeta" <gshereme@redhat.com> To: infra@ovirt.org, "Eyal Edri" <eedri@redhat.com>, "David Caro" <dcar= oest@redhat.com> Cc: devel@ovirt.org Sent: Wednesday, March 25, 2015 1:40:35 PM Subject: [ovirt-devel] gerrit jenkins bot has gotten noisier =20 Hey guys, =20 Sometime last week, the jenkins bot upped the verbosity of his notifications on patches. Was this by design? =20 Example: https://gerrit.ovirt.org/#/c/39098/ =20 He now adds many "build started" messages. He used to only let us know about success / failure. =20 Not a huge deal, but it's more noise to filter through -- both in gerrit and email. =20 Agreed, especially for emails. Personally I don't care about build

=20 =20 ----- Original Message ----- process details, I'd like to know only final result of the build. If the build failed, I could find details on jenkins. =20 Martin =20

...

=20 Thanks, Greg =20 Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel =20

--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --sV6E+871crhbObqU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVErDVAAoJEEBxx+HSYmnDtpMIAJ2wW1x19RN4c0N128NzNpQV WdnShj8P2kTaZ2zjuchcL2a1M96/Uo2Y0zHrxZVwDma5oeWOZMCP8gscZPbTbzfC 4APfPrL2PgF+7+ZD7/h0ypVq871hXYt/oDPF1yx4Jagv9va8+cRugaCtOSOpwrVI vjbgyIuF73yRDt2eCalcW6FdKkGsgoh+XElKcqz38k+T8GWvkwFHFM8foQWWW72n 5G5dIrMBGEEXvpFh0xgHoWyp2sTLgNoeDR6l0tfgGR4XNwSnt2Ao8NwrG1jbVNR5 IqMKcoyMYO3/6MT1uQaA3DOpttNvBCoZ+6MeQ7F7dQVTSmw6M4heytBPC/V3h6I= =IqnD -----END PGP SIGNATURE----- --sV6E+871crhbObqU--

----- Original Message -----

From: "Eyal Edri" <eedri@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "Martin Perina" <mperina@redhat.com>, "Greg Sheremeta" <gshereme@redhat.com>, infra@ovirt.org, devel@ovirt.org Sent: Wednesday, March 25, 2015 2:27:35 PM Subject: Re: [ovirt-devel] gerrit jenkins bot has gotten noisier

Indeed.

this alert is needed due to previous incidents where patches were merged before a final jenkins run was done, and without a commiter being aware of his patch breaking the code.

I have no problem with that. But wouldn't it be less noisier to send just one email "build started" and one email "build finished"? Currently we are receiving 3 or 4 "build started" emails (one per each build phase), that's a bit noisy IMO. Thanks Martin

we're aware that in some cases the jenkins jobs might take a while to finish, due to lack of resources, but we're working on reducing that time with more memory for the hypervisors,smarter filtering of the jobs and better flow control.

e.

----- Original Message -----

...

From: "David Caro" <dcaroest@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Greg Sheremeta" <gshereme@redhat.com>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com>, devel@ovirt.org Sent: Wednesday, March 25, 2015 2:57:57 PM Subject: Re: [ovirt-devel] gerrit jenkins bot has gotten noisier

This was done because it was requested some time ago.

That will also remind devels that they should not merge any patches that have not finished running the jenkins jobs yet.

In a (hopefully) near future, that will not be needed as jobs will become a gateway to merge, meaning that the regular merge flow will require passing the jenkins jobs. In the meantime, it's just a remainder.

On 03/25, Martin Perina wrote:

...

----- Original Message -----

...

From: "Greg Sheremeta" <gshereme@redhat.com> To: infra@ovirt.org, "Eyal Edri" <eedri@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: devel@ovirt.org Sent: Wednesday, March 25, 2015 1:40:35 PM Subject: [ovirt-devel] gerrit jenkins bot has gotten noisier

Hey guys,

Sometime last week, the jenkins bot upped the verbosity of his notifications on patches. Was this by design?

Example: https://gerrit.ovirt.org/#/c/39098/

He now adds many "build started" messages. He used to only let us know about success / failure.

Not a huge deal, but it's more noise to filter through -- both in gerrit and email.

Agreed, especially for emails. Personally I don't care about build process details, I'd like to know only final result of the build. If the build failed, I could find details on jenkins.

Martin

...

Thanks, Greg

Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- David Caro

Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605

=20 =20 ----- Original Message -----

...

From: "Eyal Edri" <eedri@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "Martin Perina" <mperina@redhat.com>, "Greg Sheremeta" <gshereme@re= dhat.com>, infra@ovirt.org, devel@ovirt.org Sent: Wednesday, March 25, 2015 2:27:35 PM Subject: Re: [ovirt-devel] gerrit jenkins bot has gotten noisier =20 Indeed. =20 this alert is needed due to previous incidents where patches were merged before a final jenkins run was done, and without a commiter being aware of his=

--ikqct/fZAlyRpWN7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/25, Martin Perina wrote: patch

...

breaking the code. =20 I have no problem with that. But wouldn't it be less noisier to send just= one email "build started" and one email "build finished"? Currently we are re= ceiving 3 or 4 "build started" emails (one per each build phase), that's a bit noisy IMO.

=20 Thanks =20 Martin =20

...

=20 we're aware that in some cases the jenkins jobs might take a while to f= inish, due to lack of resources, but we're working on reducing that time with = more memory for the hypervisors,smarter filtering of the jobs and better flow contr=

The gerrit jenkins plugin does not allow that right now, feel free to investigate and send a patch to add that feature, it's java ;) Another alternative is to use a real flow and have just one job started for each event (for example using zuul). Something that we talked about before = we haven't had the time yet to implement. ol.

...

=20 e. =20 ----- Original Message -----

...

From: "David Caro" <dcaroest@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Greg Sheremeta" <gshereme@redhat.com>, infra@ovirt.org, "Eyal Ed= ri" <eedri@redhat.com>, devel@ovirt.org Sent: Wednesday, March 25, 2015 2:57:57 PM Subject: Re: [ovirt-devel] gerrit jenkins bot has gotten noisier =20 =20 This was done because it was requested some time ago. =20 That will also remind devels that they should not merge any patches t= hat have not finished running the jenkins jobs yet. =20 In a (hopefully) near future, that will not be needed as jobs will be= come a gateway to merge, meaning that the regular merge flow will require pa= ssing the jenkins jobs. In the meantime, it's just a remainder. =20 On 03/25, Martin Perina wrote:

...

...

From: "Greg Sheremeta" <gshereme@redhat.com> To: infra@ovirt.org, "Eyal Edri" <eedri@redhat.com>, "David Caro" <dcaroest@redhat.com> Cc: devel@ovirt.org Sent: Wednesday, March 25, 2015 1:40:35 PM Subject: [ovirt-devel] gerrit jenkins bot has gotten noisier =20 Hey guys, =20 Sometime last week, the jenkins bot upped the verbosity of his notifications on patches. Was this by design? =20 Example: https://gerrit.ovirt.org/#/c/39098/ =20 He now adds many "build started" messages. He used to only let us know about success / failure. =20 Not a huge deal, but it's more noise to filter through -- both in gerrit and email. =20 Agreed, especially for emails. Personally I don't care about build

=20 =20 ----- Original Message ----- process details, I'd like to know only final result of the build. If the build failed, I could find details on jenkins. =20 Martin =20

...

=20 Thanks, Greg =20 Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel =20 =20 -- David Caro =20 Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D =20 Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 =20 =20

--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --ikqct/fZAlyRpWN7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVEsDHAAoJEEBxx+HSYmnDP4MH+gOVtL86F6ZPsFM+MZchEDBK E1G7iEG01PtDaMuly0NI3o8si+/wWYkqMg4lQbGAzDwPvqn0kIIMHi1hWksz1BJ3 IKnEx3Ga0ZycKDMgwI39crpB32X5M4gjPFLsuxj6gGFCQQY/86pIjV7IoaCq65si u6w3VhwdT+Vxnp+CaQDfjwDTv/HYyLQmOi/votBarejd71Q/X3p6vjxZDEFvHO9n QY7uez3GKSrE4bohmlXraHFy2mQ6hvbEUwWVwNqvdcv7EsB19yz73oki7aiLS3Nf Ncx0FBs2s7mnl5wGsQiKyaz5MurhKs3vBUnVvEpHwCeebLWnEpm5F+foD9IWVnA= =qxEa -----END PGP SIGNATURE----- --ikqct/fZAlyRpWN7--

=20 =20 On 25 Mar 2015, at 13:58, David Caro <dcaroest@redhat.com> wrote: =20

...

=20 This was done because it was requested some time ago. =20 That will also remind devels that they should not merge any patches tha= t have not finished running the jenkins jobs yet. =20 In a (hopefully) near future, that will not be needed as jobs will beco= me a gateway to merge, meaning that the regular merge flow will require pass= ing the jenkins jobs. =20 I would strongly object to this, until we have a positive experience of n= o false positives for at least couple of months. Then it is a great idea.=20 =20 That's like expecting that every patch sent for review to pass all the test= s, all the time for a month and not failing once, and I don't mean each MERGED

--+9uAEI//NVSmpZEF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/26, Michal Skrivanek wrote: patch, I mean each one sent for review. Just so you have some numbers on what you are currently asking for, some st= ats about builds for the last two weeks: Number of SUCCESS builds: 50061 Number of FAILED builds: 1777 Number of UNSTABLE builds: 749 Number of ABORTED builds: 124 Number of NOTBUILT builds: 326 Total number of builds: 53037 Percentage of failed builds: 5.61% Here, failed builds includes infra issues and test failures, we don't have means yet to properly distinguish both. I know this is including all the projects, not just the most 'complicated' ones, but that means that, on small projects, where the maintainer of the project is also writing it's own acceptance tests, the failure ratio is a l= ot lower than on the bigger projects, where the failures are ignored and the t= ests not maintained, or left for the lonely infra guy that has ~50% of it's time= to handle them all, doing a quick ugly calculation, that guy has 48 seconds to review each failure and fix it (being it an infra issue or not). So you expect that someone that has no involvement on the development of mo= st of the projects, single-handedly fix and triage all those builds, 48 seconds each, and also care about all the other infra-related duties. And not only succeed doing that, but maintain all the system from failing once during two months. I'm sorry but as I see it a lot has to change for that to be feasible, and I really don't think it's fair to request it to that 1/2 guy.

=20

...

In the meantime, it's just a remainder. =20 On 03/25, Martin Perina wrote:

...

...

From: "Greg Sheremeta" <gshereme@redhat.com> To: infra@ovirt.org, "Eyal Edri" <eedri@redhat.com>, "David Caro" <dc= aroest@redhat.com> Cc: devel@ovirt.org Sent: Wednesday, March 25, 2015 1:40:35 PM Subject: [ovirt-devel] gerrit jenkins bot has gotten noisier =20 Hey guys, =20 Sometime last week, the jenkins bot upped the verbosity of his notifications on patches. Was this by design? =20 Example: https://gerrit.ovirt.org/#/c/39098/ =20 He now adds many "build started" messages. He used to only let us know about success / failure. =20 Not a huge deal, but it's more noise to filter through -- both in gerrit and email. =20 Agreed, especially for emails. Personally I don't care about build

=20 =20 ----- Original Message ----- process details, I'd like to know only final result of the build. If the build failed, I could find details on jenkins. =20 Martin =20

...

=20 Thanks, Greg =20 Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel =20 --=20 David Caro =20 Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D =20 Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605

---

Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --+9uAEI//NVSmpZEF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEbBAEBAgAGBQJVE9eDAAoJEEBxx+HSYmnD/vsH91dhVr+o3T/wIgABxXhkTu1c DqTzR/qnMe4pddgvj82TiVc7pFc3FbnWZFkreetpkkXAGhxI8NdNDTsRNc7GPcnI qc+iIw3qpOz95fdJtjcRsYe/d2l8DdZNxKWHeubetkEDDc8+MYOhrtRlSQQxfP2f zVZPQL4ONphqove57TlyQQHDNJVuNnKHf+mR7lG0LIjhI9/3eHispQJPWhpRA4vj FF1BswMpfR5arOGB62iCqsP6Pamt7cRoONkDx4abaDi8aPAQd5C8M47xZeoSAMkk Kxaj9R5E/GIplXV1IboSA0mxFsJJEodEdkeDDxZBk5Ne7rBAYgNpXIT8kh1bLQ== =PP0i -----END PGP SIGNATURE----- --+9uAEI//NVSmpZEF--