On Sun, Nov 27, 2016 at 12:31 PM, Eyal Edri <eedri(a)redhat.com> wrote:
Not sure I understand what do you mean by Gerrit Headers.
Can you give examples?
Here the point when the header disappeared:
Author: Petr Horáček <phoracek(a)redhat.com>
Date: Wed Nov 16 15:28:01 2016 +0100
net: enable link.bond to handle options
Note that this change also requires change in slaves editation
(in _revert_transaction) since we cannot edit options of a bonding
with attached slaves.
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Author: Maor Lipchuk <mlipchuk(a)redhat.com>
Date: Wed Nov 9 16:01:04 2016 +0200
API: Introduce getQemuImageInfo API.
The new API suppose to return information fetched using qemuimg info.
This should be usable to get the compat version of the volume.
This API will not use a job since it only returns information
about the volume and do not change it.
It is similar to how getVolumeInfo is working.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Continuous-Integration: Jenkins CI
Note that the older commit had:
On Fri, Nov 25, 2016 at 4:57 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
> On Fri, Nov 25, 2016 at 4:45 PM, Tomáš Golembiovský <tgolembi(a)redhat.com>
> > Hi,
> > I've noticed that in vdsm repo the merged commits do not contain the
> > info headers added by Gerrit any more (Reviewed-by/Reviewed-on/etc.).
> > Is that intentional? If yes, what was the motivation behind this?
> > The change seem to have happened about 4 days ago. Sometime between the
> > following two commits:
> > * 505f5da API: Introduce getQemuImageInfo API. [Maor Lipchuk]
> > * 1c4a39c protocoldetector: Avoid unneeded getpeername() [Nir Soffer]
> We switched vdsm to fast-forward 4 days ago, maybe this was unintended
> side effect of this change?
> The gerrit headers are very useful, please add back.
> Infra mailing list
EMEA ENG Virtualization R&D
Red Hat Israel
irc: eedri (on #tlv #rhev-dev #rhev-integ)